JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
3iff
Tycoon
Tycoon
Posts: 997
Joined: 21 Oct 2005 09:26
Location: Birmingham, England

Re: JGR's Patch Pack

Post by 3iff » 25 May 2016 09:36

Mizari wrote:
Pyoro wrote:Isn't it also a parameter in FIRS? Maybe make a little GRF with that feature. Shouldn't be too difficult to c&p the code.
It's removed in the latest FIRS. The default ratings is terrible.
Have a look in the graphics development forum - "Station Ratings". I'm having a go at providing a newgrf that does the job.

Jyratos
Engineer
Engineer
Posts: 71
Joined: 31 Mar 2014 19:47
Location: A small village near Paris, France

Re: JGR's Patch Pack

Post by Jyratos » 05 Jun 2016 16:46

Hello, I found an annoying problem with planes :

With improved breakdowns patch enabled, planes break down to 0 km/h mid-air. It seems to happen only with WAS planes.

If you want, here is a savegame :
Attachments
BUG.sav
(31.7 KiB) Downloaded 21 times

User avatar
JGR
Tycoon
Tycoon
Posts: 1990
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 05 Jun 2016 20:53

Jyratos wrote:Hello, I found an annoying problem with planes :

With improved breakdowns patch enabled, planes break down to 0 km/h mid-air. It seems to happen only with WAS planes.

If you want, here is a savegame :
Thanks for reporting this, I'll look into it.

Edit: This is now fixed and will be in the next release.
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

nihues
Engineer
Engineer
Posts: 46
Joined: 13 Jan 2015 10:26

Re: JGR's Patch Pack

Post by nihues » 06 Jun 2016 16:13

JGR, can you please look this?

viewtopic.php?f=26&t=30188&p=1170135#p1170129

I"m having the same problem, maybe it's a Patch bug? (ECS no Tourist appearing)

User avatar
JGR
Tycoon
Tycoon
Posts: 1990
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 06 Jun 2016 21:18

nihues wrote:JGR, can you please look this?

viewtopic.php?f=26&t=30188&p=1170135#p1170129

I"m having the same problem, maybe it's a Patch bug? (ECS no Tourist appearing)
This is due to the town cargo generation factor patch, and so has been present in every jgrpp release to date.
I'm slightly surprised that no-one has noticed it until now, then again I suppose most players don't use ECS.

This is fixed now and will be in the next release.
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

le_harv
Engineer
Engineer
Posts: 65
Joined: 27 Sep 2014 05:16
Location: Calgary, Canada

Re: JGR's Patch Pack

Post by le_harv » 07 Jun 2016 02:05

Great package! I know this is probably a long shot and probably a little bit niche but have you ever considered this patch?

viewtopic.php?f=33&t=63721

As I said, a bit niche, but I like it because it allows for timetable creation with arrival and departure 'dates'as opposed to time elapsed at a stop. It currently uses days and I don't know if it can be adapted to ticks or the clock face. Also since the 'wait in depot' got added it's done something weird to road vehicles and depots. I've tried poking around but I got lost pretty easily.

User avatar
JGR
Tycoon
Tycoon
Posts: 1990
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 07 Jun 2016 14:44

le_harv wrote:Great package! I know this is probably a long shot and probably a little bit niche but have you ever considered this patch?

viewtopic.php?f=33&t=63721

As I said, a bit niche, but I like it because it allows for timetable creation with arrival and departure 'dates'as opposed to time elapsed at a stop. It currently uses days and I don't know if it can be adapted to ticks or the clock face. Also since the 'wait in depot' got added it's done something weird to road vehicles and depots. I've tried poking around but I got lost pretty easily.
Without looking at the code yet, it sounds like there is a lot of overlap with timetable patches already included in the patchpack.
I don't think it would be practical to merge that on top of the existing patches.
Is some kind of timetable padding mechanism what you'd be looking for?
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

le_harv
Engineer
Engineer
Posts: 65
Joined: 27 Sep 2014 05:16
Location: Calgary, Canada

Re: JGR's Patch Pack

Post by le_harv » 08 Jun 2016 04:13

JGR wrote: Without looking at the code yet, it sounds like there is a lot of overlap with timetable patches already included in the patchpack.
I don't think it would be practical to merge that on top of the existing patches.
Is some kind of timetable padding mechanism what you'd be looking for?
Really the core mechanism that I am looking for is to do with how you create a schedule. So OpenTTD in it's current format does time tables like this:
  • Stay at station for 15 days
  • Travel for 10 days
  • Stay at station for 5 days
Now if the train takes 12 days to travel it's still going to wait for 5 days at the station when it gets there.

What the aforementioned patch does in it's current state is operate more like an actual schedule. You select 'dates' for the vehicle to arrive so lets say you timetable starts on 01/01/00 your would set a departure time for 15/01/00. Then because it should take ten days to travel you can set expected arrival at the next station as 25/01/00 with a departure of 30/01/00. Now in this example. If the train took 12 days to travel instead of 10 it will arrive 27/01/00 but still leave 30/01/00.

I hope that makes sense.

User avatar
JGR
Tycoon
Tycoon
Posts: 1990
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 08 Jun 2016 12:51

le_harv wrote: Really the core mechanism that I am looking for is to do with how you create a schedule. So OpenTTD in it's current format does time tables like this:
  • Stay at station for 15 days
  • Travel for 10 days
  • Stay at station for 5 days
Now if the train takes 12 days to travel it's still going to wait for 5 days at the station when it gets there.

What the aforementioned patch does in it's current state is operate more like an actual schedule. You select 'dates' for the vehicle to arrive so lets say you timetable starts on 01/01/00 your would set a departure time for 15/01/00. Then because it should take ten days to travel you can set expected arrival at the next station as 25/01/00 with a departure of 30/01/00. Now in this example. If the train took 12 days to travel instead of 10 it will arrive 27/01/00 but still leave 30/01/00.

I hope that makes sense.
The behaviour in trunk is already that if a vehicle arrives late or early, it will make up time or wait to meet the timetable.
In your example, the train would wait for 3 days at the station, if it arrived 2 days late.

If you set the start date for the timetable, and then the arrival time for say the last entry, how does that work for intermediary entries?
Are your set times relative to the previous entry or is something more clever going on? If it's the former it boils down to a different UI to set timetable entries. If you adjust an arrival date, are subsequent entries bumped?
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

le_harv
Engineer
Engineer
Posts: 65
Joined: 27 Sep 2014 05:16
Location: Calgary, Canada

Re: JGR's Patch Pack

Post by le_harv » 12 Jun 2016 23:10

JGR wrote: The behaviour in trunk is already that if a vehicle arrives late or early, it will make up time or wait to meet the timetable.
In your example, the train would wait for 3 days at the station, if it arrived 2 days late.

If you set the start date for the timetable, and then the arrival time for say the last entry, how does that work for intermediary entries?
Are your set times relative to the previous entry or is something more clever going on? If it's the former it boils down to a different UI to set timetable entries. If you adjust an arrival date, are subsequent entries bumped?
This is slightly awkward. You're absolutely right. My apologies for not noticing that.

As to the second part, there is a autofill function that sets the other stops relative to the start date however there is the added dimension of actually picking the date for departure. You can choose the exact date for departure as opposed to setting length of stay to manipulate that departure date, for example. If you change a date the others aren't affected as you have to set a total timetable length at the beginning.

Your system is quite intuitive. I will play around some more, thanks for pointing it out to me.

User avatar
Leanden
Tycoon
Tycoon
Posts: 2620
Joined: 19 Mar 2009 19:25
Location: Kent

Re: JGR's Patch Pack

Post by Leanden » 15 Jun 2016 13:57

JGR, how much would i have to bribe you/twist your arm to include the Yellow Path Signals patch, (its an optional parameter in advanced settings that modifies standard PBS signals).

viewtopic.php?f=33&t=74451

I believe its just an extension of the long reserve patch you have already included :)
Image

User avatar
JGR
Tycoon
Tycoon
Posts: 1990
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 15 Jun 2016 18:21

Leanden wrote:JGR, how much would i have to bribe you/twist your arm to include the Yellow Path Signals patch, (its an optional parameter in advanced settings that modifies standard PBS signals).

viewtopic.php?f=33&t=74451

I believe its just an extension of the long reserve patch you have already included :)
Integrating this brings up a lot of questions about behaviour and edge cases which haven't really been addressed IMO.
I don't think it really makes sense to include this without also including something like YAAM, which also raises again the question of what to do with block signals, as the current behaviour does not make sense.
As the various block/pre signals are fairly useless in a yellow PBS/YAAM environment, I'd be inclined to think more radically about signal types.
As for integration with the long reserve feature, as the yellow signals patch effectively turns it on by default, there needs to be some non-tedious way to turn it off on a per-signal basis.

If I did merge it, it would have to be off by default as it would cause havoc if unexpectedly enabled on an existing game.
Either way, a significant amount of thought/more development needs to occur before it would be sensible to merge this sort of behaviour.
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

User avatar
Leanden
Tycoon
Tycoon
Posts: 2620
Joined: 19 Mar 2009 19:25
Location: Kent

Re: JGR's Patch Pack

Post by Leanden » 15 Jun 2016 21:23

Oh absolutely i would have it off by default. I wasnt aware of YAAM, what is that?
Image

User avatar
supermop
Tycoon
Tycoon
Posts: 1046
Joined: 21 Feb 2010 00:15
Location: Fitzroy North - 96

Re: JGR's Patch Pack

Post by supermop » 15 Jun 2016 21:45

Leanden wrote:Oh absolutely i would have it off by default. I wasnt aware of YAAM, what is that?

Fun with SPADs!

User avatar
JGR
Tycoon
Tycoon
Posts: 1990
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 15 Jun 2016 23:26

Leanden wrote:Oh absolutely i would have it off by default. I wasnt aware of YAAM, what is that?
This: viewtopic.php?f=33&t=74482
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

User avatar
Leanden
Tycoon
Tycoon
Posts: 2620
Joined: 19 Mar 2009 19:25
Location: Kent

Re: JGR's Patch Pack

Post by Leanden » 15 Jun 2016 23:27

Ooo ill have to look into that.

Looking at the other patches in your pack i cant see anything that would conflict with yellow PBS, even programmable signals sits on its own signal ID, and the leftover id could be used to input the MAS signals and still keep the standard path signals in game?
Image

User avatar
Leanden
Tycoon
Tycoon
Posts: 2620
Joined: 19 Mar 2009 19:25
Location: Kent

Re: JGR's Patch Pack

Post by Leanden » 16 Jun 2016 00:09

Having read over YAAM i would personally leave it out if i was including yellow pbs, as that is severely changing a core aspect of the game, A LOT more than reserving 3 signals instead of 1 ;)
Image

nihues
Engineer
Engineer
Posts: 46
Joined: 13 Jan 2015 10:26

Re: JGR's Patch Pack

Post by nihues » 17 Jun 2016 21:09

Hello JGR, I'm having a crash. It started in 1977 and almost 20 years later with no crashes, got again, and now got an autosave days earlier of the crash. All attached.. Dunno if i'ts related to your patchpack. Using lastest 0.13.3.

Here is the code crash.log
[+] Spoiler

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Thu Jun 16 15:53:58 2016
In game date: 1977-02-02 (0, 0)

Crash reason:
 Exception: E1212012
 Location:  00007FF90E461F28
 Message:   Assertion failed at line 141 of /home/jgr/openttd/cross-win64/src/core/math_func.hpp: min <= max

OpenTTD version:
 Version:    jgrpp-0.13.3 (0)
 NewGRF ver: 17006bcf
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Jun 12 2016 21:39:11
 Configure:  ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
 FFFF0000 00007FF9 00000016 00000000 00000000 00000000 00000001 00000000
 E1212012 00000000 00000000 00000000 0E461F28 00007FF9 00000000 00007FF9
 00000000 00000000 02C470E0 00000000 0EAD9CF0 00007FF9 00050318 00000000
 00000000 00000000 FFFFFFFF 00000000 0EB2E190 00007FF9 0E9637A5 00007FF9
 BAB80000 0000971D 25C76EAE 00007FF9 02A6CBE8 00000000 11542AF7 00007FF9
 02A6CBE0 00000000 0E446FF9 00007FF9 0000000C 00007FF9 00000000 00000000
 628BD998 0000C776 EB432EFD 00002481 00000016 00000000 0E95AB1C 00007FF9
 00000001 00000000 25C76EAE 00007FF9 000136E2 00000000 00000314 00000000
 00000006 00000000 1152C9A7 00007FF9 00000003 00000000 000136E2 00000000
 0000001E 00000000 00000480 00000000 00000247 00000000 09939810 00000000
 000000B2 00000000 0E95EF3E 00007FF9 00000001 00000000 25C76EAE 00000000
 02A6D260 00000000 000136E2 00000000 02A6CCD8 00000000 00000030 00000003
 0000001B 00000000 02C6E220 00000000 00000001 00000000 FFFFE20F 00000000
 00000006 00000000 03501980 00000000 02C402FC 00000000 00000019 00000000
 00000000 00000000 11574E90 00007FF9 11574FF0 00007FF9 0EADCC10 00007FF9
 00050318 00000000 03501980 00000000 00000001 00000000 00000001 00000000
 22000022 00000000 00000000 00000000 00150320 00000000 0000001B 00000000
 00000000 00000000 000D0028 00000000 00000002 00000000 02C6E294 00000000
 00000001 00000000 00000010 00000000 02C40000 00000000 114F0AD9 00007FF9
 02C40000 00000000 02C6E220 00000000 00000000 00000000 00000000 00000000
 00000001 00000000 0EAB7ACD 00007FF9 0EB2D6A0 00007FF9 02A6D110 00000000
 02C6E294 00000000 00000000 00000000 02C6E230 00000000 02A6D110 00000000
 02A6CED9 00000000 0EB2FC77 00007FF9 00010003 00000000 02A6CED9 00000000
 00000000 00000000 04010000 00000000 02A6D110 00000000 00000000 00000000

Registers:
 RAX: 00007FF911578BA4 RBX: 0000000000000016 RCX: 0000000000000000 RDX: 0000000003513990
 RSI: 0000000000000000 RDI: 0000000000000001 RBP: 000000000000009E RSP: 0000000002A6CB30
 R8:  0000000002C86BB0 R9:  0000000000000001 R10: 00000000FFFFE245 R11: 0000000000000027
 R12: 0000000000000910 R13: 0000000000000000 R14: 00007FF90E9C38E0 R15: 000000000053A990
 RIP: 00007FF90E461F28 EFLAGS: 00000202

 Bytes at instruction pointer:
 48 8B 8C 24 C0 00 00 00 48 33 CC E8 98 7A 00 00 48 81 C4 D8 00 00 00 C3

Operating system:
 Name:     Windows
 Release:  6.2.9200 ()
 Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
 Blitter:      32bpp-sse4
 Graphics set: OpenGFX (5580)
 Language:     C:\Users\Fabricio\Dropbox\Openttd JGRPP 0.9\lang\english_US.lng
 Music driver: win32
 Music set:    original_windows (1)
 Network:      no
 Sound driver: win32
 Sound set:    original_windows (0)
 Video driver: win32

Fonts:
 Small:  Arial
 Medium: Tahoma
 Large:  Times New Roman
 Mono:   sprite

AI Configuration (local: 0) (current: 0):
  0: Human
 GS: Neighbours are important (v16)

Libraries:
 FreeType:   2.6.0
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
 C:\Users\Fabricio\Dropbox\Openttd JGRPP 0.9\openttd.exe handle: 0000000000400000 size: 37240704 crc: 03E92138 date: 2016-06-12 20:39:16
 C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007ff9114d0000 size: 1819208 crc: 7A6120F9 date: 2016-04-23 05:24:28
 C:\WINDOWS\system32\KERNEL32.DLL handle: 00007ff911030000 size: 705584 crc: DD3F02D6 date: 2015-10-30 07:17:46
 C:\WINDOWS\system32\KERNELBASE.dll handle: 00007ff90e3f0000 size: 1997328 crc: C05A51D0 date: 2016-04-23 05:24:41
 C:\WINDOWS\system32\apphelp.dll handle: 00007ff90c2e0000 size: 479744 crc: 702D6C0F date: 2015-10-30 07:17:50
 C:\WINDOWS\system32\ADVAPI32.dll handle: 00007ff9110e0000 size: 671472 crc: A52B4190 date: 2016-01-28 17:14:16
 C:\WINDOWS\system32\msvcrt.dll handle: 00007ff90e930000 size: 633760 crc: 247C0236 date: 2015-10-30 07:18:03
 C:\WINDOWS\system32\sechost.dll handle: 00007ff90e8d0000 size: 371360 crc: F09DC2E8 date: 2015-10-30 07:18:03
 C:\WINDOWS\system32\RPCRT4.dll handle: 00007ff910e70000 size: 1161120 crc: C7047B07 date: 2016-04-23 05:22:15
 C:\WINDOWS\system32\GDI32.dll handle: 00007ff911340000 size: 1594920 crc: A0BD7AA7 date: 2016-04-23 05:00:43
 C:\WINDOWS\system32\USER32.dll handle: 00007ff90eab0000 size: 1399224 crc: 7AEC2979 date: 2016-04-23 05:00:45
 C:\WINDOWS\system32\IMM32.dll handle: 00007ff910ff0000 size: 230416 crc: D52158C0 date: 2015-10-30 07:17:58
 C:\WINDOWS\system32\SHELL32.dll handle: 00007ff90f230000 size: 22561256 crc: A2839AC0 date: 2016-04-23 05:09:05
 C:\WINDOWS\system32\cfgmgr32.dll handle: 00007ff90e820000 size: 264488 crc: 1178E451 date: 2015-10-30 07:17:50
 C:\WINDOWS\system32\windows.storage.dll handle: 00007ff90dcd0000 size: 6605504 crc: C9428E4A date: 2016-04-23 05:08:45
 C:\WINDOWS\system32\combase.dll handle: 00007ff910a10000 size: 2606824 crc: 10B62289 date: 2016-01-27 05:46:42
 C:\WINDOWS\system32\bcryptPrimitives.dll handle: 00007ff90e7b0000 size: 431296 crc: 9F19A044 date: 2015-10-30 07:18:03
 C:\WINDOWS\system32\shlwapi.dll handle: 00007ff90e9d0000 size: 332104 crc: 9EA86865 date: 2015-10-30 07:18:14
 C:\WINDOWS\system32\kernel.appcore.dll handle: 00007ff90daf0000 size: 45016 crc: A6EF8C2D date: 2015-10-30 07:17:47
 C:\WINDOWS\system32\shcore.dll handle: 00007ff90db80000 size: 725776 crc: 3E753D6C date: 2016-04-23 05:08:41
 C:\WINDOWS\system32\powrprof.dll handle: 00007ff90db20000 size: 294472 crc: C01CDE24 date: 2015-10-30 07:17:48
 C:\WINDOWS\system32\profapi.dll handle: 00007ff90db00000 size: 68752 crc: 530B5C2C date: 2015-10-30 07:18:03
 C:\WINDOWS\system32\WS2_32.dll handle: 00007ff90ec10000 size: 430816 crc: C93B2BDA date: 2015-10-30 07:18:03
 C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007ff90c020000 size: 121992 crc: B480264F date: 2015-10-30 07:17:57
 C:\WINDOWS\SYSTEM32\WINMMBASE.dll handle: 0000000000180000 size: 166344 crc: F410A696 date: 2015-10-30 07:17:57
 C:\WINDOWS\system32\uxtheme.dll handle: 00007ff90c550000 size: 589312 crc: 5FCF2AF5 date: 2015-10-30 07:18:15
 C:\WINDOWS\system32\MSCTF.dll handle: 00007ff910800000 size: 1415200 crc: 4FB7AA27 date: 2016-01-28 17:14:13
 C:\WINDOWS\system32\dwmapi.dll handle: 00007ff90b370000 size: 107520 crc: F19EA449 date: 2015-10-30 07:17:58
 C:\WINDOWS\system32\mswsock.dll handle: 00007ff90d3c0000 size: 357216 crc: 31E14371 date: 2015-10-30 07:18:03
 C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007ff906d50000 size: 440120 crc: 7B397B17 date: 2015-10-30 07:17:57
 C:\WINDOWS\SYSTEM32\PROPSYS.dll handle: 00007ff90b570000 size: 1603224 crc: E0F4EB2A date: 2015-10-30 07:17:59
 C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 00007ff90c520000 size: 149816 crc: D9B3F76C date: 2015-10-30 07:17:50
 C:\WINDOWS\system32\OLEAUT32.dll handle: 00007ff910da0000 size: 785088 crc: 372AF6B1 date: 2015-10-30 07:18:03
 C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007ff900220000 size: 245248 crc: ACC4D569 date: 2015-10-30 07:17:57
 C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007ff90a450000 size: 32592 crc: 7C87F235 date: 2015-10-30 07:17:57
 C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007ff8ff660000 size: 22752 crc: 6642CF0D date: 2015-10-30 07:17:57
 C:\WINDOWS\SYSTEM32\VirtualMIDISynth\VirtualMIDISynth.dll handle: 00007ff8fe9b0000 size: 577536 crc: 2F9BA22F date: 2016-04-24 14:12:34
 C:\WINDOWS\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_5.82.10586.0_none_396e892957c7fb25\COMCTL32.dll handle: 00007ff907150000 size: 679776 crc: F5426B25 date: 2015-10-30 07:18:14
 C:\WINDOWS\SYSTEM32\CRYPTBASE.DLL handle: 00007ff90d590000 size: 31072 crc: A616F376 date: 2015-10-30 07:18:03
 C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007ff8f6900000 size: 536256 crc: F1B31B9B date: 2016-02-23 10:31:19
 C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007ff90a130000 size: 1270072 crc: D09BD426 date: 2016-01-27 05:46:48
 C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007ff900210000 size: 27648 crc: ABE231B6 date: 2015-10-30 07:17:57
 C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007ff8fec50000 size: 105392 crc: FE9F1281 date: 2015-10-30 07:17:57
 C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007ff8feed0000 size: 25088 crc: 7C988B63 date: 2015-10-30 07:17:57
 C:\WINDOWS\system32\clbcatq.dll handle: 00007ff910960000 size: 662704 crc: 0C48BB7E date: 2015-10-30 07:17:51
 C:\WINDOWS\system32\psapi.dll handle: 00007ff90f220000 size: 18656 crc: 4BB4B30F date: 2015-10-30 07:17:50

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.13.2, savegame version 194, not modified, _openttd_newgrf_version = 0x17006bac
New game mode: 1 landscape: 1
Added NewGRF: GRF ID 634D0100, checksum 65E3C5D513D64016A318AE2320DE7B32, filename: betabridges-0.5\betabridges.grf (md5sum matches)
Added NewGRF: GRF ID 4D470305, checksum 2E96B9AB2BEA686BFF94961AD433A701, filename: basecosts-5.0\basecosts.grf (md5sum matches)
Added NewGRF: GRF ID 79210502, checksum FAFE655EC51D907391C38B116B199307, filename: brazilian_town_names-2.0\braziliantownnames.grf (md5sum matches)
Added NewGRF: GRF ID 46429003, checksum 28996AB1BCB293EF81D43E1A2E8E29F4, filename: ottdc_grfpack\1_other\separators\vehicles.grf (md5sum matches)
Added NewGRF: GRF ID 4A4D0101, checksum AFE4E75999A3FF92D4B01DBEE9A803E9, filename: sailing_ships-0.62\ss.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 536506BDDDBD8644815FC2E7E6A80D7A, filename: fish_2-2.0.2\fish.grf (md5sum matches)
Added NewGRF: GRF ID 9787EAFE, checksum 62F9DAB7C36362EE0499F479E8713139, filename: road_hog-beta2\road-hog.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21\pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 46429001, checksum 96715B253307A55DA94B02E43C792602, filename: ottdc_grfpack\1_other\separators\stations.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 43485053, checksum 3FFDBE665AF574189F8A6B08C94F3A71, filename: chips_station_set-1.6.1\chips.grf (md5sum matches)
Added NewGRF: GRF ID 45520400, checksum 1D00426064137AA49B6FC4F4BCFF173F, filename: ottdc_grfpack\7_stations\brickfreight\brickfreightw.GRF (md5sum matches)
Added NewGRF: GRF ID 45520102, checksum 1406B06F6475037445A944963CA6D5CE, filename: ottdc_grfpack\7_stations\basic_platforms\basic_platformsw.grf (md5sum matches)
Added NewGRF: GRF ID 45520500, checksum 7E30CA79D5A8B3A6CBE873E26096D7D2, filename: ottdc_grfpack\7_stations\modernsuburban\modernsuburbanw.GRF (md5sum matches)
Added NewGRF: GRF ID 52455400, checksum 1600687C50C5AB1E72EDD487CAD50E2A, filename: coded_by_aegir._artwork_by_aegir-1\ae_cityw.grf (md5sum matches)
Added NewGRF: GRF ID 52455200, checksum 0E5A9C5ACD2BCAF7FA0658C3F905A660, filename: rural_stations-1\ae_ruraw.grf (md5sum matches)
Added NewGRF: GRF ID 43415463, checksum 422B1603DC1CEDA4E59E715E12EAD332, filename: ottdc_grfpack\7_stations\canstn\canstnw.grf (md5sum matches)
Added NewGRF: GRF ID 6D620601, checksum 44EB2F155862E4D4F0AB671D7021AF54, filename: ottdc_grfpack\7_stations\newstats\newstatsw.grf (md5sum matches)
Added NewGRF: GRF ID 4D50006A, checksum 3A797B1A7E3968A91CB45199BCF52520, filename: ore_unloader_station-0.1\iorestat.grf (md5sum matches)
Added NewGRF: GRF ID 49464E4F, checksum 9EE9117BD4511BD6879429ECF8DC9335, filename: sno__supercheeses_newobjects-0.3.1\sno-supercheesesnewobjects.grf (md5sum matches)
Added NewGRF: GRF ID 504A0013, checksum E2FB4F9E66207F8016B7303323FDD00C, filename: isrdwestyle_objects-1.0\isrdwe_objects_v1_0.grf (md5sum matches)
Added NewGRF: GRF ID 54430201, checksum C837D48D657129DD915830D60D68E09F, filename: cs_stationset_v0.1-1\csstationsw.grf (md5sum matches)
Added NewGRF: GRF ID 504A0103, checksum F4056FECA93218E2B1FC015B0C7844A2, filename: isrstyle_dock-1.3\isrdock_v1_3.grf (md5sum matches)
Added NewGRF: GRF ID 4A430001, checksum 4CF50E2A770F6672A77A8842A3129ECA, filename: british_stations_set-0.0.4final\dstatsw.grf (md5sum matches)
Added NewGRF: GRF ID 54570200, checksum 3DEB9B30A6254AE8606A5A9A99A9A696, filename: ottdc_grfpack\7_stations\usstats\usstatsw.grf (md5sum matches)
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2\ogfx-airports.grf (md5sum matches)
Added NewGRF: GRF ID 46429004, checksum 2AA504F45E3F67753A0F07EBB2417A67, filename: ottdc_grfpack\1_other\separators\newindustries.grf (md5sum matches)
Added NewGRF: GRF ID F1250006, checksum FE6C7CCC6CF0D1069BB360D20AC0609E, filename: firs_2-2.1.1\firs.grf (md5sum matches)
Added NewGRF: GRF ID 46429005, checksum A356711BD741FB811600BFD01470379E, filename: ottdc_grfpack\1_other\separators\town-buildings.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum B21E7D6ADD69B1C07643939764FB4878, filename: swedish_houses-1.1.2\swehouses.grf (md5sum matches)
Added NewGRF: GRF ID 46429006, checksum BE358E05F2AE2D1DFE8E85ED45495BF1, filename: ottdc_grfpack\1_other\separators\landscape.grf (md5sum matches)
Added NewGRF: GRF ID 6D620C00, checksum 79F501FF2571BBC7E0713E3E86F513FB, filename: marico.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum 136D889FDAEAA3491F8320248A04425C, filename: opengfx_landscape-1.1.2\ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 53441101, checksum 3E2397532428AB013862B22EDBB396E5, filename: INFRA Green P1\infra_green1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53441129, checksum 9CF044DD9054F863295D5AA8A1671999, filename: INFRA Green P3\infra_green1x1_p3.grf (md5sum matches)
Added NewGRF: GRF ID 53541101, checksum AAE3DC77FAC504FB07D9F8752F49ECA4, filename: INFRA Streets P1-OpenTTD\infra_streets1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53541119, checksum 40AC1CC9C1E328BE359094B7754054DB, filename: INFRA Streets P2-OpenTTD\infra_streets1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID 53541129, checksum 249C8A47E845E9D0270FFAFE5E2EB4C1, filename: INFRA Streets P3-OpenTTD\infra_streets1x1_p3.grf (md5sum matches)
Added NewGRF: GRF ID 53441119, checksum 4201D77058BC82C4F2DC0294AFBA6DC3, filename: INFRA Green P2\infra_green1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0501, checksum 60082E7DF1D3976274AB86843C3E07B2, filename: dutch_road_furniture-0.7.1\dutchroadfurniture.grf (md5sum matches)
Added NewGRF: GRF ID 48570101, checksum 60EE47680819FD7645E06E63E4DA559B, filename: tars_mountain_lifts-v0.3\tars_mountain_liftsv0.3.grf (md5sum matches)
Added NewGRF: GRF ID 0100403A, checksum DF16420F1C03C7888A313B36AFB683FB, filename: city_objects-b07\co07.grf (md5sum matches)
Added NewGRF: GRF ID BEBE0100, checksum 292651F47482C993AA61F5A312EE451C, filename: farm_objects-2\farmobjects.grf (md5sum matches)
Added NewGRF: GRF ID 44573553, checksum EF7529EBEAF35758EE07E628B25F608D, filename: dwenewobjects-v0.1\dwe_newobj.grf (md5sum matches)
Added NewGRF: GRF ID 444E0400, checksum 735D3D74D5DCADBF1FD6EF7A9C5A3519, filename: vast_station_tiles-0.2.0\vast.grf (md5sum matches)
Added NewGRF: GRF ID 444E0800, checksum 334F8C4697455569073434DB107F864A, filename: vast_objects-0.3.0\vastobjects.grf (md5sum matches)
Added NewGRF: GRF ID 444E0C00, checksum B5D2AB5FC93A09E1FAB5F0DB82307ECF, filename: vast_fences-0.2.0\vastfences.grf (md5sum matches)
Added NewGRF: GRF ID 504A0107, checksum 4D04391AC5C796C3039F1CD853EF5345, filename: beach_objects-1.1\beach_v1_1.grf (md5sum matches)
Added NewGRF: GRF ID 4D480201, checksum 9E914C31E5FC7FC3F686D009BD55F331, filename: alexandra_palace-1.0.0\alexandrapalace.grf (md5sum matches)
Added NewGRF: GRF ID 504A0102, checksum 29EA308A78B7740794B80A117D14BF34, filename: dutch_delta_works-1.1\dutchdeltaworks_v1_1.grf (md5sum matches)
Added NewGRF: GRF ID 4D4D9910, checksum 3CD3F4D0D98DDC0DB08E9AD74B88A9E2, filename: the_lighthouse_set-1.2\the_lighthouse_set_v1.2.grf (md5sum matches)
Added NewGRF: GRF ID 46429002, checksum 8FB0984C37C6EEBFEE21C84C2EC8869C, filename: ottdc_grfpack\1_other\separators\infrstructure.grf (md5sum matches)
Added NewGRF: GRF ID 44503000, checksum 0BF5A48500990CF4CBFED5D7CC6ED120, filename: japanese_tracks-3.2\jptracks.grf (md5sum matches)
Added NewGRF: GRF ID 4D666F01, checksum 1C3723AAE56C6648B61BC211EA344835, filename: ottdc_grfpack\2_landscape\stolentrees\testw.grf (md5sum matches)
Added NewGRF: GRF ID 524B0301, checksum BB7BBE4FF23B349D17ED0A682503680C, filename: lightrailtramtracks-0.2\tramtrkw.grf (md5sum matches)
Added NewGRF: GRF ID 415A0301, checksum 8667797182D6F6C670D7BE5D677ACB45, filename: american_road_replacement_set-2.0.0\americanroads.grf (md5sum matches)
Added NewGRF: GRF ID 4672780A, checksum 7AF65E8BD107B5A4660031E1B4C4F822, filename: monkey_bar_bridge-1.4.1\monkeybarbridge.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0202, checksum F7FA6C6ECEA645CA788B88555E118F4D, filename: transrapid_track_set-1.0.0\traratrk.grf (md5sum matches)
Added NewGRF: GRF ID 46727800, checksum 3B58B9177D1A1B54D356F64B93526116, filename: smits-1.0\smits.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B31, checksum 4E0B2D42462F295F36AFBA90D239A323, filename: opengfx_trains-0.3.0\ogfx-trains.grf (md5sum matches)
Added NewGRF: GRF ID 41560102, checksum 7D4DD258F3998C8DB3A918C2472B25F3, filename: pipe-6.40\pipe.grf (md5sum matches)
Added NewGRF: GRF ID 54430202, checksum 081B62FD686AF2161866A0CF6EA043AC, filename: cs_platforms_set-1\csplatformsw.grf (md5sum matches)
Added NewGRF: GRF ID 58534453, checksum 2E100BCA91DB8371CD9D57DBEC3AB0C8, filename: ottdc_grfpack\7_stations\dutchstat\dutchstatw.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0901, checksum 4619642A3BF1A535AEDBDA426FF63EBB, filename: friss-0.5.2\friss-stations.grf (md5sum matches)
Added NewGRF: GRF ID 464B0000, checksum E266FE2217DE82D7C1F8968EC81A2915, filename: hungarian_stations-1\hungarian_stations.grf (md5sum matches)
Added NewGRF: GRF ID 464B0001, checksum B5A131DCAC1D7C7E24166EDEA2D106F1, filename: hungarian_stations_2-1\hungarian_stations2.grf (md5sum matches)
Added NewGRF: GRF ID 464B0002, checksum 9D3B823C988DB972503A72E58180D077, filename: hungarian_stations_3-1\hungarian_stations3.grf (md5sum matches)
Added NewGRF: GRF ID 4E530107, checksum 2C7C69E0C385722EC2C89520CC0F3DE8, filename: ttd_urban_renewal_all_win\newstations_allw.grf (md5sum matches)
Added NewGRF: GRF ID 45520001, checksum 4F6DAB25CE0EA99584803A4C3AE77143, filename: ottdc_grfpack\z_obsolete\pgs\pgs-subuw.grf (md5sum matches)
Added NewGRF: GRF ID 45530500, checksum D9BE5AFA481FC3E0A96E6EB72B455612, filename: japanese_stations-3.6\jpstations.grf (md5sum matches)
Added NewGRF: GRF ID 42533031, checksum A6CF807078DE75D0209D53BE8BA6FDEC, filename: brianum_speed_limit_for_bridges-1.0\brianum_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 52455300, checksum 37C0B839B13C4B18051580C81EEDF427, filename: suburban_stations-1\ae_subuw.grf (md5sum matches)
Added NewGRF: GRF ID 54440103, checksum 87A22193371A7E04279130835E21ACF2, filename: polish_pkp_set_2.0-2.0.11\pkp-set-2.0.11.grf (md5sum matches)
Tick 51523: GRF config changed
GRF parameter changed: GRF ID 54440103, filename: polish_pkp_set_2.0-2.0.11\pkp-set-2.0.11.grf (md5sum matches)
Tick 18194: game loaded
Revision text changed to jgrpp-0.13.3, savegame version 195, not modified, _openttd_newgrf_version = 0x17006bcf
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x00007FF90E461F28 RaiseException + 104
[01] msvcrt               0x00007FF90E95AB1C raise + 508
[02] msvcrt               0x00007FF90E95EF3E abort + 46
[03] openttd              0x000000000052CCFF error(char const*, ...) + 95 (/home/jgr/openttd/cross-win64/src/openttd.cpp:129)
[04] openttd              0x000000000062B4E1 Clamp<int> (/home/jgr/openttd/cross-win64/src/core/math_func.hpp:141)
[05] openttd              0x00000000008ECF69 EnginePreviewWindow::DrawWidget(Rect const&, int) const + 329 (/home/jgr/openttd/cross-win64/src/engine_gui.cpp:118)
[06] openttd              0x000000000066F176 NWidgetLeaf::Draw(Window const*) + 2054 (/home/jgr/openttd/cross-win64/src/widget.cpp:2510)
[07] openttd              0x000000000066C0EE NWidgetPIPContainer::Draw(Window const*) + 30 (/home/jgr/openttd/cross-win64/src/widget.cpp:1112)
[08] openttd              0x000000000066E482 NWidgetBackground::Draw(Window const*) + 370 (/home/jgr/openttd/cross-win64/src/widget.cpp:1862)
[09] openttd              0x000000000066C0EE NWidgetPIPContainer::Draw(Window const*) + 30 (/home/jgr/openttd/cross-win64/src/widget.cpp:1112)
[10] openttd              0x000000000066F3E0 Window::DrawWidgets() const + 32 (/home/jgr/openttd/cross-win64/src/widget.cpp:605)
[11] openttd              0x0000000000675A3A DrawOverlappedWindowForAll(int, int, int, int) + 154 (/home/jgr/openttd/cross-win64/src/window.cpp:945)
[12] openttd              0x00000000004ACF2F RedrawScreenRect(int, int, int, int) + 127 (/home/jgr/openttd/cross-win64/src/gfx.cpp:1296)
[13] openttd              0x00000000004AD105 DrawDirtyBlocks() + 373 (/home/jgr/openttd/cross-win64/src/gfx.cpp:1388)
[14] openttd              0x0000000000677AB3 UpdateWindows() + 243 (/home/jgr/openttd/cross-win64/src/window.cpp:3076)
[15] openttd              0x0000000000654FA8 VideoDriver_Win32::MainLoop() + 488 (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:1282)
[16] openttd              0x000000000052E5C1 openttd_main(int, char**) + 5233 (/home/jgr/openttd/cross-win64/src/openttd.cpp:902)
[17] openttd              0x000000000053BE4F WinMain + 239 (/home/jgr/openttd/cross-win64/src/os/windows/win32.cpp:466)
[18] openttd              0x00000000004013ED __tmainCRTStartup + 573 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:332)
[19] openttd              0x00000000004014FB WinMainCRTStartup + 27 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:184)
[20] KERNEL32             0x00007FF911048102 BaseThreadInitThunk + 34
[21] ntdll                0x00007FF91152C5B4 RtlUserThreadStart + 52

*** End of additional info ***
Attachments
Openttd JGR crash dump.zip
first crash, recovered, no crash after sav.
(648.36 KiB) Downloaded 18 times
autosave-3-crash.sav
second crash, always crash days later, same error as first crash....
(188.25 KiB) Downloaded 19 times
Last edited by nihues on 17 Jun 2016 22:38, edited 1 time in total.

nihues
Engineer
Engineer
Posts: 46
Joined: 13 Jan 2015 10:26

Re: JGR's Patch Pack

Post by nihues » 17 Jun 2016 21:23

started a save 1 year before the 2nd crash and it crashed on 1st Jan 1994. Same error.

EDIT: probably could be a NewGRF error. But what NewGRF?

https://bugs.openttd.org/task/3683

User avatar
Leanden
Tycoon
Tycoon
Posts: 2620
Joined: 19 Mar 2009 19:25
Location: Kent

Re: JGR's Patch Pack

Post by Leanden » 17 Jun 2016 22:23

For the love of god please put spoiler tags around that crash dump!!! Yowzers.
Image

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 2 guests