Tib's Patch Pack v2.6 (r14004)

[Indiana]

@Tiberius: I was the yellow player ^^
Think he used the Ctrl-Key to place the Busstop somewhere in the city.

[Chico008]

Is it possible for the next version to include This Patch
jump based on waiting/accepted cargo

this could be very usefull and a good add-on for the conditionnal order already implemented.

[Tiberius]

V2 uploaded, see the first post.

[nonick37]

This one crashes after seconds to a few minutes. Playing tropical, no grfs loaded.

Code: Select all

*** OpenTTD Crash Report ***
Date: 2008-07-11 08:51:22
Build: r13691M-TibPP built on Jul 11 2008 08:45:34
Reason: Assertion failed at ..\src\saveload.cpp:506: x >= 0 && x <= 65535
Exception C0000005 at 00433BDE
Registers:
 EAX: 01AFEDC8 EBX: 00000000 ECX: 0012F7A8 EDX: 01AFEE0A
 ESI: 000A2C57 EDI: 00000063 EBP: 0012F9D4 ESP: 0012F9C0
 EIP: 00433BDE EFLAGS: 00010206

Bytes at CS:EIP:
 88 1D 00 00 00 00 8B C6 C1 E8 08 50 E8 78 FA FF FF EB 81 3B D3 7C 14 7F

Stack trace: 
 005ADFF0 0060E660 00000063 005ADFF0 005C59F8 0012F9F8 0043438E 0060E660
 00000000 005ADFF0 0041E6EF 004343E3 005AA578 005AE198 0012FAC0 004345E1
 00000000 0043461A 00000001 005F7DA0 00000000 0043564B 0012FAD8 00000104
 00000000 7E428EA0 00000000 00511708 008A04BE 00000084 00000000 30B3040E
 0092B68C 7E428EAB 567FFB74 0012FA90 0054E4F4 0012FA70 005C512C 00000000
 0012FACC 0012FAD8 00000104 00000000 0012FAE5 000000F6 0012FAD8 00000042
 00000084 00000000 7E428EFC 00000000 0012FAAC 0054E534 0012FAD8 00000104
 005C512C 00000000 0012FACC 0012FBE4 0012FA18 0012FFB0 00563565 00000000
 0012FBE4 0042B443 00000001 00000002 00000000 04B12190 6F747561 65766173
 61732E30 00000076 00000492 0000040E 000002B3 0012FB20 7E418734 008A04BE
 00000113 00000001 04B12190 0051271D DCBAABCD 00000000 0012FB5C 0051271D
 0012FB88 7E418BD9 7FFDF000 0012FB88 7E41989A 0012FB48 7E41986B 00000000
 0012FC20 00000000 00000014 00000001 00000000 00000000 00000010 00000000
 00000001 00000001 00000000 008A04BE 0012FB3C 00000001 0012FBD0 7E44048F
 7E419870 FFFFFFFF 7E41986B 7E419791 00000000 0051271D 008A04BE 00000113
 00000001 7E4189EA 00000000 7E41929B 04B12180 008A04BE 04B12190 0012FC20
 00000000 00000000 0012FBA8 00000001 00000064 00000000 7E41929B 7E42A82E
 7E42A837 0012FBF4 0042B4B0 00000000 0012FBDC 7E42A78F 00512326 00693058
 0060F39C 0012FD14 00000000 0012FBF8 04B12190 04B121AE 00000000 00000000
 008A04BE 00000113 00000001 0051271D 04B12190 0000040E 000002B3 0042ABC2
 0012FD2C 00000001 00000001 00C70000 00000180 00000000 FFFFFFFF 00000000
 7C9100A4 00000000 00000000 FFFFFFFF 0012FE34 005C4E98 00000000 FFFFFFFF
 00000000 00000000 00000000 0000FDE8 00020700 00000000 00020774 0012FCC4
 7C82167A 00000033 FFFFFFFF 00000031 00000100 0000FDE9 0012FD2C 00000001

Module information:
 L:\spill\win32_bin_r13691M-TibPP\openttd.exe handle: 00400000 size: 2156032 crc: 7CF39C0C date: 2008-07-11 06:47:22
 C:\WINDOWS\system32\ntdll.dll handle: 7C900000 size: 701952 crc: F3A022F2 date: 2008-04-14 07:21:34
 C:\WINDOWS\system32\kernel32.dll handle: 7C800000 size: 990720 crc: 6F29C544 date: 2008-04-14 07:22:06
 C:\WINDOWS\system32\WINMM.dll handle: 76B30000 size: 175104 crc: 7BEDE23C date: 2008-04-14 07:22:34
 C:\WINDOWS\system32\ADVAPI32.dll handle: 77DC0000 size: 680448 crc: F532FB73 date: 2008-04-14 07:21:54
 C:\WINDOWS\system32\RPCRT4.dll handle: 77E70000 size: 584704 crc: 24CDCA86 date: 2008-04-14 07:22:20
 C:\WINDOWS\system32\Secur32.dll handle: 77FE0000 size: 56320 crc: B9A4AD9A date: 2008-04-14 07:22:22
 C:\WINDOWS\system32\GDI32.dll handle: 77F10000 size: 285184 crc: 0E0FC0BF date: 2008-04-14 07:22:04
 C:\WINDOWS\system32\USER32.dll handle: 7E410000 size: 578560 crc: 1718C5B9 date: 2008-04-14 07:22:32
 C:\WINDOWS\system32\WS2_32.dll handle: 71AA0000 size: 82432 crc: 143EDF88 date: 2008-04-14 07:22:34
 C:\WINDOWS\system32\msvcrt.dll handle: 77C00000 size: 343040 crc: D029EA11 date: 2008-04-14 07:22:14
 C:\WINDOWS\system32\WS2HELP.dll handle: 71A90000 size: 19968 crc: F4C43B5D date: 2008-04-14 07:22:34
 C:\WINDOWS\system32\OPENGL32.dll handle: 5F240000 size: 713728 crc: E27D7720 date: 2008-04-14 07:22:18
 C:\WINDOWS\system32\GLU32.dll handle: 61550000 size: 123392 crc: EA91460D date: 2008-04-14 07:22:04
 C:\WINDOWS\system32\DDRAW.dll handle: 73730000 size: 279552 crc: 5937997E date: 2008-04-14 07:21:58
 C:\WINDOWS\system32\DCIMAN32.dll handle: 73B90000 size: 8704 crc: 849F3839 date: 2008-04-14 07:21:58
 C:\WINDOWS\system32\avgrsstx.dll handle: 10000000 size: 10520 crc: D2B9D9CC date: 2008-07-05 06:47:02
 C:\WINDOWS\system32\SHFolder.dll handle: 76770000 size: 25088 crc: 6DD9C0E2 date: 2008-04-14 07:22:22
 C:\WINDOWS\system32\SHLWAPI.dll handle: 77F60000 size: 474112 crc: 0BED9332 date: 2008-04-14 07:22:22
 C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.2600.5512_x-ww_35d4ce83\comctl32.dll handle: 773C0000 size: 1054208 crc: 57A0F7A2 date: 2008-04-14 07:19:06
 C:\WINDOWS\system32\comctl32.dll handle: 5D5D0000 size: 617472 crc: 870B149F date: 2008-04-14 07:21:56
 C:\WINDOWS\system32\WINTRUST.dll handle: 76C20000 size: 176640 crc: D0E05E62 date: 2008-04-14 07:22:34
 C:\WINDOWS\system32\CRYPT32.dll handle: 77A70000 size: 600064 crc: E0AB16D2 date: 2008-04-14 07:21:58
 C:\WINDOWS\system32\MSASN1.dll handle: 77B10000 size: 57344 crc: 95DC280E date: 2008-04-14 07:22:12
 C:\WINDOWS\system32\IMAGEHLP.dll handle: 76C80000 size: 144384 crc: D2FDB25D date: 2008-04-14 07:22:04
 C:\WINDOWS\system32\wdmaud.drv handle: 72CF0000 size: 23552 crc: 5BA618B8 date: 2008-04-14 07:23:24
 C:\WINDOWS\system32\msacm32.drv handle: 72CE0000 size: 20480 crc: 52BC6A6F date: 2002-09-16 12:00:00
 C:\WINDOWS\system32\MSACM32.dll handle: 77BD0000 size: 71680 crc: 34E73AB4 date: 2008-04-14 07:22:10
 C:\WINDOWS\system32\midimap.dll handle: 77BC0000 size: 18944 crc: 1660BD48 date: 2008-04-14 07:22:08
 C:\WINDOWS\system32\uxtheme.dll handle: 5B290000 size: 218624 crc: C168CF0D date: 2008-04-14 07:22:32
 C:\WINDOWS\system32\MSCTF.dll handle: 746F0000 size: 297984 crc: B188498A date: 2008-04-14 07:22:12
 C:\WINDOWS\system32\ctagent.dll handle: 02000000 size: 7168 crc: 8991329B date: 2006-08-11 12:56:02
 C:\WINDOWS\system32\mswsock.dll handle: 71A40000 size: 246784 crc: 0F7A3AF8 date: 2008-04-14 07:22:14
 C:\WINDOWS\system32\hnetcfg.dll handle: 698D0000 size: 345088 crc: 7D6C7F3C date: 2008-04-14 07:22:04
 C:\WINDOWS\System32\wshtcpip.dll handle: 71A80000 size: 19456 crc: 087F87B5 date: 2008-04-14 07:22:34
 C:\Programfiler\GPSoftware\Directory Opus\dopushlp.dll handle: 01CC0000 size: 292368 crc: F317EA43 date: 2007-09-13 12:39:12
 C:\WINDOWS\system32\SHELL32.dll handle: 7C9C0000 size: 8466944 crc: 73541E5F date: 2008-04-14 07:22:22
 C:\WINDOWS\system32\MPR.dll handle: 71B10000 size: 59904 crc: 39D5400E date: 2008-04-14 07:22:08
 C:\WINDOWS\system32\ole32.dll handle: 774D0000 size: 1287168 crc: C77BBDA6 date: 2008-04-14 07:22:18
 C:\WINDOWS\system32\OLEAUT32.dll handle: 77110000 size: 551936 crc: E928ACA1 date: 2008-04-14 07:22:18
 C:\WINDOWS\system32\psapi.dll handle: 76BE0000 size: 23040 crc: 344E9591 date: 2008-04-14 07:22:20

System information:
 Windows version 5.1 2600 S

---- gamelog start ----
Tick 0: new game started
     Revision text changed to r13691M-TibPP, savegame version 123, maybe modified, _openttd_newgrf_version = 0x0700357b
     New game mode: 1 landscape: 2
---- gamelog end ----

[Chico008]

i got the same error with Daylenght when saving every day;
trying changing the autosave to quarter or every 6 months.

Tibs, the patch list is stiil the same as V1 ? waht are the updates ?

thx

[Tiberius]

To nonick37:
Sorry but those backtrack is dutch to me ... It's easier for me to debug if I can "reproduce" the situation.
Perhaps you can upload your openttd.cfg and describe the steps after you started OpenTTD, IN DETAIL ?
i.e. what configurations you have modified, how did you created the new map, etc.
I guess at least you touched Daylength Factor and Autosave interval ?

EDIT: Seems I got it. Daylength patch is overflowing the competitor-starting timer, which have 32 bits in memory but only 16 bits in savegame ... I'll roll-out a patch soon.

Tibs, the patch list is stiil the same as V1 ? waht are the updates ?

Updating that list of patches to trunk actually takes quite some work
I'll try add something new later, you can also try the Russian OpenTTD Community Patchpack if you want LOTS of features

[Chico008]

i can still follow th egerman tracker, but russian is impossible for me

[nonick37]

well this was done with everything default.. or maybe settings are copied from another version of the game. I didnt change any setting here at least. But good, you found the bug. daylength was set to 50 or so here. And it did occur during some saving action. So good job

[Tiberius]

Hopefully I've fixed the bug, please refer to the first post for updated patch & binaries

[nonick37]

My game doesnt crash like it used to, so i guess you've fixed it.

I used to play the russian patch, but somehow in the end it was so buggy, that it wasnt fun anymore.. several ruined savegames..
But one thing was quite nice. Copy&paste did copy the path based signals as well. It does not in this patchpack. If this isnt hard to change, it would be nice, if not, well isnt the end of the world.

Managed to compile the daily.. so maybe i should be able to help out soon. need to refresh my c/c++ skills a bit first tho..

[Tiberius]

Copy&paste did copy the path based signals as well. It does not in this patchpack. If this isnt hard to change, it would be nice, if not, well isnt the end of the world.

It turns out to be a one-liner (bug) ...
Therefore I've updated the binary & patch, in the first post as usual

[nonick37]

juhu. if only microsoft were as fast as you!

now its close to perfect. Of course a on desync destination patch would be great to make the game more realistic. And signals/waypoints programmable. But, this is still awsome!

[Chico008]

Thanks for tou work.

but i have error when compiling :



the first one is not the probleme, but the folowings ones are.
what is the operand to use ?

in the file, it theses lines :

Code: Select all

377	data[i][j] += (data[i][j-k] == INVALID_DATAPOINT ? 0 : data[i][j-k]);
388     data[i][j] -= (data[i][j-1] == INVALID_DATAPOINT ? 0 : data[i][j-1]);

i compile with Cygwin, but got the same errors on Ubuntu.

[nonick37]

I am sorry but I think.. if it isnt only my computer.. that i found a new bug. The Transfer/unload button is empty in the vehicle orders list.
The same button is used by the order jumping (or whatever it is calle) patch, and the button works for this patch. At least I guess thats the same button.
I havent really used the functionality of this patch, but it do seem like a very nice idea

[Chico008]

yes, the last case is always empty.
for normal use, can't select the unload method.
for conditionnal orderd, can't select the cargo for waiting/acceptation.

[AndiK]

Would it be possible to add this patch?
Although you say that the current timetable implementation "works great", i find it incredibly stupid to spend a lot of time manually spreading trains around a timetable and constantly revisiting existing routes to fine tune their timetable.
I know that the code is a littttle bit outdated, but hope's the last thing to die...


PS: There's a more recent "alternative" implementation of the same functionality somewhere in the forum. It works differently and is only semi-automatic and a bit static. I can only speak for myself, but I've never really gotten into it. Full automation ftw! \o/

Bye
Andi

[Chico008]

another bug

when some autosave are already present, lunching a new server, when someone connect, the server crash :

Code: Select all

openttd: /openttd/src/saveload.cpp:506: void SlSaveLoadConv(void*, VarType): Assertion `x >= 0 && x <= 65535' failed.

[Tiberius]

(As usual please see the first post for updated files)

Updated to r13704.
Fixed Transfer/Unload button problem (strange patch error ...)
Fixed GCC unhappy with graph_gui.cpp problem

(The SSE2 build is way more popular than I anticipated, honestly ...
Seems there are MANY people playing OTTD with a decent computer yes? )

[Chico008]

thanks for the patch of the patch

i'll test it in multiplayer, and if there are some remaining bugs, i'll report.

[Chico008]

got a bug after 10 hours of game

Code: Select all

openttd: /srv/r13704M/src/train_cmd.cpp:2932: Track ChooseTrainTrack(Vehicle*, TileIndex, DiagDirection, TrackBits, bool, bool*, bool): Assertion `IsFrontEngine(v)' failed.