Oh, btw, you can set openttd process affinity to one core - in some way it boost game speed drastically, while lowering fps and increasing lag spikes.Leanden wrote:The map size unfortunately has to stay as it is because of a project i am working on which needs the smaller scale
JGR's Patch Pack
Moderator: OpenTTD Developers
Re: JGR's Patch Pack
Re: JGR's Patch Pack
I can't reproduce any problem here. Any more info might be helpful.aberro wrote:I have some strange bug - I barely can scroll map in cargo flow mode. It's like it's returning to same point it was a frame before. And the more stations there is the harder becomes to scroll map. Sadly, I don't have time to debug now.
Increasing the day length may help with this.Leanden wrote:The map size unfortunately has to stay as it is because of a project i am working on which needs the smaller scale
I'm not sure about this. A few things, in particular link graph update jobs, are run in separate threads.aberro wrote:Oh, btw, you can set openttd process affinity to one core - in some way it boost game speed drastically, while lowering fps and increasing lag spikes.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
Well, I just open map, scroll it somewhere into any area with a dense traffic, switch it to cargo flow mode and try to scroll it, but it's only jitters and almost not moving.JGR wrote:I can't reproduce any problem here. Any more info might be helpful.
Maybe, but nonetheless, when I set affinity to single core, game runs in fast-forward, like, two times faster, all vehicles just flashes through the screen, but fps drops by two-three times (or it's not really fps drops, but lag spike increases).JGR wrote:I'm not sure about this. A few things, in particular link graph update jobs, are run in separate threads.
Re: JGR's Patch Pack
Hello,
I wonder if JGR can fix panning issue on Windows RS3? Here is a copy-paste from related thread:
Much appreciated!
I wonder if JGR can fix panning issue on Windows RS3? Here is a copy-paste from related thread:
I think it will take years for openttd devs to fix this so the only hope is JGRtomb wrote:The patch working for me is:
file win32_v.cpp, line 750:
if (_cursor.UpdateCursorPosition(x, y, false)) {
I've only changed true to false in the mentioned line to avoid queued mouse events processing inside CursorVars::UpdateCursorPosition. When building with SDL video driver (not my case), you'll find similar line in sdl_v.cpp (line 535).
Note: It seems to be the workaround only. As fas as I understand the code, queued mouse event processing was introduced to improve cursor behaviour "esp. when OpenTTD lags a bit" (quote from source code comment). My observation is: on modern PCs processing the queue is not required. That's why I disabled it, not trying to find the bug in processing (I don't know the sources well, spent 2 hours on the whole process).
Much appreciated!
Ask, and it shall be given you.
Seek, and ye shall find.
Knock, and it shall open unto you.
Seek, and ye shall find.
Knock, and it shall open unto you.
Re: JGR's Patch Pack
Was just about to post this. Any chance you could slip this in your upcoming update JGR?eshield wrote:Hello,
I wonder if JGR can fix panning issue on Windows RS3? Here is a copy-paste from related thread:I think it will take years for openttd devs to fix this so the only hope is JGRtomb wrote:The patch working for me is:
file win32_v.cpp, line 750:
if (_cursor.UpdateCursorPosition(x, y, false)) {
I've only changed true to false in the mentioned line to avoid queued mouse events processing inside CursorVars::UpdateCursorPosition. When building with SDL video driver (not my case), you'll find similar line in sdl_v.cpp (line 535).
Note: It seems to be the workaround only. As fas as I understand the code, queued mouse event processing was introduced to improve cursor behaviour "esp. when OpenTTD lags a bit" (quote from source code comment). My observation is: on modern PCs processing the queue is not required. That's why I disabled it, not trying to find the bug in processing (I don't know the sources well, spent 2 hours on the whole process).
Much appreciated!
Re: JGR's Patch Pack
eshield wrote:Hello,
I wonder if JGR can fix panning issue on Windows RS3? Here is a copy-paste from related thread:I think it will take years for openttd devs to fix this so the only hope is JGRtomb wrote:The patch working for me is:
file win32_v.cpp, line 750:
if (_cursor.UpdateCursorPosition(x, y, false)) {
I've only changed true to false in the mentioned line to avoid queued mouse events processing inside CursorVars::UpdateCursorPosition. When building with SDL video driver (not my case), you'll find similar line in sdl_v.cpp (line 535).
Note: It seems to be the workaround only. As fas as I understand the code, queued mouse event processing was introduced to improve cursor behaviour "esp. when OpenTTD lags a bit" (quote from source code comment). My observation is: on modern PCs processing the queue is not required. That's why I disabled it, not trying to find the bug in processing (I don't know the sources well, spent 2 hours on the whole process).
Much appreciated!
In the thread it looks to be a more complicated problem than is solved by the workaround above.Gliptal wrote:Was just about to post this. Any chance you could slip this in your upcoming update JGR?
I don't have a Windows system to test on, which makes testing more complicated.
I'm inclined to wait until a more complete/permanent solution is available.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
Hey JGR, could you please add a link to Github release page RSS feed to the first post? It's easier to get notified about new releases using RSS feed than watching the forum activity (the last version did not get any announcement, I've noticed it only when servers with version 0.22.0 started appearing).
For some reason Android version crashes very often on user devices, and stack traces are not very usable - it's usually inside main loop in HandleMouseEvents(), when iterating through window list, it looks like a memory corruption or use-after-delete. Considering the amount of Android-specific patches, I don't think it will be easy to reproduce on PC. If anyone is able to reproduce this crash on Android via specific steps, please tell me.
For some reason Android version crashes very often on user devices, and stack traces are not very usable - it's usually inside main loop in HandleMouseEvents(), when iterating through window list, it looks like a memory corruption or use-after-delete. Considering the amount of Android-specific patches, I don't think it will be easy to reproduce on PC. If anyone is able to reproduce this crash on Android via specific steps, please tell me.
Re: JGR's Patch Pack
I understand, given the latest info I support your decision of waiting it out. Not that my support means anything that is.JGR wrote:In the thread it looks to be a more complicated problem than is solved by the workaround above.
I don't have a Windows system to test on, which makes testing more complicated.
I'm inclined to wait until a more complete/permanent solution is available.
On another note, savegames are fully compatible between updates, correct?
Re: JGR's Patch Pack
Object placement, specifically fenced land. Is that part of this patch, or part of the official/trunk game? I've found a bug with it.
When you buy land with sign placement, you can only buy it once. If you try to buy it again, you get a message that you already own it. If you try to place fenced land on top of fenced land, it allows it to happen, with the accompanying charge. It should give the same "You already own it" message.
On a related note, are we ever going to get draggable sign placement? I hate having to click 30 individual tiles around an airport. I'd rather be able to click-and-drag to do it.
When you buy land with sign placement, you can only buy it once. If you try to buy it again, you get a message that you already own it. If you try to place fenced land on top of fenced land, it allows it to happen, with the accompanying charge. It should give the same "You already own it" message.
On a related note, are we ever going to get draggable sign placement? I hate having to click 30 individual tiles around an airport. I'd rather be able to click-and-drag to do it.
Re: JGR's Patch Pack
That is done now.pelya wrote:Hey JGR, could you please add a link to Github release page RSS feed to the first post? It's easier to get notified about new releases using RSS feed than watching the forum activity (the last version did not get any announcement, I've noticed it only when servers with version 0.22.0 started appearing).
Yes there should be full backwards compatibility for loading savegames from previous patchpack versions and trunk, and limited compatibility for loading from other versions as listed in the first post.Gliptal wrote:On another note, savegames are fully compatible between updates, correct?
I'm not aware of any changes to NewGRF objects in this patchpack. It's not a feature that I use or test.cmhbob wrote:Object placement, specifically fenced land. Is that part of this patch, or part of the official/trunk game? I've found a bug with it.
You may want to check the trunk behaviour and/or raise it with the NewGRF author.
It's not something that there seems to much demand or need for. Why is there a need to purchase tiles around an airport?cmhbob wrote:On a related note, are we ever going to get draggable sign placement? I hate having to click 30 individual tiles around an airport. I'd rather be able to click-and-drag to do it.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
I do that to secure land for airport expansion so I don't have to bulldoze a bunch of stuff in the future. I've also done it around train stations for the same reason.JGR wrote:It's not something that there seems to much demand or need for. Why is there a need to purchase tiles around an airport?cmhbob wrote:On a related note, are we ever going to get draggable sign placement? I hate having to click 30 individual tiles around an airport. I'd rather be able to click-and-drag to do it.
Now the hard part is figuring out which newgrf that is. Actually, it looks like it's OpenGFX+Landscape.
Thanks for the reply.
Re: JGR's Patch Pack
May I ask for a small but important fix:
force New orders are 'non-stop' by default to true if any infrastructure settings are enabled.
Implicit orders should not be available in case of infrastructure sharing.
Many inexperienced users keep this option off as it is default in original openttd, which make terrible mess if somebody put two station in shared town and buses start unattended to go to competitors stations.
This mess is even quadrupled when cargodist is enabled...
force New orders are 'non-stop' by default to true if any infrastructure settings are enabled.
Implicit orders should not be available in case of infrastructure sharing.
Many inexperienced users keep this option off as it is default in original openttd, which make terrible mess if somebody put two station in shared town and buses start unattended to go to competitors stations.
This mess is even quadrupled when cargodist is enabled...
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
Re: JGR's Patch Pack
Objects have been around for many years and any trunk bugs should have been worked out by now. Take this bug to the object author and let him/her deal with it.JGR wrote:I'm not aware of any changes to NewGRF objects in this patchpack. It's not a feature that I use or test.cmhbob wrote:Object placement, specifically fenced land. Is that part of this patch, or part of the official/trunk game? I've found a bug with it.
You may want to check the trunk behaviour and/or raise it with the NewGRF author.
wallyweb on tt-forums: Screenshots - Wallyweb World - Projects & Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
Re: JGR's Patch Pack
Unfortunately there is still bug related to "disallow removing water tiles" option. It is not possible to fund water industries, for example FIRS fishing grounds or ports, this include game generation - no such industry appears.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
Re: JGR's Patch Pack
Really 'non-stop' should be the default anyway.McZapkie wrote:May I ask for a small but important fix:
force New orders are 'non-stop' by default to true if any infrastructure settings are enabled.
Implicit orders should not be available in case of infrastructure sharing.
Many inexperienced users keep this option off as it is default in original openttd, which make terrible mess if somebody put two station in shared town and buses start unattended to go to competitors stations.
This mess is even quadrupled when cargodist is enabled...
However, ignoring the user setting may generate additional bug reports due to user confusion.
Some users seem to be averse to non-stop orders.
I will look into/consider this.
This should be fixed now, thanks for the bug report.McZapkie wrote:Unfortunately there is still bug related to "disallow removing water tiles" option. It is not possible to fund water industries, for example FIRS fishing grounds or ports, this include game generation - no such industry appears.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
Yes, this is a long term fix related to the trunk, but forcing option if infrastructure sharing is enabled can be a short term fix, I doubt anybody would complain, because intentionally used "random walking" play style is rather uncommon, especially on servers using shared infrastructure.JGR wrote: Really 'non-stop' should be the default anyway.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
- Redirect Left
- Tycoon
- Posts: 7249
- Joined: 22 Jan 2005 19:31
- Location: Wakefield, West Yorkshire
Re: JGR's Patch Pack
Fall update for Windows 10 breaks RMB panning of the map, it's described here; viewtopic.php?f=31&t=77042 - i just got the fall update and this has now caused issues for me, in patchpack and trunk
Would be ace if you could figure out how to fix it and put it into the patchpack!
Would be ace if you could figure out how to fix it and put it into the patchpack!
- wicket-303
- Engineer
- Posts: 21
- Joined: 19 Sep 2017 05:52
- Location: Japan
- Contact:
Re: JGR's Patch Pack
Hello
JGR's Patch Pack is very wonderful. However, the time and day will inevitably deviate ...
Is it impossible to fit "Tick per minute" and "Day lengch factor" perfectly?
JGR's Patch Pack is very wonderful. However, the time and day will inevitably deviate ...
Is it impossible to fit "Tick per minute" and "Day lengch factor" perfectly?
Re: JGR's Patch Pack
I'd say more - is it impossible to make "Tick per minute" floating point? Because I'm using "Day length factor" times 10 and trying to align 24 hours with year, but it's definitely impossible, target value is 187.69791(6) (74 ticks per day * 10 daytime factor * 365.25 days in year = 270285, divided by 1440 minutes in day)wicket-303 wrote:Hello
JGR's Patch Pack is very wonderful. However, the time and day will inevitably deviate ...
Is it impossible to fit "Tick per minute" and "Day lengch factor" perfectly?
Re: JGR's Patch Pack
Just discovered this and wow,
playing around with the signal routing and its so useful when you have a mix of platform lengths in a station and a mix of through and bay platforms,
the only thing i have not yet got my head around is slot operations,
is there any link which describes how to use them?
playing around with the signal routing and its so useful when you have a mix of platform lengths in a station and a mix of through and bay platforms,
the only thing i have not yet got my head around is slot operations,
is there any link which describes how to use them?
Who is online
Users browsing this forum: No registered users and 50 guests