Improved Shares - Patch 1

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Improved Shares - Patch 1

Post by TheJosh »

Hey,

I'm going to be making some improvements to shares.
For a complete overview of the changes I'm planning, see this url:
http://wiki.openttd.org/index.php/User: ... ved_Shares

This is part 1, its a small GUI overhaul

The only change in this patch is that all of the owners of a company are now properly listed, and they are under the heading "Company owners:" This is to make way for the future overhaul of shares.

This patch will cause the company window to grow or shrink depending on the number of owners.

This patch also causes the current company to be listed as an owner, so if no-one has bought shares, the current company will be 100% owner. If someone buys 25% of the shares, the current company will become 75% owner, etc etc. If 4 different companies own 25% each, the current company will not be listed.

This patch does not in any way affect the way shares are handled by the game. It is merely a cosmetic patch.


Patch Version: 1.4
OpenTTD Rev: 13013

Changes:
1.1: Made the current player be shown as the manager name.
1.2: Updated the patch to revision 12437
1.3: Updated the patch to revision 12537
1.4: Updated the patch to revision 13013
Attachments
Screen shot showing 4 companies
Screen shot showing 4 companies
Screenshot.png (103.31 KiB) Viewed 7152 times
shares.part1.version1.4.patch
Version 1.4 of the patch, created against rev 13013
(6.39 KiB) Downloaded 144 times
Last edited by TheJosh on 08 May 2008 14:02, edited 6 times in total.
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

User avatar
athanasios
Tycoon
Tycoon
Posts: 3138
Joined: 23 Jun 2005 00:09
Contact:

Re: Improved Shares - Patch 1

Post by athanasios »

Such info shouldn't be missing from trunk from the beginning.
http://members.fortunecity.com/gamesart
"If no one is a fool I am also a fool." -The TTD maniac.


I prefer to be contacted through PMs. Thanks.

User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: Improved Shares - Patch 1

Post by Ammler »

Hmm, how does a company own itself? Shouldn't the owner be the Manager then?

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Re: Improved Shares - Patch 1

Post by TheJosh »

A company owns itself if its unowned by someone else It was simply implied in the previous gui, but is specific now
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Re: Improved Shares - Patch 1

Post by Bilbo »

This could be useful, even with current code company can be owned by 3 different people nd current code shows only first two I think.

I think that the line with "self-ownage" should be painted in another color, so you will more easily recognize that it is you. Or perhaps replace the company name by string like "owned by itself" too.
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)

Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4754
Joined: 09 Sep 2007 05:03
Location: home

Re: Improved Shares - Patch 1

Post by Alberth »

Maybe use the name of the company-owner for the self-ownership?

[edit: fixed typo]

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Re: Improved Shares - Patch 1

Post by TheJosh »

What about:

50% owned by itself
25% owned by Pizza Transport
25% owned by Random Transport

I don't mind changing it, as long as there is some kind of consensus.
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

T-Unit
Transport Coordinator
Transport Coordinator
Posts: 368
Joined: 03 Feb 2007 18:53
Location: Leeds, England

Re: Improved Shares - Patch 1

Post by T-Unit »

It would be better if it was the name of the Company Owner.

User avatar
WWTBAM
Moderator
Moderator
Posts: 3682
Joined: 02 Apr 2005 07:01
Location: Sydney NSW Antipodea
Contact:

Re: Improved Shares - Patch 1

Post by WWTBAM »

T-Unit wrote:It would be better if it was the name of the Company Owner.
agree with T-Unit
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Re: Improved Shares - Patch 1

Post by TheJosh »

What do people mean by the "company owner"? does that mean the manager?
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4754
Joined: 09 Sep 2007 05:03
Location: home

Re: Improved Shares - Patch 1

Post by Alberth »

TheJosh wrote:What do people mean by the "company owner"? does that mean the manager?
I just missed you at #openttd... yes, I mean to use the name of the manager.

Sincerely, Albert

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Re: Improved Shares - Patch 1

Post by TheJosh »

I will change the patch to use the name of the manager, as per many requests
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

dibsen
Engineer
Engineer
Posts: 3
Joined: 27 Aug 2007 11:28

Re: Improved Shares - Patch 1

Post by dibsen »

Using the manager's name seems completely senseless to me since you do not own your company. In fact the company's shares are available on the market as long no company buys them; so i would find a simple phrase like "xx% available" more accurate.

Btw.: I always missed the possibility of emitting new shares like I was used to do back then when I was no Transport but a Railroad Tycoon. ;)

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Re: Improved Shares - Patch 1

Post by TheJosh »

I have updated the patch to version 1.1
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

User avatar
leno4
Traffic Manager
Traffic Manager
Posts: 247
Joined: 10 Mar 2008 02:45
Location: Australia

Re: Improved Shares - Patch 1

Post by leno4 »

should be added to the trunk, would be good for mp

dibsen
Engineer
Engineer
Posts: 3
Joined: 27 Aug 2007 11:28

Re: Improved Shares - Patch 1

Post by dibsen »

Sorry for posting without checking the newest patch... please allow me to ask three simple questions anyway.
Am I overruled? Is the manager in 100% possession of is company by default? And is she/he neither asked if shares she/he owns are sold nor is accounted the value of those?

User avatar
leno4
Traffic Manager
Traffic Manager
Posts: 247
Joined: 10 Mar 2008 02:45
Location: Australia

Re: Improved Shares - Patch 1

Post by leno4 »

Ammler wrote:Hmm, how does a company own itself? Shouldn't the owner be the Manager then?
Maybe if you open your eyes you will see that is has "manager" in (brackets)

T-Unit
Transport Coordinator
Transport Coordinator
Posts: 368
Joined: 03 Feb 2007 18:53
Location: Leeds, England

Re: Improved Shares - Patch 1

Post by T-Unit »

@leno4: it didnt when he said that
@dibsen: When you set up a company you own the whole company as you will be putting in the money for it, or borrowing it from the bank against your own collateral. Therefore the manager owns 100% of the shares until they decide to go public and sell them off.

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Re: Improved Shares - Patch 1

Post by TheJosh »

I have updated the patch again to r12437. See the first post.
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

TheJosh
Engineer
Engineer
Posts: 75
Joined: 17 Apr 2007 12:19
Contact:

Re: Improved Shares - Patch 1

Post by TheJosh »

With the release of 0.6.0, the devs will be happy to start accepting patches and the like, therefore I have updated the patch to the latest trunk rev.

See the first post.
Want to make a real difference? Australia HOPE International - Bringing hope to African orphans and widows.

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 3 guests