Patch: Password at join -- r11876

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply

Do you like this patch? (Please comment)

Like
12
100%
Don't like
0
No votes
 
Total votes: 12

User avatar
NukeBuster
Traffic Manager
Traffic Manager
Posts: 222
Joined: 04 Jan 2006 18:16
Location: Alphen aan den Rijn, The Netherlands
Contact:

Patch: Password at join -- r11876

Post by NukeBuster » 16 Jan 2008 16:55

Password at join
A few days ago a saw a suggestion, to let the password dialog box show when joining a network game so setting a password will not be forgotten.

Suggestion.

I present you a very small patch(4 new lines:)), please try it and give comments/suggestions.

*edit: To test it, you'll have to compile with "./configure --revision=11876".

How does it work?
-When joining a new company and no default password is set in openttd.cfg it will show this dialog(the same as in the company menu).
-When no password is desired, just hit enter.
-It only affects network games.
Picture of the password dialog at join.
Picture of the password dialog at join.
Unnamed, 23rd May 1950.png (34.3 KiB) Viewed 7067 times
Attachments
password_at_join_r11876.patch
r11876
(755 Bytes) Downloaded 196 times
Last edited by NukeBuster on 02 Feb 2008 00:33, edited 5 times in total.
NukeBuster

Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !

OpenTTD patch(es): Password at join

User avatar
XeryusTC
Tycoon
Tycoon
Posts: 15415
Joined: 02 May 2005 11:05
Skype: XeryusTC
Location: localhost

Re: Patch: Password at join -- r11876

Post by XeryusTC » 16 Jan 2008 18:15

Could you make it a server wide option to turn this off? It isn't very useful when people get prompted for passwords on the #openttdcoop sandbox server. There is already a rolling password in place there.
Don't panic - My YouTube channel - Follow me on twitter (@XeryusTC) - Play Tribes: Ascend - Tired of Dropbox? Try SpiderOak (use this link and we both get 1GB extra space)
Image
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
Image Image Image Image Image Image Image

User avatar
NukeBuster
Traffic Manager
Traffic Manager
Posts: 222
Joined: 04 Jan 2006 18:16
Location: Alphen aan den Rijn, The Netherlands
Contact:

Re: Patch: Password at join -- r11876

Post by NukeBuster » 16 Jan 2008 19:17

Do they all share the same company?

If they join an existing company they won't get the dialog. (So only the original owner will get the password prompt when creating a NEW company) Also if enter is pressed no password is set.

And besides that, if they have a default password set in openttd.cfg in the present nightly(not my patch) then that password will be used as password for the new company.
Last edited by NukeBuster on 21 Jan 2008 13:43, edited 1 time in total.
NukeBuster

Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !

OpenTTD patch(es): Password at join

User avatar
osai
Traffic Manager
Traffic Manager
Posts: 132
Joined: 22 Sep 2004 14:56
Location: 10.0.1.254
Contact:

Re: Patch: Password at join -- r11876

Post by osai » 16 Jan 2008 22:18

They do.
Only the server password changes. No need to set a company password anymore.

User avatar
NukeBuster
Traffic Manager
Traffic Manager
Posts: 222
Joined: 04 Jan 2006 18:16
Location: Alphen aan den Rijn, The Netherlands
Contact:

Re: Patch: Password at join -- r11876

Post by NukeBuster » 16 Jan 2008 23:05

Well, without my patch. If anyone who joins creates a new company and has a default password set in openttd.cfg you would probably already have the same problem.
NukeBuster

Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !

OpenTTD patch(es): Password at join

User avatar
NukeBuster
Traffic Manager
Traffic Manager
Posts: 222
Joined: 04 Jan 2006 18:16
Location: Alphen aan den Rijn, The Netherlands
Contact:

Re: Patch: Password at join -- r11876

Post by NukeBuster » 18 Jan 2008 20:25

XeryusTC wrote:Could you make it a server wide option to turn this off? It isn't very useful when people get prompted for passwords on the #openttdcoop sandbox server. There is already a rolling password in place there.
I will make a second patch, for just that. A password deny/allow option so setting a company password can be disabled by the server.
NukeBuster

Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !

OpenTTD patch(es): Password at join

User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Re: Patch: Password at join -- r11876

Post by Bilbo » 20 Jan 2008 17:03

I believe that there is some sort of patch from the WWOTTD that disallows players to mess with the company in which they are in (i.e. changing color scheme, face, name, password ...)

It was sort of some dirty hack (player atempting to change these things were simply removed from server and the change was not done), but perhaps it could be done as server-side patch option more cleanly.
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)

dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Password at join -- r11876

Post by dihedral » 22 Jan 2008 20:11

dirty is an understatement :-)

User avatar
NukeBuster
Traffic Manager
Traffic Manager
Posts: 222
Joined: 04 Jan 2006 18:16
Location: Alphen aan den Rijn, The Netherlands
Contact:

Re: Patch: Password at join -- r11876

Post by NukeBuster » 31 Jan 2008 23:03

What do you think about this patch?
NukeBuster

Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !

OpenTTD patch(es): Password at join

User avatar
Zuu
OpenTTD Developer
OpenTTD Developer
Posts: 4553
Joined: 09 Jun 2003 18:21
Location: /home/sweden

Re: Patch: Password at join -- r11876

Post by Zuu » 02 Feb 2008 23:16

I think it is a good idea. I haven't tried the patch myself though.

Also if I understand your answer correctly OpenTTDCoop server will not have a problem with your patch as it will only pop up the password-window on new companies.

So is there anyone that still have any objections against the patch?
My OpenTTD contributions (AIs, Game Scripts, patches, OpenTTD Auto Updater, and some sprites)
Junctioneer (a traffic intersection simulator)

User avatar
NukeBuster
Traffic Manager
Traffic Manager
Posts: 222
Joined: 04 Jan 2006 18:16
Location: Alphen aan den Rijn, The Netherlands
Contact:

Re: Patch: Password at join -- r11876

Post by NukeBuster » 02 Feb 2008 23:25

Zuu wrote:I think it is a good idea. I haven't tried the patch myself though.

Also if I understand your answer correctly OpenTTDCoop server will not have a problem with your patch as it will only pop up the password-window on new companies.

So is there anyone that still have any objections against the patch?
I guess I'll have to bug the devs about this. Will add a comment in flyspray tommorrow.
NukeBuster

Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !

OpenTTD patch(es): Password at join

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 10 guests