Page 2 of 3

Re: [Patch] Industry Station Names (r12044)

Posted: 04 Feb 2008 09:27
by peter1138
Arrrr, fair enough.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 15 Nov 2008 16:28
by a.locritani
Sorry for resurrecting this post: I only want to signal that with a big help of Micheal Blunk, I wrote a grf that does (almost) what your patch does. I know that now it's doesn't works for OTTD, but when property 24 is implemented, I hope it can be useful.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 11 Aug 2010 22:26
by Vaulter
a.locritani wrote:Sorry for resurrecting this post: I only want to signal that with a big help of Micheal Blunk, I wrote a grf that does (almost) what your patch does. I know that now it's doesn't works for OTTD, but when property 24 is implemented, I hope it can be useful.
Please note that this grf is not intended to be used with another industries' grf - only use it with default industries (thanks Michael for pointing it out)
But, judging by posts in this threads, this patch works with any industries

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 11 Aug 2010 22:55
by Gremnon
It's also 2 years old, and over 8000 revisions out of date.
Which would seem to make it rather obsolete all the same.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 11 Aug 2010 22:56
by Yexo
Yes. On the other hand the patch is now nearly 2 years old while that newgrf still works. Also that patch will never be included in trunk (since it can be done by a newgrf). So what exactly is the reason to resurrect this topic?

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 12 Aug 2010 11:14
by Vaulter
Yexo wrote:Yes. On the other hand the patch is now nearly 2 years old while that newgrf still works. Also that patch will never be included in trunk (since it can be done by a newgrf). So what exactly is the reason to resurrect this topic?
read carefully. Again:
Please note that this grf is not intended to be used with another industries' grf - only use it with default industries (thanks Michael for pointing it out)

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 12 Aug 2010 12:13
by Yexo
Yes, I know that. Did you also read my answer to that?
1. The patch is very old, it needs to be updated to actually work.
2. This patch (even if updated) will never be included in trunk.
3. The newgrf still works, and if you want the same behavior while using industry newgrfs you're better of posting in those newgrf topics to ask them to implement this too.
Who is going to update a patch that has exactly 0 chance of getting in trunk?

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 12 Aug 2010 12:50
by Vaulter
Yexo wrote:Yes, I know that. Did you also read my answer to that?
1. The patch is very old, it needs to be updated to actually work.
2. This patch (even if updated) will never be included in trunk.
3. The newgrf still works, and if you want the same behavior while using industry newgrfs you're better of posting in those newgrf topics to ask them to implement this too.
Who is going to update a patch that has exactly 0 chance of getting in trunk?
1. No problem
2. Didn't even mind
3. Ok.

Patch Updated

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 12 Aug 2010 15:47
by JacobD88
Vaulter wrote:Patch Updated
Thanks vaulter :bow: , this is much more useful to me than requesting that all the NewGRF Industry authors update their GRFs or altering them myself where we are allowed to. It's a shame this is unlikely to make it into trunk. A centralised feature to control station naming by industry is much more appealing to me than having to rely on the GRF authors wanting to include that feature as it gives me control without having to mod GRFs :wink:

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 12 Aug 2010 18:00
by Gremnon
Out of curiosity, does that patch only apply against 1.0.3, or trunk as well? If trunk plays nice with it, I've got an idea I want to experiment with using this patch.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 12 Aug 2010 19:12
by Vaulter
Gremnon wrote:Out of curiosity
You just should to check. Patch is very simple to have any issues applying to trunk.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 12 Aug 2010 19:43
by Gremnon
I'm having a few slight arguments with the computer at the moment that are preventing me from actually checking, which is why I asked. Will check myself soon as I can.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 11 Dec 2010 10:21
by xmirakulix
The Patch didn't apply anymore after the changes in
(svn r21444) -Codechange: compute the type of elements in the argv string array on the fly and compare it with the type set by strgen
I am attaching an updated patch against r21459.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 28 May 2011 16:03
by xmirakulix
These changes broke the patch:
(svn r22258) -Codechange: introduce a wrapper class to clean up the arguments to FormatString
Attaching the patch against trunk r22502.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 31 May 2011 17:23
by xmirakulix
Patch updated to apply against current trunk

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 01 Oct 2011 08:31
by xmirakulix
Updated to current trunk

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 04 Sep 2013 20:57
by R2dical
Update to latest nightly, and also a shot at the coding style used for openttd :)

Edit: Oh yes, I changed the distance from 4 to 3, so stations will get the industry name only if it services the industry.

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 13 Dec 2013 20:51
by frabac
Hi there.

I start by thanking you so much because this patch, although not dramatic, is SO nice to have, especially when you have a big map and you want remember where things are: THANK YOU.

And... I bring you good news: I have just applied it to r26156 and it works just fine! Among the many patches I tried, this is the first one that just works without complaining :-)

So, happy transporting everyone! :-)

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 19 Jan 2014 22:39
by skippern
Good enough having the industry type (or resource type) in the station name, but when multiple industries are within the area of a station, names could be {Town} Industries, {Town} Industrial Park, etc.

So we could have the following stations:
Sometown Coal Mines
Sometown Factory
Sometown Power Plant
Sometown Iron Ore
Sometown Farms
Sometown Industries
Sometown Oil Wells

Re: [Patch] Industry Station Names (v1; r12436)

Posted: 22 Jan 2014 10:30
by R2dical
Shouldn't be too hard to add a multiple industries check in, would have to go in just before the added industry check...