Patch: Build UNDER Slopes

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

How?

Cool :)
112
96%
Crap :)
5
4%
 
Total votes: 117

User avatar
benc
Engineer
Engineer
Posts: 62
Joined: 30 Apr 2007 01:57

tunnel building broken

Post by benc »

Ev wrote:*fix for destructive tunnel's end bug;
Can you elaborate on what this bug is? I can't find it on http://bugs.openttd.org/

If you're just referring to ability to build the tunnel below without having to manually excavate the other end: that's a usability feature, not a bug! Please don't break it.
Attachments
tunnel_excavation.png
tunnel_excavation.png (7.27 KiB) Viewed 3835 times
Ev
Engineer
Engineer
Posts: 21
Joined: 19 Jun 2007 18:59

Post by Ev »

----------
Last edited by Ev on 27 Jun 2007 22:07, edited 3 times in total.
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Post by DaleStan »

FFS!!! Just fix put an appropriate is-tile-clear check before the terraforming.

Don't disable it because it's broken. FIX IT!
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
Ev
Engineer
Engineer
Posts: 21
Joined: 19 Jun 2007 18:59

Post by Ev »

----------
Last edited by Ev on 27 Jun 2007 22:00, edited 1 time in total.
User avatar
benc
Engineer
Engineer
Posts: 62
Joined: 30 Apr 2007 01:57

Post by benc »

Cool. Did you ever request re-open for FS#890? New-feature patches shouldn't be fixing bugs. The trunk needs the fix regardless of whether the feature is accepted. :)
peter1138
OpenTTD Developer
OpenTTD Developer
Posts: 1732
Joined: 30 Mar 2005 09:43

Post by peter1138 »

Huh? FS#890 was fixed...
He's like, some kind of OpenTTD developer.
User avatar
benc
Engineer
Engineer
Posts: 62
Joined: 30 Apr 2007 01:57

Post by benc »

It was marked as fixed but r10219 didn't actually fix the problem. Not sure why Ev didn't re-report it earlier.

Attached is a bugfix patch, extracted from the main build-under-slopes patch. All credit to Ev of course.
Attachments
fix_tunnel_autoexcavate_r10300.diff
(926 Bytes) Downloaded 130 times
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Post by Rubidium »

benc wrote:It was marked as fixed but r10219 didn't actually fix the problem.
How do I reproduce that, because the bug reported in FS#890 is fixed in trunk, i.e. I cannot reproduce it anymore.
Ev
Engineer
Engineer
Posts: 21
Joined: 19 Jun 2007 18:59

Post by Ev »

----------
Last edited by Ev on 27 Jun 2007 22:00, edited 1 time in total.
Ev
Engineer
Engineer
Posts: 21
Joined: 19 Jun 2007 18:59

Post by Ev »

----------
Last edited by Ev on 27 Jun 2007 22:01, edited 1 time in total.
kaan
Route Supervisor
Route Supervisor
Posts: 399
Joined: 02 Apr 2007 20:13
Location: Nørup, Denmark

Post by kaan »

Rubidium wrote:
benc wrote:It was marked as fixed but r10219 didn't actually fix the problem.
How do I reproduce that, because the bug reported in FS#890 is fixed in trunk, i.e. I cannot reproduce it anymore.
I just reproduced the bug, pictured in tunnel.png above, with trunk r10304.

Code: Select all

if (YouAreHappyAndYouKnowIt) {
    ClapYourHands();
}
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Post by Rubidium »

Now it should be fixed (again).

With one note: half road tiles get *always* removed when you are terraforming, building train depots, building diagonal rail etc. Therefor half road tiles *will* get removed when they are at the to be excavated tile. The patch in this thread did not obey to this "rule", so that's not the one that is used to fix this bug.
madman2003
Engineer
Engineer
Posts: 116
Joined: 20 May 2004 17:21

Post by madman2003 »

Ev wrote:I would like to request to include patch into trunk.
I suggest you post to flyspray.
Ev
Engineer
Engineer
Posts: 21
Joined: 19 Jun 2007 18:59

Post by Ev »

----------
Last edited by Ev on 27 Jun 2007 22:01, edited 1 time in total.
User avatar
Digitalfox
Chief Executive
Chief Executive
Posts: 708
Joined: 28 Oct 2004 04:42
Location: Catch the Fox if you can... Almost 20 years and counting!

Post by Digitalfox »

Ev wrote:Thanks for recommendation, i have already.
Ev look at the comment Rubidium made in flyspray about your patch, if you haven't already :)

http://bugs.openttd.org/task/928
csuke
Transport Coordinator
Transport Coordinator
Posts: 361
Joined: 05 Jun 2004 18:48
Location: London UK

Post by csuke »

Rubidium wrote:...With one note: half road tiles get *always* removed when you are terraforming, building train depots, building diagonal rail etc. Therefor half road tiles *will* get removed when they are at the to be excavated tile. The patch in this thread did not obey to this "rule", so that's not the one that is used to fix this bug.

Could you point me to the thread which discusses this (if there is one), i would be quite interested to see the discussion on how this became a feature rather than a bug
Image
User avatar
rav
Traffic Manager
Traffic Manager
Posts: 253
Joined: 17 May 2007 13:36
Location: Netherlands
Contact:

Post by rav »

csuke wrote: Could you point me to the thread which discusses this (if there is one), i would be quite interested to see the discussion on how this became a feature rather than a bug
here you go: http://www.tt-forums.net/viewtopic.php?t=30878
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Post by Rubidium »

csuke wrote:Could you point me to the thread which discusses this (if there is one), i would be quite interested to see the discussion on how this became a feature rather than a bug
It is also in TTD and half road tiles are absolutely useless in games; vehicles do not even drive on them. So removing them should be possible.
User avatar
benc
Engineer
Engineer
Posts: 62
Joined: 30 Apr 2007 01:57

Post by benc »

Makes good sense for buses and lorries, but trams need half road tiles to turn around.
Ev
Engineer
Engineer
Posts: 21
Joined: 19 Jun 2007 18:59

Post by Ev »

----------
Last edited by Ev on 27 Jun 2007 22:01, edited 1 time in total.
Locked

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 39 guests