Moderator: OpenTTD Developers
ported to trunk, and ripped out "adjacent stations".
(Ok... it is nearly a whole rewrite)
Maybe this has a greater chance of moving into trunk,
as it does not change any game mechanics (like adjacent stations did).
Short introduction of usage:
CTRL not pressed: Same station-placement behavior like always.
-no station around(station-spread radius): no popup
-touching other station: no popup
-touching more than 1 station: no popup (will fail to build anyway)
-1 or more stations around, not touching any station: display popup
Bug reports and coding/style hints are welcome.
Credits to Wolf01 for the idea.
Look for the latest posts in this thread for the most recent version,
as i do not update this patch anymore.
- (22.61 KiB) Downloaded 770 times
- Elbhaven Transport, 31. Jan 1970.png (61.32 KiB) Viewed 29140 times
- win32.exe+langfiles. just exctract over a nightly build
- (1.53 MiB) Downloaded 570 times
I don't think it is disturbing.
If the stations would automatically join before (=touching borders), they will automatically join now too.
It pops up, if the station is further away than 1 tile, and within range of "patches->station_spread".
I don't think a special key is needed to activate this functionality.
(Maybe this will be a patch setting, tho)
Let's say I have a medium sized town where I want to build an extensive bus network, and the station spread was set to a relative high number e.g. 30, then this box would pop up for every single bus stop I build in this town, even if I build the bus stops at opposite ends of the town.
Also, the devs don't tend to like the standard behaviour to be changed much, as could be seen with the custom face patch fiasco. I'd be surprised if they wanted to include it in the trunk without it being changed to ctrl-click. Just my 2 pence.
The problem with that ithe savegame wouldn't be compatible anymore; when loading an old savegame you would get another 'random' face, whereas it just should have converted the old face format to the new format.Bot_40 wrote:as could be seen with the custom face patch fiasco
This is the single most important issue remaining for the patch to be merged. All other issues were already resolved.
And on-topic, I think that the more advanced features like distant joining shouldn't be turned on by default, thus when you click CTRL the window should show up. On the other hand I'm not sure whether you want to join stations over such a large distance.
Secondly from the comment Frostregen made about the distance being the station spread; the whole new station should stay within that station spread; don't know whether it checks for that though; I have not tested it though.
About FindStationsNearby, take a look at CircularTileSearch.
I understant, but it not like version is 1.0Rubidium wrote:The problem with that ithe savegame wouldn't be compatible anymore
I mean, it's not mal to break compatibility, and it's always best to do it on version 0.5 than 1.0
Can you imagine in year 2011 (at version 1.3 ?) someone ask "wtf, why this is like that?!", someone answer "yes, it was to keep compatibility between 0.5 and 0.6 four year ago"....
If you really annoy everybody by breaking compatibility, it must be a very good reason. Just a new face is certainly not.
I disagree with you. Savegame compatability isn't a limiting factor for new features. We can rewrite the whole savegame format if we like, we only need to make sure that the old savegames are read properly. There is no need to write thousands of exceptions within the core code for this because all the old savegames are automatically conveerted to the current format.Archonix wrote:Ahh, well that opens a whole other kettle of fish. Sometimes you need to break compatibility in order to introduce features or you run the risk of ending up with reams of checking code that, as with the code in windows, introduces the potential for a great many bugs.
Users browsing this forum: No registered users and 5 guests