Altered ship behaviour in 20190704 nightly

Got a problem with OpenTTD? Find some help here.

Moderator: OpenTTD Developers

Post Reply
User avatar
leifbk
Chief Executive
Chief Executive
Posts: 757
Joined: 23 Dec 2013 16:33
Location: Bærum, Norway
Contact:

Altered ship behaviour in 20190704 nightly

Post by leifbk » 06 Jul 2019 15:36

I've just built the new 20190704 nightly from source. I loaded my latest savegame from the 20190606 version. Now all my fishing boats are whining about having lost their way, although they seem to do just fine. However, they're now anchoring at other tiles than they used to:
Selection_071.png
Selection_071.png (10.43 KiB) Viewed 654 times
Ships won't dock nicely alongside the harbour anymore. This looks plain weird:
Selection_070.png
Selection_070.png (251.89 KiB) Viewed 654 times
The Cadiz and the Nieuwpoort have arrived straight from the depot. Rather than turn 90 degrees immediately after coming out of the depot, they now go one tile out, and then approach the dock at 45 degrees.

User avatar
jfs
Director
Director
Posts: 562
Joined: 08 Jan 2003 23:09
Location: Denmark

Re: Altered ship behaviour in 20190704 nightly

Post by jfs » 06 Jul 2019 17:40

Almost certainly relates to PR #7380 Multi-tile docks.

Are the boats perpetually lost, or do they just report being lost despite finding their way just fine? Or was being lost just a one-time event after loading?

It's expected that ships end up docking slightly differently with the change.

Eddi
Tycoon
Tycoon
Posts: 7414
Joined: 17 Jan 2007 00:14

Re: Altered ship behaviour in 20190704 nightly

Post by Eddi » 06 Jul 2019 17:51

the docking behaviour change is intended, now all tiles next to a dock are available for docking, instead of just one.

as for the "being lost" issue, my first thought would be an issue with the path cache. it would really help to know if this is a one-time issue on loading or if it happens repeatedly
You might not exactly be interested in Ferion, but if you are, have fun :)

User avatar
leifbk
Chief Executive
Chief Executive
Posts: 757
Joined: 23 Dec 2013 16:33
Location: Bærum, Norway
Contact:

Re: Altered ship behaviour in 20190704 nightly

Post by leifbk » 06 Jul 2019 18:07

Eddi wrote:
06 Jul 2019 17:51
the docking behaviour change is intended, now all tiles next to a dock are available for docking, instead of just one.
I get very upset when I see ships dock this way. I'm thinking that the captain must be drunk :shock:
Eddi wrote: as for the "being lost" issue, my first thought would be an issue with the path cache. it would really help to know if this is a one-time issue on loading or if it happens repeatedly
I started a new game, and now the fishing boats are okay. I guess it's the path cache as you're saying.

User avatar
jfs
Director
Director
Posts: 562
Joined: 08 Jan 2003 23:09
Location: Denmark

Re: Altered ship behaviour in 20190704 nightly

Post by jfs » 06 Jul 2019 18:54

I hacked the station catchment highlight code a bit to also show the docking tiles in red.

The regular dock is not changed from original, but I think the pathing to the docking tile may be different.

Water industry station docks cover the entire industry, but most of the tiles may be impassable to ships so even though they are technically "docking tiles" they aren't usable. But ships will be able to dock in more places around oil rigs and other water industries now.
docking-dock.png
docking-dock.png (28.45 KiB) Viewed 593 times
docking-oilfield.png
docking-oilfield.png (58.97 KiB) Viewed 593 times

Eddi
Tycoon
Tycoon
Posts: 7414
Joined: 17 Jan 2007 00:14

Re: Altered ship behaviour in 20190704 nightly

Post by Eddi » 06 Jul 2019 20:52

jfs wrote:
06 Jul 2019 18:54
The regular dock is not changed from original
that part must have been cut from the patch before merging
You might not exactly be interested in Ferion, but if you are, have fun :)

Eddi
Tycoon
Tycoon
Posts: 7414
Joined: 17 Jan 2007 00:14

Re: Altered ship behaviour in 20190704 nightly

Post by Eddi » 06 Jul 2019 20:54

leifbk wrote:
06 Jul 2019 18:07
I started a new game, and now the fishing boats are okay. I guess it's the path cache as you're saying.
we still need that other savegame for testing, though.
You might not exactly be interested in Ferion, but if you are, have fun :)

User avatar
leifbk
Chief Executive
Chief Executive
Posts: 757
Joined: 23 Dec 2013 16:33
Location: Bærum, Norway
Contact:

Re: Altered ship behaviour in 20190704 nightly

Post by leifbk » 06 Jul 2019 21:00

Eddi wrote:
06 Jul 2019 20:54
leifbk wrote:
06 Jul 2019 18:07
I started a new game, and now the fishing boats are okay. I guess it's the path cache as you're saying.
we still need that other savegame for testing, though.
Okay, have fun :)
Spireset Transport, 2001-06-16.sav
(343.87 KiB) Downloaded 21 times

User avatar
leifbk
Chief Executive
Chief Executive
Posts: 757
Joined: 23 Dec 2013 16:33
Location: Bærum, Norway
Contact:

Re: Altered ship behaviour in 20190704 nightly

Post by leifbk » 08 Jul 2019 18:11

leifbk wrote:
06 Jul 2019 18:07
I started a new game, and now the fishing boats are okay. I guess it's the path cache as you're saying.
After I wrote this I paused the game and haven't touched it again until now, and the fishing boats again sometimes report that they've lost their way. It seems to happen when a new boat arrives before the previous one has left, and then the first boat complains about having lost its way after it has left the fishing grounds. I see that they dock at different places, and this is probably the cause of the confusion.

User avatar
leifbk
Chief Executive
Chief Executive
Posts: 757
Joined: 23 Dec 2013 16:33
Location: Bærum, Norway
Contact:

Re: Altered ship behaviour in 20190704 nightly

Post by leifbk » 22 Jul 2019 08:27

I'm now running the 20190718 nightly, and it seems like the fishing boat problem has been kind of resolved. That is, I've always used a minimal number of orders for ships, and now the pathfinder obviously has been adjusted to a shorter maximum distance between waypoints. It appears like it has been reduced to about 50 tiles Manhattan Distance. For each route where the ships complained about having lost their way, I've now placed extra buoys and inserted them into the order list, and the complaints have ended.

It would be nice if such changes had been documented somewhere.

I still don't like how the ships seem to crash into the dockside, run by a drunken captain, but at least that's a relatively minor nuisance compared to the constant whining about ships having lost their way.

Post Reply

Return to “OpenTTD Problems”

Who is online

Users browsing this forum: No registered users and 2 guests