Transport Tycoon Forums

Yes the new patch works without a problem, on clean trunk and with all the extra patches I stuff into my build.
Thanks!

The error of 'another airport nearby', might it have been caused by the Noise Limit switch? That always gives (me) this error when you try to build a noisier airport than the local authority is prepared to accept.

Updates against both 0.7.0 and trunk.

Updates against both 0.7.1 and trunk.

Could you update your code to the newest revision?

Sincerely
xZise

I am currently away from the system I usually code with, which makes updating patches a little harder.

In spite of the above, I have tried to manually bring this patch to date--see the attached file. However, I have only tested it for compilation errors, so you may come across bugs. Please report them if you do.

Update against current trunk.

Update against current trunk.

The patch requires a update after r18807 changed the way airports work (mostly the modifications of AirportFTAClass). I'm attaching a version I have been updating until r18705, in case it helps.

Edit: Corrected a wrong statement.

Terkhen wrote:The patch requires a update after r18807 changed the way airports work (mostly the removal of AirportFTAClass). I'm attaching a version I have been updating until r18705, in case it helps.

Just to avoid confusion: AirportFTAClass wasn't completely removed, only a few variables were moved out of it (like airport size).

Great patch. Should be in trunk I think. Is there any (technical) reason why it's not?

http://bugs.openttd.org/task/1562
and
http://bugs.openttd.org/task/877

Valentijn wrote:Is there any (technical) reason why it's not?

Yes. As the first post in this topic already says, it's most useful when coupled with a patch to close airports.

I think about a year ago I've looked at merging a close airport patch, but there where several problems. One of them was that the eisting implementation of the close airports patch is not a proper one, it works, but it uses airport flags that are meant for the statemachine to check if the airport is closed. Second problem was a discussion about the functionality: should it be implemented and if yes, only for airports or also for docks/road stops/train stations.

There is another reason not to implement the upgrade airports patch in trunk, and that is my current work on newgrf airports. There are some ideas on how to implement overbuilding airports for newgrf airports, but nothing final has been decided. I'd rather implement overbuilding airports after newgrf airports is in trunk, so avoid doing the work twice or making newgrf airporrs harder.

Yexo wrote:I think about a year ago I've looked at merging a close airport patch, but there where several problems. One of them was that the eisting implementation of the close airports patch is not a proper one, it works, but it uses airport flags that are meant for the statemachine to check if the airport is closed.

Doing it the "proper" way would require adding a new variable to the airport part of a station, which would have to be saved, and this would in turn require increasing the savegame version number. This would result in increased maintenance burden for the patch for as long as it remains off-trunk, and savegame incompatibility with vanilla trunk. As such, this is a change that I am unlikely to do unless and until it is the only remaining obstacle to merging.

Yexo wrote:Second problem was a discussion about the functionality: should it be implemented and if yes, only for airports or also for docks/road stops/train stations.

Well, since the functionality is repeatedly asked for, I would say it should. But I am probably biased on this one, since I wrote the patch because I felt a need for it.

While at it, here is another update to the airport upgrade patch. Enjoy.

There arent nice people around here who want to patch this and then compile this than uploaud it so i can play?
i am a total noob in this :S


Is it possible to add some patches in the main build the user will have optoins to turn the patches on or off?

Yexo wrote:... functionality: should it be implemented and if yes, only for airports or also for docks/road stops/train stations.

I think there's one reason to allow airports only: it's relatively easy to block trains RV and ships from getting to their station by removing tracks or road and ships are slow, one can stop them. Aircrafts otoh don't queue and are quite quick, thus putting all planes into a holding pattern is tedious

cirdan wrote:Doing it the "proper" way would require adding a new variable to the airport part of a station, which would have to be saved, and this would in turn require increasing the savegame version number. This would result in increased maintenance burden for the patch for as long as it remains off-trunk, and savegame incompatibility with vanilla trunk. As such, this is a change that I am unlikely to do unless and until it is the only remaining obstacle to merging.

This in turn, of course makes the patch unlikely to be picked up when the time seems proper. Sounds like catch 22.

planetmaker wrote:This in turn, of course makes the patch unlikely to be picked up when the time seems proper. Sounds like catch 22.

Well, this point is not really important as long as there are other issues with the patch, such as the developers' still wondering whether it should also apply to other station types (see your point above).

In any case, I do not care much about whether the patch is merged into trunk or not. I keep it up to date for my own personal use, and post it here for others' benefit. In fact, I have assumed that there is not much interest in the patch, since the last time a developer made a post in the flyspray task was a year and a half ago.

silly try to upgrade the patch to 1.0.0-RC1
please, check it very well

Could somebody patch this too the last version and upload it for me that would be be very nice.

There you go.

Updates against 1.0.0 and current trunk.