OpenTTD 0.4.8 preparations

[SirkoZ]

Was this considered as a bug?

Code: Select all

r4576              - temperate bank in tropical game

I don't think it's a bug - I mean - it's a nice addition to tropic towns (looks nice) and it does the job - accepts diamonds plus this bank has been in tropic terrain since TTD...Any thoughts?

[Darkvater]

Was this considered as a bug?

Code: Select all

r4576              - temperate bank in tropical game

I don't think it's a bug - I mean - it's a nice addition to tropic towns (looks nice) and it does the job - accepts diamonds plus this bank has been in tropic terrain since TTD...Any thoughts?

It has been fixed in trunk/ anyways so if it's not in 0.4.8 it's in 0.5.0. Not that much of a difference.

[SirkoZ]

Oh...so no more nice banks in tropical? Just those idle/accepting boxes?

Who said this was a bug anyway?!

If the original TTD has this bank listed in the industry table (and it has) - therefore it is not a bug. I really liked it anyways...

[Darkvater]

I have backported the major part of the above list to the 0.4/ branch.

Additional, updated trunk backports were:

Code: Select all

r4639              - Turkish town names (to go with turkish language)
r4674              - Sound allocation calloc() parameter mixup

Outstanding revisions are:

• r4203 - mingw compilation fixed. I think this has to do with the multistop rewrite. Or just in general one of orudge's weird OS/2 machines? Can anyone with mingw check?
• 4320 - rs->num_vehicles not saved. Changes saveload code, must be very cautious if we want to keep compatibility
• r4325, r4326 - multistop rewrite
• r4359 - MSVC6 compile fixed. Direct consequence of r4529, multistop rewrite.

The same list but broken down by person where applicable:

• Celestar: r4203, r4320, r4325, r4326, r4359 (multistop)

On the todo list are:

• Tasks for OpenTTD 0.4.8
• r4506 - FS95 - Use tile hash for depot pathfinding. In or not?

[belugas]

Oh...so no more nice banks in tropical? Just those idle/accepting boxes?

Wait until newindustries come

Who said this was a bug anyway?!

If the original TTD has this bank listed in the industry table (and it has) - therefore it is not a bug. I really liked it anyways...

If you look in TTDPatch newgrf documentation, you would read the following block :

(*) Unpatched TTD has a bug where temperate banks would appear in a tropic game while playing. This was caused by a mix-up that gave chance to temperate banks instead of tropic banks to appear at tropic. The GeneralFixes switch fixes this problem unless the miscmods.dontfixtropicbanks bit is set.

If TTDPatch thinks it is a bug, i think we can, too...
The real bug is that no tropical bank will randomly appear during the game. Ever.

[SirkoZ]

Well ok... I'll wait for new industries then.

In TTDPatch I usually have the banks switched on though...

Thanks for explanation.

[Darkvater]

Language changes have been backported...hopefully correctly.

Further candidates for backporting are:

• r4688 - Ensure the map memory is cleared after it is allocated. This fixes random deserts that sometimes occurred.
• r4689 - Codechange: correct parameter order or calloc, and use the sizeof the variable rather than a struct
• r4690 - [Fix] Fixed ShowQueryString() to close FS#151

[Korenn]

Well ok... I'll wait for new industries then.

In TTDPatch I usually have the banks switched on though...

Thanks for explanation.

as far as I understand it, they're not going to completely remove banks from tropical, but fix a bug where temperate banks would appear instead of tropical banks...

[Darkvater]

Translators:
http://www.tt-forums.net/viewtopic.php?p=438270#438270

Outstanding revisions are (all belonging to Celestar):

• 4320 - rs->num_vehicles not saved. Changes saveload code, must be very cautious if we want to keep compatibility
• r4325, r4326 - multistop rewrite
• r4359 - MSVC6 compile fixed. Direct consequence of r4529, multistop rewrite.

On the todo list are:

• Tasks for OpenTTD 0.4.8
• r4506 - FS95 - Use tile hash for depot pathfinding. In or not?

Branch synchronised/backport status:
branch 0.4/ synched with fixes up to r4729

General interest:
Savegame changes from 0.4.5 until now have been the following:

• r3725 - PATS, patches saved with savegame (22)
• r3915 - Autosave interval no longer saved (23)
• r4150 - Elrails (24)
• r4259 - Multistop fixes (25)
• r4466 - s/st->last_vehicle/st->last_vehicle_type/ (26)

[mrshadow76]

I am working on an enhancement that would allow pre-building of routes, and then they would be referenced by each individual vehicle. This would allow better tracking of revenue of intermodal routes.

Two things:

1) Should this be done for 0.5.0?

2) How do I get the latest source, and is there a support structure for developers?

[Brianetta]

1) Should this be done for 0.5.0?

Yes. 0.4 is for bugfixing only.

2) How do I get the latest source, and is there a support structure for developers?

Source is controlled by the subversion revision control system and is available at svn://svn.openttd.org/trunk/ (or use HTTP to read the code online). The support structure is basically FlySpray and IRC (irc.freenode.org #openttd). Darkvater is the lead programmer-in-exile, and knows more than most.

[Darkvater]

On the todo list are:

• Tasks for OpenTTD 0.4.8
• r4506 - FS95 - Use tile hash for depot pathfinding. In or not?

Changes backported from trunk/:

• r4203 - Fix: compile on older mingw32 versions (3.1.0)
• Fix (FS#57): Disable NPF totally for ships only for 0.4/ branch and 0.4.8.
• r4750 - Trains entering invalid rail-types under bridges on sloped tile
• r4766 - Vehicles under bridge were sometimes affected by bridge speed-limit
• r4812 - NTP doesn't check railtype (depends on r4008, r4110, elrails)
• r4825, r4826, r4829 - autoreplace/autoclone crash on max limit
• r4827 - terraform treetype gui button fixup
• r4892 - segfault on sorting empty network-list
• r4906 - refresh depot window when converted
• r4911 - AI no longer attempts to build signals under bridges
• r4914 - Aircraft can now serve as feeders
• r4859 - pathfinder over level crossings
• r4735, r4787, r4813, r4820, r4836, r4845, r4849, r4850, r4851, r4861, r4862 4863, r4864, r4866, r4873, r4874, r4886, r4890, r4898 - translation updates.

Todo:

• r4753 - Truncate dropdown-list string length to prevent overflow
• r4828, r4871, r4876, r4889 - players console command

Types with an exclamation mark after them are not yet decided for backporting.

Branch synchronised/backport status:
branch 0.4/ synched with fixes up to r4930

[Darkvater]

Types with an exclamation mark after them are not yet decided for backporting.

On the todo list are:

• Tasks for OpenTTD 0.4.8
• r4506 - FS95 - Use tile hash for depot pathfinding.
• r4753 - Truncate dropdown-list string length to prevent overflow
• r4828, r4871, r4876, r4889 - players console command

Branch synchronised/backport status:
branch 0.4/ synched with fixes up to r4930

[ASM]

IMHO this bug should be fixed in 0.4.8, see FS#198, changesets 5085 and 5088.

[SirkoZ]

IMHO this bug should be fixed in 0.4.8, see FS#198, changesets 5085 and 5088.

Very interesting observation - my smooth_economy patch works well with unchanged macros though.

I'll try out the changed macros immediately...

[SirkoZ]

Wow - it's already been included into trunk...

It works - quite nicely - now 2 more bugs with the current smooth_economy - IT_FARM_2 = tropical maize_farm doesn't plant any fields and once industry production decreases to 32/40 units per month it does not increase anymore, which is annoying - here is a quick fix for those 2 bugs.

[comrade-max]

i dont know whether this is the right place to put it, but i think the 6 new airports patch should be added to the normal release (i think u call it the trunk, im not too wise on these things). i think it adds so much to the game, poysonally i cant use torrtoise SVN due to the fact it bugs up my system for some strange reason, and i love the patchs features, so this means i am forced to use the miniIN nightly doodad even though i prefer the normal nightly

[fabca2]

i dont know whether this is the right place to put it, but i think the 6 new airports patch should be added to the normal release (i think u call it the trunk, im not too wise on these things). i think it adds so much to the game, poysonally i cant use torrtoise SVN due to the fact it bugs up my system for some strange reason, and i love the patchs features, so this means i am forced to use the miniIN nightly doodad even though i prefer the normal nightly

I think 0.4.8 is a FIX only release, not a feature release..
I belive there are so many more important feature that exist on trunk (elrail, new bridge, ypaf...)
I'm like you, i'm waiting...
But I think these 6 new airport won't be on 0.4.8

[Darkvater]

Changes backported from trunk/:

• Fix [FS#145]: Starting scenarios did not adhere to local difficulty
• r5071 - "Erroneous train reversal on waypoints". Don't reverse under any circumstances.
• r4753 - Truncate text in dropdown lists to stop text overflowing
• r4964 - Fix NTP over bridges: don't check the rail type when on a bridge
• r5085, r5088 - Add parentheses to CHANCE16*() macro parameters
• r5092 - Race condition if the AI could give a new vehicle its orders
• r5097 - AI used information from the wrong industry when calculating the amount of to be transported goods
• r4939, r4956, r4971, r4977, r5003, r5004, r5007, r5017, r5035, r5036, r5078 - translation updates

Types with an exclamation mark after them are not yet decided for backporting.
The FlySpray tasks for 0.4.8 are imho insignificant enough to release a RC1 in the very near future. Great, found another bug; tunnel terraforming... (r4012 (which is r3992, r3995))

On the todo list are:

• Tasks for OpenTTD 0.4.8
• r4506 - FS95 - Use tile hash for depot pathfinding.

Branch synchronised/backport status:
branch 0.4/ synched with fixes up to r5110

[SirkoZ]

Could anyone (of the devs) make background of chatbox brighter, so every color would be readable?