persistant build tools [trunk as of r14902]

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

persistant build tools [trunk as of r14902]

Post by planetmaker »

Meanwhile this patch extended into a patch which makes all build tools persistant.
In order to enable persistant build tools, you need to enable (in the GUI section of the settings) "keep build tool active after usage".

Diff file for trunk revision: r14400.

==== Old post ===
Hi,
the intention of this patch is to make building a larger number of bridges easier or faster.

So far for every bridge built, one has to select the build bridge tool anew. This patch introduces a new setting "keep bridgebuilding". When active, the bridge building tool stays active after usage, thus allowing to build immediately another bridge, behaving much the same like any track building tool.
Attachments
keep_bridgebuilding_r14214.diff
keep building bridges for r14214
(3.6 KiB) Downloaded 73 times
Last edited by planetmaker on 11 Jan 2009 16:48, edited 7 times in total.
User avatar
Zhall
Tycoon
Tycoon
Posts: 1237
Joined: 17 Jul 2007 01:36
Skype: moonray_zdo
Location: Teh matrix, duh.
Contact:

Re: keep building (rail) bridges tool open

Post by Zhall »

Is it really THAT difficult to open another viewport and spam B on your keyboard and drag 1/2" between the main view and the viewport?
User avatar
XeryusTC
Tycoon
Tycoon
Posts: 15415
Joined: 02 May 2005 11:05
Skype: XeryusTC
Location: localhost

Re: keep building (rail) bridges tool open

Post by XeryusTC »

It is better than pressing B 10 times in a row to build some bridges, especially when you want to find out which bridge looks the best in a certain situation.
Don't panic - My YouTube channel - Follow me on twitter (@XeryusTC) - Play Tribes: Ascend - Tired of Dropbox? Try SpiderOak (use this link and we both get 1GB extra space)
Image
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
Image Image Image Image Image Image Image
User avatar
Timitry
Transport Coordinator
Transport Coordinator
Posts: 313
Joined: 01 Oct 2004 15:28
Contact:

Re: keep building (rail) bridges tool open

Post by Timitry »

I definetely will use this option when merged to trunk. The only disadvantage i can see is that you'd need to close the bridge building window (which should be possible with b) if you want to click on a station or so. I'd like the same behaviour also for tunnels. We already have that feature for non-standard stations, where it is really helpful. I think if you're saying "is it so hard to spam b all the time?", the same would go for stations, where you'd had to press 9 all the time...

Imho a very useful feature, thanks!
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: keep building (rail) bridges tool open

Post by planetmaker »

Timitry wrote:I definetely will use this option when merged to trunk. The only disadvantage i can see is that you'd need to close the bridge building window (which should be possible with b) if you want to click on a station or so. I'd like the same behaviour also for tunnels. We already have that feature for non-standard stations, where it is really helpful. I think if you're saying "is it so hard to spam b all the time?", the same would go for stations, where you'd had to press 9 all the time...

Imho a very useful feature, thanks!
The same for tunnels should be quite easy and indeed is one of the extentions which I plan to add next. Probably I should add the same for road and water bridges, too :) .
User avatar
Timitry
Transport Coordinator
Transport Coordinator
Posts: 313
Joined: 01 Oct 2004 15:28
Contact:

Re: keep building (rail) bridges tool open

Post by Timitry »

Yes, that sounds good.
Maybe even add it for Road Stops, as you often want to build a lot of drive-through bus or lorry stops next to each other, which involves a lot of klicking or hotkey-pressing, too :)
Eddi
Tycoon
Tycoon
Posts: 8272
Joined: 17 Jan 2007 00:14

Re: keep building (rail) bridges tool open

Post by Eddi »

i agree (on a general level), the handling of windows should be more consistent.

e.g. the station build window (with newstations) stays open, but the roadstop build window closes (very annoying, when you want to build multistop stations)

i'd vote for keep all windows open, unless explicitely closed (e.g. with ESC), or a different window is opened

on a side note: it should be easier to distinguish if you are currently building a road or rail bridge/tunnel, you confuse those too easily, especially while building in cities, where you switch between transportation types often.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: keep building (rail) bridges tool open

Post by planetmaker »

Eddi wrote:i agree (on a general level), the handling of windows should be more consistent.

e.g. the station build window (with newstations) stays open, but the roadstop build window closes (very annoying, when you want to build multistop stations)

i'd vote for keep all windows open, unless explicitely closed (e.g. with ESC), or a different window is opened
Sounds like a "make all tools persistant"-patch ;)
Eddi wrote: on a side note: it should be easier to distinguish if you are currently building a road or rail bridge/tunnel, you confuse those too easily, especially while building in cities, where you switch between transportation types often.
Hm, indeed. Happend to me also quite often. But currently I'm lacking a good idea on how to distinguish - except a different mouse cursor or something along those lines. But that's a job for an artist :)
User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1518
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: keep building (rail) bridges tool open

Post by SirkoZ »

planetmaker wrote:Sounds like a "make all tools persistant"-patch ;)
That would probably be the best - like the road tool or rail tool that doesn't close (like in TTOrig. :-) ) it would be quite useful if also tunnel (like in TTOrig. :-) ) and bridge and also station tools were persistent - so to speak.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: persistant build tools

Post by planetmaker »

Here now I got every build tool behave persistant - thanks to sulai's 'fewer clicks' patch, I now figured out how and where to look. Persistant build tool behaviour is controlled by the "keep building tools active after usage" settings in the GUI part of the settings. If switched off the gui behaviour isn't changed at all wrt current trunk behaviour.

Comments and criticism welcome. Especially: should I make this patch without the patch setting?

EDIT: grammar+spelling
Attachments
persistant_building_r14400.diff
persistant build tools for r14400
(6.84 KiB) Downloaded 89 times
Last edited by planetmaker on 26 Sep 2008 10:57, edited 1 time in total.
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: persistant build tools

Post by DaleStan »

planetmaker wrote: sulai's 'less klicks' patch
The word is still "fewer", even if sulai can't figure that out, but even he can spell "clicks". The spell-checker is your friend. When it's unhappy, it's usually correct.
planetmaker wrote:should I make this patch without the patch setting?
You should tie it to the pushpin, not any global option.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: persistant build tools

Post by planetmaker »

An update to r14856 with unmodified behaviour. Currently I think having an option for every single tools to switch on persistancy is a bit over doing it. Thoughts by other people?
Attachments
persistant_building_r14856.diff
svn patch for r14856
(6.64 KiB) Downloaded 62 times
User avatar
DJ Nekkid
Tycoon
Tycoon
Posts: 2141
Joined: 30 Nov 2006 20:33

Re: persistant build tools

Post by DJ Nekkid »

I think _most_ of us agree, tools beeing active when first opened is a good thing.
Member of the
ImageImage
User avatar
Torben DH
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 31 Dec 2004 09:09
Location: Denmark

Re: persistant build tools

Post by Torben DH »

really nice fature cant wait for it to be part of trunk...
TDH
User avatar
Timitry
Transport Coordinator
Transport Coordinator
Posts: 313
Joined: 01 Oct 2004 15:28
Contact:

Re: persistant build tools

Post by Timitry »

It just hit trunk :)


frosch [Wed, 07 Jan 2009 17:40:17 +0000] rev 10611
(svn r14902) -Feature: Advanced setting to keep various building tools active, which are usually closed after placing an object. (planetmaker)


So i guess it should be in tonight's nightly :)

Thanks for this great addition to the game!
User avatar
CommanderZ
Tycoon
Tycoon
Posts: 1872
Joined: 07 Apr 2008 18:29
Location: Czech Republic
Contact:

Re: persistant build tools

Post by CommanderZ »

Gr8 8)

Good to see a good patch be trunked.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 18 guests