Patch: middle stop

Tiberius · Post by **Tiberius** » 04 Jun 2008 04:36

Update for latest trunk, original from:
http://www.tt-forums.net/viewtopic.php? ... op#p685930
Thanks, Eddi!

This patch will make trains shorter than the station stop at the middle of the platform.

EDIT: change to svn-diff style, the code itself isn't altered.

pavel1269 · Post by **pavel1269** » 23 Mar 2009 19:51

update to this nice eyecandy patch

edit: updated againts 2435revisions

Eddi · Post by **Eddi** » 24 Mar 2009 05:35

i don't see why this needed an update. the original patch still applies fine here.

anyway, part of the intention of the initial patch was to NOT change the indentation level of the following lines. it only adds conflict potential with no benefit.

pavel1269 · Post by **pavel1269** » 24 Mar 2009 08:03

Eddi wrote: anyway, part of the intention of the initial patch was to NOT change the indentation level of the following lines. it only adds conflict potential with no benefit.

can you say that again? dont understand you :-/

Post by **planetmaker** » 24 Mar 2009 08:43

What Eddi means (and he's somewhat right with that) is the following kind of differences between the patch files

Code: Select all

-                             if (x < stop) {
-                                     uint16 spd;
+                                     if (x < stop) {
+                                             uint16 spd;

You changed (probably following coding style), the indentation level of the lines. If you don't change them, the diff will stay smaller and it is less likely to break.

pavel1269 · Post by **pavel1269** » 24 Mar 2009 14:21

wow, i thought, that this is a very small problem .... better to have it perfectly working ... no?

its just one " " ....

Eddi · Post by **Eddi** » 24 Mar 2009 16:52

the problem is not that it's a " ", the problem is that the line appears in the patch. so if any of the lines which appear in the patch are changed in trunk, a conflict will occur.

ergo, the fewer lines appear in the patch, the lower the chance for a conflict. what you did was add lines to the patch without providing new functionality, so the change is bad. there were only three conflicting changes in the history of this patch (my first version is from r6982, that is almost 9000 revisions)

pavel1269 · Post by **pavel1269** » 27 Mar 2009 16:48

updated again, not without those unneccessary " "
also if you play with reversing only at line ends, train will now reverse in single-entrance station just fine, no more going to end and there turning

Eddi · Post by **Eddi** » 28 Mar 2009 10:54

if you really want to pick this up and develop it into a real feature:

allow for each order to select wether the train should stop at the beginning, middle or end of platform. plus a setting which should be default
adapt "realistic acceleration" to slow down towards the real stopping point, not the end of the station

ostlandr · Post by **ostlandr** » 31 Mar 2009 02:55

I liked this patch when I was using Tibb's Patchpack. Was nice, as it made short trains more efficient rather than that long haul to the end of the station and back.

DJ Nekkid · Post by **DJ Nekkid** » 31 Mar 2009 10:03

Eddi wrote:if you really want to pick this up and develop it into a real feature:

allow for each order to select wether the train should stop at the beginning, middle or end of platform. plus a setting which should be default

adapt "realistic acceleration" to slow down towards the real stopping point, not the end of the station

I Agree, thoose things would be really nice!

pavel1269 · Post by **pavel1269** » 31 Mar 2009 10:16

I will start as soon as i would have free time, but first i want to complete my daylength patch ... forget one last thing there

welshdragon · Post by **welshdragon** » 12 Apr 2009 14:16

CIA-9 wrote: OpenTTD: rubidium * r16037 /trunk/src/ (14 files in 4 dirs): -Feature: allow (per order) to let a train stop at the near end, middle or far end of a platform from the point of view of the driver of the train that enters the station.

(from #openttd just 2 minutes ago)

Aali · Post by **Aali** » 12 Apr 2009 14:40

AFAIK it wasn't based on this patch. Either way, the functionality provided by it (and then some) is there

SirXavius · Post by **SirXavius** » 12 Apr 2009 19:43

Enlighten me now; what's the benefit of this patch during gameplay? I'm sure it must be helpful to be included in the trunk....

pavel1269 · Post by **pavel1269** » 12 Apr 2009 20:08

if you dont se income, you can ignore it ...

but if you have some main station, huge one, but there is still going some local traffic, which is usually short, it take soo long till it reach end so you can use here begin (near end) to improve it, or center as eyecandy

it helps but not that much

2007Alain2007 · Post by **2007Alain2007** » 19 Apr 2009 11:47

HI all this is in trunk just to say

you can pick were about you want the train to stop

well done for getting it there

Transport Tycoon Forums

Patch: middle stop

Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop

Re: Patch: middle stop(in trunk)

Who is online