Patch: drag&drop land purchase

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Patch: drag&drop land purchase

Post by Roest »

What the title says. Just a small patch to make it possible to purchase land by drag&drop.

As a side effect, i moved void PlaceProc_BuyLand(TileIndex tile) from rail_gui.cpp to terraform_gui.cpp. Just makes a bit more sense.
Attachments
dd_buy_land_r12684.diff
(3.92 KiB) Downloaded 220 times
Xaroth
Engineer
Engineer
Posts: 103
Joined: 01 May 2006 09:09

Re: Patch: drag&drop land purchase

Post by Xaroth »

woot :bow: :bow: :bow: :bow: :bow: :bow:

been waiting for this one for quite a while
Lead Manager of OpenDUNE
Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4765
Joined: 09 Sep 2007 05:03
Location: home

Re: Patch: drag&drop land purchase

Post by Alberth »

In general, patches should be submitted to FlySpray if you want to have them merged into trunk by one of the devs.

You should fix your comments; a line consisting solely of a comment should use C style comment rather than C++ line comments. Also, the commented out return statements look kind of weird to me, however I am not familiar with that part of the code.

Sincerely,
Albert
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Patch: drag&drop land purchase

Post by Roest »

Well ok, i didn't make this clear in the first post. This isn't the last word on this. First of all, i made it for myself because i found it kinda weird that functionality wasn't there in the first place and i really missed it. To make it really trunk compatible, i'll have to polish it up a bit.
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Re: Patch: drag&drop land purchase

Post by Rubidium »

In general it is wise for people that make patches to do a search for the feature they want to introduce in both the forum and in flyspray (also including the closed tasks). Then you would know what the fate of this patch is.
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Patch: drag&drop land purchase

Post by Roest »

Well i did the search now. Guess its fate is that it will be for my single player games only. Good to have anyway.

Edit: So the main concern against it, is that players can simply block others from reaching industries by purchasing the land around them. Would it increase its chances to live in a world beyond my little refuge here, if it would be off by default in multiplayer games, and only available in singleplayer?
User avatar
Wolf01
Tycoon
Tycoon
Posts: 2016
Joined: 24 Apr 2004 10:43
Location: Venezia - Italia
Contact:

Re: Patch: drag&drop land purchase

Post by Wolf01 »

I already made it available to singleplayer only but it was rejected many times, not for coding style but for the idea itself
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Patch: drag&drop land purchase

Post by Roest »

Wolf01 wrote:I already made it available to singleplayer only but it was rejected many times, not for coding style but for the idea itself
There goes my hopeful career as a path author. :|
User avatar
athanasios
Tycoon
Tycoon
Posts: 3138
Joined: 23 Jun 2005 00:09
Contact:

Re: Patch: drag&drop land purchase

Post by athanasios »

:cry: Developers don't like such a feature.
But never mind, you 'll make another one.
http://members.fortunecity.com/gamesart
"If no one is a fool I am also a fool." -The TTD maniac.


I prefer to be contacted through PMs. Thanks.
Tiberius
Engineer
Engineer
Posts: 86
Joined: 17 Sep 2004 03:15

Re: Patch: drag&drop land purchase

Post by Tiberius »

version bump :)

EDIT: change to svn-diff style (actual code not modified at all)
Attachments
dd-buyland_r13374.patch
(3.85 KiB) Downloaded 168 times
I may implement/fix/tweak/eat/ditch it soon (or in distant future, if at all, so don't hold your breath).
If anyone want to be the one please implement it for us all 8)
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 11 guests