Sudden negative cargo payment rates

[Hungerford]

I am having a strange problem with my current OpenTTD game. My economy is set to stable but over the past few years of gameplay, my cargo payment rates have begun to fluctuate wildly. They have now reached the point where several key cargoes have become worthless to transport.

I have never encountered this problem before - I have played further on from the stage shown on the screenshot and it reaches a point where the payment rate for passengers becomes negative although the rate for coal becomes positive again. Effectively, I end up having to shut 90% of my network because of this issue.

Anybody have any ideas as to what is going on? I didn't even know that dynamic cargo rates were a feature of OpenTTD.

[planetmaker]

Do you have a savegame for us?

[Wold]

Do you have a savegame for us?

Inflation has probably something to do with that.

[Hungerford]

Here is the saved file. I hope you can work out what's going on.

[Transportman]

Do you have a savegame for us?

Inflation has probably something to do with that.

Given the sudden decline in operating profit and the upside down curves in the cargo payments rate (longer deliveries should mean lower profits, not lower losses), I think there is something else going on.

I can't load the savegame because I miss the rusrailw(1).grf.

[Hungerford]

Do you have a savegame for us?

Inflation has probably something to do with that.

Given the sudden decline in operating profit and the upside down curves in the cargo payments rate (longer deliveries should mean lower profits, not lower losses), I think there is something else going on.

I can't load the savegame because I miss the rusrailw(1).grf.

Sent you a PM with the missing file.

[Transportman]

I have loaded your game and fastforwarded a couple of years, and noticed something strange in the Cargo Payments rate graphs. They go up like very fast, but when the 10 day delivery value hits something like €100,000k it changes to the negative side, to rise back up again.

[Hungerford]

I have loaded your game and fastforwarded a couple of years, and noticed something strange in the Cargo Payments rate graphs. They go up like very fast, but when the 10 day delivery value hits something like €100,000k it changes to the negative side, to rise back up again.

It sounds like a bug somewhere, especially as I am using the default industries etc. The only newgrfs I have are for vehicles and stations.

[Wold]

Well I don't know the insides of the game but I guess due to inflation the price overflows ( int32 - 2,147,483,647 ) and starts from -2,147,483,648 again. If you can attach rusrail(1).grf it would be great. A short term fix could be for the prices to be a signed int..

[Hungerford]

Here is the newgrf file which is needed to load my savegame.

[Yexo]

Well I don't know the insides of the game but I guess due to inflation the price overflows ( int32 - 2,147,483,647 ) and starts from -2,147,483,648 again. If you can attach rusrail(1).grf it would be great. A short term fix could be for the prices to be a signed int..

I'm not quite sure what exactly you are proposing. An int32 is a signed int.

[FLHerne]

Probably a typo for unsigned int. That would make more sense...

[Eddi]

internally, all places which handle prices should be "overflow-safe int64" (aka "Money"). the bug you see here is likely an oversight and should be trivial to solve, once the exact location where it goes wrong is found.

and "unsigned int" makes pretty much no sense...