JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Argus
Tycoon
Tycoon
Posts: 1204
Joined: 16 Oct 2018 08:31
Location: Heart of the Highlands. Not Scottish. Czech.

Re: JGR's Patch Pack

Post by Argus »

I've already figured out what's bothering me.
The button says unload everything, which is different from "unload only what the station requests". However, this is what the button says in English too, so it's not a translation error. So when I check the train I see a button saying unload all and I think the command is wrong.
Since it doesn't say what specifically the train or other means of transport is supposed to do, I'm not sure if I entered the command correctly.
User avatar
emyaqin
Engineer
Engineer
Posts: 2
Joined: 17 Dec 2017 10:49
Location: Indonesia

Re: JGR's Patch Pack

Post by emyaqin »

Its not a bug, but rather a request about the autosave feature. I don't know since which version but the latest 0.56.2 made the autosave to use the real time clock like every 10 minutes, etc. There's a toggle whether to use the real time clock or not, but it's still very confusing.

If I put every 1 minute, the game saves approximately every month but not at the same dates like it used to with a monthly autosave. I would love to have that feature back since I frequently use the autosave to rollback to the first date of the month in case something's wrong.
Eddi
Tycoon
Tycoon
Posts: 8272
Joined: 17 Jan 2007 00:14

Re: JGR's Patch Pack

Post by Eddi »

emyaqin wrote: 28 Jan 2024 05:42[...] rollback [...] in case something's wrong.
is there anything in particular about the 1st of the month that is necessary for this rollback?

some people [that includes me] spend a lot of time with the game paused, and in those cases, real time autosave is much better.
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

Eddi wrote: 29 Jan 2024 23:20 some people [that includes me] spend a lot of time with the game paused, and in those cases, real time autosave is much better.
This is something I also do, so timebased works better.
Whenever I am building, the game is paused. Mostly to avoid minor screwups when making new junctions that causes crashes, but also just so i don't have to deal with moving units whilst I'm working, as it can be distracting.

I appreciate its not everyone's cup of tea, or maybe even 'cheaty' to some to pause when building, but having the choice in savegame times is definitely warranted I think.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
Eddi
Tycoon
Tycoon
Posts: 8272
Joined: 17 Jan 2007 00:14

Re: JGR's Patch Pack

Post by Eddi »

also, autosave in scenario editor, which has no date progression, and thus can never trigger a "monthly" autosave.
User avatar
Valdez
Traffic Manager
Traffic Manager
Posts: 202
Joined: 23 Mar 2011 21:33
Location: Czech Republic

Re: JGR's Patch Pack

Post by Valdez »

An oopsie happened
crash.png
(450.09 KiB) Not downloaded yet
I'm getting the same error trying to load some older saves
Attachments
crash-20240201T235241Z.png
(236.97 KiB) Not downloaded yet
crash-20240201T235241Z.sav
(14.26 MiB) Downloaded 33 times
My visits on the forums are sporadic only, so PMs may go unanswered for a long time. If you wish to report a bug etc., the best option is via DM or ping on r/Openttd Discord
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Valdez wrote: 01 Feb 2024 23:55 An oopsie happened

crash.png

I'm getting the same error trying to load some older saves
There's an area of the map where the slope/landscape is broken, the crash is when the aircraft flies over it.
I may be able to smooth this over in your save.

Edit: I've fixed the broken tiles
AJ&WRR, 1989-03-25.sav
(14.23 MiB) Downloaded 33 times
Last edited by JGR on 02 Feb 2024 00:56, edited 2 times in total.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

Just noticed this. At certain zoom levels, it's possible for boats to leave a trail of pixels behind them.
Zooming in or out removes and stops these being left behind. Moving the camera doesn't get rid of them, unless they go off screen.
Attachments
2024-02-02 00_48_26-OpenTTD jgrpp-0.56.2.png
2024-02-02 00_48_26-OpenTTD jgrpp-0.56.2.png (64.3 KiB) Viewed 2085 times
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
Argus
Tycoon
Tycoon
Posts: 1204
Joined: 16 Oct 2018 08:31
Location: Heart of the Highlands. Not Scottish. Czech.

Re: JGR's Patch Pack

Post by Argus »

Another fall
Attachments
crash-20240202T105309Z.7z
(7.86 KiB) Downloaded 18 times
crash-20240202T105309Z.sav
(1.04 MiB) Downloaded 16 times
User avatar
Valdez
Traffic Manager
Traffic Manager
Posts: 202
Joined: 23 Mar 2011 21:33
Location: Czech Republic

Re: JGR's Patch Pack

Post by Valdez »

JGR wrote: 02 Feb 2024 00:46 Edit: I've fixed the broken tiles
AJ&WRR, 1989-03-25.sav
Thanks.
Also love how this got 16 downloads before I even got to it :D
My visits on the forums are sporadic only, so PMs may go unanswered for a long time. If you wish to report a bug etc., the best option is via DM or ping on r/Openttd Discord
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Redirect Left wrote: 02 Feb 2024 00:49 Just noticed this. At certain zoom levels, it's possible for boats to leave a trail of pixels behind them.
Zooming in or out removes and stops these being left behind. Moving the camera doesn't get rid of them, unless they go off screen.
Which ship GRF is this incidentally? Usually this sort of thing is because the GRF has used sprites which are too large.
Argus wrote: 02 Feb 2024 10:56Another fall
This will likely be fixed in the next release.
Ex TTDPatch Coder
Patch Pack, Github
Argus
Tycoon
Tycoon
Posts: 1204
Joined: 16 Oct 2018 08:31
Location: Heart of the Highlands. Not Scottish. Czech.

Re: JGR's Patch Pack

Post by Argus »

JGR wrote: 02 Feb 2024 21:15
Argus wrote: 02 Feb 2024 10:56Another fall
This will likely be fixed in the next release.
What caused him? I later found out that the script is broken by changing the industry.
By the way, I'm guessing the USS Nimitz as far as the problem ship goes.
viewtopic.php?p=1263377&hilit=nimitz#p1263377
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

JGR wrote: 02 Feb 2024 21:15
Redirect Left wrote: 02 Feb 2024 00:49 Just noticed this. At certain zoom levels, it's possible for boats to leave a trail of pixels behind them.
Zooming in or out removes and stops these being left behind. Moving the camera doesn't get rid of them, unless they go off screen.
Which ship GRF is this incidentally? Usually this sort of thing is because the GRF has used sprites which are too large.
They are the default boats. I launched a map in vanilla OTTD and got the same boats. All of the boats in that screenshot (and in the entire save) are the Bakewell 300 Hovercrafts.
Here is the GRF list of what i used in that game, if you think i have overlooked something, and also the savegame, saved at the zoom level & exact location the glitch appears for me.
Attachments
2024-02-03 05_27_32-OpenTTD jgrpp-0.56.2.png
2024-02-03 05_27_32-OpenTTD jgrpp-0.56.2.png (6.57 KiB) Viewed 1840 times
JUN 2023.sav
(9.46 MiB) Downloaded 17 times
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Redirect Left wrote: 03 Feb 2024 05:28 They are the default boats. I launched a map in vanilla OTTD and got the same boats. All of the boats in that screenshot (and in the entire save) are the Bakewell 300 Hovercrafts.
Here is the GRF list of what i used in that game, if you think i have overlooked something, and also the savegame, saved at the zoom level & exact location the glitch appears for me.
This should be fixed now, it'll be in the next release.
Argus wrote: 02 Feb 2024 22:48 What caused him?
I assume that you were doing something in the build vehicle window to cause the engine list to change out of sync with the scrollbar.
Ex TTDPatch Coder
Patch Pack, Github
Argus
Tycoon
Tycoon
Posts: 1204
Joined: 16 Oct 2018 08:31
Location: Heart of the Highlands. Not Scottish. Czech.

Re: JGR's Patch Pack

Post by Argus »

Oh, this one. There was some movement of the hand with the mouse. I must have accidentally pressed a button or something. :)
Argus
Tycoon
Tycoon
Posts: 1204
Joined: 16 Oct 2018 08:31
Location: Heart of the Highlands. Not Scottish. Czech.

Re: JGR's Patch Pack

Post by Argus »

Noticed an unwanted effect when moving with the map near the edge
Attachments
MacDonald & Co., 1. říj 1968.png
(152.54 KiB) Not downloaded yet
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Argus wrote: 03 Feb 2024 21:41 Noticed an unwanted effect when moving with the map near the edge
This one should be already fixed for the next release.
Ex TTDPatch Coder
Patch Pack, Github
Argus
Tycoon
Tycoon
Posts: 1204
Joined: 16 Oct 2018 08:31
Location: Heart of the Highlands. Not Scottish. Czech.

Re: JGR's Patch Pack

Post by Argus »

And the previously reported error with colors still applies.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Argus wrote: 03 Feb 2024 22:22 And the previously reported error with colors still applies.
I've raised a PR upstream.
Ex TTDPatch Coder
Patch Pack, Github
Davie_UCF
Traffic Manager
Traffic Manager
Posts: 155
Joined: 11 Sep 2004 19:55
Location: Colchester, Essex, United Kingdom

Re: JGR's Patch Pack

Post by Davie_UCF »

Hi JGR, I have an issue with a savegame where a few vehicles are stuck at the entrance of bus stations. kamnet suggested I contact you to see if you can see if theres anything you can do. Will appreciate it if you can take a look, I understand it may be a lost cause.

Thread here
viewtopic.php?p=1267884
East of England/East Anglia scenario/map released!! http://www.tt-forums.net/viewtopic.php?p=205440#205440
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Google [Bot] and 8 guests