JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Narc wrote:
JGR wrote:Thanks for reporting this. Can you post the crash log please?
I'm not the person who reported it originally, but here's a crash.log from basically the exact same thing:

...

Good luck, let me know if you need anything else.
This looks suspiciously similar to the bug (fixed in 0.13.3) where if a template vehicle was deleted when it was in use by more than one group, it'd only be unassigned from the first group. If a train in one of the remaining groups was then replaced using the now deleted template, something would go wrong along the lines of your crash log.
Can you check in your savegame if there are groups with templates in use, which are not in the available templates list for any available rail type (i.e. always says "Uses template of different rail type")?
If so, using the "stop replacement" button for those groups should make the problem go away.
Thanks for the crashlog and info.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Narc
Engineer
Engineer
Posts: 12
Joined: 16 May 2008 20:47

Re: JGR's Patch Pack

Post by Narc »

JGR wrote:[...]
This looks suspiciously similar to the bug (fixed in 0.13.3) where [...] something would go wrong along the lines of your crash log.
Can you check in your savegame if there are groups with templates in use, which are not in the available templates list for any available rail type (i.e. always says "Uses template of different rail type")?[...]
Sorry to disappoint, but I'm running 0.13.3, it's a fresh new map, and that was the first template I (tried to) set up.

I'm suspecting it's something odd about the NewGRFs I'm using (I just noticed I have two kinds of metro track GRFs) interacting badly with the template patch. Let me know if you'd like a save (might be a while to get it, though) -- all the GRFs are from the online content manager.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Narc wrote:Sorry to disappoint, but I'm running 0.13.3, it's a fresh new map, and that was the first template I (tried to) set up.

I'm suspecting it's something odd about the NewGRFs I'm using (I just noticed I have two kinds of metro track GRFs) interacting badly with the template patch. Let me know if you'd like a save (might be a while to get it, though) -- all the GRFs are from the online content manager.
Hmm, then I'm not sure. A save game would be helpful.
Ex TTDPatch Coder
Patch Pack, Github
SimYouLater
Chief Executive
Chief Executive
Posts: 675
Joined: 03 Apr 2016 20:19

Re: JGR's Patch Pack

Post by SimYouLater »

Would you be able to add Traffic Lights in the near future? Sorry if this has been asked before.
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.
User avatar
Narc
Engineer
Engineer
Posts: 12
Joined: 16 May 2008 20:47

Re: JGR's Patch Pack

Post by Narc »

JGR wrote:
Narc wrote:Sorry to disappoint, but I'm running 0.13.3, it's a fresh new map, and that was the first template I (tried to) set up.

I'm suspecting it's something odd about the NewGRFs I'm using (I just noticed I have two kinds of metro track GRFs) interacting badly with the template patch. Let me know if you'd like a save (might be a while to get it, though) -- all the GRFs are from the online content manager.
Hmm, then I'm not sure. A save game would be helpful.
Well, the issue does seem to be specific to the locomotive I was trying to use (suggesting the NewGRFs being at fault), but really it shouldn't happen, should it?

Here's the save: http://dev.narc.ro/openttd/assert-failure-jgrpp.sav (5.7 MiB; content should all be automatically obtainable)
Steps to reproduce as follows:
  1. Load the save
  2. Open the trains list
  3. Go into template replacement (for any group; I've used a custom one as well as the "All trains" group)
  4. Start a new template, and
  5. Specifically use the "2-6-2 Suburban (Steam)" to start the new template (I've tried a few others and they're okay)
Upon clicking to buy the locomotive, you should see the assert failure pop up; if it doesn't, let me know, so I can just consider myself cursed and quit trying to use that engine (even if it is just right for the line I'm setting up).
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Narc wrote:
JGR wrote:
Narc wrote:Sorry to disappoint, but I'm running 0.13.3, it's a fresh new map, and that was the first template I (tried to) set up.

I'm suspecting it's something odd about the NewGRFs I'm using (I just noticed I have two kinds of metro track GRFs) interacting badly with the template patch. Let me know if you'd like a save (might be a while to get it, though) -- all the GRFs are from the online content manager.
Hmm, then I'm not sure. A save game would be helpful.
Well, the issue does seem to be specific to the locomotive I was trying to use (suggesting the NewGRFs being at fault), but really it shouldn't happen, should it?

Here's the save: http://dev.narc.ro/openttd/assert-failure-jgrpp.sav (5.7 MiB; content should all be automatically obtainable)
Steps to reproduce as follows:
  1. Load the save
  2. Open the trains list
  3. Go into template replacement (for any group; I've used a custom one as well as the "All trains" group)
  4. Start a new template, and
  5. Specifically use the "2-6-2 Suburban (Steam)" to start the new template (I've tried a few others and they're okay)
Upon clicking to buy the locomotive, you should see the assert failure pop up; if it doesn't, let me know, so I can just consider myself cursed and quit trying to use that engine (even if it is just right for the line I'm setting up).
It looks like the NewGRF is trying to query the tile the train is on to check whether it has power or not, which seems a bit odd for a steam engine.
As template/virtual trains do not live on actual rail tiles this doesn't work, but should be straightforward to fix.

Edit: This is done and will be in the next release.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Narc
Engineer
Engineer
Posts: 12
Joined: 16 May 2008 20:47

Re: JGR's Patch Pack

Post by Narc »

JGR wrote:It looks like the NewGRF is trying to query the tile the train is on to check whether it has power or not, which seems a bit odd for a steam engine.
As template/virtual trains do not live on actual rail tiles this doesn't work, but should be straightforward to fix.

Edit: This is done and will be in the next release.
Beautiful, thanks kindly!
Sacro
Tycoon
Tycoon
Posts: 1145
Joined: 18 Jun 2005 21:08
Location: Here
Contact:

Re: JGR's Patch Pack

Post by Sacro »

Nice to see this is still going :D

Any chance of adding the Yellow Signals patch and YAAM (yet another acceleration model)?
We Am De Best

Host of ThroughTheTube site
User avatar
Leanden
Tycoon
Tycoon
Posts: 2613
Joined: 19 Mar 2009 19:25
Location: Kent

Re: JGR's Patch Pack

Post by Leanden »

Sacro wrote:Nice to see this is still going :D

Any chance of adding the Yellow Signals patch and YAAM (yet another acceleration model)?
Im guessing you didnt read the whole thread then, or even the last page?
Image
Sacro
Tycoon
Tycoon
Posts: 1145
Joined: 18 Jun 2005 21:08
Location: Here
Contact:

Re: JGR's Patch Pack

Post by Sacro »

Leanden wrote:
Sacro wrote:Nice to see this is still going :D

Any chance of adding the Yellow Signals patch and YAAM (yet another acceleration model)?
Im guessing you didnt read the whole thread then, or even the last page?
All 24 pages no? And for others looking, you have to go back 2 pages to find the response.
We Am De Best

Host of ThroughTheTube site
czerwony6969
Engineer
Engineer
Posts: 4
Joined: 09 Jul 2016 20:17

Re: JGR's Patch Pack

Post by czerwony6969 »

Hello. I have a bug:


*** OpenTTD Crash Report ***

Crash at: Sat Jul 09 19:33:32 2016
In game date: 1927-06-05 (56, 5)

Crash reason:
Exception: E1212012
Location: 000007FEFDBCA06D
Message: Assertion failed at line 205 of /home/jgr/openttd/cross-win64/src/pathfinder/yapf/yapf_destrail.hpp: n.m_estimate >= n.m_parent->m_estimate

Within context:
0: CallVehicleTicks: veh: 18: (Pociąg 7)

OpenTTD version:
Version: jgrpp-0.13.3 (0)
NewGRF ver: 17006bcf
Bits: 64
Endian: little
Dedicated: no
Build date: Jun 12 2016 21:39:11
Configure: ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
00000016 00000000 00000000 00000000 00000008 00000000 77929AE6 00000000
E1212012 00000000 00000000 00000000 FDBCA06D 000007FE 00000000 000007FE
15681300 80000000 77981392 00000000 00012010 00000000 00000130 000007FE
00720506 00000000 0000002C 00000000 00000000 00000000 FFFFFFFF 000007FE
00012010 00000000 77B6087A 00000000 00012010 00000000 55A04C02 00000000
002274B8 00000000 0000002C 00000000 00000000 00000000 FE0E05E9 000007FE
00000001 00000000 FE101925 000007FE 00000016 00000000 55A04C02 00000000
FE155180 000007FE 00000001 00000000 00000003 00000000 77B57E0A 00000000
FE156180 000007FE 00000314 00000000 000005DA 00000000 00227DC0 00000000
0022A7D8 00000000 00000001 00000000 316837C8 00000000 FE1053AA 000007FE
00000001 00000000 00227B10 00000000 31683848 00000000 316837C8 00000000
02A8A0B0 00000000 02A00230 00000000 00000000 00000000 00000001 00000000
00000001 00000000 77BA3084 00000000 002275B8 00000000 3F00003F 00000003
7791CBCA 00000000 77929095 00000000 00000000 00000000 002275E8 00000000
00000000 00000000 A70002A5 00000000 00000082 00000000 00000000 00000000
00000000 00000000 77B52C54 00000000 77B6C730 00000000 779350BC 00000000
00720506 00000000 02000002 00000000 00000001 00000000 00655AF0 00000000
00000001 00000000 540A19F5 00000000 014F064E 00000000 00000202 00000000
00000000 00000000 0012004B 00000000 0000001A 00000000 00000231 00000000
00000000 00000000 00000000 00000000 77910000 00000000 02A86F60 00000000
00000000 00000000 77934F11 00000000 00720506 00000000 77983488 00000000
00000001 00000000 00720506 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000010 00000000 00010003 00000000 00000001 00000000
02A86F60 00000000 779829E9 00000000 02A00000 00000000 FFFFFF01 FFFFFFFF

Registers:
RAX: 0000000070867C6A RBX: 0000000000000016 RCX: 0000000000226DE0 RDX: 0000000000000000
RSI: 0000000000000000 RDI: 0000000000000008 RBP: 0000000000000002 RSP: 00000000002273F0
R8: 0000000000000000 R9: 0000000000000000 R10: 0000000000000000 R11: 0000000000000286
R12: 000007FEFE151130 R13: 000000000053A990 R14: 0000000000000001 R15: 0000000000000314
RIP: 000007FEFDBCA06D EFLAGS: 00000206

Bytes at instruction pointer:
48 81 C4 C8 00 00 00 C3 90 90 90 90 90 90 90 90 90 90 90 48 83 EC 28 65

Operating system:
Name: Windows
Release: 6.1.7601 (Service Pack 1)
Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
Blitter: 32bpp-sse2-anim
Graphics set: OpenGFX (5580)
Language: D:\Gierki\OpenTTD\lang\polish.lng
Music driver: win32
Music set: NoMusic (0)
Network: server
Sound driver: win32
Sound set: NoSound (2)
Video driver: win32

Fonts:
Small: sprite
Medium: sprite
Large: sprite
Mono: sprite

AI Configuration (local: 0) (current: 16):
0: Human
1: Human
GS: Renewed City Growth + Tile Label Industry Builder (v4)

Libraries:
FreeType: 2.6.0
LZMA: 5.2.1
LZO: 2.09
PNG: 1.5.23
Zlib: 1.2.8

Module information:
D:\Gierki\OpenTTD\openttd.exe handle: 0000000000400000 size: 37240704 crc: 03E92138 date: 2016-06-12 19:39:16
C:\Windows\SYSTEM32\ntdll.dll handle: 0000000077b30000 size: 1732888 crc: 14363964 date: 2016-05-16 23:17:39
C:\Windows\system32\kernel32.dll handle: 0000000077a10000 size: 1163264 crc: 0FDFC0E4 date: 2016-05-16 23:14:25
C:\Windows\system32\KERNELBASE.dll handle: 000007fefdbb0000 size: 419840 crc: 78E9E216 date: 2016-05-16 23:14:25
C:\Windows\system32\ADVAPI32.dll handle: 000007fefe420000 size: 880640 crc: 3B4F81E7 date: 2016-05-16 23:14:20
C:\Windows\system32\msvcrt.dll handle: 000007fefe0c0000 size: 634880 crc: 9D1B448A date: 2011-12-16 08:46:06
C:\Windows\SYSTEM32\sechost.dll handle: 000007fefe400000 size: 113664 crc: 978CFAE5 date: 2009-07-14 01:41:53
C:\Windows\system32\RPCRT4.dll handle: 000007feffd10000 size: 1212928 crc: 17DAAA67 date: 2016-05-16 23:14:34
C:\Windows\system32\GDI32.dll handle: 000007fefe860000 size: 405504 crc: 3CDE120A date: 2016-05-18 16:09:22
C:\Windows\system32\USER32.dll handle: 0000000077910000 size: 1008640 crc: 390AABAD date: 2015-11-10 18:55:26
C:\Windows\system32\LPK.dll handle: 000007fefe500000 size: 41472 crc: C0FE73F0 date: 2016-05-13 22:09:19
C:\Windows\system32\USP10.dll handle: 000007fefdc70000 size: 802304 crc: 3DC2D6D4 date: 2015-11-03 19:04:51
C:\Windows\system32\IMM32.dll handle: 000007fefe1e0000 size: 167424 crc: 41B2805A date: 2009-07-14 01:41:09
C:\Windows\system32\MSCTF.dll handle: 000007fefdfa0000 size: 1067520 crc: 362B3A40 date: 2015-01-17 02:48:38
C:\Windows\system32\SHELL32.dll handle: 000007fefea30000 size: 14186496 crc: F1F6E755 date: 2016-04-09 06:58:02
C:\Windows\system32\SHLWAPI.dll handle: 000007fefe160000 size: 448512 crc: 086DF743 date: 2010-11-21 03:24:22
C:\Windows\system32\WINMM.dll handle: 000007fefb380000 size: 217600 crc: 7BC1529F date: 2009-07-14 01:41:56
C:\Windows\system32\WS2_32.dll handle: 000007fefdd40000 size: 296448 crc: EE1BC529 date: 2016-05-11 17:02:50
C:\Windows\system32\NSI.dll handle: 000007fefe0b0000 size: 13824 crc: 53B46F6C date: 2009-07-14 01:41:53
C:\Windows\system32\ole32.dll handle: 000007fefdd90000 size: 2084864 crc: A92D057C date: 2016-03-17 22:56:24
C:\Windows\system32\uxtheme.dll handle: 000007fefa780000 size: 332288 crc: B0A13DF9 date: 2009-07-14 01:41:56
C:\Windows\system32\dwmapi.dll handle: 000007fefa380000 size: 82944 crc: F979E48B date: 2015-07-09 17:58:26
C:\Windows\system32\CRYPTBASE.dll handle: 000007fefd750000 size: 43520 crc: A5115230 date: 2016-05-16 23:14:22
C:\Windows\system32\mswsock.dll handle: 000007fefd050000 size: 327168 crc: 2E4865A8 date: 2016-05-11 17:02:42
C:\Windows\System32\wshtcpip.dll handle: 000007fefb490000 size: 13312 crc: 5D1E2C55 date: 2009-07-14 01:41:58
C:\Windows\system32\MMDevAPI.DLL handle: 000007fefa920000 size: 284160 crc: CDF2EF81 date: 2009-07-14 01:41:26
C:\Windows\system32\PROPSYS.dll handle: 000007fefaa20000 size: 1212416 crc: B83FA3BE date: 2010-11-21 03:23:55
C:\Windows\system32\OLEAUT32.dll handle: 000007fefe950000 size: 862208 crc: C9245F94 date: 2016-05-12 17:14:57
C:\Windows\system32\wdmaud.drv handle: 000007fef1a70000 size: 217088 crc: 12829973 date: 2010-11-21 03:24:32
C:\Windows\system32\ksuser.dll handle: 00000000754b0000 size: 5120 crc: 781141DD date: 2015-12-08 19:07:31
C:\Windows\system32\AVRT.dll handle: 000007fefa910000 size: 18432 crc: 5CE53CB7 date: 2009-07-14 01:40:05
C:\Windows\system32\SETUPAPI.dll handle: 000007feffb30000 size: 1900544 crc: A364BD6A date: 2010-11-21 03:24:28
C:\Windows\system32\CFGMGR32.dll handle: 000007fefd8d0000 size: 207872 crc: 1984C339 date: 2010-11-21 03:24:00
C:\Windows\system32\DEVOBJ.dll handle: 000007fefd910000 size: 93184 crc: A7541AE2 date: 2009-07-14 01:40:28
C:\Windows\system32\AUDIOSES.DLL handle: 000007fef1890000 size: 296448 crc: E010A4A9 date: 2015-02-03 03:30:55
C:\Windows\system32\msacm32.drv handle: 000007fef1880000 size: 25600 crc: 2B579A05 date: 2009-07-14 01:38:50
C:\Windows\system32\MSACM32.dll handle: 000007fef1860000 size: 83456 crc: 3D67538B date: 2009-07-14 01:41:27
C:\Windows\system32\midimap.dll handle: 000007fef1850000 size: 20480 crc: CB902A13 date: 2009-07-14 01:41:23
C:\Windows\system32\CLBCatQ.DLL handle: 000007feff7c0000 size: 607744 crc: 939E35C9 date: 2009-07-14 01:40:15
C:\Windows\System32\wship6.dll handle: 000007fefd040000 size: 13824 crc: E3FBF123 date: 2009-07-14 01:41:58
C:\Windows\system32\psapi.dll handle: 0000000077cf0000 size: 9216 crc: 84B5E9BA date: 2009-07-14 01:41:53

---- gamelog start ----
Tick 0: new game started
Revision text changed to 1.5.1, savegame version 194, not modified, _openttd_newgrf_version = 0x15186aa2
New game mode: 2 landscape: 1
Added NewGRF: GRF ID 57A50001, checksum 318F3C3F17CA68EAD533BAC88B093094, filename: was_world_airliners_set-0.1\was.grf (md5sum matches)
Added NewGRF: GRF ID 41560102, checksum 7D4DD258F3998C8DB3A918C2472B25F3, filename: pipe-6.40\pipe.grf (md5sum matches)
Added NewGRF: GRF ID 634D0100, checksum 65E3C5D513D64016A318AE2320DE7B32, filename: betabridges-0.5\betabridges.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum 72A8D6A48DE743563FC773B291BC9906, filename: opengfx_landscape-1.1.1\ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 464B0000, checksum E266FE2217DE82D7C1F8968EC81A2915, filename: hungarian_stations-1\hungarian_stations.grf (md5sum matches)
Added NewGRF: GRF ID 464B0001, checksum B5A131DCAC1D7C7E24166EDEA2D106F1, filename: hungarian_stations_2-1\hungarian_stations2.grf (md5sum matches)
Added NewGRF: GRF ID 464B0002, checksum 9D3B823C988DB972503A72E58180D077, filename: hungarian_stations_3-1\hungarian_stations3.grf (md5sum matches)
Added NewGRF: GRF ID 0B0F3337, checksum 8B6F892BBB8946B39B67CC11B8F340EC, filename: hungarianmetroset-0.1\hungarianmetroset.grf (md5sum matches)
Added NewGRF: GRF ID 444A5401, checksum B9E9E16F258B32DC91E8BABEF037AFA7, filename: nutracks-r247\nutracks.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0402, checksum 055724E1608C73A181748D39F28CB0E7, filename: metro_track_set-2.1.1\metrotrackset.grf (md5sum matches)
Added NewGRF: GRF ID 4D430207, checksum 5D12406F7B2E0B76C7EDADF7524E62EC, filename: polroad-18\polroad.grf (md5sum matches)
Added NewGRF: GRF ID 1560B248, checksum 76BE5A3BA8C66817C14CFA05177D20D9, filename: redfish-0.4\redfish.grf (md5sum matches)
Added NewGRF: GRF ID 4D430107, checksum B0926C15DC893124EA54969A3BD5B4CF, filename: polish_tram_set_by_sojita-11\poltrams.grf (md5sum matches)
Added NewGRF: GRF ID 54440103, checksum 87A22193371A7E04279130835E21ACF2, filename: polish_pkp_set_2.0-2.0.11\pkp-set-2.0.11.grf (md5sum matches)
Added NewGRF: GRF ID 4D635069, checksum 57F1EEB0BA84C54411D58242AE5110DF, filename: preindustrial_era_houses-0.3\preindustrial.grf (md5sum matches)
Added NewGRF: GRF ID 72777473, checksum EBEAB33B398DE7F2921F853C496F6F91, filename: uk_town_set-2.2\ukts_2.2.grf (md5sum matches)
Added NewGRF: GRF ID 4D470305, checksum 2E96B9AB2BEA686BFF94961AD433A701, filename: basecosts-5.0\basecosts.grf (md5sum matches)
Added NewGRF: GRF ID 4D634D69, checksum 1174B806DC94A7C29E7E9275A1701F34, filename: manpower_ogfxindustries-2.7\manpower-ogfx-industries.grf (md5sum matches)
Tick 1280: game loaded
New game mode: 1 landscape: 1
Tick 18473: game loaded
New game mode: 2 landscape: 1
Tick 18473: game loaded
New game mode: 1 landscape: 1
Tick 32263: game loaded
New game mode: 2 landscape: 1
Tick 32263: game loaded
New game mode: 1 landscape: 1
Tick 45389: game loaded
New game mode: 2 landscape: 1
Tick 45389: game loaded
Revision text changed to Spring 2013 Pa, savegame version 222, not modified, _openttd_newgrf_version = 0x140069e8
Tick 45389: settings changed
Setting changed: construction.command_pause_level : 1 -> 3
Tick 45389: GRF config changed
Compatible NewGRF loaded: GRF ID 4F472B34, checksum 136D889FDAEAA3491F8320248A04425C, filename: opengfx_landscape-1.1.2\ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 50560006, checksum 66C1CE2308CDE9995FEEA3E7FC2E4FA4, filename: csdset_v_1.5.0-1.0.5\csdseto.grf (md5sum matches)
Added NewGRF: GRF ID 4D530102, checksum BE7A51161EB3894E71E9961D9C183EBA, filename: czech_railways_set-1.0\cdset.grf (md5sum matches)
Added NewGRF: GRF ID 58534453, checksum 2E100BCA91DB8371CD9D57DBEC3AB0C8, filename: dutch_stations_set-1.0.0alpha\dutchstatw.grf (md5sum matches)
Added NewGRF: GRF ID 504A0110, checksum E8244C5278CB2408A818854DC11F8940, filename: dutch_station_addition_set-0.8\dstatadd_v0_8.grf (md5sum matches)
Added NewGRF: GRF ID 534A0100, checksum BDE1AA7B696D4AFE9F74CB4AD0B3812A, filename: PolishBusV2w.GRF (md5sum matches)
Added NewGRF: GRF ID 534A0000, checksum F296AB1B0F472E7ACA3FBCA493BADB3D, filename: polish_road_set-5\plroadsetv5w.grf (md5sum matches)
Tick 45389: game loaded
Revision text changed to jgrpp-0.8.1, savegame version 194, not modified, _openttd_newgrf_version = 0x16006b4a
Tick 45389: GRF config changed
Compatible NewGRF loaded: GRF ID 4D430207, checksum 1D297AAD8A7F19F49ED60997CADCEF9E, filename: polroad-19\polroad.grf (md5sum matches)
GRF order changed: 54440103 moved 8 places downGRF ID 54440103, filename: polish_pkp_set_2.0-2.0.11\pkp-set-2.0.11.grf (md5sum matches)
Removed NewGRF: GRF ID 50560006, filename: csdset_v_1.5.0-1.0.5\csdseto.grf (md5sum matches)
Removed NewGRF: GRF ID 504A0110, filename: dutch_station_addition_set-0.8\dstatadd_v0_8.grf (md5sum matches)
Added NewGRF: GRF ID 54440103, checksum 4FE5592D927460CDFC6BCFA57D9B7558, filename: pkp-set-2.0.12.grf (md5sum matches). Gamelog inconsistency: GrfID was already added!
Tick 45389: game loaded
Revision text changed to jgrpp-0.13.3, savegame version 195, not modified, _openttd_newgrf_version = 0x17006bcf
Tick 45389: GRF config changed
Compatible NewGRF loaded: GRF ID FBFB0402, checksum D83CC84C8B92C924C5EBEEE96565D194, filename: metro_track_set-2.1.2\metrotrackset.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 4D430207, checksum 095E9379015151E0C3CC3A938CDB7B4C, filename: polroad-32\polroad.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 4D430107, checksum 0388A85A7FC086124A96FBDF603CBCDE, filename: polish_tram_set_by_sojita-14\poltrams.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 4D635069, checksum 3984C2C5ADCC45F2545F9E3988CF6C9B, filename: preindustrial_era_houses-0.4\preindustrial.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 4D634D69, checksum B760846BD34E882AF930AD9FACDBCF5C, filename: manpower_ogfxindustries-2.9\manpower-ogfx-industries.grf (md5sum matches)
Tick 45389: game loaded
New game mode: 1 landscape: 1
Tick 61695: settings changed
Setting changed: vehicle.disable_elrails : 1 -> 0
Tick 61695: settings changed
Setting changed: construction.max_tunnel_length : 4096 -> 96
Tick 61695: settings changed
Setting changed: construction.max_bridge_length : 256 -> 56
Tick 61695: settings changed
Setting changed: vehicle.adjacent_crossings : 1 -> 0
Tick 61695: settings changed
Setting changed: vehicle.freight_trains : 1 -> 2
Tick 61695: settings changed
Setting changed: vehicle.freight_trains : 2 -> 3
Tick 61695: settings changed
Setting changed: vehicle.freight_trains : 3 -> 4
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE 0x000007FEFDBCA06D RaiseException + 61
[01] msvcrt 0x000007FEFE101925 raise + 565
[02] msvcrt 0x000007FEFE1053AA abort + 46
[03] openttd 0x000000000052CCFF error(char const*, ...) + 95 (/home/jgr/openttd/cross-win64/src/openttd.cpp:129)
[04] openttd 0x00000000007DC94D CYapfDestinationTileOrStationRailT<CYapfRail_TypesT<CYapfRail2, CFollowTrackT<(TransportType)0, Train, false, false>, CNodeList_HashTableT<CYapfRailNodeT<CYapfNodeKeyTrackDir>, 8, 10>, CYapfDestinationTileOrStationRailT, CYapfFollowRailT> >::PfCalcEstimate(CYapfRailNodeT<CYapfNodeKeyTrackDir>&) (/home/jgr/openttd/cross-win64/src/pathfinder/yapf/yapf_destrail.hpp:205)
[05] openttd 0x000000000082FD83 CYapfFollowRailT<CYapfRail_TypesT<CYapfRail2, CFollowTrackT<(TransportType)0, Train, false, false>, CNodeList_HashTableT<CYapfRailNodeT<CYapfNodeKeyTrackDir>, 8, 10>, CYapfDestinationTileOrStationRailT, CYapfFollowRailT> >::ChooseRailTrack(Train const*, unsigned int, DiagDirection, TrackBits, bool&, bool, PBSTileInfo*) + 147 (/home/jgr/openttd/cross-win64/src/pathfinder/yapf/yapf_rail.cpp:508)
[06] openttd 0x00000000008301A7 CYapfFollowRailT<CYapfRail_TypesT<CYapfRail2, CFollowTrackT<(TransportType)0, Train, false, false>, CNodeList_HashTableT<CYapfRailNodeT<CYapfNodeKeyTrackDir>, 8, 10>, CYapfDestinationTileOrStationRailT, CYapfFollowRailT> >::stChooseRailTrack(Train const*, unsigned int, DiagDirection, TrackBits, bool&, bool, PBSTileInfo*) + 439 (/home/jgr/openttd/cross-win64/src/pathfinder/yapf/yapf_rail.cpp:481)
[07] openttd 0x00000000005446FF YapfTrainChooseTrack(Train const*, unsigned int, DiagDirection, TrackBits, bool&, bool, PBSTileInfo*) + 79 (/home/jgr/openttd/cross-win64/src/pathfinder/yapf/yapf_rail.cpp:622)
[08] openttd 0x000000000062DDAD ChooseTrainTrack (/home/jgr/openttd/cross-win64/src/train_cmd.cpp:2841)
[09] openttd 0x000000000062E818 TryPathReserve(Train*, bool, bool) + 632 (/home/jgr/openttd/cross-win64/src/train_cmd.cpp:2995)
[10] openttd 0x0000000000632BAD CheckTrainStayInDepot (/home/jgr/openttd/cross-win64/src/train_cmd.cpp:2316)
[11] openttd 0x0000000000632E3D Train::Tick() + 93 (/home/jgr/openttd/cross-win64/src/train_cmd.cpp:4473)
[12] openttd 0x00000000006499C2 CallVehicleTicks() + 386 (/home/jgr/openttd/cross-win64/src/vehicle.cpp:1011)
[13] openttd 0x000000000053082A StateGameLoop() + 442 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1530)
[14] openttd 0x00000000004E3FE8 NetworkGameLoop() + 248 (/home/jgr/openttd/cross-win64/src/network/network.cpp:1004)
[15] openttd 0x0000000000530941 GameLoop() + 161 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1625)
[16] openttd 0x0000000000654F89 VideoDriver_Win32::MainLoop() + 457 (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:1277)
[17] openttd 0x000000000052E5C1 openttd_main(int, char**) + 5233 (/home/jgr/openttd/cross-win64/src/openttd.cpp:902)
[18] openttd 0x000000000053BE4F WinMain + 239 (/home/jgr/openttd/cross-win64/src/os/windows/win32.cpp:466)
[19] openttd 0x00000000004013ED __tmainCRTStartup + 573 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:332)
[20] openttd 0x00000000004014FB WinMainCRTStartup + 27 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:184)
[21] kernel32 0x0000000077A259BD BaseThreadInitThunk + 13
[22] ntdll 0x0000000077B5A2E1 RtlUserThreadStart + 33

*** End of additional info ***
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

czerwony6969 wrote:Hello. I have a bug:
...
Thanks for the bug report. Can you post the savegame as well?
Ex TTDPatch Coder
Patch Pack, Github
czerwony6969
Engineer
Engineer
Posts: 4
Joined: 09 Jul 2016 20:17

Re: JGR's Patch Pack

Post by czerwony6969 »

Sure :)
Attachments
Bloggs & Co., 6 cze 1927.sav
(2.13 MiB) Downloaded 75 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

czerwony6969 wrote:Sure :)
Hi, can you post a copy of or a link to 'PolishBusV2w.grf', which is used by your game, as well?
Ex TTDPatch Coder
Patch Pack, Github
czerwony6969
Engineer
Engineer
Posts: 4
Joined: 09 Jul 2016 20:17

Re: JGR's Patch Pack

Post by czerwony6969 »

Here is GRF.
Attachments
PolishBusV2w.GRF
(187 KiB) Downloaded 84 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

czerwony6969 wrote:Hello. I have a bug:
...
I notice that the various pathfinder penalty settings in your game are set to highly interesting values.
I've not done a thorough analysis yet, but I'm inclined to suspect that this is the source of the problem.
[+] Spoiler

Code: Select all

pf.wait_for_pbs_path = 2
pf.reserve_paths = on
pf.path_backoff_interval = 1
pf.opf.pf_maxlength = 5136
pf.opf.pf_maxdepth = 4
pf.npf.npf_max_search_nodes = 100000
pf.npf.npf_rail_firstred_penalty = 100000
pf.npf.npf_rail_firstred_exit_penalty = 100000
pf.npf.npf_rail_lastred_penalty = 100000
pf.npf.npf_rail_station_penalty = 100000
pf.npf.npf_rail_slope_penalty = 100000
pf.npf.npf_rail_curve_penalty = 100000
pf.npf.npf_rail_depot_reverse_penalty = 100000
pf.npf.npf_rail_pbs_cross_penalty = 100000
pf.npf.npf_rail_pbs_signal_back_penalty = 100000
pf.npf.npf_buoy_penalty = 100000
pf.npf.npf_water_curve_penalty = 100000
pf.npf.npf_road_curve_penalty = 100000
pf.npf.npf_crossing_penalty = 100000
pf.npf.npf_road_drive_through_penalty = 100000
pf.npf.npf_road_dt_occupied_penalty = 100000
pf.npf.npf_road_bay_occupied_penalty = 100000
pf.npf.maximum_go_to_depot_penalty = 1000000
pf.yapf.disable_node_optimization = on
pf.yapf.max_search_nodes = 500
pf.yapf.rail_firstred_twoway_eol = on
pf.yapf.rail_firstred_penalty = 3
pf.yapf.rail_firstred_exit_penalty = 1000000
pf.yapf.rail_lastred_penalty = 1000000
pf.yapf.rail_lastred_exit_penalty = 1000000
pf.yapf.rail_station_penalty = 1000000
pf.yapf.rail_slope_penalty = 1000000
pf.yapf.rail_curve45_penalty = 1000000
pf.yapf.rail_curve90_penalty = 1000000
pf.yapf.rail_depot_reverse_penalty = 1000000
pf.yapf.rail_crossing_penalty = 1000000
pf.yapf.rail_look_ahead_max_signals = 100
pf.yapf.rail_look_ahead_signal_p0 = 1000000
pf.yapf.rail_look_ahead_signal_p1 = -1000000
pf.yapf.rail_look_ahead_signal_p2 = -1000000
pf.yapf.rail_pbs_cross_penalty = 1000000
pf.yapf.rail_pbs_station_penalty = 1000000
pf.yapf.rail_pbs_signal_back_penalty = 1000000
pf.yapf.rail_doubleslip_penalty = 1000000
pf.yapf.rail_longer_platform_penalty = 20000
pf.yapf.rail_longer_platform_per_tile_penalty = 20000
pf.yapf.rail_shorter_platform_penalty = 31
pf.yapf.rail_shorter_platform_per_tile_penalty = 20000
pf.yapf.road_slope_penalty = 0
pf.yapf.road_curve_penalty = 1000000
pf.yapf.road_crossing_penalty = 1000000
pf.yapf.road_stop_penalty = 1000000
pf.yapf.road_stop_occupied_penalty = 1000000
pf.yapf.road_stop_bay_occupied_penalty = 1000000
pf.yapf.maximum_go_to_depot_penalty = 1000000

Code: Select all

pf.yapf.rail_look_ahead_signal_p0 = 1000000
pf.yapf.rail_look_ahead_signal_p1 = -1000000
pf.yapf.rail_look_ahead_signal_p2 = -1000000
These are particularly bad, as it means that you will get negative pathfinder costs for red signals en-route, which is a feasible cause of the error you ran into, which is implicitly checking for negative penalties.

Code: Select all

pf.yapf.rail_look_ahead_max_signals = 100
This in combination with the above, and the other large values in general, seems likely to result in numeric overflow issues, which is another feasible cause for the error you ran into.

Why did you set these settings to these particular values?

Most of these parameters are not intended to be set by end-users, and any tuning of the remaining ones should be done with care.
Can I suggest that you set them all back to the default values.
Ex TTDPatch Coder
Patch Pack, Github
czerwony6969
Engineer
Engineer
Posts: 4
Joined: 09 Jul 2016 20:17

Re: JGR's Patch Pack

Post by czerwony6969 »

[quote="JGR"][\quote="JGR"]

Thanks for You time. I didn't change this settings.
I delete OTTD (with user folder) from my computer and I get fresh installation. When I open the same save I have the same problem :/
Here is fresh CFG:
Attachments
openttd.cfg
(12.86 KiB) Downloaded 84 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

The pathfinder settings are also stored inside the savegame. Changing the config file only affects new games.

I've reset the pathfinder settings in the savegame you posted earlier to their default values. See attached.
Attachments
Bloggs & Co., 6 cze 1927 - fixed.sav
(2.13 MiB) Downloaded 81 times
Ex TTDPatch Coder
Patch Pack, Github
lyarenei
Engineer
Engineer
Posts: 22
Joined: 21 Dec 2015 15:36

Re: JGR's Patch Pack

Post by lyarenei »

Hi, just to report a very little bug in rev.cpp when compiling with older gcc version (tried with 4.9.2)

Code: Select all

[SRC] Compiling rev.cpp
/home/lyarenei/ottd-j/src/rev.cpp:66:41: error: expected primary-expression before ';' 
token const byte _openttd_revision_modified = ;
					   			    					^
Makefile:238: recipe for target 'rev.o' failed
Adding a value resolves it. I don't know If it somehow affects gameplay, but probably not.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

lyarenei wrote:Hi, just to report a very little bug in rev.cpp when compiling with older gcc version (tried with 4.9.2)

Code: Select all

[SRC] Compiling rev.cpp
/home/lyarenei/ottd-j/src/rev.cpp:66:41: error: expected primary-expression before ';' 
token const byte _openttd_revision_modified = ;
					   			    					^
Makefile:238: recipe for target 'rev.o' failed
Adding a value resolves it. I don't know If it somehow affects gameplay, but probably not.
Can you post here what the output of running `./findversion.sh` is.
Which method did you use to get the source, and what is in your .ottdrev-vc and/or .ottdrev files?
Thanks for reporting the issue.
Ex TTDPatch Coder
Patch Pack, Github
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 13 guests