OpenTTD 1.0.5 does not supports Autopilot 3.0+

[OpenM]

After I actualize version of my OpenTTD servers i've got a problem with autopilot script. In console I see a additional character (red marker):

Autopilot engaged
Starting new game: 'testing'
(...)
â*** testuser has joined the game (Client #3)
â[All] testuser: chat test
â[All] testuser: chat test2
â[All] testuser: IRC doesn't work

Propably these changes is the reason for problem with additional character:

- Fix: Chat/console messages got sometimes messed up due to LTR names in RTL translations and vice-versa [FS#3746] (r21006, r21004)

Anybody knows how to adapt AP+ to ignore this character? This broke all of AP+ scripts (commands, callback, IRC...) and injures my servers.
The problem occurs only when AP+ getting information from the chat (other informations like companies data are without additional character).

[Rubidium]

It's Autopilot that doesn't support OpenTTD 1.0.5.

In any case, autopilot should just filter the text direction characters out of the strings. I have no idea how to do this, though I've suggested starting OpenTTD with a script that removes the text direction characters with sed but I've not seen that being implemented.

For the rest I've got no clue how to fix autopilot; "fixing" OpenTTD means re-introducing the bug that is fixed by adding these text direction characters.

[Whos]

Maybe first let's see what was changed in new version in the chat.

Probably a some characters was added, and autopilot copy these accidentally. I'm sure that we could convert the script to run under 1.0.5. Undoubtedly it's only one character there, where it should not.

[OpenM]

Please, it is important for me. Anyone help?

[Zuu]

Perhaps change autopilot to first trim the lines before processing them?

[OpenM]

Easy to say. I don't know where I must find suitable line. If the authors will show what exactly has been changed ("before" and "after"), it would be easier. Autopilot just taking too more information from game, where was appeared additional character.
Contact autopilot -> game is correctly.
Game -> autopilot is broken.
Propably by one character.

I appeal to authors to show exactly changes to the code in the game.

[Lord Aro]

You mean OpenTTD?

Try these:

http://hg.openttd.org/openttd/trunk.hg/rev/6a104752d524 - r21004
http://hg.openttd.org/openttd/trunk.hg/rev/00b13ac8d935 - r21006

[OpenM]

You mean OpenTTD?

Try these:

http://hg.openttd.org/openttd/trunk.hg/rev/6a104752d524 - r21004
http://hg.openttd.org/openttd/trunk.hg/rev/00b13ac8d935 - r21006

Yes, thank you very much. I'll try to adapt Autopilot for code changes. .

[Zuu]

I took a quick look at the source code and I can tell you that there is a comment line:

Code: Select all

						# Get this far, and we have exactly one line of output from the server.

Looking at the context, the line is probably stored in $linestr. Here's some more code to provide you also with the context:

Code: Select all

				foreach linestr [split [string map {"\r" {} } $out_buffer] "\n"] {
					# You'll get at least one empty from the split
					if {$linestr != {} } {
						regexp -nocase {^(\[\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d\])\s+(.*)} $linestr line timestamp linestr
						set line [split $linestr]
						# Get this far, and we have exactly one line of output from the server.
						# Now we have fun with ifs and cases!
						if {[string first {dbg: } $linestr] == 0} {

As a side note, I don't know TCL at all, so in order to trim $linestr I would need to lookup how to do that in TCL, something I leave for you to do.

[dihedral]

Sorry i was not around to reply at the time you asked for help....

From my perspective, I will refuse to continue fixing and adding support for autopilot, and consider it a dead project merely kept alive as there is no suitable replacement.

I am working on a replacement project, which however will not support the current stable releases of OpenTTD.
I hope to get the project to a usable state before the next stable is release, could possibly take a few weeks longer though

[planetmaker]

There's a fix available within the newest trunk revision of ap+: http://dev.openttdcoop.org/projects/autopilot

[dihedral]

the fix renders that version of autopilot incompatible with earlier versions of OpenTTD