OpenGFX - Graphics Base Set

[Moriarty]

Nightly OTTD builds (at the moment, anyway) require the nightly versions of OGFX . IIRC it's only small sprites in the town-list menu, or something along those lines...

Hmmm. I didn't know there was a "nightly" version of the OGFX, thanks.

[Nite Owl]

did you check your transparency settings (Ctrl+X)?

The simplest and most obvious answer is usually the correct one. Somewhat embarrassing too given how long I have been playing this game. My apologies for my lack of insight. My thanks to Eddi for pointing me in the right direction. My thanks to FooBar for his suggestions. I assure you all that I will try to get more sleep in the future. At least my journey into the ridiculous benefited Moriarty with some new information making it not a total waste of time.

[YukonRob]

There are missing sprites when played with the latest nightly (well a few days ago anyway). Looks to be a/some gui button(s).

[planetmaker]

There are missing sprites when played with the latest nightly (well a few days ago anyway). Looks to be a/some gui button(s).

Did you try an OpenGFX nightly as well?

[YukonRob]

Good idea. Will do. Thanks.

[Edit] As I suspected you already knew it works fine with the nightly

[inkieminstrel]

Running make -d install is failing for me. Here's the last section of output before failure:

Code: Select all

Updating goal targets....
Considering target file `install'.
 File `install' does not exist.
  Considering target file `opengfx'.
   File `opengfx' does not exist.
    Considering target file `Makefile.dep'.
    File `Makefile.dep' was considered already.
    Considering target file `opengfx.obg'.
     File `opengfx.obg' does not exist.
     Looking for an implicit rule for `opengfx.obg'.
     Trying pattern rule with stem `opengfx'.
     Trying rule prerequisite `ogfx1_base.grf'.
     Trying rule prerequisite `ogfxc_arctic.grf'.
     Trying rule prerequisite `ogfxh_tropical.grf'.
     Trying rule prerequisite `ogfxi_logos.grf'.
     Trying rule prerequisite `ogfxt_toyland.grf'.
     Trying rule prerequisite `ogfxe_extra.grf'.
     Trying rule prerequisite `.version'.
     Found an implicit rule for `opengfx.obg'.
      Considering target file `ogfx1_base.grf'.
       File `ogfx1_base.grf' does not exist.
       Looking for an implicit rule for `ogfx1_base.grf'.
       Trying pattern rule with stem `ogfx1_base'.
       Trying implicit prerequisite `ogfx1_base.nml'.
       Trying implicit prerequisite `ogfx1_base.gfx.dep'.
       Trying rule prerequisite `lang/english.lng'.
       Trying rule prerequisite `Makefile.dep'.
       Trying implicit prerequisite `ogfx1_base.tags.txt'.
       Trying pattern rule with stem `ogfx1_base.grf'.
       Trying implicit prerequisite `ogfx1_base.grf,v'.
       Trying pattern rule with stem `ogfx1_base.grf'.
       Trying implicit prerequisite `RCS/ogfx1_base.grf,v'.
       Trying pattern rule with stem `ogfx1_base.grf'.
       Trying implicit prerequisite `RCS/ogfx1_base.grf'.
       Trying pattern rule with stem `ogfx1_base.grf'.
       Trying implicit prerequisite `s.ogfx1_base.grf'.
       Trying pattern rule with stem `ogfx1_base.grf'.
       Trying implicit prerequisite `SCCS/s.ogfx1_base.grf'.
       Trying pattern rule with stem `ogfx1_base'.
       Trying implicit prerequisite `ogfx1_base.nml'.
       Trying implicit prerequisite `ogfx1_base.gfx.dep'.
       Trying rule prerequisite `lang/english.lng'.
       Trying rule prerequisite `Makefile.dep'.
       Trying implicit prerequisite `ogfx1_base.tags.txt'.
       Looking for a rule with intermediate file `ogfx1_base.tags.txt'.
        Avoiding implicit rule recursion.
        Trying pattern rule with stem `ogfx1_base'.
       Found an implicit rule for `ogfx1_base.grf'.
        Pruning file `ogfx1_base.nml'.
       Considering target file `ogfx1_base.tags.txt'.
        File `ogfx1_base.tags.txt' does not exist.
        Finished prerequisites of target file `ogfx1_base.tags.txt'.
       Must remake target `ogfx1_base.tags.txt'.
Putting child 0x7fcd88c8a7f0 (ogfx1_base.tags.txt) PID 93430 on the chain.
Live child 0x7fcd88c8a7f0 (ogfx1_base.tags.txt) PID 93430 
[LANG] ogfx1_base.tags.txt
Reaping winning child 0x7fcd88c8a7f0 PID 93430 
echo "TITLE    :OpenGFX" > ogfx1_base.tags.txt
Live child 0x7fcd88c8a7f0 (ogfx1_base.tags.txt) PID 93431 
Reaping winning child 0x7fcd88c8a7f0 PID 93431 
Removing child 0x7fcd88c8a7f0 PID 93431 from chain.
       Successfully remade target file `ogfx1_base.tags.txt'.
       Finished prerequisites of target file `ogfx1_base.grf'.
      Giving up on target file `ogfx1_base.grf'.
     Finished prerequisites of target file `opengfx.obg'.
    Giving up on target file `opengfx.obg'.
   Finished prerequisites of target file `opengfx'.
  Giving up on target file `opengfx'.
 Finished prerequisites of target file `install'.
Giving up on target file `install'.
Removing intermediate files...
rm ogfx1_base.tags.txt

Here's the output of make test:

Code: Select all

Graphics source list:         sprites/png/terrain/waterfeatures/waterfeatures.xcf2png sprites/png/infrastructure/locks.xcf2png sprites/png/terrain/terrain.xcf2png sprites/png/trees/trees.xcf2png sprites/png/industries/coalmine.xcf2png sprites/png/industries/goldmine/goldmine.xcf2png sprites/png/industries/oilwell/oilwell.xcf2png
Make:                         make
MD5sum:                       md5 -r
unix2dos:                      
gcc:                          cc -nostdinc -C -E - <
zip:                          zip -9rq
bzip:                         bzip2 -9fk
gimp:                         gimp -n -i -b - <
Need / Use gimp:              yes / yes
OS-Information:               Darwin
REPO title:                   OpenGFX r1013M
Installation directory:       /Users/me/Documents/OpenTTD/baseset/opengfx
Documentation directory:      /Users/me/Documents/OpenTTD/baseset/opengfx
Repository revision:          r1013
Current tag:                  
Current branch string:        
Current version string:       r1013M
Build targets:                opengfx.obg ogfx1_base.grf ogfxc_arctic.grf ogfxh_tropical.grf ogfxi_logos.grf ogfxt_toyland.grf ogfxe_extra.grf
Doc files:                    docs/readme.txt docs/license.txt docs/changelog.txt
Bundle filenames       tar:   opengfx.tar
                       zip:   opengfx-r1013M.zip
                       bzip:  opengfx.tar.bz2
Dirs (build/src/base):        opengfx / opengfx-r1013M-source / opengfx-
Dependency check type:        
Excluded from source bundle:  ^.devzone|^.hg
Repository dirs (= VPATH):    . docs extra/aoHTMLoutput extra/ttd-box-editor extra/ttd-box-editor/sprite-source lang scripts sprites sprites/arctic sprites/base sprites/extra sprites/logos sprites/png/AfricanManagerFaces sprites/png/aircraft sprites/png/extra sprites/png/gui sprites/png/houses sprites/png/industries sprites/png/industries/food_factory sprites/png/industries/goldmine sprites/png/industries/oilwell sprites/png/industries/sugarmine sprites/png/industries/toyfactory sprites/png/infrastructure sprites/png/infrastructure/rail sprites/png/infrastructure/signals sprites/png/landscape sprites/png/miscellaneous sprites/png/roadvehicles sprites/png/ships sprites/png/stations sprites/png/terrain sprites/png/terrain/waterfeatures sprites/png/trains sprites/png/trees sprites/png/trees/arctic sprites/png/trees/temperate sprites/png/trees/toyland sprites/source sprites/source/SugarMine sprites/source/gui sprites/source/houses sprites/source/industries sprites/source/infrastructure sprites/source/landscape sprites/source/miscellaneous sprites/source/stations sprites/source/templates sprites/source/terrain sprites/source/trains sprites/templates sprites/toyland sprites/tropical
nml:                          nmlc -c -p DOS
Language files:               lang/english.lng

Any ideas what could be missing? Thanks

[Alberth]

This all seems to be statistics, internal reasoning, and property dumps.
If you run plain 'make' what is the output (in particular, the error message)?

What revision exactly are you trying to build?

[planetmaker]

I can't exactly reproduce that behaviour so far nor do I see what's failing for you. I'll try later today on OSX as well, though I didn't exactly change OpenGFX' build system since I switched my main dev platform from OSX to linux.

Do you build from the mercurial checkout or did you aquire the tar ball of the sources? What are the modifications you applied to the sources?
EDIT: Also the (complete) output of make install _V= might be interesting

[inkieminstrel]

Thanks for looking at it. I've had trouble getting any useful output. Here's the complete output of make install _V=:

Code: Select all

~/proj/opengfx $ make install _V=
[ -f .version ] && [ "`cat .version`" = "r1013" ] || echo r1013 > .version
[LANG] custom_tags.txt
echo "VERSION  :r1013" > custom_tags.txt
echo "TITLE    :OpenGFX r1013" >> custom_tags.txt
echo "FILENAME :opengfx.obg ogfx1_base.grf ogfxc_arctic.grf ogfxh_tropical.grf ogfxi_logos.grf ogfxt_toyland.grf ogfxe_extra.grf" >> custom_tags.txt
[CPP] ogfxe_extra.nml
cc -D REPO_REVISION=1013 -nostdinc -C -E - < sprites/ogfxe_extra.pnml > ogfxe_extra.nml
[DEP] ogfxe_extra.gfx.dep
nmlc -M --MF ogfxe_extra.gfx.dep ogfxe_extra.nml
[CPP] ogfxt_toyland.nml
cc -D REPO_REVISION=1013 -nostdinc -C -E - < sprites/ogfxt_toyland.pnml > ogfxt_toyland.nml
[DEP] ogfxt_toyland.gfx.dep
nmlc -M --MF ogfxt_toyland.gfx.dep ogfxt_toyland.nml
[CPP] ogfxi_logos.nml
cc -D REPO_REVISION=1013 -nostdinc -C -E - < sprites/ogfxi_logos.pnml > ogfxi_logos.nml
[DEP] ogfxi_logos.gfx.dep
nmlc -M --MF ogfxi_logos.gfx.dep ogfxi_logos.nml
[CPP] ogfxh_tropical.nml
cc -D REPO_REVISION=1013 -nostdinc -C -E - < sprites/ogfxh_tropical.pnml > ogfxh_tropical.nml
[DEP] ogfxh_tropical.gfx.dep
nmlc -M --MF ogfxh_tropical.gfx.dep ogfxh_tropical.nml
[CPP] ogfxc_arctic.nml
cc -D REPO_REVISION=1013 -nostdinc -C -E - < sprites/ogfxc_arctic.pnml > ogfxc_arctic.nml
[DEP] ogfxc_arctic.gfx.dep
nmlc -M --MF ogfxc_arctic.gfx.dep ogfxc_arctic.nml
[CPP] ogfx1_base.nml
cc -D REPO_REVISION=1013 -nostdinc -C -E - < sprites/ogfx1_base.pnml > ogfx1_base.nml
[DEP] ogfx1_base.gfx.dep
nmlc -M --MF ogfx1_base.gfx.dep ogfx1_base.nml
[DEP] ogfxe_extra.src.dep
cc -C -M -MF ogfxe_extra.src.dep -E -MT ogfxe_extra.nml - < sprites/ogfxe_extra.pnml
[DEP] ogfxt_toyland.src.dep
cc -C -M -MF ogfxt_toyland.src.dep -E -MT ogfxt_toyland.nml - < sprites/ogfxt_toyland.pnml
[DEP] ogfxi_logos.src.dep
cc -C -M -MF ogfxi_logos.src.dep -E -MT ogfxi_logos.nml - < sprites/ogfxi_logos.pnml
[DEP] ogfxh_tropical.src.dep
cc -C -M -MF ogfxh_tropical.src.dep -E -MT ogfxh_tropical.nml - < sprites/ogfxh_tropical.pnml
[DEP] ogfxc_arctic.src.dep
cc -C -M -MF ogfxc_arctic.src.dep -E -MT ogfxc_arctic.nml - < sprites/ogfxc_arctic.pnml
[DEP] ogfx1_base.src.dep
cc -C -M -MF ogfx1_base.src.dep -E -MT ogfx1_base.nml - < sprites/ogfx1_base.pnml
[DEP] Makefile.dep
echo "" > Makefile.dep
for j in sprites/png/terrain/waterfeatures/waterfeatures.xcf2png sprites/png/infrastructure/locks.xcf2png sprites/png/terrain/terrain.xcf2png sprites/png/trees/trees.xcf2png sprites/png/industries/coalmine.xcf2png sprites/png/industries/goldmine/goldmine.xcf2png sprites/png/industries/oilwell/oilwell.xcf2png; do for i in `cat $j | grep "\([pP][cCnN][xXgG]\)" | cut -d\  -f1 | sed "s/\.\([pP][cCnN][xXgG]\)/.scm/"`; do echo "$i: $j" >> Makefile.dep; done; done
cat sprites/png/terrain/waterfeatures/waterfeatures.xcf2png sprites/png/infrastructure/locks.xcf2png sprites/png/terrain/terrain.xcf2png sprites/png/trees/trees.xcf2png sprites/png/industries/coalmine.xcf2png sprites/png/industries/goldmine/goldmine.xcf2png sprites/png/industries/oilwell/oilwell.xcf2png | grep "\([pP][cCnN][xXgG]\)" | sed "s/[ ] */ /g" | cut -d\  -f1-2 | sed "s/ /: /g" >> Makefile.dep
for i in `cat sprites/png/terrain/waterfeatures/waterfeatures.xcf2png sprites/png/infrastructure/locks.xcf2png sprites/png/terrain/terrain.xcf2png sprites/png/trees/trees.xcf2png sprites/png/industries/coalmine.xcf2png sprites/png/industries/goldmine/goldmine.xcf2png sprites/png/industries/oilwell/oilwell.xcf2png | grep "\([pP][cCnN][xXgG]\)" | cut -d\  -f1`; do echo "gfx: $i" >> Makefile.dep; done
[LANG] ogfx1_base.tags.txt
echo "TITLE    :OpenGFX" > ogfx1_base.tags.txt
rm ogfx1_base.tags.txt

Here is a gist of running "make -d install _V=" https://gist.github.com/anonymous/c52c23175a31a573cc2f I didn't want to post the whole thing here because it's huge. This line seemed particularly interesting: "Giving up on target file `ogfx1_base.grf'." That file never gets built.

My hg tip points to 1013:077bef2d0c2c. I built from hg checkout. I haven't made any changes from the source. In fact, I just tried it again from a clean clone with the same results.

[planetmaker]

OpenGFX 0.5.2-RC1

In order to allow everyone to download the needed base graphics from online content I snapshot the current development build as RC for the upcoming OpenGFX 0.5.2.

Changes:

- Add: 2x GUI zoom sprites
- Add: the all black ground sprites introduced in OpenTTD r26869
- Add: Translations for Africans, Italian, Latin and Lithuanian
- Update: Translation for English (US)

[planetmaker]

OpenGFX 0.5.2 released

Final release of this version which comes with a few fixes for the some GUI sprites. Thanks goes mainly towards frosch.
Maintainers might appreciate some improvement in the Makefile and dependency generation

Code: Select all

OpenGFX 0.5.2 (12 Apr 2015)
---------------------------
- Add: [Makefile] target 'bananas' (closes #6877, #6848)
- Fix: [Makefile] Add dependency generation for pnml->nml
- Fix: [Makefile] dependencies, esp. wrt. HG revision numbers getting compiled into files
- Fix: Alignment of GUI icons that have different sizes in 1x and 2x zoom
- Fix: 2x GUI sprite for purchase land was attached to the viewport sprite instead of to the GUI sprite (commit:ba02a90fab52) (issue FS#6267)
- Fix: Do not crop the default-window-size icon (issue FS#6258)

OpenTTD's installer was also updated to distribute now this version with 1.5.0 so that there won't be reported anymore any missing sprites for a fresh install of OpenTTD.

As usual get it ingame via content download.
If that's no option use DevZone's bundles server: http://bundles.openttdcoop.org/opengfx/releases/LATEST/

[Ivan Dives]

Build from source fails for me with:

[NML] ogfxe_extra.grf
nmlc ERROR: "sprites/extra/extra-openttd-recolour.pnml", line 2: OTTD_RECOLOUR is not a valid sprite replacement type
Included from: "ogfxe_extra.pnml", line 25
Makefile:330: recipe for target 'ogfxe_extra.grf' failed

I attached build logs for 0.5.2 and nightly-v5586. Please support.

[Alberth]

OTTD_RECOLOUR is a feature of NML 0.4.0, please try upgrading your nml version.
See also https://hg.openttdcoop.org/nml/files/fb ... og.txt#L17

[Ivan Dives]

OTTD_RECOLOUR is a feature of NML 0.4.0, please try upgrading your nml version.
See also https://hg.openttdcoop.org/nml/files/fb ... og.txt#L17

Thank you. Updating nml helped.

[Ivan Dives]

Clean build of openttd-opengfx-0.5.2 fails once in approximately 10 times if compiled with -j5 .
I attached the build log. Support please.

[planetmaker]

It seems to be some kind of race condtion.. I observed a similar(?) issue when still using gimp 2.6 which didn't handle well parallel execution of different gimp instances.

[frosch]

Looks like gimp fails, so it's likely this issue: https://dev.openttdcoop.org/issues/3439
Apparently there is some shared data folder for gimp, though i never noticed one on my system.
There are two patches in the tracker:

• Disable -j option (boring )
• Some magic with the data dir

Maybe it is also possible to remove the option "-n" from gimp, so it does not run in multiple processes. But no idea

[Froix]

I'm back again and continuing from where I stopped, here's my proposed maglev tracks for OpenGFX. I'll upload the sprites if I get the greenlight otherwise I'll make a newgrf out of it.

openmag1.png (300.9 KiB) Viewed 8345 times

openmag2.png (217.27 KiB) Viewed 8345 times

P.S. It's okay to say "No! Those are horrible!"

[Pingaware]

I think they're better than the current ones. If other people agree, that should be all that's needed for them to be included. By which I mean, consensus all that's needed. Not my opinion. Which alone is practically worthless.

[luxtram]

I'm back again and continuing from where I stopped, here's my proposed maglev tracks for OpenGFX. I'll upload the sprites if I get the greenlight otherwise I'll make a newgrf out of it.

openmag1.png

openmag2.png

P.S. It's okay to say "No! Those are horrible!"

Looks nice. Still here are, hopefully constructive, comments:

1) I think that horizontal line is a bit too thin.
2) also as there is not much texture on the empty parts then it feels a bit flat (or boring, perhaps cut them out, or add more texture?).

Personally I prefer multiple options, so newgrf is an good idea.