Patch: Fix for Bug #669

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Locked
mindphlux
Engineer
Engineer
Posts: 2
Joined: 28 Mar 2007 11:24
Location: Lemgo, Germany
Contact:

Patch: Fix for Bug #669

Post by mindphlux »

Hi gang,

first of all, I'm new here. That didn't really keep me away from messing with the OTTD code a bit, just to get me started. I hope I did nothing wrong with this post, if I did, enlighten me :)

Attached to this post is a patch to solve

http://bugs.openttd.org/task/669

where Celestar reports that it's possible to build airports, ship ports and depots as well as road vehicle depots even at a time where none of these vehicle types are available (e.g. 1900).

My patch fixes this issue. An error message (see screenshot) is displayed when the player tries to build stations or depots without having the required vehicle type available. An exception is the bus and lorry station - I prevent building the depot, but not the stations since I couldn't find out how to distinguish these vehicle types.

Included in the patch are the localized error messages for english and german language.

I hope this is useful in some way or another - the bug tracker states this is scheduled for 0.51, but it's not yet implemented by someone else, so I decided I could fix that for starters.

Regards,

mindphlux
Attachments
Error message - could use formatting?
Error message - could use formatting?
Unnamed, 6th Jan 1900.png (86.73 KiB) Viewed 1333 times
patch-669.patch
Patch against rev 9518
(5.82 KiB) Downloaded 114 times
TrueBrain
OpenTTD Developer
OpenTTD Developer
Posts: 1370
Joined: 31 May 2004 09:21

Post by TrueBrain »

As you might have guessed yourself, it is most wise to post this patch, and your comments, in the bug report on the page you quote yourself. You can freely create an account there and add your patch, so it is for everyone to read. This forum is _not_ the place for this, as this way there isn't a single place to track all patches/comments/suggestions of a bug report. I hope you understand that.

So I kindly ask you to attach your patch to the bug-report on http://bugs.openttd.org/, together with your comments, and I do hope to see more of such patches in the future :)
The only thing necessary for the triumph of evil is for good men to do nothing.
Locked

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 3 guests