Municipal(Town Owned) Airports

DaleStan · Post by **DaleStan** » 23 Oct 2005 03:24

oVRoM wrote:So a quick & very dirty patch would be simple
Code: Select all
assert(i < lengthof(_players) || 15);

If you're going to do that, may as well change it to
"((void)0);". What you wrote simplifies to "assert(foo || true);", which simplifies to "assert(true);", since foo has no side-effects.

Hint: ((i < lengthof(_players)) || 15)

JimboTG · Post by **JimboTG** » 23 Oct 2005 04:53

very quick and dirty indeed, i think i know how to fix that without altering an assert, but like i say i wont be able to do anything until tonight. i will however have it fixed for the next update(probably around midweek) but until then use that quick fix.

thanks for the valuable feedback

ThunderAI · Post by **ThunderAI** » 23 Oct 2005 05:21

Nice,

May I make a suggestion. I would suggest that rather than 20% of total revenue for a trip from or to a Municipal Airport, a company is changed based upon a 'landing fee' as adjusted by the Municipality. Even when no revenue is generated you are charged for landing.

I dont know any airports where an airline is charged on revenue.

webfreakz.nl · Post by **webfreakz.nl** » 23 Oct 2005 09:04

I did a clean checkout of SVN and applied your patch but it has some errors.-
(will post the line/file later)

What I discovered was when I load a scenario it is slower than
when an original OpenTTD loads the same scenario?
And the TAB button doesn't work anymore?

edit:

the error file was settings_gui.c on line 703 but with TortoiseMerge it shows
also errors on line 691-693.

JimboTG · Post by **JimboTG** » 23 Oct 2005 10:44

How big was the map you were playing? What was the difficulty setting as regards towns? High/low/normal? was there any particular point that the game slowed down? did you get errors if you updated the source or when you just applied the diff straight?

The patch does need some optimisation, these are things Im working on right now. Also the last revision I wrote against was 3070 so some new bugs might have been introduced with other updates

webfreakz.nl · Post by **webfreakz.nl** » 23 Oct 2005 16:06

I just did a clean checkout and applied the patch. My map is 512x512. The game opens immediately with an original OpenTTD .exe / a self compiled one of the SVN source, but with your patch included and a clean SVN source is has a delay of about ± 1-2 seconds.

Smoky555 · Post by **Smoky555** » 24 Oct 2005 06:13

JimboTG, could you publish only m_airport patch (without subsidiaries) ?

oVRoM · Post by **oVRoM** » 24 Oct 2005 10:54

Smoky555 wrote:JimboTG, could you publish only m_airport patch (without subsidiaries) ?

Check the first post, it's there.

SirkoZ · Post by **SirkoZ** » 27 Oct 2005 21:53

BUG: As experienced in the latest Integrated_nightly (r3090), the client and even server crashes when one tries to query ("?") the municipal airport. Although I don't know how the exe with this patch alone would perform but I think the same...

EDIT: I have just checked out the airport code for a possible different municipal airport.....let's put it this way - it'll require some more checking.

Smoky555 · Post by **Smoky555** » 01 Nov 2005 05:08

Jimbo, i can't apply your patch to the latest SVN (3113).
It is an many errors in vehicle.c
Could you make new patch for the latest SVN?

DaleStan · Post by **DaleStan** » 01 Nov 2005 05:33

While we're in the business, why the whitespace changes in settings_gui.c?

JimboTG · Post by **JimboTG** » 01 Nov 2005 17:28

sorry guys ive hadsome stuff to deal with lately so i havnt had much time to play with this, the situation looks to remain that way for quite a while yet. the whitespace changes i made were just to help me to understand the way the gui works, as for the other bugs they are all caused by the fundamental problem that OWNER_TOWN is not actually classed as a player, so the game assumes something fishy is going on, I dont know how Im gonna fix this without major headaches. I will try to grab some time on this when I can, but no promises

leenx · Post by **leenx** » 11 Nov 2005 04:08

This is pretty amazing!

I love the OPENTTD community!
I started a discussion about this topic about 3 months ago... there some ideas there, please take a look... I dreaming in testing this patch in a nigthly...

http://www.tt-forums.net/viewtopic.php?t=20093

^Cartman^ · Post by **^Cartman^** » 11 Nov 2005 09:25

You should make cities not building airports when there is already an airport not so far away... only a little suggestion, because cities in my multiplayer game makes airports close to our airports.

Post by **WWTBAM** » 11 Nov 2005 10:24

or offer you a free landing for a certain amouint of time and close all nearby airports of that city and ofcourse change the ais routes or even better if the ais is in adecent spot convert it.

onewayticket · Post by **onewayticket** » 12 Jan 2006 15:27

is this patch still being developed?

JimboTG · Post by **JimboTG** » 15 Jan 2006 05:20

It is with a heavy heart that I must inform you all that I can no longer spend any time on this patch for a couple of reasons.

1.) Im trying to emmigrate to Canada which cost lots of money, so im putting in as many hours in the taxi as possible.

2.) My level of C programming is poor/mediocre at the best of times (ask anyone who's analyzed the patch itself) so its better off in the hands of a more competant coder.

I do however encourage anyone else who wants to play with it to do so. I will happily answer any questions about the source code as long as I can remember the answer myself. As far as I know city airports has been requested A LOT so there must be someone out there with the skill and motivation to see it through. Hopefully Ive made a good first step.

Transport Tycoon Forums

Municipal(Town Owned) Airports

Re: Municipal(Town Owned) Airports

Ideas...

Who is online