Chill's patchpack v14_7

[ChillCore]

Incidentally... What's the "flat black tiles" grf for? I hadn't realised I needed it, and it's not stopping me playing not having it...

Its purpose is drawing the tiles outside the map correctly. In clean trunk outside the map is void space with the moreheighlevels patch they are drawn black. (but the tiles are still not really there.)
If you want to see how the terrain is drawn outside the map, have a looksie at void_cmd.cpp -> static void DrawTile_Void(TileInfo *ti) . Replace the first line with the last and see the outside_map tiles in a different style of tiles.

I have got it... I just don't remember having it. That said, it made me curious because when I was using OpenGFX with the latest 9 series, the outside edge had interesting psychedelic issues, which went away with both the original graphics, and when I upgraded to 10.

The glitches are because of the way I integrated the flat_black_tiles.grf in the patch. I added them to the very end of OpenGFX so every time that there are new sprites introduced in OpenGFX the glitches will come back untill I change the code again. Copypaste inserts the sprites somewhere else and does not need adjusting when sprites are added.
Also as the original sprites never change they will always work correctly as OpenTTD handles that internally in some (mysterious to me) way.
To fix this I should introduce the sprites after (or before) the copypaste sprites. Me being lazy ...

ps:
If you think that was an interesting psychedelic issue ... check the picture on the first page.
I can put that back if you want. /* evil moehaahaha here */ (<- In caps but I don't want to shout)

In my opinion "untimetabled" is not the same as "stay for 0 days" - but in vanilla, they are one and the same. Effectively (as far as I can see - this is conjecture), cargodist and auto-separation create timetables (especially for passenger trains) that have "stay for 0 days" where "0 days" would normally be 1 or 2 days. That said, I have some trains where all stops are 0 days, that do show on the departure boards, and some trains where all stops are not 0 days, or one stop is 0 days, that do not show on the departure boards. I can't see any rhyme nor reason to it, other than (seemingly), once it's broken, any further stations will also be broken.

To my knowledge CargoDist does not set travel/waiting times ... auto seperation and automated timetables does.
Also see my reply to Dwight_K._Schrute as I would be repeating myself if I answered twice.

I don't play with automated timetables but departure boards are broken sometimes... and sometime it works... there is no pattern...

I did some quick testing yesterday before going to bed.

I loaded my old vanilla savegame and departure times were there.
Then I opened the advanced settings and enabled "automate timetables", after that I clicked the "automate" button and the departure times disappeared.
To continue I disabled the "automate timetables" setting again and clicked the "autofill" button (which seems to be replaced with automate on switching the advanced setting) and the departures times came back.
But when I tried just now, it worked also with the the automate timetables on, my waiting times were not zero.
Some very inconsistent behaviour indeed.

I should also mention that In my test folder I had already changed some code in the auto-separation patch to not have 0 waiting times. I have to test the same again with my not yet modified release build and a new savegame to see if I can reproduce it.

At least I know where to search now and I'll see if I can avoid having waiting/loading times set to zero, travel times can never be zero by default I think, or try it the other way round, not skipping the departures times if there are zero waiting/loading times.

[Wasila]

I don't know if this is to do with trunk, but I decided not to risk the wrath of the devs so I'll post it in here .

I'm trying to expand my stations, and of course to do that I have to demolish roads. It worked before, but now I'm getting 'Paris Region local authority refuse to allow this' as I try to bulldoze their roads. I have an Outstanding rating and this has happened in numerous cities. Help would be appreciated!

Wasila

[ChillCore]

I can not reproduce this Wasila. I have tried in the unmodified v10 I posted before.
Have you bumped to trunk? Just to know if I should try this in my bumped version.
Savegame please.

[Scautura]

In my opinion "untimetabled" is not the same as "stay for 0 days" - but in vanilla, they are one and the same. Effectively (as far as I can see - this is conjecture), cargodist and auto-separation create timetables (especially for passenger trains) that have "stay for 0 days" where "0 days" would normally be 1 or 2 days. That said, I have some trains where all stops are 0 days, that do show on the departure boards, and some trains where all stops are not 0 days, or one stop is 0 days, that do not show on the departure boards. I can't see any rhyme nor reason to it, other than (seemingly), once it's broken, any further stations will also be broken.

To my knowledge CargoDist does not set travel/waiting times ... auto seperation and automated timetables does.
Also see my reply to Dwight_K._Schrute as I would be repeating myself if I answered twice.

That should read "daylength" where it reads "cargodist"... Doh! Brainfart...

[Wasila]

This is the version of the patch which was applied to r20768

http://rapidshare.com/files/419980257/G ... 8.sav.html

[Dwight_K._Schrute]

Already thought about including this patch???:

http://www.tt-forums.net/viewtopic.php? ... lit=zoning

Seems to be really useful

[id10terror]

is it just me, or is anyone else having trouble with thier ai's being able to access library functions (using binary from http://www.tt-forums.net/viewtopic.php?p=903766#p903766)

[ChillCore]

This is the version of the patch which was applied to r20768

http://rapidshare.com/files/419980257/G ... 8.sav.html

I had a looksie and all I can say is that you should try harder. see attachment.
I first paid for road repairs, then I built some roads on the west, I then made a local bus service with ten busses and bribed the town autorities.
I still could not demolish the roads until the road repairs were done and the local bus service was operational. The busses were blocked by the road repairs before.

Already thought about including this patch???:

http://www.tt-forums.net/viewtopic.php? ... lit=zoning

Seems to be really useful

I have been thinking about including many patches but I have been too busy keeping up with trunk, fixing conflicts and checking for bugs.
It is included in my to add list.

is it just me, or is anyone else having trouble with thier ai's being able to access library functions (using binary from http://www.tt-forums.net/viewtopic.php?p=903766#p903766)

I think it is just you ... lol
No seriously, Wasila's game has AI's and they seem to be doing fine.
Also in my test game that I am playing myself I have my own AI running without problems. A bit slower then normal because of increased height but it is doing its thing.

I'll check in a bit while I test some more things.
I did notice that "AILibCommon version 1" fails to install itself properly (*)maybe that is the problem? I could be wrong as I have not checked what library AIAI uses

(*) noticed in the windows nightly when updating my download content. I have not not yet reported as I did not yet check if the same happens with my linux build(s).



Also I did some more testing yesterday with the departures patch (patchpack v10 I posted before).
It seemed to work even with waiting times of 0, automated timetabling and trams. But when I expanded the tram station with a rail station, my trains were not added to the departure list.
Also when changing the daylenght it worked until the daylenght setting was too high and the departures list was cleared. The tramline was pretty short and it cleared at daylenght setting 38 or something.
Needs more testing ... Something is wrong but I have no clue what it is yet apart that there is a coflict somewhere.

[Wasila]

I first paid for road repairs, then I built some roads on the west, I then made a local bus service with ten busses and bribed the town autorities.

Strange... I've set-up some road reconstruction so when that's over I'll start a tram route (I suppose it's in need of one anyway). But even so, with an Outstanding rating I should be able to demolish roads?

EDIT: This only happens with roads - I can demolish buildings fine.

[Dwight_K._Schrute]

I first paid for road repairs, then I built some roads on the west, I then made a local bus service with ten busses and bribed the town autorities.

Strange... I've set-up some road reconstruction so when that's over I'll start a tram route (I suppose it's in need of one anyway). But even so, with an Outstanding rating I should be able to demolish roads?

EDIT: This only happens with roads - I can demolish buildings fine.

I don't think this is a patch thing... happend to me a bunch of times in clean 1.0.2... since then I've been playing with magic bulldozer...

[hthhs]

departureboards should be working now. The patch has been updated in its thread.

[ChillCore]

departureboards should be working now. The patch has been updated in its thread.

Strange thing is that it is/was working ... my last test had busses, trains and airplanes all coming together in one station and it worked, as in all showed up in the departures list.
I guess it will work better now.
The only thing that does not seem to work correctly is with long routes and (heavely) increased daylenght.
I will have to try and fix that. Maybe remove the 240 days in the future limit and or play around with the dayticks in your patch.

I will check it out in a bit and try(*) to post an update tomorow. Even I am looking forward to it, fixes in Bigger maps, cargodist, departures-clock and the moreheightlevels patches ... not to forget trunk.


No suggestions for a new shortcut in the measurements tools?
Nothing else is broken or needs retuning?


(*) I have Ubuntu 10.04 installed now and am in the middle of moving things, also I still need to install a few things. My compiling enviroment for OpenTTD was the first thing I made sure was working but as I do other stuff too with my puter ...

ps: Sorry for the messed up quote, seems like I must still correctly configure my keyboard also. I noticed just now.

Edit: fixed quote, corrected info: Bigger maps is not copypaste.

[hthhs]

Strange thing is that it is/was working ... my last test had busses, trains and airplanes all coming together in one station and it worked, as in all showed up in the departures list.

Having actually looked at the bodies of the functions I was calling, I now have no idea how versions of departureboards for r20801 ever worked

The only thing that does not seem to work correctly is with long routes and (heavely) increased daylenght.
I will have to try and fix that. Maybe remove the 240 days in the future limit and or play around with the dayticks in your patch.

That sounds like an excellent plan. The 240 day was quite arbitrary anyway - (the equivalent of) 4 hours seemed a reasonable limit at the time.

I plan on looking into making minutes independent of original days this weekend - but doing so might break at least Improved Timetable Management.

If I change departureboards again I'd like to put all the files it adds in a subdirectory within src - would you object to this?

(*) I have Ubuntu 10.04 installed now and am in the middle of moving things, also I still need to install a few things. My compiling enviroment for OpenTTD was the first thing I made sure was working but as I do other stuff too with my puter ...

Ooh, shiny! I'm loath to upgrade from 9.10 because I finally seem to have got it working just right...

[ChillCore]

Having actually looked at the bodies of the functions I was calling, I now have no idea how versions of departureboards for r20801 ever worked

The force works in mysterious ways?

That sounds like an excellent plan. The 240 day was quite arbitrary anyway - (the equivalent of) 4 hours seemed a reasonable limit at the time.

Maybe multiplying the 240 by daylenght will work also. I have not yet tested and all roads lead to Rome as they say ...

If I change departureboards again I'd like to put all the files it adds in a subdirectory within src - would you object to this?

I am not in the position to object to anything. If you think that you need to make a change then make it as you see fit.
You should not consider a patchpack if you want your patch to end up in trunk.
The changes I have to make would be my "problem". (<- Not a big one if you only move the files).

May I ask why you would want to do that? Trunk keeps almost all the files in the src folder unless they adress something very specific. eg. pathfinder, tables, saveloadcode, etc.

Ooh, shiny! I'm loath to upgrade from 9.10 because I finally seem to have got it working just right...

10.04 is an LTS version so I am going to stick to it for a while I think.
I still have my 9.04 though as I started on a new HDD. Once I have everything working as I want and moved my files, I am going to wipe the old disk and use it as storage so that with the next upgrade I do not have to move everything again.

ps: departures.cpp could use a litlle coding style in the multiline comments.

[Melfice]

It seems Departure boards is not working properly for me.
I set up a train-route, say A-B-C-B-A.
This shows up on the Departure boards properly.
I then, later, add a route A-D-E-D-A, with D and E lying on the other side of A (completely picture E-D-A-B-C)
That second route will never show up on the Departure boards.

More astonishing:
I set up three bus-routes: A-B, B-C and A-B-C-B-A.
All of these show up properly.
Later I create a train-route: D-E, which is unconnected in any way to the bus-routes. D-E does NOT show up, at all.

I don't have a save, unfortunately, but I could create one, if necessary.

So... what? Are trains bugged in terms of Departure boards functionality? Am I doing something wrong?

EDIT: After trying twice more, it worked properly once. The second time it was bollocks again.

[ChillCore]

It seems Departure boards is not working properly for me.

As hthhs mentioned there was a little bugsie in the departures patch ...
The attached patch should work better then the one before.
My savegame that did not show departures times at all has all of them showing up correctly now.

@hthhs:
I have only included your latest bugfix, I did not have to change something else. (In comparison to the previous version of the patchpack.)

updated:
--------
- Bigger maps patch to r20829 (Bugfix when clicking very large maps with debugging tools on.)
- Cargodist to r20839 (Smallmap positioning bugfix.)
- More height levels to v31_2 (Land is already leveled bugfix, new terrafoming code.)
- Departures0.83-clock0.3 (Departures board did not always work correctly.)

Yes, you can still continue your savegames from 9_9_4 and later.

Known bug:
PublicServerGame_193_Final.sav will crash your game.

Code: Select all

Assertion failed at line 482 of .../src/object_cmd.cpp: level < 6

I did not yet have much time to search for the error, but this version is definately an impovement over the previous.

Also attached, for SirXavius, a (short) recap of my changes since v1. (Needs some more adjusting.)

[Melfice]

Ah... my bad!
You guys should speak proper English then! How do you expect us non-techies to know what you're saying if you go around speaking techno-babble.

And now to twiddle my thumbs until somebody posts a binary. XD
No rush.

EDIT: Well, I tried. But msys doesn't even find zlib, so it won't compile.
So, uh... back to twiddling thumbs! =D

[ChillCore]

EDIT: Well, I tried. But msys doesn't even find zlib, so it won't compile.
So, uh... back to twiddling thumbs! =D

I wish I could help you but it has been ages that I have setup the compiling enviroment for MinGW-MSYS on Windows.
Maybe you did something wrong when telling MSYS where to find zlib? I struggled too the first time setting things up. If I remember correctly I had to adjust the directories in my commands to where the files actually were before it worked.

Try, try, try again ... at some point it will work and a new world will open to you.

ps: In between trying you can still play the previous version and then when somebody has posted a new binary you can simply upgrade and continue your game.

[Melfice]

EDIT: Well, I tried. But msys doesn't even find zlib, so it won't compile.
So, uh... back to twiddling thumbs! =D

I wish I could help you but it has been ages that I have setup the compiling enviroment for MinGW-MSYS on Windows.
Maybe you did something wrong when telling MSYS where to find zlib? I struggled too the first time setting things up. If I remember correctly I had to adjust the directories in my commands to where the files actually were before it worked.

Try, try, try again ... at some point it will work and a new world will open to you.

ps: In between trying you can still play the previous version and then when somebody has posted a new binary you can simply upgrade and continue your game.

Naw, I did everything according to the book, but when it comes to the point where you start compiling (after I've applied the patch with Tortoise SVN), it just says that it can't find zlib or that it wasn't activated. (or something along those lines, anyway)
I've tried several things, but I just can't work it out. No biggie, though. I can wait.

And yeah. I was just going to play, regardless.

[NekoMaster]

I can't get the patch to compile in Xubuntu. I have all the required libraries that the openttd wiki says i need, and Im using the same commands I always do, but when I try to compile it says theres no make file...

Code: Select all

matthew@LPT1-Xubuntu:~$ cd openttd
matthew@LPT1-Xubuntu:~/openttd$ patch -p0 < cpp.diffpatching file src/viewport_func.h
patching file src/fios.cpp
patching file src/settings.cpp
patching file src/newgrf_debug_gui.cpp
patching file src/toolbar_gui.cpp
patching file src/functions.h
patching file src/date_type.h
patching file src/viewport_type.h
patching file src/vehicle_type.h
patching file src/moving_average.cpp
patching file src/tgp.cpp
patching file src/lang/swedish.txt
patching file src/lang/german.txt
patching file src/lang/english.txt
patching file src/lang/dutch.txt
patching file src/settings_gui.cpp
patching file src/fios_gui.cpp
patching file src/order_base.h
patching file src/heightmap.h
patching file src/command_queue.cpp
patching file src/newgrf_object.h
patching file src/terraform_cmd.cpp
patching file src/genworld_gui.cpp
patching file src/town.h
patching file src/misc_gui.cpp
patching file src/tgp.h
patching file src/disaster_cmd.cpp
patching file src/rail_cmd.cpp
patching file src/smallmap_gui.cpp
patching file src/date.cpp
patching file src/station.cpp
patching file src/command_queue.h
patching file src/newgrf.cpp
patching file src/timetable_cmd.cpp
patching file src/station_gui.h
patching file src/station_cmd.cpp
patching file src/table/sprites.h
patching file src/table/settings.h
patching file src/town_cmd.cpp
patching file src/copy_paste_gui.cpp
patching file src/copy_paste.h
patching file src/smallmap_gui.h
patching file src/ship_cmd.cpp
patching file src/tunnelbridge.h
patching file src/moving_average.h
patching file src/order_cmd.cpp
patching file src/window_type.h
patching file src/programmable_signals.cpp
patching file src/company_cmd.cpp
patching file src/misc.cpp
patching file src/vehicle_cmd.cpp
patching file src/fios.h
patching file src/programmable_signals_gui.cpp
patching file src/map_func.h
patching file src/train_cmd.cpp
patching file src/aircraft.h
patching file src/rail_gui.h
patching file src/terraform_gui.cpp
patching file src/core/math_func.cpp
patching file src/core/math_func.hpp
patching file src/core/multimap.hpp
patching file src/road_cmd.cpp
patching file src/command.cpp
patching file src/tree_cmd.cpp
patching file src/departures_gui.cpp
patching file src/map_type.h
patching file src/rail_gui.cpp
patching file src/ground_vehicle.hpp
patching file src/tunnelbridge_cmd.cpp
patching file src/company_base.h
patching file src/settings_type.h
patching file src/ai/api/ai_tile.hpp
patching file src/clear_cmd.cpp
patching file src/timetable_gui.cpp
patching file src/depot_gui.cpp
patching file src/date_gui.cpp
patching file src/command_type.h
patching file src/station_gui.cpp
patching file src/industry_type.h
patching file src/departures_gui.h
patching file src/strings.cpp
patching file src/newgrf.h
patching file src/heightmap.cpp
patching file src/window.cpp
patching file src/depot_map.h
patching file src/map.cpp
patching file src/transparency.h
patching file src/cargopacket.h
patching file src/tile_type.h
patching file src/water_cmd.cpp
patching file src/economy_base.h
patching file src/economy.cpp
patching file src/company_gui.cpp
patching file src/cargopacket.cpp
patching file src/gui.h
patching file src/signal_func.h
patching file src/programmable_signals.h
patching file src/copy_paste.cpp
patching file src/network/network_server.cpp
patching file src/network/network_gui.cpp
patching file src/depot.cpp
patching file src/saveload/saveload.cpp
patching file src/saveload/saveload_internal.h
patching file src/saveload/oldloader_sl.cpp
patching file src/saveload/economy_sl.cpp
patching file src/saveload/linkgraph_sl.cpp
patching file src/saveload/signs_sl.cpp
patching file src/saveload/cargopacket_sl.cpp
patching file src/saveload/afterload.cpp
patching file src/saveload/saveload.h
patching file src/saveload/object_sl.cpp
patching file src/saveload/map_sl.cpp
patching file src/saveload/signal_sl.cpp
patching file src/saveload/vehicle_sl.cpp
patching file src/saveload/station_sl.cpp
patching file src/transparency_gui.cpp
patching file src/station_base.h
patching file src/openttd.h
patching file src/signal_type.h
patching file src/void_cmd.cpp
patching file src/economy_func.h
patching file src/landscape.cpp
patching file src/watch_gui.cpp
patching file src/roadveh_cmd.cpp
patching file src/pbs.cpp
patching file src/tile_map.cpp
patching file src/linkgraph/linkgraph.cpp
patching file src/linkgraph/demands.h
patching file src/linkgraph/flowmapper.h
patching file src/linkgraph/linkgraph.h
patching file src/linkgraph/mcf.cpp
patching file src/linkgraph/linkgraph_type.h
patching file src/linkgraph/mcf.h
patching file src/linkgraph/demands.cpp
patching file src/linkgraph/flowmapper.cpp
patching file src/landscape.h
patching file src/bridge.h
patching file src/station_func.h
patching file src/tunnel_map.cpp
patching file src/newgrf_engine.cpp
patching file src/signal.cpp
patching file src/vehicle.cpp
patching file src/viewport.cpp
patching file src/watch_gui.h
patching file src/company_manager_face.h
patching file src/newgrf_station.h
patching file src/tile_map.h
patching file src/tunnel_map.h
patching file src/elrail.cpp
patching file src/screenshot.cpp
patching file src/departures.cpp
patching file src/signs_base.h
patching file src/departures_func.h
patching file src/pathfinder/yapf/yapf_costrail.hpp
patching file src/pathfinder/npf/npf.cpp
patching file src/pathfinder/follow_track.hpp
patching file src/industry_cmd.cpp
patching file src/vehicle_base.h
patching file src/tunnelbridge_map.h
patching file src/departures_type.h
patching file src/autoreplace_cmd.cpp
patching file src/tilehighlight_type.h
patching file src/gfxinit.cpp
patching file src/openttd.cpp
patching file src/aircraft_cmd.cpp
patching file src/rail_map.h
patching file src/date_func.h
patching file docs/copy_paste_array.txt
patching file projects/openttd_vs80.vcproj
patching file projects/openttd_vs100.vcxproj
patching file projects/openttd_vs90.vcproj
patching file projects/openttd_vs100.vcxproj.filters
patching file source.list
matthew@LPT1-Xubuntu:~/openttd$ ./configure
checking awk... awk
detecting OS... UNIX
checking build system type... i486-linux-gnu
checking host system type... i486-linux-gnu
checking universal build... no
checking build cc... gcc
checking host cc... gcc
checking build c++... g++
checking host c++... g++
checking strip... disabled
checking builtin depend... yes
checking makedepend... disabled
detecting cpu-type... 32 bits
checking static... no
checking unicode... no
using debug level... no
using desync debug level... no
using link time optimization... no
checking OSX sysroot... not OSX, skipping
checking Allegro... not found
checking SDL... found
checking COCOA... not OSX, skipping
checking GDI video driver... not Windows, skipping
checking dedicated... not selected
checking network... found
checking ai... found
checking translator... no
checking assert... enabled
checking zlib... found
checking lzo2... found
checking libpng... found
checking libfreetype... found
checking libfontconfig... not found
checking libicu... not found
checking psp-config... not PSP, skipping
checking libtimidity... not found
checking direct-music... not Windows, skipping
checking sort... sort
checking endianess... AUTO
suppress language errors... no
checking stripping... skipped
checking distcc... no (only used when forced)
checking ccache... no (only used when forced)
checking OSX application bundle... not OSX, skipping
checking revision... svn detection
checking iconv... not OSX, skipping
personal home directory... .openttd
shared data directory... none
installation directory... /
icon theme directory... share/icons/hicolor
manual page directory... share/man/man6
menu item directory... share/applications
using CFLAGS... -O2 -fomit-frame-pointer  -Wall -Wno-multichar -Wsign-compare -Wundef -Wwrite-strings -Wpointer-arith -W -Wno-unused-parameter -Wformat=2 -Wredundant-decls -fno-strict-aliasing -Wcast-qual -fno-strict-overflow -rdynamic -DUNIX -DWITH_SDL -I/usr/include/SDL  -D_REENTRANT -DWITH_ZLIB -DWITH_LZO -I/home/matthew/openttd/src/3rdparty/squirrel/include -DENABLE_AI -DWITH_PNG  -I/usr/include/libpng12  -DWITH_FREETYPE -I/usr/include/freetype2  -DENABLE_NETWORK -DWITH_PERSONAL_DIR -DPERSONAL_DIR=\".openttd\" -DGLOBAL_DATA_DIR=\"/usr/local/share/games/openttd\"
using CXXFLAGS...  -std=gnu++0x
using LDFLAGS... -lstdc++ -lpthread -lc -L/usr/lib -lSDL -lz -llzo2 -L/usr/lib -lpng12  -lfreetype -lz   -rdynamic
Generating Makefile...
Generating menu item...
Generating lang/Makefile...
Generating grf/Makefile...
Generating objs/Makefile...
matthew@LPT1-Xubuntu:~/openttd$ ./make
bash: ./make: No such file or directory