Passengers/Mail with Specific Destinations

[kemkim]

I forgot to add: I will upload a patch soon. I just want to test it a bit more.

So, would you like to upload the exe soon? I'm eager to test it

[TolgaAbaci]

OK. The very first release of this new feature is ready. I am uploading the binary here to the forums, I hope this is OK since it's not too big, if not I'll remove it, and look for some other place. This binary should work with the data files from the latest nightly build.

Please do not forget that this is still in alpha stage and I need your help in identifying all the bugs and shortcomings.

You will find the switch to enable new behaviour in the patches menu, economy tab. It requires you to start a new game, it cannot be applied to existing games, sorry. When the switch is on, you will not be able to load games saved with the switch off, and vice versa.

Important things to keep in mind when testing:

- Look out for abnormal/unbalanced behaviour in game.
- Intentionally try to break the code by doing unexpected things, shouldn't be too difficult at this stage
- Check for unusually high CPU/memory usage.
- Check whether the save/load works properly.
- Do some tests with the switch turned off to see whether the original gameplay is left unchanged, to make sure that the patch will be included in future versions of OTTD.

Edit: english.lng added to .rar file.

-Tolga

[goalie]

could you add the lng file to the rar file too

because i get an invalid language pack error

[TolgaAbaci]

could you add the lng file to the rar file too

Sorry, I forgot about it, should be in there now.

[lucaspiller]

Could you also upload a patch for people who don't use Windows?

[TolgaAbaci]

Could you also upload a patch for people who don't use Windows?

Sorry, I am not able to compile for Linux at the moment. You'll have to wait until I create the patch file with the source.

[lucaspiller]

I mean just a source patch, not an executable. I expect the people who don't use Windows will be very happy with you for that.

Anyway I am still stuck with Windows so I did some testing.

Not many bugs apart from this (see screenshot), the destinations don't just go over the edge of the Window.

After I took this screenshot the game crashed - I don't whether this is useful. Nothing significant happened at that point but I did an emergency save (it wouldn't load for me but you may be able to find something in it so you can get it in the post.

Code: Select all

*** OpenTTD Crash Report ***
Date: 2004-08-05 21:31:20
Build: ??? built on Tue Jul 27 21:31:20 2004
Exception C0000005 at 0043E8C4
Registers:
 EAX: 2444B70F EBX: 00000000 ECX: 000083C7 EDX: 00B65010
 ESI: 00000057 EDI: 000000B5 EBP: 0012FC14 ESP: 0012FAB0
 EIP: 0043E8C4 EFLAGS: 00010246

Bytes at CS:EIP:
 0F B6 48 51 DB 45 0C 8B 8C 8D A8 FE FF FF 85 C9 89 4D 0C DB 45 0C 7D 06

Stack trace: 
 00008E39 0053D900 46F28A0D 00000000 000000B0 00000000 00000096 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 0000005A 00000000 00000000 00000078
 00000000 00000000 00000000 00000077 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 0053F328 0053F3F8 00000000 00000000 00789B04 00000490 0053F020
 0012FCB4 00418AB1 FFFF0301 FFFFFFFF 0053F2CC 00000000 0053F328 00000000
 000000FA 0012FC38 0043F127 0053F3F8 000083C7 00000000 00000002 0000007D
 00008E39 77D54E1E 0012FCB4 0040AE7C 00000018 00416C9D 00000000 004157B0
 00789AF0 0000000F 00000000 00000000 0041A68A 77D444A8 77D441A5 77D45310
 77D43D96 77D54E1E 00416C9D 00000000 77D4658D 00000000 00000000 00000000
 00000000 0012FC74 00000064 77D54E1E 00416C9D 00000000 77D54ED7 77D54EBC
 00000025 0012FCF8 004159E2 00000000 0041B293 77E7AD86 00000001 00000000
 00080306 0000000F 00000000 00000000 00416C7F 00000220 00000195 00000000
 00000000 00000000 0012FD14 004152C4 00000001 7FFDF000 00140100 00B00178
 00B007E0 00B01B00 00B01B08 00B00178 00144B60 EBEAE9E8 EFEEED00 F3F2F1F0
 F7F6F5F4 00B00C30 0012FDF2 00B00758 00B01B08 00B00750 00B00100 00B00178
 000003AE 77E60000 77ECDF20 77ECEDD8 00B007D8 00B01B00 00000000 00000000
 00000001 FFFFFFFF 0012FD9C 00481608 00000000 FFFFFFFF 00000000 0012FE98
 0041CAAD 00000000 00142391 77E60000 0012FDF2 00B00178 00B01B08 00B00758

Module information:
 C:\cygwin\home\luca Spiller\Copy of openttd\ttd.exe handle: 00400000 size: 554496 crc: 74BF1570 date: 2004-08-05 19:22:28
 C:\WINDOWS\System32\ntdll.dll handle: 77F50000 size: 654336 crc: 137C90F3 date: 2003-05-01 15:56:12
 C:\WINDOWS\system32\kernel32.dll handle: 77E60000 size: 930304 crc: C9D88465 date: 2002-08-29 02:41:00
 C:\WINDOWS\System32\WINMM.dll handle: 76B40000 size: 171520 crc: CDB2A62A date: 2002-08-29 02:41:18
 C:\WINDOWS\system32\USER32.dll handle: 77D40000 size: 560128 crc: F6F0009F date: 2003-09-25 16:49:02
 C:\WINDOWS\system32\GDI32.dll handle: 7E090000 size: 257536 crc: C8DE69D8 date: 2004-03-30 01:48:36
 C:\WINDOWS\system32\ADVAPI32.dll handle: 77DD0000 size: 558080 crc: E8B5CA96 date: 2002-08-29 02:40:48
 C:\WINDOWS\system32\RPCRT4.dll handle: 78000000 size: 535552 crc: 9779ECD0 date: 2004-03-06 02:16:11
 C:\WINDOWS\System32\WS2_32.dll handle: 71AB0000 size: 75264 crc: 00979D06 date: 2001-08-18 11:00:00
 C:\WINDOWS\system32\msvcrt.dll handle: 77C10000 size: 323072 crc: 6B4C287C date: 2002-08-29 02:41:08
 C:\WINDOWS\System32\WS2HELP.dll handle: 71AA0000 size: 18944 crc: A104BC20 date: 2001-08-18 11:00:00
 C:\WINDOWS\System32\LPK.DLL handle: 629C0000 size: 18944 crc: 339805F0 date: 2001-08-18 11:00:00
 C:\WINDOWS\System32\USP10.dll handle: 72FA0000 size: 339456 crc: EEE0DBE8 date: 2002-08-29 02:41:18
 C:\WINDOWS\System32\wdmaud.drv handle: 72D20000 size: 22016 crc: 111175C9 date: 2001-08-18 11:00:00
 C:\WINDOWS\System32\msacm32.drv handle: 72D10000 size: 20480 crc: D5406BAE date: 2001-08-18 11:00:00
 C:\WINDOWS\System32\MSACM32.dll handle: 77BE0000 size: 67072 crc: 7C7B8D2A date: 2001-08-18 11:00:00
 C:\WINDOWS\System32\midimap.dll handle: 77BD0000 size: 17920 crc: 27FE86C2 date: 2001-08-18 11:00:00
 C:\WINDOWS\system32\ole32.dll handle: 771B0000 size: 1183744 crc: A00DF465 date: 2004-03-06 02:16:11
 C:\WINDOWS\System32\uxtheme.dll handle: 5AD70000 size: 203264 crc: 0F5145F0 date: 2002-08-29 02:41:18
 C:\Program Files\Messenger Plus! 3\MsgPlusH.dll handle: 10000000 size: 1269760 crc: BAD76C2A date: 2004-06-01 12:49:35
 C:\WINDOWS\system32\COMCTL32.dll handle: 77340000 size: 557056 crc: A7EC730F date: 2002-08-29 02:40:50
 C:\WINDOWS\system32\comdlg32.dll handle: 763B0000 size: 258048 crc: 02604FC3 date: 2002-08-29 02:40:50
 C:\WINDOWS\system32\SHLWAPI.dll handle: 70A70000 size: 395264 crc: 795B232E date: 2004-01-21 14:18:42
 C:\WINDOWS\system32\SHELL32.dll handle: 773D0000 size: 8240640 crc: D672E18A date: 2003-06-11 20:43:48
 C:\WINDOWS\system32\OLEAUT32.dll handle: 77120000 size: 569344 crc: D0AA7380 date: 2002-08-29 02:41:10
 C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.10.0_x-ww_f7fb5805\comctl32.dll handle: 71950000 size: 921600 crc: 48455D90 date: 2002-08-29 02:41:32
 C:\PROGRA~1\Grisoft\AVG6\avgoerun.dll handle: 00FF0000 size: 40960 crc: 53C6146A date: 2003-01-27 05:00:00
 C:\WINDOWS\System32\MSCTF.dll handle: 74720000 size: 266752 crc: 7830BEFF date: 2002-08-29 02:41:02
 C:\WINDOWS\System32\SynTPFcs.dll handle: 63000000 size: 65536 crc: 8F166CAE date: 2003-05-02 16:21:10
 C:\WINDOWS\system32\VERSION.dll handle: 77C00000 size: 16384 crc: 974DCE59 date: 2001-08-18 11:00:00
 C:\freeserve\freeserveconnectionkit\Freehook.dll handle: 01470000 size: 77824 crc: C4D4622C date: 2003-03-03 10:40:30
 C:\WINDOWS\System32\CLBCATQ.DLL handle: 7C890000 size: 499712 crc: 17CD2928 date: 2004-03-06 02:16:11
 C:\WINDOWS\System32\COMRes.dll handle: 77050000 size: 792064 crc: B9EC5C2F date: 2001-08-18 11:00:00
 C:\WINDOWS\System32\dmime.dll handle: 77300000 size: 171520 crc: 11D1A985 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\DSOUND.dll handle: 51080000 size: 355328 crc: 18E43175 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmusic.dll handle: 014D0000 size: 116736 crc: 845CD555 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\KsUser.dll handle: 5EF80000 size: 4096 crc: 853DEC10 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmsynth.dll handle: 01710000 size: 100864 crc: 8F12DF7F date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmloader.dll handle: 01730000 size: 33280 crc: CED7D165 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmstyle.dll handle: 01790000 size: 98816 crc: F1BF6B2E date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmband.dll handle: 01CC0000 size: 27136 crc: D295B557 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\mslbui.dll handle: 605D0000 size: 22528 crc: 5C30C4B7 date: 2002-08-29 02:41:06
 C:\WINDOWS\System32\psapi.dll handle: 76BF0000 size: 17408 crc: 6F4CD869 date: 2002-08-29 02:41:10

System information:
 Windows version 5.1 2600 Service Pack 1

[TolgaAbaci]

@lucaspiller: I'll have a look at this.

[TolgaAbaci]

Not many bugs apart from this (see screenshot), the destinations don't just go over the edge of the Window.

OK. That one was easy to fix (I'll post a new binary once a number of fixes are done).

[goalie]

i ll cannot play this exe
with the cargosetw.grf
newshipsetw.grf
and dbsetw.grf

[lucaspiller]

TolgaAbaci: I think it has something to do with the aircraft now - also I have found another bug. Passenger generation seems a bit high:

[TolgaAbaci]

i ll cannot play this exe
with the cargosetw.grf
newshipsetw.grf
and dbsetw.grf

I haven't tested with those. What kind of error do you get?

[TolgaAbaci]

TolgaAbaci: I think it has something to do with the aircraft now - also I have found another bug. Passenger generation seems a bit high:

OK, that's another GUI matter, will be fixed.

Btw, the aircraft do not have modified GUIs yet.

[4Eyessniper]

Hi everyone! First of all: great work on this patch Tolga! I watch these forums for a while, but since I browse about 10 forums concerning other games, I wasnt reall bothered to register , but to help getting this developped, I registered .

Ok, I found this (probably minor GUI-) bug. When you place a bus (dunno about other vehicles) as full-load in a (new) station, everypassenger load-spike comes after eachother in the list, while they still go to the same direction, see my screeny below!

[4Eyessniper]

Another thing that caught my attention. This busstation is crowded with people (passenger generation from a town indeed seems to go very, very fast). The bus is on full-load, but it wont fill up entirely. Probably has to do with the list with passengers+directions is full (so it cant add a line under it, so it wont load up)?

Be aware that when this bus stopped to do a full load, this busstation was not yet used and it's been standing there since it arrived (see attachment)

[4Eyessniper]

TolgaAbaci: I think it has something to do with the aircraft now - also I have found another bug. Passenger generation seems a bit high:

OK, that's another GUI matter, will be fixed.

Btw, the aircraft do not have modified GUIs yet.

Sorry for me spamming all these bugreports, I am bored atm

Is that really a gui matter (I'm not a programmer or anything (so please tell me if I bugreport it all the wrong way))? Because the amount of passengers seen in this screenshot is tremendous high and the amount of passengers last month seems a bit low! It's like godmode for OpenTTD

[4Eyessniper]

Code: Select all

*** OpenTTD Crash Report ***
Date: 2004-08-06 00:42:33
Build: ??? built on Tue Jul 27 21:31:20 2004
Exception C0000005 at 0043E8C4
Registers:
 EAX: 2444B70F EBX: 00000000 ECX: 000083C7 EDX: 00B537E8
 ESI: 00000002 EDI: 00000025 EBP: 0012FC14 ESP: 0012FAB0
 EIP: 0043E8C4 EFLAGS: 00010246

Bytes at CS:EIP:
 0F B6 48 51 DB 45 0C 8B 8C 8D A8 FE FF FF 85 C9 89 4D 0C DB 45 0C 7D 06

Stack trace: 
 00007AB2 0053D39C 28E23617 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 0000007A 00000000 00000000 00000000
 00000000 0000008E 0000006A 00000038 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 0053F328 0053F460 00000075 00000003 00418A82 00000120 0053F08C
 0012FCB4 00418AB1 FFFF0401 FFFFFFFF 0053F2CC 00000000 0053F460 00000000
 000000FA 0012FC38 0043F127 0053F328 000083C7 00000000 00000003 00000085
 00007AB2 77D4932C 0012FCB4 0040AE7C 00000006 02356822 00000000 004157B0
 7FFDE000 0012FCAC 77E77561 0012FC80 77E775DD 77D4932C 02356803 00000000
 00000000 0012FC78 FFFFD8F0 FFFFFFFF 00000014 00000001 00000000 00000000
 00000010 0012FC64 00000064 77D4932C 02356803 00000000 77D493E5 77D493CA
 00000025 0012FCF8 004159E2 00000000 0041B293 77E79F93 00000001 00000000
 008F025A 0000000F 00000000 00000000 023567E5 0000018A 0000015A 00000000
 00000000 00000000 0012FD14 004152C4 00000001 7FFDF000 EFEEED00 F3F2F1F0
 D7F6F5F4 FBFAF9F8 DFFEFDFC E3E2E1E0 E7E6E5E4 EBEAE9E8 00140100 001445E0
 77E83E68 0012FDF2 77E82140 00000219 0012FD90 77F519F3 0012FD00 000003A0
 00B00450 00B007E0 00000008 0000000B 00B00450 00B00AB0 00000000 00000000
 00B01810 FFFFFFFF 0012FD9C 00481608 00000000 FFFFFFFF 00000000 0012FE98
 0041CAAD 00000000 00142389 0012FDF2 00000008 0000005B 000000FF 00B00178

Module information:
 C:\Games\Transport Tycoon Deluxe\openttd\ttd.exe handle: 00400000 size: 554496 crc: 74BF1570 date: 2004-08-05 18:22:28
 C:\WINDOWS\System32\ntdll.dll handle: 77F50000 size: 674304 crc: B36A7E6D date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\kernel32.dll handle: 77E60000 size: 926720 crc: C1948880 date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\WINMM.dll handle: 76B40000 size: 170496 crc: 9D5CC63C date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\USER32.dll handle: 77D40000 size: 561152 crc: 8DF26500 date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\GDI32.dll handle: 77C70000 size: 250880 crc: 6D3EEE96 date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\ADVAPI32.dll handle: 77DD0000 size: 549888 crc: 4BADAC6D date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\RPCRT4.dll handle: 77CC0000 size: 463872 crc: 54CB1526 date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\WS2_32.dll handle: 71AB0000 size: 75264 crc: 00979D06 date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\msvcrt.dll handle: 77C10000 size: 322560 crc: 8051A029 date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\WS2HELP.dll handle: 71AA0000 size: 18944 crc: A104BC20 date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\NVDESK32.DLL handle: 10000000 size: 102400 crc: C0326CAE date: 2001-11-28 23:28:00
 C:\WINDOWS\System32\rdpsnd.dll handle: 5DAC0000 size: 14848 crc: A30E2C7A date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\wdmaud.drv handle: 72D20000 size: 22016 crc: 111175C9 date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\msacm32.drv handle: 72D10000 size: 20480 crc: D5406BAE date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\MSACM32.dll handle: 77BE0000 size: 67072 crc: 7C7B8D2A date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\midimap.dll handle: 77BD0000 size: 17920 crc: 27FE86C2 date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\ole32.dll handle: 771B0000 size: 1141248 crc: 00318E45 date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\CLBCATQ.DLL handle: 76FD0000 size: 468480 crc: D661B3D0 date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\OLEAUT32.dll handle: 77120000 size: 569344 crc: B195ED9C date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\COMRes.dll handle: 77050000 size: 792064 crc: B9EC5C2F date: 2001-08-23 12:00:00
 C:\WINDOWS\system32\VERSION.dll handle: 77C00000 size: 16384 crc: 974DCE59 date: 2001-08-23 12:00:00
 C:\WINDOWS\System32\dmime.dll handle: 77300000 size: 171520 crc: 11D1A985 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\DSOUND.dll handle: 51080000 size: 336384 crc: 517AD574 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmusic.dll handle: 00FF0000 size: 97280 crc: 309AC9BA date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\KsUser.dll handle: 5EF80000 size: 4096 crc: 853DEC10 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmsynth.dll handle: 77480000 size: 100864 crc: 8F12DF7F date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\dmloader.dll handle: 77380000 size: 33280 crc: CED7D165 date: 2002-12-11 23:14:32
 C:\WINDOWS\System32\psapi.dll handle: 76BF0000 size: 17408 crc: A2661614 date: 2001-08-23 12:00:00

System information:
 Windows version 5.1 2600 

And then after a while I got this error. I didnt do much, because I was browsing the forums.[/code]

[4Eyessniper]

I have another question, because I dont know if this is a bug or a 'feature':

Imagine three towns that all have one busstation. The 2 furthest busstations also have a trainstation which are connected to eachother without any stop in between:

Code: Select all

    busroute
A ---- B ---- C
[_____________]
   trainroute

a bus has the following route (after it has been to C it goes back to A):

Code: Select all

A --> B --> C
^___________]

the train just pendles between A and C. Now you would expect people that want to go from B to A to take the bus from B to C and then transfer to the train, because this is a lot faster (stations A and C are really far apart). This, unfortunately doesnt happen. The passengers just keep sitting in the bus so they take the full bus ride from B --> C --> A (Of course I normally would solve this by letting the bus stop at B again after it has been at C). Is this as you expected and wanted or is it a 'bug'?

(once again, sorry if I spam too much )

[TolgaAbaci]

Ok, I found this (probably minor GUI-) bug. When you place a bus (dunno about other vehicles) as full-load in a (new) station, everypassenger load-spike comes after eachother in the list, while they still go to the same direction, see my screeny below!

It's not a minor GUI bug, in fact it's a case I neglected in loading of vehicles. Easy to fix, already handled now, will be included in next release.

[TolgaAbaci]

Is that really a gui matter (I'm not a programmer or anything (so please tell me if I bugreport it all the wrong way))? Because the amount of passengers seen in this screenshot is tremendous high and the amount of passengers last month seems a bit low! It's like godmode for OpenTTD

As far as I see, the low number display it is a GUI matter. However, it's true that passenger generation seems to be too high at the moment. It should be reduced. I am open to suggestions on what percentage.