I knowdihedral wrote:that's a shame - you miss out on a lot of good & nifty little featuresmaartena wrote: No, I don't load GRFs and never have loaded GRFs, not even in standalone

Still hoping for inclusion of the "generic tram set"

Moderator: OpenTTD Developers
I knowdihedral wrote:that's a shame - you miss out on a lot of good & nifty little featuresmaartena wrote: No, I don't load GRFs and never have loaded GRFs, not even in standalone
I hate to burst your little bubble, but trg?r.grf and openttd?.grf are all GRFs. The latter are even newgrfs.maartena wrote:No, I don't load GRFs and never have loaded GRFs, not even in standalone
I suppose I have beta 2.Rubidium wrote:Have you actually tested beta2? Because I have fixed something that you see as the registers behaving incorrectly a few hours before the release, even though it had absolutely nothing to do with registers. The registers work exactly as they should.When the GRF tells it to store value X, it stores value X and when you retrieve it it is still value X.George wrote:sorry, bur the industry and registers code does not work.
However, when the GRF is called with a NewGRF callback that your GRF does not expect and then 'chooses' to go through the production callback code.
Primarily by telling what is broken. I myself do not like starting TTDP because I have to run it in DosBox (due to my inability to get Wine working). This means that it takes about 5 minutes to start a game, the game itself is slow as hell and for some reason unknown to me DosBox does not want to release my mouse. This means that a side-by-side comparison of TTDP and OpenTTD is virtually impossible for me.George wrote:Sorry, I did not understand your remark, but I suppose, because in TTDP it works as intended, that there is something wrong with newgrf support in OTTD, not in GRF itself. How can I help to fix the bug or is it known?
Sorry for making you so emotional.Rubidium wrote:Primarily by telling what is broken. I myself do not like starting TTDP because I have to run it in DosBox (due to my inability to get Wine working). This means that it takes about 5 minutes to start a game, the game itself is slow as hell and for some reason unknown to me DosBox does not want to release my mouse. This means that a side-by-side comparison of TTDP and OpenTTD is virtually impossible for me.George wrote:Sorry, I did not understand your remark, but I suppose, because in TTDP it works as intended, that there is something wrong with newgrf support in OTTD, not in GRF itself. How can I help to fix the bug or is it known?
When somebody later told me that the changes were done too often, it made me find an slight inconsistency in the code which did perform a 'random action 2' callback on the industry, which eventually caused the production callback to be called too often and with improperly initialized variables.
Code: Select all
// display registers
102 * 58 04 0A FF 01 DE D0 90 "Tran: " 7B " Tot: " 7B " Know: " 7B 0D
"R0: " 7C " -> R3: " 7C " IR0: " 7C " PL: " 7C 00
103 * 120 02 0A 7E 89
7C 00 28 FF FF FF 00 0E
1A 20 00 01 00 00 0F
7C 01 20 FF FF FF 00 0E
1A 20 01 01 00 00 0F
7C 02 20 FF FF FF 00 0E
1A 20 02 01 00 00 0F
7C 0E 20 FF FF 00 00 0A
1A 20 00 00 01 00 00
7C 0F 20 FF FF 00 00 0E
1A 20 03 01 00 00 0F
93 20 FF 00 00 00 0A
1A 20 00 00 01 00 00
7C 00 20 FF 00 00 00 0E
1A 00 04 01 00 00
01 DE 80 00 00 00 00 00 00 00 00 DE 80
Rubidium wrote:It is actually true. For some reason, when the Cudham station is full it turns around and goes back. At that moment it cannot find a route to Cudham anymore because the pathfinder does not support 'dead end bouncing', i.e. it will not create a route that involves turning at some dead end. As a result of that it does not get a route, which makes OpenTTD correctly show the train lost message as it cannot find a route to the destination for that train.ostlandr wrote:Train 20 in the save game is the one that keeps saying it's lost.
I haveMoriarty wrote:You've not heard of an OS called Debian have you?rabbit67890 wrote:Wow a world's recordRubidium wrote:0.5.0 took 3 months so nothing is certain.![]()
![]()
![]()
I expect you're aware that TTDPatch can dump a log of all values read or calculated, which can provide the register values indirectly?Rubidium wrote:It took me (read: I wasted) a lot of hours to painstakingly trace the NewGRF and the value changes in the registers
I did not.DaleStan wrote:I expect you're aware that TTDPatch can dump a log of all values read or calculated, which can provide the register values indirectly?
Spot the difference becomes kinda hard when random numbers are used.DaleStan wrote:Then you just have to make sure that Open's following the same path at the same times and/or play spot the differences, which (if Open has a similar feature somewhere) could be as simple as diffing the logs.
Well, if you haven't yet, read up on Cht: grfdebug. It's not a straight dump, obviously, and (even post log-parser) still requires some cross-referencing with the NFO, but any values that are either read or written will be listed.Rubidium wrote:I did not.DaleStan wrote:I expect you're aware that TTDPatch can dump a log of all values read or calculated, which can provide the register values indirectly?
True. But I was hoping/expecting that the problems would make themselves obvious without too much randomness.Rubidium wrote:Spot the difference becomes kinda hard when random numbers are used.
Okay, point taken.DaleStan wrote:I hate to burst your little bubble, but trg?r.grf and openttd?.grf are all GRFs. The latter are even newgrfs.maartena wrote:No, I don't load GRFs and never have loaded GRFs, not even in standalone
ill reproduce with crash.dmpmaartena wrote:Hmmm.... My "Maarten 1" server crashed with the following crash report:
Don't know what this d:\developpement folder is all about.... (is that a non-english way of spelling development?)
*** OpenTTD Crash Report ***
Date: 2007-12-12 10:48:02
Build: 0.6.0-beta2 built on Dec 9 2007 22:47:34
Reason: Assertion failed at d:\developpement\ottd\0.6.0-beta2\src\water_map.h:127: o != OWNER_WATER
Exception C0000005 at 00498906
Registers:
EAX: 00CFC4E0 EBX: 00000000 ECX: 0012F808 EDX: 00CFC53C
ESI: 0004E17D EDI: 00000080 EBP: 0012FA40 ESP: 0012FA20
EIP: 00498906 EFLAGS: 00010202
Bytes at CS:EIP:
88 1D 00 00 00 00 E8 DC FD FF FF FF 74 24 0C 8B C6 E8 3F BD FF FF A1 74
Stack trace:
0004DD7D 00000004 00498AEC 00000011 02D91704 0012FA88 0004E17D 01010001
0012FA74 00487540 0004E17D 00000011 00000000 00000001 00488FA0 00000001
0012FAB4 0004E17D 00000025 02D91704 00C90000 0012FA94 004160CD 00000001
0012FB60 0004E17D 00000025 00000000 7C01FFFF 0012FACC 00405248 00000001
00000000 00000000 0000017D 00000025 00405849 00000025 00000000 00000000
00000025 00000025 00000025 0012FB7C 004162C3 0004E17D 00000000 00000000
00000001 004160A3 00000001 0004E17D 0000FFFF 00000000 015EAD70 00000138
00000138 0000017D 0000017D 0000017D 00000138 00001388 000017D8 0012FBCC
00000000 00000000 00000000 0001FFFF 00000025 00000000 0101FFFF 001E3505
00000000 0001FFFF 00000025 00000000 0001FFFF 001E3505 00000000 0001FFFF
00662104 000DE6B5 000005C8 00000025 00000000 0001FFFF 00000000 0012FBDC
0040566B 00000001 0004E17D 00000000 00573000 02344B40 0057A544 01000080
00001380 000017D0 00000097 004160ED 00000000 00000025 00000000 0001FFFF
00000025 00000000 0001FFFF 00000000 00000000 00000000 FFFFD8F0 00539D10
0041B540 0004E17D 0004E17D 00000000 00000000 00970864 00000000 5A6BF6C7
5A6BF6A9 0012FC14 00000000 0041B6D4 00002701 0012FC24 00424D19 5A6BF68A
00000000 77E619D1 004CABDA 00665860 005DED8C 0012FD10 00000000 004242EF
0012FD24 00000002 00000001 010101C7 00000000 00833A36 FFFFFFFF 00000000
00000000 00000000 FFFFFFFF 0012FE30 0057C4E0 00000000 000002C8 FFFFFFFF
00000000 00000000 00000000 00000000 6C6C756E 0012FC00 77E5F56F 00000027
FFFFFFFF 00000025 00000104 0000FDE9 69646564 65746163 00000064 0012FCE8
77E5F4E8 0000FDE9 00000000 000205D4 6C6C756E 0012FD00 00000104 00000000
00000000 00000ECE 0012FF28 00441D6A 6C6C756E 00000000 000205D4 FFFFFFFF
0012FD24 00000104 00004B8B 0012FF28 0012FF28 0044192F 0012FE28 00000ECE
Module information:
C:\Openttd\server1\openttd.exe handle: 00400000 size: 1751040 crc: ED0BA8D6 date: 2007-12-10 06:50:00
C:\WINDOWS\system32\ntdll.dll handle: 7C800000 size: 765440 crc: 4D1DA366 date: 2007-02-18 08:33:06
C:\WINDOWS\system32\kernel32.dll handle: 77E40000 size: 1037824 crc: B0182336 date: 2007-04-18 16:25:36
C:\WINDOWS\system32\WINMM.dll handle: 76AA0000 size: 174080 crc: 1AD9C7AF date: 2007-02-17 12:09:08
C:\WINDOWS\system32\USER32.dll handle: 77380000 size: 583680 crc: 2C67E4E6 date: 2007-03-02 06:38:46
C:\WINDOWS\system32\GDI32.dll handle: 77C00000 size: 282624 crc: 03189088 date: 2007-03-02 06:38:46
C:\WINDOWS\system32\ADVAPI32.dll handle: 77F50000 size: 618496 crc: F464142C date: 2007-02-17 10:16:46
C:\WINDOWS\system32\RPCRT4.dll handle: 77C50000 size: 642048 crc: D59B9058 date: 2007-07-11 10:38:05
C:\WINDOWS\system32\Secur32.dll handle: 76F50000 size: 65024 crc: 1E253891 date: 2007-02-17 11:58:56
C:\WINDOWS\system32\WS2_32.dll handle: 71C00000 size: 83456 crc: A73E4DEB date: 2007-02-17 12:11:36
C:\WINDOWS\system32\msvcrt.dll handle: 77BA0000 size: 348672 crc: 6029DD23 date: 2007-02-17 11:36:50
C:\WINDOWS\system32\WS2HELP.dll handle: 71BF0000 size: 19456 crc: DA5809E2 date: 2007-02-17 12:11:36
C:\WINDOWS\system32\IMM32.DLL handle: 76290000 size: 110592 crc: 6BEE4725 date: 2007-02-17 11:19:36
C:\WINDOWS\system32\rdpsnd.dll handle: 71BC0000 size: 18432 crc: 2DBF3ADE date: 2005-11-30 12:00:00
C:\WINDOWS\system32\WINSTA.dll handle: 771F0000 size: 56320 crc: 65DD91A1 date: 2007-02-17 12:09:16
C:\WINDOWS\system32\NETAPI32.dll handle: 71C40000 size: 345088 crc: 73F00B90 date: 2007-02-17 11:37:26
C:\WINDOWS\system32\PSAPI.DLL handle: 76B70000 size: 20480 crc: B394590E date: 2007-02-17 11:52:44
C:\WINDOWS\system32\SHFolder.dll handle: 766D0000 size: 25088 crc: B736DB79 date: 2007-02-17 11:59:28
C:\WINDOWS\system32\SHLWAPI.dll handle: 77DA0000 size: 320000 crc: 2D7A1E2B date: 2007-02-17 11:59:42
C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.3790.3959_x-ww_D8713E55\comctl32.dll handle: 77420000 size: 1051648 crc: CAE5A761 date: 2007-02-18 09:01:02
C:\WINDOWS\system32\mswsock.dll handle: 71B20000 size: 256000 crc: AF38F354 date: 2007-02-17 11:36:58
C:\WINDOWS\system32\hnetcfg.dll handle: 5F270000 size: 355328 crc: A1A5AD03 date: 2007-02-17 11:14:26
C:\WINDOWS\System32\wshtcpip.dll handle: 71AE0000 size: 18944 crc: 72B633AE date: 2007-02-17 12:11:46
C:\WINDOWS\system32\DNSAPI.dll handle: 76ED0000 size: 160256 crc: 0E91211E date: 2007-02-17 10:50:50
C:\WINDOWS\System32\winrnr.dll handle: 76F70000 size: 17408 crc: 3C43229F date: 2007-02-17 12:09:14
C:\WINDOWS\system32\WLDAP32.dll handle: 76F10000 size: 179712 crc: E7B0A880 date: 2007-02-17 12:09:28
C:\WINDOWS\system32\rasadhlp.dll handle: 76F80000 size: 7680 crc: 773920D1 date: 2007-02-17 11:55:08
System information:
Windows version 5.2 3790 S
Also, I pressed "emergency save" and it said it succeeded.
I have attached crash.zip to this post which contains crash.log, crash.sav, and crash.dmp - not sure if it will help, but if there is anything I can do to find out what the problem may have been, let me know!
Code: Select all
'crash.dmp': Loaded '*C:\Openttd\server1\openttd.exe', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\ntdll.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\kernel32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\winmm.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\user32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\gdi32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\advapi32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\rpcrt4.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\secur32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\ws2_32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\msvcrt.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\ws2help.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\imm32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\rdpsnd.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\winsta.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\netapi32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\psapi.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\shfolder.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\shlwapi.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.3790.3959_x-ww_D8713E55\comctl32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\mswsock.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\hnetcfg.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\wshtcpip.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\dnsapi.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\winrnr.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\wldap32.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\rasadhlp.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\dbghelp.dll', No matching binary found.
'crash.dmp': Loaded '*C:\WINDOWS\system32\version.dll', No matching binary found.
The program 'crash.dmp: Native' has exited with code 0 (0x0).
Users browsing this forum: No registered users and 21 guests