JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Mizari wrote:Are there any instabilities with multiplayer to be expected?
You may have desync issues if improved breakdowns is enabled, if that's turned off you'll probably be fine.
I'll likely do another release soonish with that sorted.
Ex TTDPatch Coder
Patch Pack, Github
Wipe
Engineer
Engineer
Posts: 6
Joined: 21 Sep 2015 20:34

Re: JGR's Patch Pack

Post by Wipe »

Would be nice to have dedicated category in settings, with options not present in trunk only.

-----

There's a crash coming from programmable signals; happened during manual save, when there was no rails built at all yet [just a small ship network].

crash.log:

Code: Select all

Crash reason:
 Signal:  Aborted (6)
 Message: Assertion failed at line 39 of /home/samira/games/openttd/openttd.jgrpp/src/rail_map.h: IsTileType(t, MP_RAILWAY)

OpenTTD version:
 Version:    jgrpp-0.5.2-8-gd715b7e (0)
 NewGRF ver: 16006b0a
 Bits:       32
 Endian:     little
 Dedicated:  no
 Build date: Sep 30 2015 14:36:00

Stacktrace:
 [00]  0x83a32f8 ./openttd                                CrashLogUnix::LogStacktrace(char*, char const*) const + 0x118
 [01]  0x828006e ./openttd                                CrashLog::FillCrashLog(char*, char const*) const + 0xce
 [02]  0x828028b ./openttd                                CrashLog::MakeCrashLog() const + 0x5b
 [03]  0x83a315b ./openttd                                + 0x35b15b
 [04] 0xb76eabbc                                          __kernel_sigreturn + 0x0
 [05] 0xb76eabe0                                          __kernel_vsyscall + 0x10
 [06] 0xb572e297 /lib/libc.so.6                           gsignal + 0x47
 [07] 0xb572fb69 /lib/libc.so.6                           abort + 0x149
 [08]  0x838f35f ./openttd                                + 0x34735f
 [09]  0x812789f ./openttd                                + 0xdf89f
 [10]  0x83d54f6 ./openttd                                SignalStateCondition::IsSignalValid() + 0x86
 [11]  0x83d5584 ./openttd                                SignalStateCondition::~SignalStateCondition() + 0x14
 [12]  0x83d55ce ./openttd                                SignalStateCondition::~SignalStateCondition() + 0xe
 [13]  0x83d4eb8 ./openttd                                SignalIf::Remove() + 0x18
 [14]  0x83d5399 ./openttd                                SignalSpecial::Remove() + 0x29
 [15]  0x83d6039 ./openttd                                SignalProgram::~SignalProgram() + 0x19
 [16]  0x83d6f30 ./openttd                                FreeSignalProgram(SignalReference) + 0x50
 [17]  0x8422cf8 ./openttd                                + 0x3dacf8
 [18]  0x8420cfc ./openttd                                + 0x3d8cfc
 [19]  0x84217aa ./openttd                                SaveOrLoad(char const*, int, Subdirectory, bool) + 0x25a
 [20]  0x83916d0 ./openttd                                SwitchToMode(SwitchMode) + 0x370
 [21]  0x8392f33 ./openttd                                GameLoop() + 0x43
 [22]  0x850d754 ./openttd                                VideoDriver_SDL::MainLoop() + 0x224
 [23]  0x8390b8f ./openttd                                openttd_main(int, char**) + 0x14cf
 [24]  0x8171d50 ./openttd                                main + 0x60
 [25] 0xb5718e7e /lib/libc.so.6                           __libc_start_main + 0xde
 [26]  0x81c6c9d ./openttd                                + 0x17ec9d

Operating system:
 Name:     Linux
 Release:  4.1.6-100.fc21.i686+PAE
 Version:  #1 SMP Mon Aug 17 22:43:44 UTC 2015
 Machine:  i686
 Compiler: GCC 4.9.2 "4.9.2 20150212 (Red Hat 4.9.2-6)"
crash.sav have zero size, and only interesting thing in console is:

Code: Select all

Writing crash savegame...
dbg: [sl] Programmable signal information for (ec0ba, 0) has been leaked!
Error: Assertion failed at line 39 of /home/samira/games/openttd/openttd.jgrpp/src/rail_map.h: IsTileType(t, MP_RAILWAY)
Aborted (core dumped)
Compiled from yesterday state of jgrpp branch.
Games are meant to be created, not played...
User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Wipe wrote:Would be nice to have dedicated category in settings, with options not present in trunk only.
I'll certainly consider this for possible future addition.
Wipe wrote:There's a crash coming from programmable signals; happened during manual save, when there was no rails built at all yet [just a small ship network].
Thanks for reporting this.

Edit: I can reproduce this now.
It seems that programmable signal programs are not cleared when initialising a new game, so any signal programs which were in the previous game get carried over and this quite upsets the savegame code when these dangling signal programs now point to tiles which aren't rails/signals. This should be fixed in the next release and on git, shortly.
Ex TTDPatch Coder
Patch Pack, Github
Wipe
Engineer
Engineer
Posts: 6
Joined: 21 Sep 2015 20:34

Re: JGR's Patch Pack

Post by Wipe »

JGR wrote: It seems that programmable signal programs are not cleared when initialising a new game, so any signal programs which were in the previous game get carried over and this quite upsets the savegame code when these dangling signal programs now point to tiles which aren't rails/signals. This should be fixed in the next release and on git, shortly.
Oh, i'm too slow :P Yeah, it was abandon -> new game

Hmm, there also seems that are problems with tracking if signals used in program are still valid... or something.

P-Signal1-2 : checks different groups of exit signals
P-Signal3 : checks P-Signals 1-2
P-Signal4 : checks P-Signal 3

Now. If i decide to sell P-Signals 1-3 first, everything is fine. Trying to sell or modify P-Signal 4 now leads to crash in most cases.

Code: Select all

 [07] 0xb5780b69 /lib/libc.so.6                           abort + 0x149
 [08]  0x838f35f ./openttd                                + 0x34735f
 [09]  0x846b315 ./openttd                                + 0x423315
 [10]  0x846b4ad ./openttd                                UpdateSignalsInBuffer() + 0x1d
 [11]  0x83d6a05 ./openttd                                CmdModifySignalInstruction(unsigned int, DoCommandFlag, unsigned int, unsigned int, char const*) + 0x445
 [12]  0x826a569 ./openttd                                DoCommandPInternal(unsigned int, unsigned int, unsigned int, unsigned int, void (*)(CommandCost const&, unsigned int, unsigned int, unsigned int), char const*, bool, bool, unsigned int) + 0x239
 [13]  0x826ab77 ./openttd                                DoCommandP(unsigned int, unsigned int, unsigned int, unsigned int, void (*)(CommandCost const&, unsigned int, unsigned int, unsigned int), char const*, bool, unsigned int) + 0xb7
 [14]  0x83d96d6 ./openttd                                ProgramWindow::OnDropdownSelect(int, int) + 0x196
 [15]  0x852ac70 ./openttd                                DropdownWindow::OnMouseLoop() + 0x200
 [16]  0x8530806 ./openttd                                InputLoop() + 0x2c6
 [17]  0x8392fc6 ./openttd                                GameLoop() + 0xd6
-snip-
dbg: [misc] SignalSegment too complex. Set _globset is full (maximum 128) // spams same message about dozen of times
Games are meant to be created, not played...
User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Wipe wrote:Hmm, there also seems that are problems with tracking if signals used in program are still valid... or something.
If possible, could you post a screenshot of what your track layout looks like here, or a savegame?
Ex TTDPatch Coder
Patch Pack, Github
Wipe
Engineer
Engineer
Posts: 6
Joined: 21 Sep 2015 20:34

Re: JGR's Patch Pack

Post by Wipe »

JGR wrote:or a savegame?
Here you go. Any attempt to delete psignals A-D in any order leads to crash.

PS: goto signal could hilight a tile for a short time [like "you cannot build here" does] aside of centering, would be easier to find what depends on what if you have many signals next to each other.
Attachments
psignals-crashme.sav
(11.38 KiB) Downloaded 148 times
Games are meant to be created, not played...
Stigah
Engineer
Engineer
Posts: 30
Joined: 07 Sep 2012 20:43

Re: JGR's Patch Pack

Post by Stigah »

I've been playing 0.4.1 for awhile now, and I just downloaded 0.5.2.

I'm trying to start a new game, but I always get this error message:

"Map generation aborted...
no suitable town locations"

Is this a bug?

This is the settings I have choosed:

Map size: 16384x16384
Land generator: TerraGenesis
No. of towns: Normal
Terrain type: Very Flat
Variety distribution: Very High
Sea level: Very Low
Tree algorithm: Improved
Maximum map height: 20
No. of industries: Very Low
Smoothness: Very Smooth
Rivers: None


How do I fix this?
Eddi
Tycoon
Tycoon
Posts: 8282
Joined: 17 Jan 2007 00:14

Re: JGR's Patch Pack

Post by Eddi »

try to recreate the map with these settings in the scenario editor. it might be that you get all-water maps.

if you want flat maps, you should probably disable variety distribution.
Stigah
Engineer
Engineer
Posts: 30
Joined: 07 Sep 2012 20:43

Re: JGR's Patch Pack

Post by Stigah »

I tried to open the scenario editor, but I don't think it worked. (The whole map is flat and green)

I took a couple of screenshots while the game was loading:

http://imgur.com/ChkrXUn
http://imgur.com/oxODUdN

It looks like it's all-water. How do I fix this? I tried to change the settings (from very flat to Alpinist), hoping it would regenerate the map, but that didn't work.
User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Wipe wrote:Here you go. Any attempt to delete psignals A-D in any order leads to crash.
This should be fixed now. When the target of a signal condition was deleted, or when clearing previous signal programs after creating a new map, the signal condition destructor used a function only valid on rail tiles to check whether the tile was a valid signal.
Wipe wrote:PS: goto signal could hilight a tile for a short time [like "you cannot build here" does] aside of centering, would be easier to find what depends on what if you have many signals next to each other.
This is something I looked at for a bit when implementing routing restrictions. If I remember correctly it seemed unexpectedly clunky to implement something like that, so I left it out. At some point in the future I may go and add it.
In the case of "you cannot build here" messages, the tile highlight is tied to the lifetime of the error message window.
Stigah wrote:I've been playing 0.4.1 for awhile now, and I just downloaded 0.5.2.

I'm trying to start a new game, but I always get this error message:

"Map generation aborted...
no suitable town locations"

Is this a bug?
Eddi wrote:try to recreate the map with these settings in the scenario editor. it might be that you get all-water maps.

if you want flat maps, you should probably disable variety distribution.
I just tried it and got an all water map (or at least as far as I was prepared to scroll).
Ex TTDPatch Coder
Patch Pack, Github
Stigah
Engineer
Engineer
Posts: 30
Joined: 07 Sep 2012 20:43

Re: JGR's Patch Pack

Post by Stigah »

I found out that 16384x16384 was a little bit too huge, so I changed it to 8192x8192. I changed variety distribution to none, and terrain type to flat.
It's still not working, unfortunately. Do you have any idea what I could do to fix this?
User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Stigah wrote:I found out that 16384x16384 was a little bit too huge, so I changed it to 8192x8192. I changed variety distribution to none, and terrain type to flat.
It's still not working, unfortunately. Do you have any idea what I could do to fix this?
It seems that this is a bug in the terrain generator when both map edges are longer than 4096. I've fixed this now and it'll be in the next release.
Ex TTDPatch Coder
Patch Pack, Github
Stigah
Engineer
Engineer
Posts: 30
Joined: 07 Sep 2012 20:43

Re: JGR's Patch Pack

Post by Stigah »

Sounds great! Thank you very much
piratgizmo
Engineer
Engineer
Posts: 2
Joined: 02 Oct 2015 16:58

Re: JGR's Patch Pack

Post by piratgizmo »

JGR wrote:
Alternatively it may be easier for you to clone the repo using:

Code: Select all

git clone -b jgrpp https://github.com/JGRennison/OpenTTD-patches.git jgrpp && cd jgrpp
THX, Worked like a Charme out of the Box 2 compile ... lets hope it runs stable ... nice collection of patches, have 2 try them out next days ...

Suitable Scenarios anyone 2 recommend (preferrable with ECS)?
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: JGR's Patch Pack

Post by ISA »

I am not sure what caused the crash. If its not in the patch let me know and I do the proper post where needed

*** OpenTTD Crash Report ***

Crash at: Sun Oct 11 13:19:16 2015
In game date: 2012-04-10 (68, 0)

Crash reason:
Exception: E1212012
Location: 7C812FD3
Message: Assertion failed at line 767 of /home/jgr/openttd/cross-win32/src/command.cpp: res.GetCost() == res2.GetCost() && res.Failed() == res2.Failed()

OpenTTD version:
Version: jgrpp-0.5.3 (0)
NewGRF ver: 16006b0b
Bits: 32
Endian: little
Dedicated: no
Build date: Oct 3 2015 14:38:05

Registers:
EAX: 0022D4F0 EBX: 00F49DC0 ECX: 00000000 EDX: 77C61A58
ESI: 00000000 EDI: 005700F0 EBP: 0022D540 ESP: 0022D4EC
EIP: 7C812FD3 EFLAGS: 00000246

Bytes at instruction pointer:
5E C9 C2 10 00 85 FF 0F 8E 5E 8E FF FF 8B 55 FC 89 55 0C 0F B7 16 8B 7D

Stack trace:
77C61890 E1212012 00000000 00000000 7C812FD3 00000000 7E4663FD 0022D50C
00000028 00170334 00000000 00F49DC0 00B04F4A 00000010 00000000 00000000
00000000 00000000 00000000 00000000 0022D3C8 0022D5A8 00570118 E1212012
00000000 00000000 00000000 77C61A58 0022D5A8 77C352D3 77C352DA 00000016
0022D91C 00000000 0022D5CC 0022D594 7E466579 00170334 00F49DC0 005700F0
00000001 0022D56C 0022D118 0022DB68 77C35C94 77C12890 FFFFFFFF 00000000
77C36BC1 00000016 0000000A 0055F771 0022D5CC 00000001 00AC4744 0022D7E0
65737341 6F697472 6166206E 64656C69 20746120 656E696C 37363720 20666F20
6D6F682F 676A2F65 706F2F72 74746E65 72632F64 2D73736F 336E6977 72732F32
6F632F63 6E616D6D 70632E64 72203A70 472E7365 6F437465 29287473 203D3D20
32736572 7465472E 74736F43 26202928 65722026 61462E73 64656C69 3D202928
6572203D 462E3273 656C6961 00292864 00000000 0000001B 0447B978 00090000
0447B978 084A36E0 07C763A8 0022D828 FFFFFFFF 00000000 00000000 000004D2
00000000 00986630 00A3FADC 0022D71C 00679603 0022D62C 0022D704 000004C2
0000002B 00000000 00000000 00000000 000000FF 0447B978 00000000 00000000
0001FFFF 00000000 00000000 00879F68 00000003 00000277 00000168 00000000
0001FFFF 00000000 00000000 004D930C 00000168 00000000 000000B4 0022D77C
FFFFFE97 7FFFFFFF 00000000 0022D87C 000849BB 03CB5EA8 00000000 00679D78
0022D79C 000849BB 00000001 00004787 00000009 00000000 00000000 00000000
00000000 000002F4 0022D774 00000001 00000277 03CB5EA8 0022D77C 00000001
00000164 0022D830 00D8C3C8 0447B978 00000001 0260A1DC 000117EF 00000000
0001FFFF 00000000 00000000 00000000 023F4928 023F492C 023F492C 00555F3D
00000000 00000000 00000000 00000000 00000000 00000004 00000003 000849BB
000849BB 00000000 000000D4 0047D7FB 00AC4744 000002FF 00AC47D4 00AC49C4

Operating system:
Name: Windows
Release: 5.1.2600 (Service Pack 3)
Compiler: GCC 4.9.2 "4.9.2"

Configuration:
Blitter: 32bpp-anim
Graphics set: OpenGFX (974)
Language: D:\Gamez\OpenTTD\lang\english_US.lng
Music driver: win32
Music set: OpenMSX (96)
Network: no
Sound driver: win32
Sound set: OpenSFX (87)
Video driver: win32

Fonts:
Small: sprite
Medium: sprite
Large: sprite
Mono: sprite

AI Configuration (local: 0):
0: Human

Libraries:
FreeType: 2.6.0
LZMA: 5.2.1
LZO: 2.09
PNG: 1.5.23
Zlib: 1.2.8

Module information:
D:\Gamez\OpenTTD\openttd.exe handle: 00400000 size: 26875345 crc: E3A312AC date: 2015-10-03 11:38:54
C:\WINDOWS\system32\ntdll.dll handle: 7c900000 size: 718336 crc: 1684124F date: 2010-12-09 15:15:41
C:\WINDOWS\system32\kernel32.dll handle: 7c800000 size: 993280 crc: FB8B7208 date: 2014-03-12 10:48:50
C:\WINDOWS\system32\ADVAPI32.dll handle: 77dd0000 size: 617472 crc: 8C2D91BB date: 2011-07-13 15:03:09
C:\WINDOWS\system32\RPCRT4.dll handle: 77e70000 size: 591360 crc: E465787D date: 2013-11-07 05:38:51
C:\WINDOWS\system32\Secur32.dll handle: 77fe0000 size: 56832 crc: 0B6CDBB1 date: 2011-07-13 15:04:19
C:\WINDOWS\system32\GDI32.dll handle: 77f10000 size: 287744 crc: D7D4014D date: 2013-10-09 13:12:48
C:\WINDOWS\system32\USER32.dll handle: 7e410000 size: 578560 crc: F7C72264 date: 2008-04-14 12:00:00
C:\WINDOWS\system32\IMM32.DLL handle: 76390000 size: 110080 crc: C1486DA0 date: 2008-04-14 12:00:00
C:\WINDOWS\system32\msvcrt.dll handle: 77c10000 size: 343040 crc: 48F3F2C9 date: 2011-07-13 15:04:00
C:\WINDOWS\system32\SHELL32.DLL handle: 7c9c0000 size: 8463872 crc: D0A57C0B date: 2012-06-08 14:24:16
C:\WINDOWS\system32\SHLWAPI.dll handle: 77f60000 size: 474112 crc: ECEDAFE7 date: 2011-07-13 15:04:28
C:\WINDOWS\system32\WINMM.DLL handle: 76b40000 size: 176128 crc: 2D7A3E5F date: 2011-10-14 14:47:29
C:\WINDOWS\system32\WS2_32.dll handle: 71ab0000 size: 82432 crc: 7C519ECA date: 2008-04-14 12:00:00
C:\WINDOWS\system32\WS2HELP.dll handle: 71aa0000 size: 19968 crc: 3F24E096 date: 2008-04-14 12:00:00
C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.2600.6028_x-ww_61e65202\comctl32.dll handle: 773d0000 size: 1054208 crc: 350BBD1B date: 2011-07-13 15:01:57
C:\WINDOWS\system32\comctl32.dll handle: 5d090000 size: 617472 crc: B00C920E date: 2011-07-13 15:03:15
C:\WINDOWS\system32\uxtheme.dll handle: 5ad70000 size: 218624 crc: A4A915A5 date: 2008-04-14 12:00:00
C:\WINDOWS\system32\nview.dll handle: 10000000 size: 1478656 crc: FAB769D3 date: 2007-08-27 22:59:00
C:\WINDOWS\system32\PSAPI.DLL handle: 76bf0000 size: 23040 crc: 75BBDCAD date: 2008-04-14 12:00:00
C:\WINDOWS\system32\ole32.dll handle: 774e0000 size: 1289728 crc: A34C066F date: 2013-08-05 13:30:32
C:\WINDOWS\system32\OLEAUT32.dll handle: 77120000 size: 552448 crc: B6510EFC date: 2013-01-26 03:55:10
C:\WINDOWS\system32\VERSION.dll handle: 77c00000 size: 18944 crc: 558B1DAF date: 2008-04-14 12:00:00
C:\WINDOWS\system32\NTMARTA.DLL handle: 77690000 size: 118784 crc: 35FC486D date: 2008-04-14 12:00:00
C:\WINDOWS\system32\SAMLIB.dll handle: 71bf0000 size: 64000 crc: F7AAF5EE date: 2008-04-14 12:00:00
C:\WINDOWS\system32\WLDAP32.dll handle: 76f60000 size: 172032 crc: C4516D53 date: 2008-04-14 12:00:00
C:\WINDOWS\system32\MSCTF.dll handle: 74720000 size: 299520 crc: 484E7AAF date: 2011-07-13 15:03:45
C:\WINDOWS\system32\msctfime.ime handle: 755c0000 size: 177152 crc: E1AAA0A2 date: 2011-07-13 15:03:45
C:\WINDOWS\system32\mswsock.dll handle: 71a50000 size: 245248 crc: 1EBE3CC4 date: 2011-07-13 15:04:02
C:\WINDOWS\system32\hnetcfg.dll handle: 662b0000 size: 344064 crc: 55F41157 date: 2011-07-13 15:03:24
C:\WINDOWS\System32\wshtcpip.dll handle: 71a90000 size: 19456 crc: F5533E87 date: 2008-04-14 12:00:00
C:\WINDOWS\system32\WINTRUST.dll handle: 76c30000 size: 178176 crc: 58F73649 date: 2012-08-24 13:52:39
C:\WINDOWS\system32\CRYPT32.dll handle: 77a80000 size: 603136 crc: AF117A68 date: 2013-10-07 10:59:21
C:\WINDOWS\system32\MSASN1.dll handle: 77b20000 size: 58880 crc: AA214C7F date: 2011-07-13 15:03:44
C:\WINDOWS\system32\IMAGEHLP.dll handle: 76c90000 size: 150528 crc: FA657074 date: 2013-11-13 02:59:42
C:\WINDOWS\system32\wdmaud.drv handle: 72d20000 size: 23552 crc: EEB914CA date: 2008-04-13 23:42:46
C:\WINDOWS\system32\msacm32.drv handle: 72d10000 size: 20480 crc: D5406BAE date: 2008-04-14 12:00:00
C:\WINDOWS\system32\MSACM32.dll handle: 77be0000 size: 71680 crc: EDE4B266 date: 2008-04-14 12:00:00
C:\WINDOWS\system32\midimap.dll handle: 77bd0000 size: 18944 crc: 2E6D5FD1 date: 2008-04-14 12:00:00
C:\WINDOWS\system32\nvwddi.dll handle: 04250000 size: 81920 crc: 0480B35B date: 2007-08-27 22:59:00

---- gamelog start ----
Tick 0: new game started
Revision text changed to r26844, savegame version 193, not modified, _openttd_newgrf_version = 0x150068dc
New game mode: 1 landscape: 0
Added NewGRF: GRF ID 4E480101, checksum A75AEB1758966FB8CA8B0D7044B5C0A8, filename: nhfoundationsw.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 237EC8B4432F26C2721B69D0814045E6, filename: indstatr.grf (matches GRFID only)
Added NewGRF: GRF ID F1250005, checksum 574836B24595A99523DC3CFDC936C1C5, filename: firs.grf (matches GRFID only)
Added NewGRF: GRF ID 4D50003F, checksum 1DE407E8A75704008414044459D18E16, filename: ISRfencew.grf (md5sum matches)
Added NewGRF: GRF ID 6D620401, checksum C5ACB6D5536A464FD78871D91840A35F, filename: dbsetxlw.grf (md5sum matches)
Added NewGRF: GRF ID 6D620403, checksum 088F2C57616F12A732A3025F5E997F80, filename: dbxl_firs.grf (md5sum matches)
Added NewGRF: GRF ID 44550001, checksum A383C2108661E1840A6FD23F5D8957DD, filename: germanrvw.grf (matches GRFID only)
Added NewGRF: GRF ID 42010000, checksum 6FE46BEACFA8B4191B9F8FEAEFBE819F, filename: gersignw.grf (md5sum matches)
Added NewGRF: GRF ID 44573553, checksum CB054F670BDBCF6CE57FB7F37D7EF5FE, filename: dwe_newobj.grf (md5sum matches)
Added NewGRF: GRF ID 44573452, checksum 39A1EB2C5FE2AD2164C807DDE631B3DD, filename: dwe_stat_r.grf (matches GRFID only)
Added NewGRF: GRF ID 4D656F17, checksum 8A4F8A04256C90BECF818D134C91C816, filename: 4LVw.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 0AE10AAC0C43918147FB411CD4D712EB, filename: fish.grf (matches GRFID only)
Added NewGRF: GRF ID 41501202, checksum 1B96AB1BA5AE3C403C4C664EDFF2C1BE, filename: heqs.grf (matches GRFID only)
Added NewGRF: GRF ID 4946424C, checksum 277B92187F074918F46CE65FD6D440EC, filename: hotairballoon.grf (md5sum matches)
Added NewGRF: GRF ID 44503000, checksum C16D1EFB187C98410B162C971A397CE8, filename: jptracks.grf (md5sum matches)
Added NewGRF: GRF ID 6D620C00, checksum C79E400CDDAF4610BC8613199D08933E, filename: marico.grf (md5sum matches)
Added NewGRF: GRF ID 44450004, checksum D173807A8A9A8A591552C3BC35E9FBEB, filename: mlss052.grf (md5sum matches)
Added NewGRF: GRF ID 4672780A, checksum B4E2FB43C2CCD3E26F4524E45DFEE4AF, filename: monkeybarbridge.grf (md5sum matches)
Added NewGRF: GRF ID 6D620004, checksum 70649F1AFC954942173B0AA89C1E8B14, filename: newshipsw.grf (md5sum matches)
Added NewGRF: GRF ID 6D620601, checksum 537A2B9E5F0644BC360248B2B802D086, filename: newstats.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum DD8430D9CAFECEB7830DDBF92A1C2B0B, filename: ogfx-landscape.grf (matches GRFID only)
Added NewGRF: GRF ID 47541003, checksum 20CF2D86E0CF5ED3465A1C9BE3285957, filename: rusplanesottd.grf (md5sum matches)
Added NewGRF: GRF ID 49464E4F, checksum BAC22546C151037276AA7775F17AB3A9, filename: SNO-Supercheese'sNewObjects.grf (md5sum matches)
Added NewGRF: GRF ID 504A0105, checksum CE85335D194874E2743ED938E2C825C1, filename: ISRoverlap.grf (md5sum matches)
Added NewGRF: GRF ID 504A0106, checksum 45F465A20FB7A43EFA2E6D4E1A70A42B, filename: ISR_objects_v1_4.grf (md5sum matches)
Added NewGRF: GRF ID 53430101, checksum B62CFBA0EBF356B0E27ECCA89366464C, filename: sacsobjects1w.grf (md5sum matches)
Added NewGRF: GRF ID 4D4D9910, checksum B692C8F66B0AF0346067E8A9FAF3660E, filename: the_lighthouse_set_v1.0.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum F3A0A556505B7A94733D85B892C2070C, filename: swehouses.grf (md5sum matches)
Added NewGRF: GRF ID 56430001, checksum 2B67D5836DDFE0E2CC2454E1540A85F2, filename: ttrs3w.grf (md5sum matches)
Added NewGRF: GRF ID 52453400, checksum A137F69178047E05260C7E886A689E1D, filename: jpbuild.grf (md5sum matches)
Added NewGRF: GRF ID 57A50001, checksum 318F3C3F17CA68EAD533BAC88B093094, filename: was.grf (md5sum matches)
Added NewGRF: GRF ID 415A0101, checksum 9BFBC924B18D42D7F564E7CD6237981D, filename: wsfferryset.grf (md5sum matches)
Added NewGRF: GRF ID 415A0701, checksum AFFD2D15EA23F8A95A50EA5FDFC4D84E, filename: arrs_objects.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 50530401, checksum 5EB6D48B4715F3F2733A5C702D4CAA69, unknown GRF
Added NewGRF: GRF ID 4A5A0301, checksum 70927A4333FE2B2F62FC03C570163E76, filename: fakeapV2.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0102, checksum B8D83E093D8BDB400B1CD0555E747C33, filename: dutchtramset.grf (md5sum matches)
Added NewGRF: GRF ID 46727800, checksum 3B58B9177D1A1B54D356F64B93526116, filename: SMITS.grf (md5sum matches)
Added NewGRF: GRF ID 46727803, checksum 3A011F33641913D8520C3CF9833D6947, filename: shanghaitransrapid.grf (md5sum matches)
Added NewGRF: GRF ID 24251D2C, checksum D651DD34D8F6F27712B309A693860859, filename: Hungarian Truck Set 0.3l.GRF (md5sum matches)
Tick 1280: GRF config changed
Added NewGRF: GRF ID 44508550, checksum D779074A639801344D5D7CAEE4990D6C, filename: SBBset.grf (md5sum matches)
Tick 1280: GRF config changed
GRF parameter changed: GRF ID 44503000, filename: jptracks.grf (md5sum matches)
Tick 15582: GRF config changed
Added NewGRF: GRF ID 74677462, checksum 2A7BF147645EFB9565FD6535B619E784, filename: jpbridges.grf (md5sum matches)
Tick 15582: GRF config changed
GRF order changed: 74677462 moved 10 places downGRF ID 74677462, filename: jpbridges.grf (md5sum matches)
Added NewGRF: GRF ID 74677462, checksum E2B89B35B6CC3F9A464B36DC7CA7CD0D, filename: total_bridges_nar.grf (md5sum matches). Gamelog inconsistency: GrfID was already added!
Tick 15582: GRF config changed
GRF parameter changed: GRF ID 56430001, filename: ttrs3w.grf (md5sum matches)
Tick 18667: GRF config changed
GRF parameter changed: GRF ID 56430001, filename: ttrs3w.grf (md5sum matches)
Tick 27084: settings changed
Setting changed: vehicle.plane_speed : 4 -> 3
Tick 27091: settings changed
Setting changed: vehicle.plane_speed : 3 -> 2
Tick 27111: settings changed
Setting changed: vehicle.plane_speed : 2 -> 1
Tick 27613: settings changed
Setting changed: station.never_expire_airports : 0 -> 1
Tick 42010: GRF config changed
GRF order changed: 6D620601 moved 19 places upGRF ID 6D620601, filename: newstats.grf (md5sum matches)
GRF order changed: F1250005 moved 2 places downGRF ID F1250005, filename: firs.grf (matches GRFID only)
Added NewGRF: GRF ID 4D50006A, checksum 75A9885D1A6494759243A60B434E9552, filename: iorestat.grf (md5sum matches)
Tick 25981: GRF config changed
Added NewGRF: GRF ID 9787EA81, checksum 344D22B14325AA88CA1D7B1272C1A7AC, filename: CanStn.grf (md5sum matches)
Tick 15339: GRF config changed
GRF parameter changed: GRF ID 4A430002, filename: indstatr.grf (matches GRFID only)
Tick 15339: GRF config changed
GRF order changed: 6D620601 moved 1 places downGRF ID 6D620601, filename: newstats.grf (md5sum matches)
Tick 15339: GRF config changed
GRF order changed: 6D620601 moved 1 places downGRF ID 6D620601, filename: newstats.grf (md5sum matches)
Tick 15339: GRF config changed
GRF parameter changed: GRF ID 4A430002, filename: indstatr.grf (matches GRFID only)
Tick 14229: GRF config changed
GRF parameter changed: GRF ID 9787EA81, filename: CanStn.grf (md5sum matches)
Tick 60239: game loaded
Missing NewGRF: GRF ID F1250005, filename: firs.grf (matches GRFID only)
Tick 60239: GRF config changed
Added NewGRF: GRF ID F1250005, checksum 61579C2EF19209EEAE3416B4F9263D5E, filename: firs.grf (matches GRFID only)
Tick 11376: GRF config changed
Compatible NewGRF loaded: GRF ID 74677462, checksum 96C5D349E24E8078555F42EFAAC3124E, filename: total_bridges_TTRS3.grf (md5sum matches)
Tick 11376: GRF config changed
GRF parameter changed: GRF ID 4E480101, filename: nhfoundationsw.grf (md5sum matches)
Tick 11376: GRF config changed
GRF parameter changed: GRF ID 4E480101, filename: nhfoundationsw.grf (md5sum matches)
Tick 11376: GRF config changed
GRF order changed: 4E480101 moved 32 places downGRF ID 4E480101, filename: nhfoundationsw.grf (md5sum matches)
Tick 17828: game loaded
Revision text changed to r27077, savegame version 194, not modified, _openttd_newgrf_version = 0x150069c5
Tick 21046: GRF config changed
GRF parameter changed: GRF ID 41533031, filename: swehouses.grf (md5sum matches)
Tick 5998: GRF config changed
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: ogfx-airports.grf (md5sum matches)
Added NewGRF: GRF ID 54470203, checksum F84B6D37659F23D19E176C99BC48DEF6, filename: airportobjects.grf (md5sum matches)
Tick 5998: GRF config changed
Removed NewGRF: GRF ID 9787EA81, filename: CanStn.grf (md5sum matches)
Tick 51321: game loaded
Compatible NewGRF loaded: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: indstatr.grf (md5sum matches)
Tick 57081: GRF config changed
GRF parameter changed: GRF ID 6D620C00, filename: marico.grf (md5sum matches)
Tick 57081: GRF config changed
GRF order changed: 6D620C00 moved 17 places upGRF ID 6D620C00, filename: marico.grf (md5sum matches)
Tick 60571: game loaded
Compatible NewGRF loaded: GRF ID 4F472B34, checksum D391F0A86BBE443111CEFB1A3972A233, filename: ogfx-landscape.grf (matches GRFID only)
Tick 58387: GRF config changed
Added NewGRF: GRF ID 53541101, checksum ECB758CAF23442BC55A0976A3EEEF1DB, filename: infra_streets1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53541119, checksum 2DB55BAA1D2B2538D5C7B5BA9AEE4CB9, filename: infra_streets1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID 53541129, checksum 4E54EB92FBD36275FE8DFEE4E328A782, filename: infra_streets1x1_p3.grf (md5sum matches)
Tick 58387: GRF config changed
GRF order changed: 53541101 moved 34 places upGRF ID 53541101, filename: infra_streets1x1_p1.grf (md5sum matches)
GRF order changed: 53541119 moved 35 places upGRF ID 53541119, filename: infra_streets1x1_p2.grf (md5sum matches)
GRF order changed: 53541129 moved 36 places upGRF ID 53541129, filename: infra_streets1x1_p3.grf (md5sum matches)
Removed NewGRF: GRF ID 53541101, filename: infra_streets1x1_p1.grf (md5sum matches)
Removed NewGRF: GRF ID 53541119, filename: infra_streets1x1_p2.grf (md5sum matches)
Removed NewGRF: GRF ID 53541129, filename: infra_streets1x1_p3.grf (md5sum matches)
Tick 17053: GRF config changed
Removed NewGRF: GRF ID 4A5A0301, filename: fakeapV2.grf (md5sum matches)
Tick 60526: GRF config changed
Added NewGRF: GRF ID 53441101, checksum 3E2397532428AB013862B22EDBB396E5, filename: infra_green1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53441119, checksum 4201D77058BC82C4F2DC0294AFBA6DC3, filename: infra_green1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID 53441129, checksum 9CF044DD9054F863295D5AA8A1671999, filename: infra_green1x1_p3.grf (md5sum matches)
Tick 17733: game loaded
Revision text changed to r27261, savegame version 194, not modified, _openttd_newgrf_version = 0x16006a7d
Compatible NewGRF loaded: GRF ID 4F472B34, checksum 00AF396CAF13DEAD1613749CDB1541EB, filename: ogfx-landscape.grf (md5sum matches)
Tick 17733: GRF config changed
Added NewGRF: GRF ID 504A0101, checksum E0D445CA409BC9FFC937F5A9E772D003, filename: seaplaneairport_v1_2.grf (md5sum matches)
Tick 17733: game loaded
Compatible NewGRF loaded: GRF ID F1250005, checksum 43DF754FDA276363086FCF25008F20D5, filename: firs.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 44550001, checksum 57CFF33C80D650C6317D31DCC45483C9, filename: germanrvw.grf (md5sum matches)
Missing NewGRF: GRF ID 44573452, filename: dwe_stat_r.grf (matches GRFID only)
Compatible NewGRF loaded: GRF ID 414E0201, checksum 2ADD4E518A1AD4C0CB82CC30623B2CFF, filename: fish.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 41501202, checksum B13DD8FB0D7C34CACAC2FE68BD137BB9, filename: heqs.grf (md5sum matches)
Missing NewGRF: GRF ID 50530401, unknown GRF
Tick 17733: GRF config changed
Added NewGRF: GRF ID 44578619, checksum B30A5E35634A59D2BDD9C2389CEDBF2C, unknown GRF
Tick 17733: GRF config changed
Added NewGRF: GRF ID 44573452, checksum 48CF5FC0DEB895136F337A7E563FC66D, filename: dwe_stat_r.grf (md5sum matches)
Tick 17733: GRF config changed
Removed NewGRF: GRF ID 44578619, unknown GRF
Tick 38001: GRF config changed
Added NewGRF: GRF ID 504A4641, checksum 457DE3A141B99D6BE258981C993B6761, filename: fakeairportobjects_v0_1.grf (md5sum matches)
Tick 55448: GRF config changed
Added NewGRF: GRF ID 48570101, checksum 2A1BF6BF856AA6DACD162703280E2029, filename: tars_mountain_lifts.grf (md5sum matches)
Tick 480: game loaded
Revision text changed to r27357, savegame version 194, not modified, _openttd_newgrf_version = 0x16006add
Tick 39673: game loaded
Revision text changed to jgrpp-0.1.1, savegame version 194, not modified, _openttd_newgrf_version = 0x16006afa
Tick 2795: game loaded
Revision text changed to jgrpp-0.2.0, savegame version 194, not modified, _openttd_newgrf_version = 0x16006afd
Tick 21236: game loaded
Revision text changed to jgrpp-0.5.1, savegame version 194, not modified, _openttd_newgrf_version = 0x16006b03
Tick 43093: game loaded
Revision text changed to jgrpp-0.5.2, savegame version 194, not modified, _openttd_newgrf_version = 0x16006b0a
Tick 29322: game loaded
Revision text changed to jgrpp-0.5.3, savegame version 194, not modified, _openttd_newgrf_version = 0x16006b0b
Tick 37043: settings changed
Setting changed: economy.station_noise_level : 0 -> 1
Tick 37530: GRF config changed
GRF parameter changed: GRF ID 4672780A, filename: monkeybarbridge.grf (md5sum matches)
Tick 37530: GRF config changed
GRF parameter changed: GRF ID 46727800, filename: SMITS.grf (md5sum matches)
Tick 37530: GRF config changed
GRF parameter changed: GRF ID 46727800, filename: SMITS.grf (md5sum matches)
Tick 37530: GRF config changed
GRF parameter changed: GRF ID 46727800, filename: SMITS.grf (md5sum matches)
Tick 37530: GRF config changed
GRF parameter changed: GRF ID 46727800, filename: SMITS.grf (md5sum matches)
Tick 37530: GRF config changed
GRF parameter changed: GRF ID 46727800, filename: SMITS.grf (md5sum matches)
Tick 37530: GRF config changed
GRF order changed: 46727800 moved 20 places upGRF ID 46727800, filename: SMITS.grf (md5sum matches)
Tick 37539: GRF config changed
GRF order changed: 46727800 moved 20 places downGRF ID 46727800, filename: SMITS.grf (md5sum matches)
Tick 37547: GRF config changed
GRF parameter changed: GRF ID 46727800, filename: SMITS.grf (md5sum matches)
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] ??? 0x7C812FD3 RaiseException + 82
[01] ??? 0x00570118
[02] ??? 0x77C36BC1 abort + 14

*** End of additional info ***
Attachments
crash.png
(401.27 KiB) Not downloaded yet
crash.sav
(3.08 MiB) Downloaded 129 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

ISA wrote:I am not sure what caused the crash. If its not in the patch let me know and I do the proper post where needed
If you can remember, did the crash occur when you pressed the "Buy Vehicle" button, or did it occur when you did something else?
From the screenshot I'm guessing it's the buy and refit patch, but I'll have to look in more detail tomorrow.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: JGR's Patch Pack

Post by ISA »

JGR wrote:
ISA wrote:I am not sure what caused the crash. If its not in the patch let me know and I do the proper post where needed
If you can remember, did the crash occur when you pressed the "Buy Vehicle" button, or did it occur when you did something else?
From the screenshot I'm guessing it's the buy and refit patch, but I'll have to look in more detail tomorrow.
If I am correct I was start buying this highlighted road vehicle in the buy menu. If that's not it then second guess would be that I was starting to give orders to a vehicle, but if I look to the picture I haven't bought any metal road vehicles... so this kinda rules thing out.
User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

ISA wrote:If I am correct I was start buying this highlighted road vehicle in the buy menu. If that's not it then second guess would be that I was starting to give orders to a vehicle, but if I look to the picture I haven't bought any metal road vehicles... so this kinda rules thing out.
The problem appears to be that the cost estimation is incorrect for articulated/multi-head vehicles where there is a non-zero cost for refitting the trailing vehicle parts.
This should be fixed in the next release, thanks for the bug report.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
JGR
Tycoon
Tycoon
Posts: 2565
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

JGR wrote:
ISA wrote:If I am correct I was start buying this highlighted road vehicle in the buy menu. If that's not it then second guess would be that I was starting to give orders to a vehicle, but if I look to the picture I haven't bought any metal road vehicles... so this kinda rules thing out.
The problem appears to be that the cost estimation is incorrect for articulated/multi-head vehicles where there is a non-zero cost for refitting the trailing vehicle parts.
This should be fixed in the next release, thanks for the bug report.
This is now available in v0.6.0 in the first post, along with some other fixes.
Ex TTDPatch Coder
Patch Pack, Github
Auge
Director
Director
Posts: 639
Joined: 23 Oct 2006 02:07
Location: Berlin

Re: JGR's Patch Pack

Post by Auge »

Hello

I tried to compile the version 0.6.0 and ended (within a few output lines) with an error.

Code: Select all

auge@Desktop:~/OpenTTD/JGR/jgrpp$ make
make[1]: Verzeichnis »/home/auge/OpenTTD/JGR/jgrpp/objs/lang« wird betreten
[LANG] Compiling string.cpp
[LANG] Compiling and Linking strgen
strgen_base.o: In Funktion `StringReader::ParseFile()':
strgen_base.cpp:(.text+0x1b10): Nicht definierter Verweis auf `strecpy(char*, char const*, char const*)'
strgen_base.cpp:(.text+0x1b24): Nicht definierter Verweis auf `strecpy(char*, char const*, char const*)'
strgen_base.cpp:(.text+0x1b38): Nicht definierter Verweis auf `strecpy(char*, char const*, char const*)'
strgen.o: In Funktion `mkpath(char*, char const*, char const*, char const*)':
strgen.cpp:(.text+0x14): Nicht definierter Verweis auf `strecpy(char*, char const*, char const*)'
strgen.cpp:(.text+0x48): Nicht definierter Verweis auf `strecpy(char*, char const*, char const*)'
strgen.o:strgen.cpp:(.text+0xd43): Weitere nicht definierte Verweise auf `strecpy(char*, char const*, char const*)' folgen
collect2: error: ld returned 1 exit status
make[1]: *** [strgen] Fehler 1
make[1]: Verzeichnis »/home/auge/OpenTTD/JGR/jgrpp/objs/lang« wird verlassen
make: *** [all] Fehler 1
auge@Desktop:~/OpenTTD/JGR/jgrpp$
"Nicht definierter Verweis auf ..." means "undefined reference to ...", OS is Ubuntu 14.04. Hope, it helps.

Tschö, Auge
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 2 guests