Mass orders/grouping interface

[Nickel_Plate]

Tried to compile diff r8288 with nightly r8288 getting a load of errors see attached

[l_Blue_l]

I think you just need to add the new source files to your project and that should solve the problem.

example, src/group_cmd.cpp

[Maedhros]

You can just add group_cmd.cpp (and any other new files) to source.list which is enough for the Makefile, and then run projects/generate to update the MS compiler project files.

[Nickel_Plate]

All the files are in the directory.

Using Cygwin to compile

[nycom]

Hello,

I updated the patch against r8332.
Now the group are working with all vehicles type.

[l_Blue_l]

I think there could be a possible problem with the create rename delete buttons now as they are small and it may be hard to fit translations into the smaller space.

A possible way to fix this is to have an Options menu either at the top or bottom of the gui with Create Rename and Delete.

Another idea is to have the other Manage List changed into a Manage Group(?) so it would be possible to Delete and/or Rename the Group for the other menu.

Edit: The All Trains group doesn't stand out that much from all the other group so maybe the other groups could be tabbed in so that All trains is clearly the main group with all the other vehicles subgroups.

That brings me onto my next idea Groups for Groups and the so it would act much like a tree where you can expand the group out each time adding a tab to the next subgroup. This will have to wait till Groups get included into the trunk and it is already a large enough patch as it is.

Btw Great Patch.

[Nickel_Plate]

Have now managed to compile latest diff r8332 with nightly r8332 by manually editing source list, i think this should be in diff file.

I am still getting a few errors, i think this as to do with this patch.

Compiled this diff ONLY with trunk, see attached.

[nycom]

I use VC2005 and it doesn't report these warnings during the compilation.

As it's just warnings, you can build the exe.

[skidd13]

At first awesome patch!!!
EDIT: cause double posts are not nice!
I tried to compile the patch with trunk on my Linux (gcc-4.1) and got those lines.

Code: Select all

...

EDIT2: I forgot to add "group_cmd.cpp,group.h,group_gui.h,group_gui.cpp" in the "source.list"

I think there could be a possible problem with the create rename delete buttons now as they are small and it may be hard to fit translations into the smaller space.

What about some icons?

1st row: ignore this
2nd row: create group
3rd row: delete group
4th row: (re)name group
5th row: replace protection off
6th row: replace protection on

[nycom]

You have to add group_cmd.ccp and group_gui.cpp to the source.list file

Your icons looks great. Maybe you can use the replace icon (in the depot gui) for the replace protection button.

I update the gui to have an idea. I think it's the final gui of my patch.

[skidd13]

You have to add group_cmd.ccp and group_gui.cpp to the source.list file

Did that and added the header also. Damned, I should have known.

Your icons looks great. Maybe you can use the replace icon (in the depot gui) for the replace protection button. I update the gui to have an idea. I think it's the final gui of my patch.

Thanks, I thought over something like the attached mockup. Besides, the funny thing is you use icon's also drawn by me.

Edit: Added the redrawn replace icons!

[nycom]

Why not mix the replace icon with a shield ?

[skidd13]

Why not mix the replace icon with a shield ?

For constancy it should stay the same. Either the shield or the replace arrow. It is OTTD Style to keep things in same style, that was also the reason why the dynamite was replaced by the multiple trains in the depot-gui.

[nycom]

Of course. But in fact, they don't have the same function. The purpose of the replace protection is to protect all vehicles from a group to be replace by the global auto replace.
That's why I suggested you to add a shield to your icon.

Can you please make a grf with your icons ?

Thanks.

[richk67]

I would suggest putting the shield in the top left of the icon. Players will still recognise the up arrow as being Replace These Now, and the shield then lets you know it is Protected. I really like these icons.

[skidd13]

I would suggest putting the shield in the top left of the icon. Players will still recognise the up arrow as being Replace These Now, and the shield then lets you know it is Protected. I really like these icons.

Nice idea. Here is the result. I prefer the second row cause the intent is a bit clearer to me. GRF will follow.

[skidd13]

Can you please make a grf with your icons ?

Here is the grf and a png so you don't have to extract it to check the order.

[richk67]

Nice... I can just imagine the autoreplace toggling between enabled (arrow is yellow - no shield), and disabled (arrow is grey, with shield). It should be an obvious toggle, and immediately apparent as an on/off.

Only possible confusion is the "normal" autoreplace button is identical to the Do Autoreplace in the depot gui. So people may think "I click this to make these go for autoreplace", whereas I think the idea is to say "autoreplace is active for this list".

Maybe have the shield icon on the "normal" version, but with the shield in grey (and red cross?). This would then clearly be slightly different to the "Do Autoreplace" button, and would hopefully say "Shield or Do Not Shield the AutoReplace"... which is the meaning we want.

Look great though... I must say I LOVE the icons in the depot. Makes so much more sense than dustbins and explosions.

[skidd13]

Only possible confusion is the "normal" autoreplace button is identical to the Do Autoreplace in the depot gui. So people may think "I click this to make these go for autoreplace", whereas I think the idea is to say "autoreplace is active for this list".

They are not the same, but similar. The vehicles behind the top one are grey. But I got your point!

Look great though... I must say I LOVE the icons in the depot. Makes so much more sense than dustbins and explosions.

Thanks, take a cookie.

[nycom]

Hello,

Here you can find the lastest update of my patch (r8375).


Features :
- Add a vehicle to a group : on the right side, click on a train and drag and drop over a group.
- Delete a vehicle from a group : on the right side, click on a train, and drag and drop over the group "All trains" or "All Road Vehicles"...
- Change a vehicle from a group : on the right side, click on a train and drag and drop over an other group.
- When you click on a group name, you can see all vehicles which are in this group (screenshot).
- You can't rename or delete the group "All trains" or "All Road Vehicles" or "All Ships" or "All Aircrafts".
- The groups are load/save.
- You can set an autoreplace which only affect the vehicles of the group. The global autoreplace override this feature unless you set "replace protection" to on (4th button on the left side)

- On the left side :

• - Create a group : press the "create" button.
  - Delete a group : select a group and press the "delete" button.
  - Rename a group : select the group you want to rename, then press the "rename" button.
  - Replace Protection, if on, global autoreplace have no effect on the group.

- On the right side :

• - Start all Click on the green flags to start all
  vehicles of the current group.
  - Stop all Click on the red flags to stop all vehicles of the current group.
  - Manage list :
  • - Send to depot all vehicles of a group.
    - Send for servicing all vehicles of a group.
    - Add Shared Vehicles to a group : add all shared vehicles of all vehicles of the group.
    - Remove all Vehicles from a group : Remove all vehicles from the current group.
    - Replace Vehicles : replace management

I upgrade SAVEGAME_VERSION to 45, so don't overwrite your savegame.

Thanks to skidd13 for the icons and grf.