[Patch] Departure boards, 24h clock + binary 25 (r27452)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Bot_40
Engineer
Engineer
Posts: 105
Joined: 27 Jan 2005 18:56
Contact:

Re: [Patch] Departure boards, 24h clock + binary

Post by Bot_40 » 05 Nov 2011 10:07

My only complaint is that it's not very realistic (most of the trains are on time :P)

Grandmaster
Engineer
Engineer
Posts: 72
Joined: 11 Feb 2007 21:10
Location: Rotterdam, Netherlands

Re: [Patch] Departure boards, 24h clock + binary

Post by Grandmaster » 05 Nov 2011 11:07

Bot_40 wrote:My only complaint is that it's not very realistic (most of the trains are on time :P)
That only means that you are a master planner. :bow:

classics_prof
Engineer
Engineer
Posts: 36
Joined: 21 Jan 2011 17:45

Re: [Patch] Departure boards, 24h clock + binary

Post by classics_prof » 07 Nov 2011 11:30

Anyone capable of creating a binary for idiots like me to be able to use? :oops:

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 07 Nov 2011 12:34

classics_prof wrote:Anyone capable of creating a binary for idiots like me to be able to use? :oops:
I'll make one this evening. :)

Edit: done, see first post of thread.

classics_prof
Engineer
Engineer
Posts: 36
Joined: 21 Jan 2011 17:45

Re: [Patch] Departure boards, 24h clock + binary

Post by classics_prof » 08 Nov 2011 08:18

Thank you! :lol:

class 350
Engineer
Engineer
Posts: 6
Joined: 07 Oct 2011 19:11

Re: [Patch] Departure boards, 24h clock + binary

Post by class 350 » 08 Nov 2011 18:28

sorry but how do I install this add on ? :oops:

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 08 Nov 2011 19:04

class 350 wrote:sorry but how do I install this add on ? :oops:
If you're on Windows, you can just download the win32 binary from the first post of this thread, extract it, go to the folder you extracted it to and run openttd.exe. (You may need to download OpenGFX and put it in the data folder if you don't already have it - you can get it from http://www.openttd.org/en/download-opengfx.)

If you want to compile it yourself, the wiki can help you do this - see http://wiki.openttd.org/Category:Compiling_OpenTTD for help. Once you have the source but before you compile it you'll need to apply the patch - to do this download the diff from the first post of this thread and do e.g.

Code: Select all

patch -p1 < diff_filename
in the source directory.

classics_prof
Engineer
Engineer
Posts: 36
Joined: 21 Jan 2011 17:45

Re: [Patch] Departure boards, 24h clock + binary

Post by classics_prof » 10 Nov 2011 09:50

Sorry hthhs but I'm having problems with your latest binary - it's headed rev0000 in the OTTD screen (top left) whereas the previous one had r22733M. Is it just me being an idiot?

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 10 Nov 2011 17:03

My guess is that it's due to me having started using git instead of svn. I don't think it should affect gameplay - does it work ok apart from the title bar?

User avatar
ChillCore
Tycoon
Tycoon
Posts: 2658
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: [Patch] Departure boards, 24h clock + binary

Post by ChillCore » 10 Nov 2011 22:55

rev0000
Looks to me like you lost version control though instead of the problem being with Git.

How did you obtain the source code htths?
Did you clone a repository or did you download a zip with the source and extracted that?
If you downloaded a zip and patched that then indeed you have no version control anymore and you will most likely have trouble updating your source to current trunk also.

You should really clone the source and continue from there if you did not.

Code: Select all

git clone http://git.openttd.org/openttd/trunk.git
To get the current source into the current directory and under version control. ;)
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 10 Nov 2011 23:29

That's the command I used.

Hmm... would me being on a branch cause it to happen? I keep the patch on a separate branch so that I can rebase it easily against updates to trunk, and so that I can have other branches for other patches if I ever make any. Keeping the master branch updated to trunk with git pull works fine.

If it matters, I use Visual Studio C++ Express 2008 to create win32 builds. The title string is displayed correctly when I build and run in Ubuntu.

User avatar
ChillCore
Tycoon
Tycoon
Posts: 2658
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: [Patch] Departure boards, 24h clock + binary

Post by ChillCore » 10 Nov 2011 23:54

I can not help you with Visual Studio as I was used to MinGW/MSYS a long time ago. (Ubuntu only since two years)
Being on a branch should not cause this ... instead the revision would have the branch name.

I do have a windows XP HDD but nothing is on there but games that do not run on linux.
I guess I could make the effort if really needed but it is a lot to install for something I will never use.
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 11 Nov 2011 00:03

I'm not especially concerned about it as long as the binary otherwise functions correctly. I tested it briefly and it seemed to work. Don't go inflicting Visual Studio on your poor machine! :P

Eddi
Tycoon
Tycoon
Posts: 7415
Joined: 17 Jan 2007 00:14

Re: [Patch] Departure boards, 24h clock + binary

Post by Eddi » 11 Nov 2011 00:14

missing version information will prevent people from playing multiplayer, even if the binaries are "correct" otherwise.

in VS, the version detection is done by "projects/determineversion.vbs", which probably fails somehow in your case. maybe it fails to find a program to execute, or maybe it gets data it cannot process.
You might not exactly be interested in Ferion, but if you are, have fun :)

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 11 Nov 2011 00:20

Oh, fun.

I'll cook up a Windows build shortly using the method I used to use.

Eddi
Tycoon
Tycoon
Posts: 7415
Joined: 17 Jan 2007 00:14

Re: [Patch] Departure boards, 24h clock + binary

Post by Eddi » 11 Nov 2011 00:25

that's not going to work properly either, since linux builds will then get a git-version, while the windows build would get an svn-version, so they won't be compatible between each other either.

the proper approach would be to debug, why the version script doesn't work for you.
You might not exactly be interested in Ferion, but if you are, have fun :)

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 11 Nov 2011 00:29

Won't it depend on how Linux users get the source before applying the patch, i.e. if they use svn then they'll get a build with an svn revision number and if they use git they'll get a git commit hash?

Michi_cc
OpenTTD Developer
OpenTTD Developer
Posts: 592
Joined: 14 Jun 2004 23:27
Location: Berlin, Germany
Contact:

Re: [Patch] Departure boards, 24h clock + binary

Post by Michi_cc » 11 Nov 2011 00:44

"projects/determineversion.vbs" only works if it can find a git.exe in your PATH. msysgit for example allows you to select if git should be added to the PATH, so I guess you didn't select that option. Or if you use cygwin git, you don't have your cygwin bin dir in the PATH.

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 11 Nov 2011 01:01

That's good to know, thank you.

I've posted a fixed binary in the first post of the thread made from a subversion checkout.

hthhs
Engineer
Engineer
Posts: 107
Joined: 03 Sep 2010 12:58
Location: London, UK

Re: [Patch] Departure boards, 24h clock + binary

Post by hthhs » 22 Jan 2012 14:14

I've added the ability to enter timetable start dates as text (in hhmm format) instead of using the date gui when "Show time in minutes rather than days" is enabled. Enable Interface > "Enter timetable start times as text ..." to do this.

Any leading zeroes in the time may be omitted, so e.g. 0120 may be entered as 120, and 0005 may be entered as 5.

The first post in the thread has been updated with the new diff. Enjoy! :)

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Bing [Bot] and 1 guest