[Patch] Industry Station Names (v1; r12436)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

peter1138
OpenTTD Developer
OpenTTD Developer
Posts: 1646
Joined: 30 Mar 2005 09:43

Re: [Patch] Industry Station Names (r12044)

Post by peter1138 » 04 Feb 2008 09:27

Arrrr, fair enough.
He's like, some kind of OpenTTD developer.

a.locritani
Engineer
Engineer
Posts: 111
Joined: 08 Feb 2007 11:59
Skype: a.locritani
Location: Italy

Re: [Patch] Industry Station Names (v1; r12436)

Post by a.locritani » 15 Nov 2008 16:28

Sorry for resurrecting this post: I only want to signal that with a big help of Micheal Blunk, I wrote a grf that does (almost) what your patch does. I know that now it's doesn't works for OTTD, but when property 24 is implemented, I hope it can be useful.

User avatar
Vaulter
Traffic Manager
Traffic Manager
Posts: 185
Joined: 21 Dec 2004 05:35
Skype: andrey-zaharov
Location: St. Petersburg, Russia
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by Vaulter » 11 Aug 2010 22:26

a.locritani wrote:Sorry for resurrecting this post: I only want to signal that with a big help of Micheal Blunk, I wrote a grf that does (almost) what your patch does. I know that now it's doesn't works for OTTD, but when property 24 is implemented, I hope it can be useful.
Please note that this grf is not intended to be used with another industries' grf - only use it with default industries (thanks Michael for pointing it out)
But, judging by posts in this threads, this patch works with any industries

User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by Gremnon » 11 Aug 2010 22:55

It's also 2 years old, and over 8000 revisions out of date.
Which would seem to make it rather obsolete all the same.

Yexo
Tycoon
Tycoon
Posts: 3653
Joined: 20 Dec 2007 12:49

Re: [Patch] Industry Station Names (v1; r12436)

Post by Yexo » 11 Aug 2010 22:56

Yes. On the other hand the patch is now nearly 2 years old while that newgrf still works. Also that patch will never be included in trunk (since it can be done by a newgrf). So what exactly is the reason to resurrect this topic?

User avatar
Vaulter
Traffic Manager
Traffic Manager
Posts: 185
Joined: 21 Dec 2004 05:35
Skype: andrey-zaharov
Location: St. Petersburg, Russia
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by Vaulter » 12 Aug 2010 11:14

Yexo wrote:Yes. On the other hand the patch is now nearly 2 years old while that newgrf still works. Also that patch will never be included in trunk (since it can be done by a newgrf). So what exactly is the reason to resurrect this topic?
read carefully. Again:
Please note that this grf is not intended to be used with another industries' grf - only use it with default industries (thanks Michael for pointing it out)

Yexo
Tycoon
Tycoon
Posts: 3653
Joined: 20 Dec 2007 12:49

Re: [Patch] Industry Station Names (v1; r12436)

Post by Yexo » 12 Aug 2010 12:13

Yes, I know that. Did you also read my answer to that?
1. The patch is very old, it needs to be updated to actually work.
2. This patch (even if updated) will never be included in trunk.
3. The newgrf still works, and if you want the same behavior while using industry newgrfs you're better of posting in those newgrf topics to ask them to implement this too.
Who is going to update a patch that has exactly 0 chance of getting in trunk?

User avatar
Vaulter
Traffic Manager
Traffic Manager
Posts: 185
Joined: 21 Dec 2004 05:35
Skype: andrey-zaharov
Location: St. Petersburg, Russia
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by Vaulter » 12 Aug 2010 12:50

Yexo wrote:Yes, I know that. Did you also read my answer to that?
1. The patch is very old, it needs to be updated to actually work.
2. This patch (even if updated) will never be included in trunk.
3. The newgrf still works, and if you want the same behavior while using industry newgrfs you're better of posting in those newgrf topics to ask them to implement this too.
Who is going to update a patch that has exactly 0 chance of getting in trunk?
1. No problem
2. Didn't even mind
3. Ok.

Patch Updated
Attachments
industry-stationnames.patch
against tags/1.0.3
(5.85 KiB) Downloaded 108 times

User avatar
JacobD88
Chief Executive
Chief Executive
Posts: 675
Joined: 16 Aug 2008 17:51
Location: Long Eaton, Nottinghamshire. UK
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by JacobD88 » 12 Aug 2010 15:47

Vaulter wrote:Patch Updated
Thanks vaulter :bow: , this is much more useful to me than requesting that all the NewGRF Industry authors update their GRFs or altering them myself where we are allowed to. It's a shame this is unlikely to make it into trunk. A centralised feature to control station naming by industry is much more appealing to me than having to rely on the GRF authors wanting to include that feature as it gives me control without having to mod GRFs :wink:

User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by Gremnon » 12 Aug 2010 18:00

Out of curiosity, does that patch only apply against 1.0.3, or trunk as well? If trunk plays nice with it, I've got an idea I want to experiment with using this patch.

User avatar
Vaulter
Traffic Manager
Traffic Manager
Posts: 185
Joined: 21 Dec 2004 05:35
Skype: andrey-zaharov
Location: St. Petersburg, Russia
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by Vaulter » 12 Aug 2010 19:12

Gremnon wrote:Out of curiosity
You just should to check. Patch is very simple to have any issues applying to trunk.

User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: [Patch] Industry Station Names (v1; r12436)

Post by Gremnon » 12 Aug 2010 19:43

I'm having a few slight arguments with the computer at the moment that are preventing me from actually checking, which is why I asked. Will check myself soon as I can.

xmirakulix
Engineer
Engineer
Posts: 36
Joined: 06 Jan 2010 18:06

Re: [Patch] Industry Station Names (v1; r12436)

Post by xmirakulix » 11 Dec 2010 10:21

The Patch didn't apply anymore after the changes in
(svn r21444) -Codechange: compute the type of elements in the argv string array on the fly and compare it with the type set by strgen
I am attaching an updated patch against r21459.
Attachments
industry_stationnames_21459.diff
Patch for Industry Station Names against trunk r21459
(6.5 KiB) Downloaded 97 times

xmirakulix
Engineer
Engineer
Posts: 36
Joined: 06 Jan 2010 18:06

Re: [Patch] Industry Station Names (v1; r12436)

Post by xmirakulix » 28 May 2011 16:03

These changes broke the patch:
(svn r22258) -Codechange: introduce a wrapper class to clean up the arguments to FormatString
Attaching the patch against trunk r22502.
Attachments
industry_stationnames_r22502.diff
(6.52 KiB) Downloaded 92 times

xmirakulix
Engineer
Engineer
Posts: 36
Joined: 06 Jan 2010 18:06

Re: [Patch] Industry Station Names (v1; r12436)

Post by xmirakulix » 31 May 2011 17:23

Patch updated to apply against current trunk
Attachments
industry_stationnames_r22502.diff
(6.52 KiB) Downloaded 88 times

xmirakulix
Engineer
Engineer
Posts: 36
Joined: 06 Jan 2010 18:06

Re: [Patch] Industry Station Names (v1; r12436)

Post by xmirakulix » 01 Oct 2011 08:31

Updated to current trunk
Attachments
industry_stationnames_r22958.diff
(6.52 KiB) Downloaded 112 times

R2dical
Traffic Manager
Traffic Manager
Posts: 165
Joined: 18 Mar 2013 22:22

Re: [Patch] Industry Station Names (v1; r12436)

Post by R2dical » 04 Sep 2013 20:57

Update to latest nightly, and also a shot at the coding style used for openttd :)

Edit: Oh yes, I changed the distance from 4 to 3, so stations will get the industry name only if it services the industry.
Attachments
Station_Names_From_Industries_r25754.patch
(5.07 KiB) Downloaded 109 times

frabac
Engineer
Engineer
Posts: 10
Joined: 17 Oct 2013 07:15

Re: [Patch] Industry Station Names (v1; r12436)

Post by frabac » 13 Dec 2013 20:51

Hi there.

I start by thanking you so much because this patch, although not dramatic, is SO nice to have, especially when you have a big map and you want remember where things are: THANK YOU.

And... I bring you good news: I have just applied it to r26156 and it works just fine! Among the many patches I tried, this is the first one that just works without complaining :-)

So, happy transporting everyone! :-)

User avatar
skippern
Traffic Manager
Traffic Manager
Posts: 199
Joined: 30 Oct 2013 13:57

Re: [Patch] Industry Station Names (v1; r12436)

Post by skippern » 19 Jan 2014 22:39

Good enough having the industry type (or resource type) in the station name, but when multiple industries are within the area of a station, names could be {Town} Industries, {Town} Industrial Park, etc.

So we could have the following stations:
Sometown Coal Mines
Sometown Factory
Sometown Power Plant
Sometown Iron Ore
Sometown Farms
Sometown Industries
Sometown Oil Wells
Skippern
OpenTTD Mac user

R2dical
Traffic Manager
Traffic Manager
Posts: 165
Joined: 18 Mar 2013 22:22

Re: [Patch] Industry Station Names (v1; r12436)

Post by R2dical » 22 Jan 2014 10:30

Shouldn't be too hard to add a multiple industries check in, would have to go in just before the added industry check...

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 3 guests