More diesel_smoke patch

[W_neun]

And maybe also a patch that heavily increases the smoke from steam trains?

Despite its name, this patch already has that feature. Next time read the thread before posting replies, please.

[Benny]

heavily increases

Do NOT tell me what to do before you know what you are talking about.. Read my post more carefully next time..

[LaDoncella]

heavily increases

Do NOT tell me what to do before you know what you are talking about.. Read my post more carefully next time..

it's rather trivial to do it.

[Benny]

What? Did you just double the smoke from steam engines like that? I mean, THAT FAST!?

[LaDoncella]

ops, there was an extra "+" in the patch file. and it wouldn't compile

[W_neun]

Thanks for the patch.

Benny:
No need to be so angry!! The "problem" is not that I did not read your post carefully enough (if that is possible with such a short text), but that 'heavily' isn't an exact definition. I thought the smoke in this patch is enough. It would look best with new smoke sprites, but pixel art is totally different from writing a patch, so Sirkoz probably won't do it. Yes, I misunderstood your post, but I think it WAS "misunderstandable", you could have said 'more heavily'. Peace.

[Benny]

Ow, I am sorry.. I just felt like beeing treated like a noob.. Wait, what..?

Edit: And, are you sure that the patch still is correct? I applyed the patch with the latest trunk in TortoiseSVN and got this:

[W_neun]

Despite his/her name, I treat nobody, whom I don't know, like a noob

LaDoncella, did you solve the problems in the patch? I still can't compile with it.

[edit] God, now YOUR post I haven't read carefully. Though it was edited, wasn't it? So it's posible to not read carrefully even such a short post. [/edit]

[Rubidium]

I applyed the patch with the latest trunk in TortoiseSVN and got this:

It wouldn't hurt to read TortoiseSVN's manual. It would've told you that that icon means there is a modified file in that directory, i.e. a file that differs from the official repository. That's kinda the idea when you're patching, right?

[Benny]

Though it was edited, wasn't it?

Very possible, but I don't know for sure.

I applyed the patch with the latest trunk in TortoiseSVN and got this:

It wouldn't hurt to read TortoiseSVN's manual. It would've told you that that icon means there is a modified file in that directory, i.e. a file that differs from the official repository. That's kinda the idea when you're patching, right?

What? But I WANT it to be changed, right?

[LaDoncella]

Ow, I am sorry.. I just felt like beeing treated like a noob.. Wait, what..?

Edit: And, are you sure that the patch still is correct? I applyed the patch with the latest trunk in TortoiseSVN and got this:

when the red exclamation appears means that you have applied a patch. However its true that it doesn't work.

Something has changed and this line doesnt work anymore.

Code: Select all

u->u.rail.cached_max_speed

[Benny]

So the patch does't work?

@ Rubindum again: Do I have to compile OpenTTD too?

[Rubidium]

Do I have to compile OpenTTD too?

Think of the source (code) being a digital document (MS Word, OpenOffice, ... doesn't really matter which editor) and the binary that document printed on paper. Does changing the digital document change the one that is already printed?

Same way you have to (re)compile OpenTTD (or reprint the document).

[Benny]

Okay. Thank you.
I will have a go with Microsoft Visual C++ 2008 Express Edition.

[LaDoncella]

double post

[LaDoncella]

So the patch does't work?

well that piece of code is from SirkoZ

I can change this (the one that doesn't work):

Code: Select all

u->cur_speed < u->u.rail.cached_max_speed

for this one:

Code: Select all

u->cur_speed < u->max_speed

however I'm pretty sure it's a very different variable.

here is the patch, now compilable sorry

[edit]. added the binary

[Benny]

Thank you for your effort, I am really thankful.

Btw: No need to be sorry!

[W_neun]

Did a quick compile, here's a screenshot:

Oh you were even faster LaDoncella

Is_this_enough_for_you_benny.PNG (105.3 KiB) Viewed 5478 times

[Benny]

Awesome!

[SirkoZ]

I totally overlooked/wasn't here to see the topic progress till today...

Not awesome but exaggerated. Those steam puffs were never designed to be put so close together, just doesn't look right.

I'll have a new version of the patch here shortly.

And of course, updaters should not use my name-style for my patch if it's updated and changed. It's NOT _sz_ and it's not 3-0.