Daylength Patch [12/09/2008] Compatibility: r14293

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Which daylength are you playing at?

1-5
53
41%
6-15
27
21%
15+
50
38%
 
Total votes: 130

PhilSophus
Chairman
Chairman
Posts: 776
Joined: 20 Jan 2007 12:08
Location: Germany

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by PhilSophus »

:shock: I'm confused. How can this sprite problem have something to do with the daylength patch?

Or in other words: Are you sure that the same kind of game (e.g. the same NewGRFs loaded) doesn't crash in clean trunk?
"The bigger the island of our knowledge, the longer the shore of our ignorance" - John A. Wheeler, Physicist, 1911-2008
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Gah....
Have a look at the images posted. The problem file is 'spritecahce.cpp'
Which suggests... sprites.

At any rate, it works for me, so I'm not complaining, and no, I don't get the same problem without daylengh.
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

Why is this patch not included in the latsest nightly's ? It's a great patch.

Anyway, Gremnon,

I lost the patch again cause the errors keep on coming, so i downloaded the latest nightly, but off course it hasn't got the daylenght patch.
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Sigh...
I'll recompile a recent one when I can get back to my usual computer... though, it would be useful if you did try to use the wiki to learn again, and read it through...
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

Yeah, i know.

But i did that several times and tryed every compiling program discribed in the wiki, but non of them worked for me.

I'm now playing the Russian bin that is offered somewhere on the forums, it has a couple of patches including the daylenght one. Only thing that is negative that it is not ECS compatible.
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Compiled against r14736
No one ask me to compile any builds for a few weeks, I won't be able to to sort it out for a while.
Attachments
daypatch-r14736.zip
(3.51 MiB) Downloaded 325 times
User avatar
Jim Starluck
Traffic Manager
Traffic Manager
Posts: 135
Joined: 26 Jun 2005 20:12
Location: Cincinnati, OH
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Jim Starluck »

Is this patch ready to be merged into trunk? And if so, why hasn't it yet? IMHO it's one of the most basic, useful patches out there, especially for those of us who like to spend more time in specific time periods (steam power ftw).
If at first you don't succeed, get a bigger locomotive and try again.
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Because it doesn't work with the latest trunk, and (not sure if this is actually a necessity) it hasn't been submitted to flyspray.
Yexo
Tycoon
Tycoon
Posts: 3663
Joined: 20 Dec 2007 12:49

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Yexo »

Gremnon wrote:Because it doesn't work with the latest trunk
That's a problem
, and (not sure if this is actually a necessity) it hasn't been submitted to flyspray.
That doesn't matter, as long as it's noticed (although it's easier to keep track of patches in FS, and they might be forgotten here easier.

Reading back on the previous page however there still seem to be several unsolved problems.
Chico008
Traffic Manager
Traffic Manager
Posts: 143
Joined: 05 Mar 2008 10:56
Location: France

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Chico008 »

Does this patch still in dev ?

could we have a patch file for the R15447 or newer trunk ?

thx.
Chico008
Traffic Manager
Traffic Manager
Posts: 143
Joined: 05 Mar 2008 10:56
Location: France

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Chico008 »

Hi, a friend fo mine managed to do the patch for r15447

he tested and said it worked fine.
you can report if it's ok.
Attachments
daypatch_r15447.diff
(8.76 KiB) Downloaded 200 times
ige
Engineer
Engineer
Posts: 47
Joined: 02 May 2008 17:58

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by ige »

If it works, is there anyone to make a bin? I am a user and tester, not a developer.
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by dihedral »

applying a patch and compiling does not make anybody a developer ;-)
and is the easiest way to help you do all the testing you'd like to do!
Forked
Engineer
Engineer
Posts: 43
Joined: 13 Jan 2008 20:36

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Forked »

Here is the win32 build with cargodest, infrastructure sharing and daylength patches... untested and unsupported.

patched with diff's updated to 15447
Daylength - link here
Cargodest - link here
Infrastructure Sharing - link here

Only three small "conflicts" when patching in daylength .. they were all settings related and easy to spot.

Again. Not tested. Not supported. Best of luck :)
Attachments
openttd-CD-IS-DL-15447M_win32.rar
(3.97 MiB) Downloaded 193 times
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by dihedral »

hehe - that'll get the nekomaster spitting out words again :-D
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by DaleStan »

So, because I was curious[0], I attempted to figure out what exactly this "neko" is over which it has gained mastery.
Apparently, it's some sort of game.

OT: This may explain why its computer keeps overheating.

[0] Pron: "bored to tears"
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
kul
Engineer
Engineer
Posts: 21
Joined: 30 Jun 2005 19:22

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by kul »

I just tried the daylength patch, and I think it's really nice. It seems that costs like Property maintenance, Loan interest and Vehicle running cost were the same on a yearly basis, whereas the income was much higher. Maybe the income from transporting goods should be lowered (divided by the times of slower time, or maybe half of it) or the costs raised (times the speed factor). Is there a reason why this isn't implemented?
sc79
Director
Director
Posts: 586
Joined: 22 Feb 2005 09:51

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by sc79 »

Maybe the income from transporting goods should be lowered (divided by the times of slower time, or maybe half of it) or the costs raised (times the speed factor). Is there a reason why this isn't implemented?
Previous versions has two ingame settings, one for each of these, and I assume it still does (though maybe noone bothered when the settings UI got updated). Check out the advanced settings.
kul
Engineer
Engineer
Posts: 21
Joined: 30 Jun 2005 19:22

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by kul »

sc79 wrote:Previous versions has two ingame settings, one for each of these, and I assume it still does (though maybe noone bothered when the settings UI got updated). Check out the advanced settings.
There was only one, under Economy.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 21 guests