2.6 nightly/alpha discussion

[Rob]

No. The last version I used so far was 1975, and I updated to 2005, which resulted in this warning.
I didn't save the gave there, I just started to find the release that "broke" my game, which turned out to be 1993.

[eis_os]

Can you send me the savegame?

[Rob]

Sure, here it is.

[eis_os]

You had enabled newobjects, the newobjects chunk size has been changed in http://svn.ttdpatch.net/trac/changeset/1989 So your game chunk fails to load.

I will try to add a note about what chunk has failed into the red box

[Rob]

Ok newroutes, so I guess I don't really lose anything when using the latest nightly.
Thanks for looking into it.

[eis_os]

The next nightly version should display the chunk id that fails. loadsave.asm -> knownextrachunkids can be used to convert it to a meaningful feature to decide yourself

[Rob]

Oh, thank you. Don't think I missed much, since I haven't found anything yet.

btw this seems to be a bug which originates also at r1993 as far as I could determine it.

[Rob]

I have my newships carry a lot less cargo lately.
According to the donotreadme for instance the Meyer Livestock Carrier should carry 360 pieces of livestock, which it always did, but now it only carriers 104. Same for the Bulk freighter, which should carry 360 tons, it now only carries 104 tons.
Can't say when it went wrong, only just noticed it but I think it originates somewhere around release 2000. It affects only newly build ships, the old ones still carry the indented amount of cargo.
I now use release 2014.
It also happens when I start a new game.

[michael blunck]

Again, I guess it´s linked with http://svn.ttdpatch.net/trac/changeset/1990.

Lakie?

regards
Michael

[Lakie]

Was that not fixed in r2012?
I'll take a look at it sometime, I don't use newgrf ships, so I'll go find a set for testing purposes.

[Edit] Found and fixed the issue, should be fully fixed for the next nightly.
If you read carefully, you'd notice it does alter the hooks for capacity.

~ Lakie

[Rob]

This has nothing to do with the fix of the ships speed.
It's about the loading capacity.
The speed fix works very nicely, but I don't rest until I find new bugs for you to crush.

[Rob]

I came across another PBS crash.
Train number 48 will enter station " Heinikenszand Woods" without reserving a path through the tunnel, which of course results in a crash.
Train 48 is the one in the picture from which its lower left corner touches the engine.

[JGR]

I am currently looking into this.

It seems to occur only if the advzfunctions and/or trace restrict switches are on.

Will report back later with more news.

[eis_os]

Important notice for DOS Users and the nightly version:

Since TTDPatch r2039 the dos version of ttdpatch understands the win2k switch and will change or better say disable certain functions in TTD Dos so it may work on 32bit Windows 2000/XP maschines.

Sum up:
Disables the sound playback protect mode call. -> If you hear still some sounds you should disable sound via setup.exe
Changes the way the mouse it drawn, this may result in not the nice cursor, but the chances for a crash may be reduced.
Disables the com port enum code -> no com1..4 errors but may crash the network code.

Reference to problems not solvable by TTDPatch:
http://web.archive.org/web/200704070114 ... em_en.html

This work is based on Marcins tests disabling mouse and sound calls.

If you have a windows9x or dos, you should ensure that win2k is set to off.

[JGR]

The bug reported by Rob should be fixed as of r2040.

[Rob]

Thanks, great to hear. Me and my game do thank you.

[Rob]

With the latest release, 2041, my restrictive signaling seems to have disappeared. Trains just go through the signals as if no restriction has been set.
This happens with the same game and settings as posted earlier.

[JGR]

This is turning out to more difficult to fix than it would seem.

My previous commit amongst other things broke trace restriction so that the odd conditions which cause the issue don't arise. Fixed as of r2042.

It seems that this bug is not a new one, as I was able to reproduce it (I had to modify the layout slightly) in r1152, r892 and 2.5 beta 8. I haven't yet tested earlier revisions (don't have them handy ATM).

The PBS code seems to interpret a reserved tunnel exit as an end of route as opclass48hroutemaphnd returns a routemap of zero. If a better route cannot be found by ignoring reserved pieces, the code still opts for the first route. In this circumstance, as all two way entry signals into the station are red, there isn't a "better route".
This seems to be an error somewhere in the tracepath function to me.
chkmarksignalroute seems to be OK AFAICT.

Comments from devs who understand how PBS is supposed to work in these circumstances are welcome...

[eis_os]

Hmm, I do think TTD(Patch) always had an habit to avoid tunnel in routes, so this problem could be a deeper in the TTD(Patch) code. When in doubt with PBS you need to ask Josef.

[WWTBAM]

Important notice for DOS Users and the nightly version:

Since TTDPatch r2039 the dos version of ttdpatch understands the win2k switch and will change or better say disable certain functions in TTD Dos so it may work on 32bit Windows 2000/XP maschines.

Sum up:
Disables the sound playback protect mode call. -> If you hear still some sounds you should disable sound via setup.exe
Changes the way the mouse it drawn, this may result in not the nice cursor, but the chances for a crash may be reduced.
Disables the com port enum code -> no com1..4 errors but may crash the network code.

Reference to problems not solvable by TTDPatch:
http://web.archive.org/web/200704070114 ... em_en.html

This work is based on Marcins tests disabling mouse and sound calls.

If you have a windows9x or dos, you should ensure that win2k is set to off.

DOS TTD starts for me on xp with a clean install. I have not tried starting a game yet though.
edit If I start a new random game ttdpatch seems to randomly crash.