Trains through non-stop stations / Whistle boards

[Dave]

I've been thinking about this and just want to throw it out to the world (mods: I'll also be placing a suggestion in TTDP, don't shout for cross-posting).

Assuming a train knows when it's entering a station (I don't actually know if that's the case), and assuming it knows it's not stopping, could something be done either in a grf or the game system to make the train sound it's horn/whistle as it enters the station? It's not compulsory anymore, but it would be a nice addition.

Also the possibility of building a whistle board (probably like a station, effectively) that causes the train to sound it's whistle or horn when required.

Both pretty empty ideas with very little benefit other than realism, but I thought I'd throw them out there to see if it was easy enough to implement.

[Zhall]

¿

[Toni Babelony]

This subject is quite interesting and I do think it'll be a great addition to TTD, though in a lot of countries this isn't common practice. However, I'm always a foamer for horny trains.

[PantyraiderZ]

Over here in the Boston Metro area, all commuter rails that pass by my station as well as the Downeaster trains blow ther horns as a safety precaution. So i'm for that.

[yorick]

I created a patch that makes train whistle when they pass a waypoint.

[Batti5]

bridge & tunnel whistle board, like in reality.

[ostlandr]

Cool idea!

http://en.wikipedia.org/wiki/Train_horn ... rn_Signals

http://en.wikipedia.org/wiki/Train_whistle

Most useful ones IMHO would be:

_ _ (two long sounds) when starting- already in game

_ _ o _ (long, long, short, long) - approach level crossing- should be used for "whistle post"

o o (two short)- acknowledge order- for waypoints?

o o o (3 short) - backing up- use when train reverses?

[Batti5]

(two long sounds) when starting- already in game
(long, long, short, long) - approach level crossing- should be used for "whistle post"
(two short)- acknowledge order- for way points?
(3 short) - backing up- use when train reverses?

I try ed WITH!!!!! recent builds, it works 100% OK, no errors, do the suggestions written above and, put it in trunk.

Plus, trains could Whistle level crossings and stations it there not stopping, and different engines could have different sounds not just locos.
And a switch in the advanced settings on/off

[2007Alain2007]

updated to R15821

[2007Alain2007]

code change

Code: Select all

-if (IsTileType(v->tile, MP_RAILWAY) && IsRailWaypoint(v->tile) && IsFrontEngine(v)) v->PlayLeaveStationSound();
+if (IsTileType(v->tile, MP_RAILWAY) && IsRailWaypoint(v->tile) && v->IsFrontEngine()) v->PlayLeaveStationSound();

hope this is ok to show the change like this

[SirkoZ]

IsFrontEngine(v) -> v->IsFrontEngine() is the same thing I changed in the diesel_smoke patch for r16724+, so yes it's OK.

[2007Alain2007]

I just working on this patch becuse it seems a nice one to get me started on

goals for this patch is to get a setting on it and also add bridge & tunnel whistle

I added bridge & tunnel whistle thats working here is the patch file for that

How dose the settings page work can any one give me a hint in the right way i just had a go at it and fail with a failt error in text doc ?

but this patch is working but still theres a no on and off setting

and also i need to clean the code up but this is the frist time i tryed to chage a patch file

but please tell me what you think

whistle.patch