Gonozal_VIII patchpack r12180

[Gonozal_VIII]

new version includes timetable based seperation patch now

[MagicBuzz]

I suggest you and Chrissicom spare some time together and work on a future Chris/GonoIN
That should definately make the updating of this revision easier

Thank you very much for integrating my patch, that will help me getting more feedbacks
Should I suggest my other patch "Autorenew old vehicules" ? http://www.tt-forums.net/viewtopic.php?f=32&t=33039
That's a very small patch that "fix" the autorenew feature when playing with no servicing

-- Edit : About the timetable separation patch, did you change something ? I see in your archive you tagged it "r12087" while mine is "r12059" and I don't experience problems with patching ? Or is that just because you had to update if for merging with other patch ?

[peebee]

new version includes timetable based seperation patch now

Is the seperation patch also in the compiled rar-file included?

[Gonozal_VIII]

no, the rar file is not updated yet but i think i'll include the autorenew patch first

[peebee]

no, the rar file is not updated yet but i think i'll include the autorenew patch first

Thanks for your quick response. What do you think how long it will take?

[Gonozal_VIII]

the patch is included now, i don't host the build myself so i can't say when i will update that

-- Edit : About the timetable separation patch, did you change something ? I see in your archive you tagged it "r12087" while mine is "r12059" and I don't experience problems with patching ? Or is that just because you had to update if for merging with other patch ?

i didn't change anything there, but i update all patches to latest trunk first before i merge them, takes more time but makes the fixing of conflicts easier.

[MagicBuzz]

Ok.

Can you confirm me there is a problem with the pax destination patch ? My OTTD crash when I try to load a saved game (saved with the patch enabled).
I'm quite confused, as I love this patch (and make my separation really usefull, as it allows desigining profitable pax routes from the begining of the game)

[Gonozal_VIII]

the build in the first post is now updated

hmm i just saved and loaded with passenger destinations enabled and it didn't crash... so it doesn't happen all the time and i don't know how to trigger it.

[MagicBuzz]

the build in the first post is now updated

hmm i just saved and loaded with passenger destinations enabled and it didn't crash... so it doesn't happen all the time and i don't know how to trigger it.

I reproduce it each time with my version at least :
- Build a pax route
- Launch some vehicules (I'm using buses)
- Save when there is at least one passenger in a station
I always crash when trying to reload the gave

=> If no passenger is waiting anywhere, it won't crash.

I'll test with your version, may be I did something wrong then installing the patch or may be my compiler makes someting wrong (??)

[MagicBuzz]

It seems the problem comes with my build (??)

I'm using Visual Studio 2005 to compile, and I used both the original patch + the (uint) fix, and your version. Both produce an error.

Quite strange. But it works with your build, so it's perfect to me

[Gonozal_VIII]

strange, i only resolved conflicts and moved the patch settings to a new tab...

[sickie]

MagicBuzz, I already replayed in the pax thread, but I remembered now, reading this one. I had a crash, not like yours, but still it was caused by a setting of pax destination patch... when I disabled Faster gradual loading setting, the game was (and still is) super stable. So try to play with pax options, hope that helps. Oh, and I compiled with Build OTTD. So if different pax settings don't solve your problem, try to recompile with Build OTTD.

[athanasios]

Pleae can you include the tiny patch found in 8bpp OpenGFX thread for fixing missing Company Colors in inner walls of depots? It is just 4 lines x 2.

regards
athanasios

[Gonozal_VIII]

very small patch indeed, i will include it with the next update

[Gord]

Fantastic work, look forward to having a go with this over the weekend.

It's almost perfect for the way i like to play with this pacth...just missing the shared rails or the older subsidaires patch, i would love to play that with the passenger destinations...i don't suppose theres any chance of those now they are both ageing quite a bit?!

The whole development side of OTTD has really come on in leaps and bounds recently. The passenger destination patch by itself has made some really impressive progress...and now this multi build thingy too...

...my wife doesn't like you developers, i can't put this game down at the moment!

[Gonozal_VIII]

i tried to fiddle with the various shared/subsidy patches but that's too conflicty for me to update, sorry

[anboni]

I love this patch! This is going to make for quite a bit of lost sleep again

I noticed one minor issue with the autosave settings: autosave defaults to 1 day while daylength defaults to 1 as well. This causes a lot of saving and with a large enough map (2048x2048 at least) started generating error messages since the second save tries to start while the first is still busy. Perhaps a safer default would be to set autosave to 1 week.

[Vikthor]

i tried to fiddle with the various shared/subsidy patches but that's too conflicty for me to update, sorry

I was trying to update the track-sharing patch, but it's indeed not so easy and I was hindered by exams and now I am leaving for London just now, so do not expect anything form me until Thursday.

[broodje]

Bugger, I tried to build a version for my own without the passenger destinations and copy paste patch with Visual Express 2008, but the build has failed .
I've got errors in PBS.CPP:

Code: Select all

pbs.cpp
..\src\pbs.cpp(180) : error C2084: function 'TrackBits GetReservedTrackbits(TileIndex)' already has a body
        e:\source\src\pbs.h(12) : see previous definition of 'GetReservedTrackbits'
..\src\pbs.cpp(213) : error C2084: function 'void SetRailwayStationPlatformReservation(TileIndex,DiagDirection,bool)' already has a body
        e:\source\src\pbs.h(14) : see previous definition of 'SetRailwayStationPlatformReservation'
..\src\pbs.cpp(235) : error C2084: function 'bool TryReserveRailTrack(TileIndex,Track)' already has a body
        e:\source\src\pbs.h(16) : see previous definition of 'TryReserveRailTrack'
..\src\pbs.cpp(285) : error C2084: function 'void UnreserveRailTrack(TileIndex,Track)' already has a body
        e:\source\src\pbs.h(17) : see previous definition of 'UnreserveRailTrack'
pathfind.cpp

and a syntax error in rail_gui.cpp:

Code: Select all

..\src\rail_gui.cpp(1624) : error C2059: syntax error : '<<'

Strangely enough there were no mismatch errors when I applied the patches to the source, except for 5 empty lines at the end of the file when I applied the PBS patch.

[Gord]

Well thank you anyway...i guessed the shared/subsidiary patch would be too troublesome. I very much appreciate your effort and reply though.

Keep up the fantastic work. The suppose the ultimate devlopment of OTTD is a game that contains every available option in one game...so its really good to see developers trying to combine all the wonderful things we have.