Patch: Password at join -- r11876
Moderator: OpenTTD Developers
- NukeBuster
- Traffic Manager
- Posts: 222
- Joined: 04 Jan 2006 18:16
- Location: Alphen aan den Rijn, The Netherlands
- Contact:
Patch: Password at join -- r11876
Password at join
A few days ago a saw a suggestion, to let the password dialog box show when joining a network game so setting a password will not be forgotten.
Suggestion.
I present you a very small patch(4 new lines:)), please try it and give comments/suggestions.
*edit: To test it, you'll have to compile with "./configure --revision=11876".
How does it work?
-When joining a new company and no default password is set in openttd.cfg it will show this dialog(the same as in the company menu).
-When no password is desired, just hit enter.
-It only affects network games.
A few days ago a saw a suggestion, to let the password dialog box show when joining a network game so setting a password will not be forgotten.
Suggestion.
I present you a very small patch(4 new lines:)), please try it and give comments/suggestions.
*edit: To test it, you'll have to compile with "./configure --revision=11876".
How does it work?
-When joining a new company and no default password is set in openttd.cfg it will show this dialog(the same as in the company menu).
-When no password is desired, just hit enter.
-It only affects network games.
- Attachments
-
- password_at_join_r11876.patch
- r11876
- (755 Bytes) Downloaded 303 times
Last edited by NukeBuster on 02 Feb 2008 00:33, edited 5 times in total.
NukeBuster
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Re: Patch: Password at join -- r11876
Could you make it a server wide option to turn this off? It isn't very useful when people get prompted for passwords on the #openttdcoop sandbox server. There is already a rolling password in place there.
Don't panic - My YouTube channel - Follow me on twitter (@XeryusTC) - Play Tribes: Ascend - Tired of Dropbox? Try SpiderOak (use this link and we both get 1GB extra space)
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
- NukeBuster
- Traffic Manager
- Posts: 222
- Joined: 04 Jan 2006 18:16
- Location: Alphen aan den Rijn, The Netherlands
- Contact:
Re: Patch: Password at join -- r11876
Do they all share the same company?
If they join an existing company they won't get the dialog. (So only the original owner will get the password prompt when creating a NEW company) Also if enter is pressed no password is set.
And besides that, if they have a default password set in openttd.cfg in the present nightly(not my patch) then that password will be used as password for the new company.
If they join an existing company they won't get the dialog. (So only the original owner will get the password prompt when creating a NEW company) Also if enter is pressed no password is set.
And besides that, if they have a default password set in openttd.cfg in the present nightly(not my patch) then that password will be used as password for the new company.
Last edited by NukeBuster on 21 Jan 2008 13:43, edited 1 time in total.
NukeBuster
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Re: Patch: Password at join -- r11876
They do.
Only the server password changes. No need to set a company password anymore.
Only the server password changes. No need to set a company password anymore.
- NukeBuster
- Traffic Manager
- Posts: 222
- Joined: 04 Jan 2006 18:16
- Location: Alphen aan den Rijn, The Netherlands
- Contact:
Re: Patch: Password at join -- r11876
Well, without my patch. If anyone who joins creates a new company and has a default password set in openttd.cfg you would probably already have the same problem.
NukeBuster
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
- NukeBuster
- Traffic Manager
- Posts: 222
- Joined: 04 Jan 2006 18:16
- Location: Alphen aan den Rijn, The Netherlands
- Contact:
Re: Patch: Password at join -- r11876
I will make a second patch, for just that. A password deny/allow option so setting a company password can be disabled by the server.XeryusTC wrote:Could you make it a server wide option to turn this off? It isn't very useful when people get prompted for passwords on the #openttdcoop sandbox server. There is already a rolling password in place there.
NukeBuster
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Re: Patch: Password at join -- r11876
I believe that there is some sort of patch from the WWOTTD that disallows players to mess with the company in which they are in (i.e. changing color scheme, face, name, password ...)
It was sort of some dirty hack (player atempting to change these things were simply removed from server and the change was not done), but perhaps it could be done as server-side patch option more cleanly.
It was sort of some dirty hack (player atempting to change these things were simply removed from server and the change was not done), but perhaps it could be done as server-side patch option more cleanly.
If you need something, do it yourself or it will be never done.
My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility
Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility
Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
Re: Patch: Password at join -- r11876
dirty is an understatement
- NukeBuster
- Traffic Manager
- Posts: 222
- Joined: 04 Jan 2006 18:16
- Location: Alphen aan den Rijn, The Netherlands
- Contact:
Re: Patch: Password at join -- r11876
What do you think about this patch?
NukeBuster
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Re: Patch: Password at join -- r11876
I think it is a good idea. I haven't tried the patch myself though.
Also if I understand your answer correctly OpenTTDCoop server will not have a problem with your patch as it will only pop up the password-window on new companies.
So is there anyone that still have any objections against the patch?
Also if I understand your answer correctly OpenTTDCoop server will not have a problem with your patch as it will only pop up the password-window on new companies.
So is there anyone that still have any objections against the patch?
My OpenTTD contributions (AIs, Game Scripts, patches, OpenTTD Auto Updater, and some sprites)
Junctioneer (a traffic intersection simulator)
Junctioneer (a traffic intersection simulator)
- NukeBuster
- Traffic Manager
- Posts: 222
- Joined: 04 Jan 2006 18:16
- Location: Alphen aan den Rijn, The Netherlands
- Contact:
Re: Patch: Password at join -- r11876
I guess I'll have to bug the devs about this. Will add a comment in flyspray tommorrow.Zuu wrote:I think it is a good idea. I haven't tried the patch myself though.
Also if I understand your answer correctly OpenTTDCoop server will not have a problem with your patch as it will only pop up the password-window on new companies.
So is there anyone that still have any objections against the patch?
NukeBuster
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !
OpenTTD patch(es): Password at join
Who is online
Users browsing this forum: Google [Bot] and 17 guests