Patch: Password at join -- r11876

[NukeBuster]

Password at join
A few days ago a saw a suggestion, to let the password dialog box show when joining a network game so setting a password will not be forgotten.

Suggestion.

I present you a very small patch(4 new lines:)), please try it and give comments/suggestions.

*edit: To test it, you'll have to compile with "./configure --revision=11876".

How does it work?
-When joining a new company and no default password is set in openttd.cfg it will show this dialog(the same as in the company menu).
-When no password is desired, just hit enter.
-It only affects network games.

Picture of the password dialog at join.

Unnamed, 23rd May 1950.png (34.3 KiB) Viewed 9749 times

[XeryusTC]

Could you make it a server wide option to turn this off? It isn't very useful when people get prompted for passwords on the #openttdcoop sandbox server. There is already a rolling password in place there.

[NukeBuster]

Do they all share the same company?

If they join an existing company they won't get the dialog. (So only the original owner will get the password prompt when creating a NEW company) Also if enter is pressed no password is set.

And besides that, if they have a default password set in openttd.cfg in the present nightly(not my patch) then that password will be used as password for the new company.

[osai]

They do.
Only the server password changes. No need to set a company password anymore.

[NukeBuster]

Well, without my patch. If anyone who joins creates a new company and has a default password set in openttd.cfg you would probably already have the same problem.

[NukeBuster]

Could you make it a server wide option to turn this off? It isn't very useful when people get prompted for passwords on the #openttdcoop sandbox server. There is already a rolling password in place there.

I will make a second patch, for just that. A password deny/allow option so setting a company password can be disabled by the server.

[Bilbo]

I believe that there is some sort of patch from the WWOTTD that disallows players to mess with the company in which they are in (i.e. changing color scheme, face, name, password ...)

It was sort of some dirty hack (player atempting to change these things were simply removed from server and the change was not done), but perhaps it could be done as server-side patch option more cleanly.

[dihedral]

dirty is an understatement

[NukeBuster]

What do you think about this patch?

[Zuu]

I think it is a good idea. I haven't tried the patch myself though.

Also if I understand your answer correctly OpenTTDCoop server will not have a problem with your patch as it will only pop up the password-window on new companies.

So is there anyone that still have any objections against the patch?

[NukeBuster]

I think it is a good idea. I haven't tried the patch myself though.

Also if I understand your answer correctly OpenTTDCoop server will not have a problem with your patch as it will only pop up the password-window on new companies.

So is there anyone that still have any objections against the patch?

I guess I'll have to bug the devs about this. Will add a comment in flyspray tommorrow.