subsidiaries & contracts

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
MeTo
Traffic Manager
Traffic Manager
Posts: 129
Joined: 06 Apr 2003 14:02
Location: UnL; Czech Republic
Contact:

Re: subsidiaries & contracts

Post by MeTo »

Ok, thanks for the information, I will wait until it is done.

Btw, in some of previous versions I did just two changes in settings_gui.cpp - I changed the position of the "shared things" button, to move it next to the "Chris IN" button and I added a next word "case" (case 1; case 2; etc.) a few lines above (I realized, without that it was not possible to click on the button).... I had no idea why, generally I don't know anything about programming, just a "try & fail" method, however, it worked :-) But apparently, these two changes are no longer enough :-)
Rafagd
Engineer
Engineer
Posts: 36
Joined: 01 Oct 2007 15:30

Re: subsidiaries & contracts

Post by Rafagd »

Well... I've thinking about markers then i got an great idea!

Instead of re-invent the wheel, what about this patch "depends" on that Marker patch and add the "mark another company's train (with contract)".

So you assign a color to the contracted train, and that patch do the magic...

Pretty tricky idea, isn't it? =]
User avatar
AntBUK
Transport Coordinator
Transport Coordinator
Posts: 319
Joined: 02 May 2007 12:29
Location: Sheffield, England
Contact:

Re: subsidiaries & contracts

Post by AntBUK »

Making it dependent on Route Markers would make it harder to get it in truck I reckon, that and one error will mess the lot up. That, and Route Markers is only tells trains "avoid this route if possible", not "you ain't coming down here!"

The other bonus to asking RichK by the way is that he might be able to help you fine tune some sections of your code.
Rasing Awareness: Aspergers Syndrome 1 (NAS UK)2 (BBC)3 (YaleDDC)


Something is driving you insane... It is me.
Rafagd
Engineer
Engineer
Posts: 36
Joined: 01 Oct 2007 15:30

Re: subsidiaries & contracts

Post by Rafagd »

I thought that markers said "YOU CANT PASS HERE!" instead of "YOU SHOULD NOT PASS HERE"...

And the "depends" is just a wrong word selection... =/

I would change his patch to give ability to change another company's "color". Just it. I think that is easy to enable/disable, so is not so unlikely to get on the trunk...

Also, I do not disagree on "code asking" thing...
xmart2k
Engineer
Engineer
Posts: 91
Joined: 04 May 2006 07:36
Contact:

Re: subsidiaries & contracts

Post by xmart2k »

any news on this patch?
Rafagd
Engineer
Engineer
Posts: 36
Joined: 01 Oct 2007 15:30

Re: subsidiaries & contracts

Post by Rafagd »

We should dicuss about the contracts ideas to move foward
gagarin
Engineer
Engineer
Posts: 57
Joined: 26 Feb 2006 18:52
Location: Berlin, Germany

Re: subsidiaries & contracts

Post by gagarin »

This week was my birthday and the first week in the university, so I had other things on my mind.

I have a version, where provisions for buying vehicles mostly work, but I have to do some bugfixing.

Greetings,
gagarin.
xmart2k
Engineer
Engineer
Posts: 91
Joined: 04 May 2006 07:36
Contact:

Re: subsidiaries & contracts

Post by xmart2k »

happy birthday and all you're wishes come true .
gagarin
Engineer
Engineer
Posts: 57
Joined: 26 Feb 2006 18:52
Location: Berlin, Germany

Re: subsidiaries & contracts

Post by gagarin »

Thank you very much :)

I've uploaded a new version where I fixed a typo which forbid buying aircrafts in shared hangars and I added provisions for depot-owners (I've found the error).

Greetings,
gagarin.
Rafagd
Engineer
Engineer
Posts: 36
Joined: 01 Oct 2007 15:30

Re: subsidiaries & contracts

Post by Rafagd »

xmart2k wrote:happy birthday and all you're wishes come true .
seconded


I'm working a lot during the week... So it's hard to code patches... Also, i need to think about the ideas on contracts...
User avatar
MeTo
Traffic Manager
Traffic Manager
Posts: 129
Joined: 06 Apr 2003 14:02
Location: UnL; Czech Republic
Contact:

Re: subsidiaries & contracts

Post by MeTo »

Happy birthday :)
Btw, do you have any idea, whether there is a chance to open a saved game created in the ChrisIN+shared tracks (downloaded from the first post of this thread) in some of next versions ? (When I compile the latest ChrisIN + shared tracks from "trunk.difF", loading the saved game does not work this time, but I mean as soon as the patch is complete and integrated in the ChrisIN)
gagarin
Engineer
Engineer
Posts: 57
Joined: 26 Feb 2006 18:52
Location: Berlin, Germany

Re: subsidiaries & contracts

Post by gagarin »

Thank you :D

I'm sure it will be possible as soon as the patch is integrates in chrissin. At the moment I'm changing the savegames with every release, which will stop when all features are implemented. So I must ask you for a little patience. :cry:

greetings,
gagarin.
T-Unit
Transport Coordinator
Transport Coordinator
Posts: 368
Joined: 03 Feb 2007 18:53
Location: Leeds, England

Re: subsidiaries & contracts

Post by T-Unit »

Hi
It has been a while since i last checked up on this. How is the work coming along?
jrm1504
Engineer
Engineer
Posts: 4
Joined: 18 Feb 2007 06:49

Re: subsidiaries & contracts

Post by jrm1504 »

It has been awhile since anything has been posted about any updates. Just curious what has been happening with the re-write. Can't wait to try it out as it matures!
Vikthor
Engineer
Engineer
Posts: 69
Joined: 13 Jun 2004 16:57
Location: Prague, Czech republic

Re: subsidiaries & contracts

Post by Vikthor »

I am not sure, whether Gagarin is just busy with RL or abandoned this patch, anyway I decided to try and add payment for using of shared tracks. I was heavily inspired by Truelight's patch for WWOTTDGD with the exception that I account for weight of train as well as distance travelled and that actual payment is not done whenever train returns on rails of his company, but in the TrainYearlyLoop (because unlike WWOTTDGD, here can the train spend it's whole journey on foreign tracks). I have not so far touched the feeder system, so feeding between different companies might not work.

Now I have question - Which patch will have(when "finished") better chances of being accepted into trunk? Or let me rephrase that, which one is more worth of being developed further? This (Gagarin's) one, or LordOfThePigs's original one as updated by Chrissicom and myself? I have no formal computer science education and don't feel skilled enough to say which one is better (Ok, LOTP's patch is probably more feature-complete, but that surely isn't everything), so if anybody competent can comment on that I will be really happy.

EDIT: Patch updated. I have added support for feeding between companies, based on Truelights code, And I have set up testing server. Configure with --revision=r11569-ts and you can test it:
Image
Attachments
tracksharing-base-r11569.diff
(44.96 KiB) Downloaded 282 times
mzam
Engineer
Engineer
Posts: 7
Joined: 15 Nov 2007 10:11

Re: subsidiaries & contracts

Post by mzam »

Hi,

I am also a bit confused. The SVN server mentioned in the first thread here is not working.
Where can I access the patches source?

Thanks,
Max
Vikthor
Engineer
Engineer
Posts: 69
Joined: 13 Jun 2004 16:57
Location: Prague, Czech republic

Re: subsidiaries & contracts

Post by Vikthor »

If you mean first post in this thread, well, it seems like Gagarins SVN server is offline. Your can take a look on the diff in my post, just above yours, it's Gagarins patch with few modifications, other than that, I do not know.
User avatar
escopena
Engineer
Engineer
Posts: 28
Joined: 22 Aug 2006 10:03
Location: Finland

Re: subsidiaries & contracts

Post by escopena »

Hi,

I tested patch posted by Vikthor, worked fine.

Is there any implements of toll ports or contracts yet? I didn't find any...
Yeah!
Draakon
Director
Director
Posts: 542
Joined: 11 Mar 2007 16:50

Re: subsidiaries & contracts

Post by Draakon »

question: whats done currently for this patch?
Vikthor
Engineer
Engineer
Posts: 69
Joined: 13 Jun 2004 16:57
Location: Prague, Czech republic

Re: subsidiaries & contracts

Post by Vikthor »

After a bit longer time I succeeded in forcing myself to make an update :D It's just an update to latest(12166) revision, so do not expect any new functionality. Anyway, here you are, enjoy.
EDIT: Uploaded bad file, this one have one issue fixed, and bumped savegame version, should be able to load trunk save games.
EDIT: Even that one was not OK, this one should.
EDIT: Update to r12188 and a patch for tracksharing combined with yapp, it seemed to work on first sight, but it wasn't thoroughly tested, so desyncs are possible.
EDIT: This update contains just a bit more changes:
  1. Update to r12209
  2. Cost will be set for 1000 ton tiles
  3. Minimum cost charged in case you travelled > 0 ton tiles on foreign track is for 1000 ton tiles.
  4. Vehicle profit should be correct now.
EDIT: I combined track sharing with Gonozal's patch pack. When used in net game with PaxDest patch it occasionally desyncs but this happens AFAIK also with clean PaxDest patch.
Attachments
tracksharing-base-r12209_SVN.diff
(42.74 KiB) Downloaded 195 times
gonozal+ts-r12218_SVN.diff
(879.14 KiB) Downloaded 1362 times
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 6 guests