Patch: Town road layout

belugas · Post by **belugas** » 09 May 2007 17:12

Goooood work!

kaan · Post by **kaan** » 09 May 2007 18:24

It looks good

skidd13 · Post by **skidd13** » 09 May 2007 19:07

And here is another update. Added layout (2,3)x(2,3) looks a bit less equal (more or less).

mosfet · Post by **mosfet** » 09 May 2007 20:50

Skidd,

One thing I keep meaning to have a go at, but never have the time or effort to do is to stop towns from building un-capped roads.

i.e. Make sure that every dead-end has pavement/sidewalk around the end, like a cul-de-sac, rather than just trailing off into grass.

What especially irritates me is when the towns build roads sloped down into water, rather than using a built-up tile with a cul-de-sac.

MeTo · Post by **MeTo** » 12 May 2007 16:46

There was any change with the option "no more roads" ? Now, if I have chosen this option, it works, there is really no road.... but if I build the road, the city builds no buildings along it....

skidd13 · Post by **skidd13** » 12 May 2007 19:01

MeTo wrote:There was any change with the option "no more roads" ? Now, if I have chosen this option, it works, there is really no road.... but if I build the road, the city builds no buildings along it....

I think this would fix it.

Code: Select all

Index: src/town_cmd.cpp
===================================================================
--- src/town_cmd.cpp    (Revision 9829)
+++ src/town_cmd.cpp    (Arbeitskopie)
@@ -1178,7 +1178,7 @@
        /* Let the town be a ghost town
         * The player wanted it in such a way. Thus there he has it. ;)
         * Never reached in editor mode. */
-       if (_patches.town_layout == TL_NO_ROADS) {
+       if (_patches.town_layout == TL_NO_ROADS && _generating_world) {
                return false;
        }

MeTo · Post by **MeTo** » 12 May 2007 19:41

thank you, it works now, cities build houses

skidd13 · Post by **skidd13** » 12 May 2007 21:55

And another update...

MaxKnight · Post by **MaxKnight** » 02 Jun 2007 19:40

Please excuse this bump, I wasn't sure whether to bring it up here or not since it's inclusion into Trunk.

It seems that it doesn't detect slopes properly when it wants to build junctions. If the tile a junction is supposed to be built on is sloped, it still builds the junction, but it gets built on foundations and is only three-way, with the last direction the one it came from. It appears to be a bug to me, but I wasn't sure if it needed to be reported to FlySpray or not. I've included a screenshot of the occurence.

skidd13 · Post by **skidd13** » 02 Jun 2007 23:25

MaxKnight wrote:Please excuse this bump, I wasn't sure whether to bring it up here or not since it's inclusion into Trunk.

It seems that it doesn't detect slopes properly when it wants to build junctions. If the tile a junction is supposed to be built on is sloped, it still builds the junction, but it gets built on foundations and is only three-way, with the last direction the one it came from. It appears to be a bug to me, but I wasn't sure if it needed to be reported to FlySpray or not. I've included a screenshot of the occurence.

I've no problem with this bump.

This behavior is intended. Well most of it. The three way is build because it is the most connective street-junction. Sure it looks a bit wired in this case. In code I marked this already, but from the coding point I don't know a nice and easy solution (yet).

MaxKnight · Post by **MaxKnight** » 02 Jun 2007 23:38

Now, I solved the problem for that town by demolishing those ugly roads and lowering the land so that the junction would be on flat land.

Since towns are capable of minor terraforming in order to build roads and whatnot, couldn't you add a check for where these junctions are to be built and force the town to try to lower the entire tile to the height of the road leading into it? If it's not possible, then skip trying to expand that direction and go another way. Would this be possible in code? I know C++, but not enough to figure out how to do something like this.

skidd13 · Post by **skidd13** » 02 Jun 2007 23:47

MaxKnight wrote:Now, I solved the problem for that town by demolishing those ugly roads and lowering the land so that the junction would be on flat land.

Since towns are capable of minor terraforming in order to build roads and whatnot, couldn't you add a check for where these junctions are to be built and force the town to try to lower the entire tile to the height of the road leading into it? If it's not possible, then skip trying to expand that direction and go another way. Would this be possible in code? I know C++, but not enough to figure out how to do something like this.

I get what you mean, but the selection where to grow the city is random (more or less). If you want to check from where the city opticaly grow you have to check the tiles around the target one and do some math there... That would cause many if cascades... not very nice. I decided to check only the slopes and not the growing direction. It looks nicer in code if you have a clean switch instead of 20-30 if cascades...

IMHO

skidd13 · Post by **skidd13** » 11 Jul 2007 15:47

I'm working on the town again. ATM I'm trying to get rid of the inconnective dead ends created by the town road layout.

Here is the first (not working as expected ATM) diff.

Edit: small fix.

Chicago Rail Authority · Post by **Chicago Rail Authority** » 11 Jul 2007 15:51

Not sure I follow... what is it about dead-ends that you're trying to get rid of?

skidd13 · Post by **skidd13** » 11 Jul 2007 15:53

Chicago Rail Authority wrote:Not sure I follow... what is it about dead-ends that you're trying to get rid of?

Roads leading into water, etc.

MarkyParky · Post by **MarkyParky** » 12 Jul 2007 09:55

Hello,

do you think it would be possible to implement "town builds no roads" to scenario editor as well? It would be handy to create custom city layouts by simply drawing the streets first, than building the city in the middle and expanding it just by clicking the button in editor...

belugas · Post by **belugas** » 12 Jul 2007 14:32

It is possible, but it has been objected.
If you really do want to create your own layout, it is quite easy. Simply create a small town and deal with the road yourself.

Bilbo · Post by **Bilbo** » 12 Jul 2007 15:09

belugas wrote:It is possible, but it has been objected.
If you really do want to create your own layout, it is quite easy. Simply create a small town and deal with the road yourself.

Yes, build small city, bulldoze it completely, then add your own street layout and then "expand" the city for letting it build the buildings

Mchl · Post by **Mchl** » 12 Jul 2007 18:47

I just got an idea. Would it be possible to make cities build bridges or tunnels when crossing railways? I don't mean there should be no level crossings, but from time to time, a town could afford a bridge

Not sure if it is in scope of this patch, probably not

Bilbo · Post by **Bilbo** » 12 Jul 2007 19:47

Mchl wrote:I just got an idea. Would it be possible to make cities build bridges or tunnels when crossing railways? I don't mean there should be no level crossings, but from time to time, a town could afford a bridge ;)

Not sure if it is in scope of this patch, probably not :oops:

Definitely when crossing maglev track, since maglev crossings are rather crossnigs of death. Maybe the chance to biuld bridge instead of crossing would depend on max. speed of vehicle that could go over it. For <100 km/h never build a bridge, for >250 km/h almost always build a bridge, between these two make some linear fade ....

Transport Tycoon Forums

Patch: Town road layout

Slight possible bug

Re: Slight possible bug

Who is online