Improved sign window

XeryusTC · Post by **XeryusTC** » 16 Jun 2007 13:08

I've made a small patch that improves on the sign edit window a bit. This patch allows easier manipulation of signs throughout the game.

Current features:

Added a delete sign button
Allow all 30 characters to be entered
Cycle through all the signs from the edit window (either alphabetical or via internal structures, configural by a patch)
No text is displayed when the sign is just created
Only allow one sign per tile (original by Oxygene )
Change sign height on terraform (original by Oxygene)

jasperthecat1 · Post by **jasperthecat1** » 16 Jun 2007 13:59

keep up the good work! that's awesome!

littlemikey · Post by **littlemikey** » 16 Jun 2007 14:58

Can you post a screenshot please?

Wolf01 · Post by **Wolf01** » 16 Jun 2007 15:40

if you could make something like this, maybe with a limit of 1024 chars you are a genius

XeryusTC · Post by **XeryusTC** » 16 Jun 2007 18:53

I was thinking of putting more characters into signs too, but I didn't think about multiline really. I just stretched up the array a bit but the sign became too big for the game and it only rendered a small part of the background and cut of a piece of the text, so there is also some change needed there.
But I'll see what I can do about the maximum amount of characters on a sign, there seem to be comming quite some complications along the way so don't expect it too soon.

jasperthecat1 · Post by **jasperthecat1** » 16 Jun 2007 18:55

Can you put it in Openttd 0.5.2?

Sacro · Post by **Sacro** » 16 Jun 2007 19:08

jasperthecat1 wrote:Can you put it in Openttd 0.5.2?

No, that'd require some sort of time machine...

0.5.2 has already been released.

Zojj · Post by **Zojj** » 16 Jun 2007 19:25

r10170 has also already been 'released'...

You could still make a patch to put it in 0.5.2. Would it cause desync?

XeryusTC · Post by **XeryusTC** » 16 Jun 2007 19:50

You could try to apply it to 0.5.2 but it is possible that applying it fails (I don't know how much the code affected by the patch has been touched).
And no, it won't cause desyncs AFAIK, it still uses the same methods as before, there is only a shortcut for deleting signs and a client side method to cycle through all the signs.

benc · Post by **benc** » 16 Jun 2007 22:42

XeryusTC wrote:* Cycle through all the signs from the edit window

Found a bug with this feature. Steps to recreate:

Create 4 signs
Click on any of the signs and then Next will only cycle through the first 3. The Prev button will cycle through all 4, though.
Delete the 1st sign
Use the Next or Prev button some more; OpenTTD will crash with "!invalid string id 0 in GetString()" when it hits where the 1st sign used to be

Also, general coding style... would be easier to grok without gotos.

XeryusTC · Post by **XeryusTC** » 16 Jun 2007 23:11

benc wrote:
XeryusTC wrote:* Cycle through all the signs from the edit window
Found a bug with this feature. Steps to recreate:

Create 4 signs

Click on any of the signs and then Next will only cycle through the first 3. The Prev button will cycle through all 4, though.

Delete the 1st sign

Use the Next or Prev button some more; OpenTTD will crash with "!invalid string id 0 in GetString()" when it hits where the 1st sign used to be

I've fixed the invalid string bug earlier today, but that switched the other problem around to the previous button. I have fixed that now too and I'll upload a new version.
And for the gotos: I mainly used them to prevent code duplication (or making more functions) and also a little bit because I borrowed code from some other OTTD window

.

XeryusTC · Post by **XeryusTC** » 17 Jun 2007 13:33

A little bump here, I fixed a warning and updated some coding style issues. See first post for new patch.

Oxygene · Post by **Oxygene** » 18 Jun 2007 15:05

The patch works quite well. Thanks for your work, XeryusTC.

I've attached two images for the interested. The first one shows XeryusTC's sign edit box.
The second one is an animation which shows how signs are now attached to the original tile so that they also move when terraforming.

XeryusTC · Post by **XeryusTC** » 18 Jun 2007 19:30

I updated the patch again, there are a minor update and I moved some code. Note that the move affects network play, when someone places a second sign on a tile where there was already a sign then you won't see it. Sign IDs might also be screwed from that point and you might see signs disappearing when a sign gets deleted from a double-sign-tile. It will not cause desyncs AFAIK though.

TheJosh · Post by **TheJosh** » 19 Jun 2007 02:58

go for trunk!

XeryusTC · Post by **XeryusTC** » 20 Jun 2007 16:49

A patch update, I added a method to cycle through the signs list alphabetically. The old method is still available and you can switch between them with a patch setting.

XeryusTC · Post by **XeryusTC** » 30 Jun 2007 18:14

OpenTTD: peter1138 * r10401 /trunk/src/ (lang/english.txt main_gui.cpp signs.h signs_gui.cpp): -Feature: new sign editor features including switching to previous/next sign (XeryusTC)

This means that this patch will be in today's nightly and you don't have to use the outdated patch on the top of the page anymore.
Have fun with it!

kaan · Post by **kaan** » 30 Jun 2007 18:25

XeryusTC wrote:
OpenTTD: peter1138 * r10401 /trunk/src/ (lang/english.txt main_gui.cpp signs.h signs_gui.cpp): -Feature: new sign editor features including switching to previous/next sign (XeryusTC)
This means that this patch will be in today's nightly and you don't have to use the outdated patch on the top of the page anymore.
Have fun with it!

CMircea · Post by **CMircea** » 02 Jul 2007 05:24

The fastest patch to go in 2007's trunk!

Post by **Rubidium** » 02 Jul 2007 08:01

Desolator wrote:The fastest patch to go in 2007's trunk!

Lets just say this is a horrible lie. I've committed some user-made patches much much faster than this patch has been committed.

Transport Tycoon Forums

Improved sign window

Improved sign window

Re: Improved sign window

Re: Improved sign window

Who is online