Patch: American Town Names

[Johnny B Goode]

I felt the British town names sounded kind of foreign to me, so I wrote this patch. Keep in mind, I was operating straight out of the Dev's Black Book, and this is my first patch. Also, I haven't tested it becasue my patch program is acting weirdly.

[Maedhros]

Also, I haven't tested it becasue my patch program is acting weirdly.

You're not kidding - that's not a particularly useful (or even valid) patch, I'm afraid.

Unfortunately it wouldn't work if it was a valid patch since the arrays of names you've defined are different to the ones you're referencing in MakeAmericanTownName. Also I have a feeling that the code wouldn't do what you were expecting anyway as it would pick a name from either of the arrays, not both of them.

[Johnny B Goode]

I fixed the invalid array calls and the generator function. Anything else needed?

EDIT: I also fixed some other errors as well.

[DaleStan]

That *still* isn't a valid patch file.

[Zuu]

Shouldn't there be a space between name1 and name2? Or are American town names written w/o space?


Also you need to make the patch using svn diff to get somewhere with your patch I'm afraid. Your patch don't specify where your new code should be added in the files. Basically edit the files straight ahead and then make a svn diff.

[Johnny B Goode]

Eh, screw this. Hopefully I can ask someone who can code for s*** to fix it.