Patch: New orders window
Moderator: OpenTTD Developers
Patch: New orders window
I'm a big friend of usability, so here are my 10 pence.
Move order and skip to order is in trunk now!
This patch changes the text buttons for the main actions to icon buttons (the cursor is also changed).
The grf should be placed in the data path. (NO newgrf!!)
Move order and skip to order is in trunk now!
This patch changes the text buttons for the main actions to icon buttons (the cursor is also changed).
The grf should be placed in the data path. (NO newgrf!!)
- Attachments
-
- New Dehli Xpress, 27th Oct 2364.png (42.56 KiB) Viewed 8083 times
-
- order_gui_icons_r10783.patch
- (26.54 KiB) Downloaded 174 times
-
- cur_n_ico.grf
- (1.57 KiB) Downloaded 174 times
Last edited by skidd13 on 04 Aug 2007 23:39, edited 46 times in total.
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Good to hear that my idea is well recieved.
I'm thinking over the button placement:
In the icon-button-bar should only be the most used buttons (only 3-4).
The text-button-bar should include the remaining buttons.
Goto and skip should really be in the icon-button-bar.
Now the question is which button(s) is needed often too?
That's why I started to code this.Mucht wrote:Saves quite some time and click-work.
I'm thinking over the button placement:
In the icon-button-bar should only be the most used buttons (only 3-4).
The text-button-bar should include the remaining buttons.
Goto and skip should really be in the icon-button-bar.
Now the question is which button(s) is needed often too?
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Patch updated.
Now full functionality should be availible. Now it's only style (I hope).
Now full functionality should be availible. Now it's only style (I hope).
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
I'm working on it. But it's a bit difficult, cause I need to replace bigger parts of the GUI!iNVERTED wrote:How about drag&drop?
Patch updated!
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Last update contains a bug, current version too.
The crash appears when you move the first order down.
ATM I can't understand why the game crashes.
I draft a small image which contains the linked order list.
vO = v->orders
O1 = first order
O2 = 2nd order
O3 = 3rd order
Somehow "New move from 01 to 02" crashes the game.
Please can someone help me. Thanks
The crash appears when you move the first order down.
ATM I can't understand why the game crashes.
I draft a small image which contains the linked order list.
vO = v->orders
O1 = first order
O2 = 2nd order
O3 = 3rd order
Somehow "New move from 01 to 02" crashes the game.
Please can someone help me. Thanks
- Attachments
-
- move_order.png (29.2 KiB) Viewed 11614 times
Last edited by skidd13 on 24 Mar 2007 16:11, edited 1 time in total.
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Hello skidd13,
There was an infinite loop in the order list when you move the first order down
Replace these two lines
by
If you want, here you can my diff, I create one command CMD_MOVE_ORDER and delete CMD_ORDER_MOVE_UP and CMD_MOVE_ORDER_DOWN.
If the bit 8 of param p2 of the cmdMoveOrder function is set to 1 so we move the selected order up else we move it down.
There was an infinite loop in the order list when you move the first order down
Replace these two lines
Code: Select all
SwapOrders(v->orders, one_past);
v->orders->next = moving_one->next;
Code: Select all
v->orders = moving_one->next;
If the bit 8 of param p2 of the cmdMoveOrder function is set to 1 so we move the selected order up else we move it down.
- Attachments
-
- move_order_9417.diff
- (26.8 KiB) Downloaded 273 times
Thanks a lot.nycom wrote:Hello skidd13,
There was an infinite loop in the order list when you move the first order down.
I was on the way to merge the two commands, cause of the Drag and Drop functionality.nycom wrote:I create one command CMD_MOVE_ORDER and delete CMD_ORDER_MOVE_UP and CMD_MOVE_ORDER_DOWN.
If the bit 8 of param p2 of the cmdMoveOrder function is set to 1 so we move the selected order up else we move it down.
Patch Updated!
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Another update!
FIXED:
- current order stay's selected
- shared orders sync crash
TODO:
Get Drag&Drop working + clean up code.
FIXED:
- current order stay's selected
- shared orders sync crash
TODO:
Get Drag&Drop working + clean up code.
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Hm, I read the question a 100 times...bkLife wrote:How do i install this magnificent patch?
Please search first!
There is a reason why in the development topic is a sticky called Howto apply a patch/diff file!
Or search in the manual (read point: 2 Source code)!
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
patch updated!
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
-
- Traffic Manager
- Posts: 141
- Joined: 30 Apr 2007 10:26
The function could itself handle drag and drop actions. But to tell the GUI to accept this is quite difficult (Cause lack of documentation and free time). I've tried it a few times but failed allway's. So I stick to this solution.doghousedean wrote:Instead of programming a new feature you could always drag the orders arround like you could in TTDX!
[edit] thats strange, you could do it in the original TTDX, but not in OTTD! oh well keep up the good work..
Patch updated. Missed a damned segfault last time.
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
I tried to implement drag and drop once again.
Somehow the event WE_DRAGDROP is never called.
I don't get the problem, can someone help to improve. Thanks.
Somehow the event WE_DRAGDROP is never called.
I don't get the problem, can someone help to improve. Thanks.
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Ok, this is not entirely for the GUI, but could you add the ability to select an existing orders window and copy/share it.
It would make converting between rail types quicker.
Additionally, if you get drag and drop working will we be able to drag from one order set to the other. (eg. move an order between vechs)
PS. Are the busess making money? You sure have a lot.
It would make converting between rail types quicker.
Additionally, if you get drag and drop working will we be able to drag from one order set to the other. (eg. move an order between vechs)
PS. Are the busess making money? You sure have a lot.
Click on the vehicle does the job either.nzhook wrote:Ok, this is not entirely for the GUI, but could you add the ability to select an existing orders window and copy/share it.
Drag and drop is such a thing in OTTD, adding a button or changing it's behavior is quite simple, but I don't get this damned drag and drop working.nzhook wrote:Additionally, if you get drag and drop working will we be able to drag from one order set to the other. (eg. move an order between vechs)
Draging a order between two vehicles would require more work than it's worth. IMO (ATM)
Why should they?! It's just for testing.nzhook wrote:PS. Are the busess making money? You sure have a lot.
What does that mean - the circumstances? I determine what circumstances prevail. -- Napoleon Bonaparte
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
---
If we cannot end now our differences, at least we can help make the world safe for diversity. -- John F. Kennedy
---
Our problems are man-made, therefore they may be solved by man. No problem of human destiny is beyond human beings. -- John F. Kennedy
Who is online
Users browsing this forum: No registered users and 0 guests