Patch: New orders window

skidd13 · Post by **skidd13** » 20 Mar 2007 18:47

I'm a big friend of usability, so here are my 10 pence.

Move order and skip to order is in trunk now!

This patch changes the text buttons for the main actions to icon buttons (the cursor is also changed).

The grf should be placed in the data path. (NO newgrf!!)

Connum · Post by **Connum** » 21 Mar 2007 10:19

always wanted something like that, thanks! =)

Wolf01 · Post by **Wolf01** » 21 Mar 2007 11:01

great,

always wanted something like that, thanks! =)

me too

Mucht · Post by **Mucht** » 21 Mar 2007 12:03

Hey thats really a great improvement! Saves quite some time and click-work.

skidd13 · Post by **skidd13** » 21 Mar 2007 13:16

Good to hear that my idea is well recieved.

Mucht wrote:Saves quite some time and click-work.

That's why I started to code this.

I'm thinking over the button placement:
In the icon-button-bar should only be the most used buttons (only 3-4).
The text-button-bar should include the remaining buttons.
Goto and skip should really be in the icon-button-bar.
Now the question is which button(s) is needed often too?

skidd13 · Post by **skidd13** » 21 Mar 2007 18:23

Patch updated.
Now full functionality should be availible. Now it's only style (I hope).

iNVERTED · Post by **iNVERTED** » 21 Mar 2007 20:38

How about drag&drop?

skidd13 · Post by **skidd13** » 24 Mar 2007 01:11

iNVERTED wrote:How about drag&drop?

I'm working on it. But it's a bit difficult, cause I need to replace bigger parts of the GUI!

Patch updated!

skidd13 · Post by **skidd13** » 24 Mar 2007 13:14

Last update contains a bug, current version too.
The crash appears when you move the first order down.
ATM I can't understand why the game crashes.

I draft a small image which contains the linked order list.

vO = v->orders
O1 = first order
O2 = 2nd order
O3 = 3rd order

Somehow "New move from 01 to 02" crashes the game.

Please can someone help me. Thanks

nycom · Post by **nycom** » 24 Mar 2007 14:50

Hello skidd13,

There was an infinite loop in the order list when you move the first order down

Replace these two lines

Code: Select all

SwapOrders(v->orders, one_past);
v->orders->next = moving_one->next;

by

Code: Select all

v->orders = moving_one->next;

If you want, here you can my diff, I create one command CMD_MOVE_ORDER and delete CMD_ORDER_MOVE_UP and CMD_MOVE_ORDER_DOWN.
If the bit 8 of param p2 of the cmdMoveOrder function is set to 1 so we move the selected order up else we move it down.

skidd13 · Post by **skidd13** » 24 Mar 2007 16:15

nycom wrote:Hello skidd13,
There was an infinite loop in the order list when you move the first order down.

Thanks a lot.

nycom wrote:I create one command CMD_MOVE_ORDER and delete CMD_ORDER_MOVE_UP and CMD_MOVE_ORDER_DOWN.
If the bit 8 of param p2 of the cmdMoveOrder function is set to 1 so we move the selected order up else we move it down.

I was on the way to merge the two commands, cause of the Drag and Drop functionality.

Patch Updated!

skidd13 · Post by **skidd13** » 26 Mar 2007 18:46

Another update!

FIXED:
- current order stay's selected
- shared orders sync crash

TODO:
Get Drag&Drop working + clean up code.

bkLife · Post by **bkLife** » 04 Apr 2007 20:58

How do i install this magnificent patch?

skidd13 · Post by **skidd13** » 05 Apr 2007 11:03

bkLife wrote:How do i install this magnificent patch?

Hm, I read the question a 100 times...

Please search first!
There is a reason why in the development topic is a sticky called Howto apply a patch/diff file!
Or search in the manual (read point: 2 Source code)!

skidd13 · Post by **skidd13** » 30 Apr 2007 00:01

patch updated!

doghousedean · Post by **doghousedean** » 02 May 2007 13:17

Instead of programming a new feature you could always drag the orders arround like you could in TTDX!

[edit] thats strange, you could do it in the original TTDX, but not in OTTD! oh well keep up the good work..

skidd13 · Post by **skidd13** » 02 May 2007 17:17

doghousedean wrote:Instead of programming a new feature you could always drag the orders arround like you could in TTDX!

[edit] thats strange, you could do it in the original TTDX, but not in OTTD! oh well keep up the good work..

The function could itself handle drag and drop actions. But to tell the GUI to accept this is quite difficult (Cause lack of documentation and free time). I've tried it a few times but failed allway's. So I stick to this solution.

Patch updated. Missed a damned segfault last time.

skidd13 · Post by **skidd13** » 04 May 2007 10:53

I tried to implement drag and drop once again.
Somehow the event WE_DRAGDROP is never called.
I don't get the problem, can someone help to improve. Thanks.

nzhook · Post by **nzhook** » 14 May 2007 10:09

Ok, this is not entirely for the GUI, but could you add the ability to select an existing orders window and copy/share it.

It would make converting between rail types quicker.

Additionally, if you get drag and drop working will we be able to drag from one order set to the other. (eg. move an order between vechs)

PS. Are the busess making money? You sure have a lot.

skidd13 · Post by **skidd13** » 14 May 2007 15:24

nzhook wrote:Ok, this is not entirely for the GUI, but could you add the ability to select an existing orders window and copy/share it.

Click on the vehicle does the job either.

nzhook wrote:Additionally, if you get drag and drop working will we be able to drag from one order set to the other. (eg. move an order between vechs)

Drag and drop is such a thing in OTTD, adding a button or changing it's behavior is quite simple, but I don't get this damned drag and drop working.
Draging a order between two vehicles would require more work than it's worth. IMO (ATM)

nzhook wrote:PS. Are the busess making money? You sure have a lot.

Why should they?! It's just for testing.

Transport Tycoon Forums

Patch: New orders window

Patch: New orders window

Who is online