Patch: Drive-Through Road Vehicle Stops

[CMircea]

Can't wait for a exe =D I love this patch! Just look at my 40 RVs there in the picture and see how easy it is to handle them:

[mart3p]

Thanks Desolator, nice screenshot.

The new win32 exe, with build on town-owned roads, is now available in the second post of this thread.

[CMircea]

*Desolator downloads the new version and adds more busses because the bus station have 1000 passengers waiting each (except the airport, which has 4000)*

[mart3p]

Thanks to a problem found by Desolator, I have posted a new win32 exe (in the second post). Hopefully that's fixed it.

[Ben_K]

Is that the random crashing one? Im getting it. Let me know if you want some details.

[CMircea]

http://bugs.openttd.org/task/604

For me, it crashed a few times, and then it went with the assert messages.

[mart3p]

Is that the random crashing one? Im getting it. Let me know if you want some details.

Yes, random crashes and asserts. I don't need further details, just try the new exe I've posted and let me know if you still have problems.

[Ben_K]

I tried the new on. It was better but still had one crash so far.

[mart3p]

Well if there's still a problem I'm going to need more information. Can you remember doing anything in particular when it crashed?

Could you post your crash.log and (if possible) a savegame that crashes shortly after loading?

[CMircea]

For now it works perfect, and I'll post 3 screenshots with my road networks that depends on these wonderful stations. The RVs are making some good money, but not anywhere near my 4 million 747s or 3 million trains (a year).

[mart3p]

Hehe, I’ve also been playing with your game, I haven’t had it crash either. But I’ve got more money than you (ok, so I’m a few years ahead) .

[CMircea]

The route between Craiova Airport & Brasov airport should be full of 747s. And replace the Concordes, they aren't making 700k a year anymore.

[CMircea]

OK, that was crazy enough, but this is even crazier! I have attached my newgrfs and a saved game so people can play that game. I have also added another airport to the 747s' route, earning 50% more.

[Ben_K]

Could you post your crash.log and (if possible) a savegame that crashes shortly after loading?

Hmmm.. I may have. I think i just carried on playing though. Try these...

[Celestar]

Nice work

I'm downloading and reading through the diff right now.

Celestar

[mart3p]

Celestar: Thanks for your interest in my patch.

Are you aware that rubidium has just sent me a preliminary code review? I am in the process of making a few changes based on his suggestions. Of course, your input would also be more than welcome.

[Celestar]

OK I'll wait until you modified your code and then make another review, if you're ok with it, we could add it to the trunk then.

Celestar

[mart3p]

OK I'll wait until you modified your code and then make another review, if you're ok with it, we could add it to the trunk then.
Celestar

That would be great, I’ll have an update ready in the next few days.

[Invisble]

you know I love this patch, the only thing is it makes the town growth explode.

Though I don't know if it is possible, but I would love it if you could make it so that you can place drive through road stops without having to destroy the road square first.

[Maedhros]

Though I don't know if it is possible, but I would love it if you could make it so that you can place drive through road stops without having to destroy the road square first.

You can - you just have to enable the patch option (in the Stations tab) first. mart3p, maybe it would be better if it defaulted to "on"?

Also, I don't know if you've seen this, but I get the following warning when compiling.

Code: Select all

/home/jc/src/openttd-svn/src/station_cmd.cpp: In function 'int32 CmdRemoveRoadStop(TileIndex, uint32, uint32, uint32)':
/home/jc/src/openttd-svn/src/station_cmd.cpp:1475: warning: comparison between signed and unsigned integer expressions

Great patch, anyway.