Potentially bug?

[Quark]

Code: Select all

.\network.c(86): warning #175: subscript out of range
  	for (cs = _clients; cs != &_clients[MAX_CLIENT_INFO]; cs++) {
  	                                   ^

Code: Select all

NetworkClientState _clients[MAX_CLIENTS];

Code: Select all

#define MAX_CLIENT_INFO (MAX_CLIENTS + 1)

[Darkvater]

Yes, looks like it. That's why one should use macros and not type by hand . The code below will always be correct. I'll pass this on to Rubidium.

Code: Select all

for (cs = _clients; cs != endof(_clients); cs++) {

[Haukinger]

I'd love to see something like this:

Code: Select all

for ( Client_List_Type::iterator cs=_clients.begin(); cs!=_clients.end(); ++cs )

It's even more always correct

[Darkvater]

Fixed r7984, thanks Quark for noticing.