Planeset patch (now supports Planeset 1.5)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
Grigory1
Traffic Manager
Traffic Manager
Posts: 204
Joined: 07 Jun 2005 09:36
Location: Tallinn, Estonia
Contact:

Post by Grigory1 »

Thanks! :D
User avatar
White Rabbit
Tycoon
Tycoon
Posts: 1734
Joined: 22 Jun 2005 19:15

Post by White Rabbit »

It'll still be available in English though, right?
Image
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

White Rabbit wrote:It'll still be available in English though, right?
Yes it will be, you can set it to English with a GRF parameter.
Image
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Here's a new win 32 exe - now with richk67's new airports! Thanks for all your work on these richk67 and congrats on getting them into the trunk. :)

Only trouble is, I'm having problems with the local authority, when trying to upgrade my busiest airport to an intercontinental. :D
Attachments
OTTD-Planeset1_5_r5364PS.zip
(1.28 MiB) Downloaded 662 times
Planeset Test, 20th Mar 2013.png
Planeset Test, 20th Mar 2013.png (94 KiB) Viewed 11400 times
Image
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Post by DaleStan »

mart3p wrote:
White Rabbit wrote:It'll still be available in English though, right?
Yes it will be, you can set it to English with a GRF parameter.
Or you can just not install the Cyrillic glyphs grf.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

The only part of the Planeset 1.5 patch not in the trunk is the code for handling NewGRF "include" strings. As this is only used for livery selection texts, I have moved this code to the NewGRF Livery Selection/Cargo Subtypes patch. This is now the only patch required to support Planeset 1.5 in OTTD. Note that all this code is already in the MiniIN.

Make sure you are using the latest version of Planesetw.grf (1.5.2) available here.

Screenshot shows various aircraft from Planeset 1.5 at the intercontinental airport. :)
Attachments
Planeset Test, 2nd Apr 2019.png
Planeset Test, 2nd Apr 2019.png (135.18 KiB) Viewed 11261 times
Image
User avatar
White Rabbit
Tycoon
Tycoon
Posts: 1734
Joined: 22 Jun 2005 19:15

Post by White Rabbit »

Did you know that krtaylor is in need of some Planeset screenshots? ;)
Image
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

White Rabbit wrote:Did you know that krtaylor is in need of some Planeset screenshots? ;)
Yes, I’d seen that but you seem to be doing quite well supplying screenshots yourself ;). krtaylor is more than welcome to use any of my screenshots from this thread. I will point him this way from the Planeset thread.
Image
User avatar
Grigory1
Traffic Manager
Traffic Manager
Posts: 204
Joined: 07 Jun 2005 09:36
Location: Tallinn, Estonia
Contact:

Post by Grigory1 »

Problem:
In OpenTTD I wish to share with PlaneSet separate GRF files with planes, with some planes there is no replacement in the list of purchases. :(
In TTDP all works normally.
Attachments
ottd_bug.PNG
ottd_bug.PNG (4.42 KiB) Viewed 10064 times
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Post by DaleStan »

It's just a wild guess, but I think you might have to provide the GRF file(s) in question.

Possibly your openttd.cfg too.

(Sorry. I'm a bit sour about getting an "It's broken. Fix it." bug report, followed immediately by a question that's answered in the readme.)
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Grigory: Do as DaleStan says - provide the GRFs and your openttd.cfg - and I will look into it.

Latest news on Planeset 1.5 support:
peter1138 added support for NewGRF sound effects to the trunk at r6532.

In the last week peter1138 has added cargo subtypes to the trunk, including support for GRF include strings. The code is based on my patch but includes many improvements by peter1138. This means that the Planeset 1.5 alternative liveries are now available using the nightly build. Thanks peter1138. :)
Image
User avatar
Grigory1
Traffic Manager
Traffic Manager
Posts: 204
Joined: 07 Jun 2005 09:36
Location: Tallinn, Estonia
Contact:

Post by Grigory1 »

@DaleStan
@mart3p
GRF+openttd.cfg
Attachments
1.rar
GRF+openttd.cfg
(9.11 KiB) Downloaded 352 times
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Grigory: Yes I see the problem. It is caused because Planeset 1.5 uses special sprites for the purchase list. These are set using an action 3 with the cargo-type set to 0xFF.

Your 747-8 does not use a special sprite for the purchase list and the one previously loaded by Planeset is not being overwritten by your GRF. The purchase list therefore uses the sprite loaded by Planeset - in this case the Boeing Sonic Cruiser.

This is a bug in OTTD. All data for a vehicle ID needs to be cleared if that vehicle ID is overwritten by another GRF file. This is not currently happening. I will try to find a fix for this.

Another unrelated problem; your 747-8 has incorrect spite offsets in some views, see screenshot.
Attachments
747-8 Glitch.png
747-8 Glitch.png (11.51 KiB) Viewed 9877 times
Image
User avatar
Grigory1
Traffic Manager
Traffic Manager
Posts: 204
Joined: 07 Jun 2005 09:36
Location: Tallinn, Estonia
Contact:

Post by Grigory1 »

mart3p wrote:Grigory: Yes I see the problem. It is caused because Planeset 1.5 uses special sprites for the purchase list. These are set using an action 3 with the cargo-type set to 0xFF.

Your 747-8 does not use a special sprite for the purchase list and the one previously loaded by Planeset is not being overwritten by your GRF. The purchase list therefore uses the sprite loaded by Planeset - in this case the Boeing Sonic Cruiser.

This is a bug in OTTD. All data for a vehicle ID needs to be cleared if that vehicle ID is overwritten by another GRF file. This is not currently happening. I will try to find a fix for this.
Thanks mart3p!
I shall hope and wait... :)
And one more question at planes in PlaneSet different spaciousness for example A380 in TTDP - 150t (real), in OpenTTD - 178t???
mart3p wrote: Another unrelated problem; your 747-8 has incorrect spite offsets in some views, see screenshot.
I know, it is the test version. I do new version Boeing 747-8 compatible with Planeset for TTDP and OpenTTD (new figure in more real scale + some new liveries and a new code)
And as I not the programmer wish to ask for what these lines in a code are necessary and whether they are necessary for the single plane
1329 * 19 02 03 00 81 7F 00 02 03 02 00 00 00 00 11 00 01 01 10 00
1330 * 16 02 03 01 85 1A 20 80 02 08 47 08 FF 00 00 00 00
And still as it is possible to install correct loading of tourists at me it has turned out 1200 :shock: (as valuables) it is necessary - 178
Wilson
Engineer
Engineer
Posts: 6
Joined: 13 Mar 2005 22:26

Post by Wilson »

I have a little bug with Planeset. I use the latest version 1.5.2 of planeset and r6689 of ottd. The problem is when I buy the same type of airplanes several times some have other refit options(liveries). I attached a screenshot.
Attachments
bug.png
bug.png (48.21 KiB) Viewed 2390 times
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Post by DaleStan »

Grigory, Wilson:
If you're trying to ask questions about the Planeset, ask in the Planeset thread, not here.

Alternatively, read the NFO spec for variable 7F and the Planeset readme.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Grigory1 wrote:And one more question at planes in PlaneSet different spaciousness for example A380 in TTDP - 150t (real), in OpenTTD - 178t???
This incorrect capacity of 178t only occurs for coal. Other cargo types are correct at 150t. This is because OTTD doesn't yet support NewCargoes. Planeset remaps cargo ID 1 (coal) to tourists using a cargo translation table. It then sets the capacity for tourists to 178. OTTD has no support for cargo translation tables so cargo ID 1 remains as coal, so the capacity of 178 is applied to coal instead of tourists.
Grigory1 wrote:And still as it is possible to install correct loading of tourists at me it has turned out 1200 :shock: (as valuables) it is necessary - 178
How are you able to refit to tourists? :shock: This can't work without NewCargoes so I don't understand this, or are you talking about TTDPatch?
Image
User avatar
Grigory1
Traffic Manager
Traffic Manager
Posts: 204
Joined: 07 Jun 2005 09:36
Location: Tallinn, Estonia
Contact:

Post by Grigory1 »

DaleStan
Sorry, I have not simply found the description for variable 7F and 85 :oops:

mart3p
Has understood, I simply wished to make a file that it worked equally in TTDP and OpenTTD
Thanks
Kahee
Engineer
Engineer
Posts: 60
Joined: 05 Aug 2007 08:57
Skype: wegrem

Re: Planeset patch (now supports Planeset 1.5)

Post by Kahee »

where can i get this airport? :?:
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Planeset patch (now supports Planeset 1.5)

Post by Roujin »

The airports seen here have been included in the game long time ago. They are all listed if you click on "Build Airport".
If you can't build a specific airport because it is greyed out, it is yet too early in the game and you have to wait until it gets available.

edit: looking at your previous posts, you're probably in the wrong section. This is about OpenTTD. These airports are not available in TTDPatch.
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 1 guest