MiniIN patches and TODO list

Got an idea for OpenTTD? Post it here!

Moderator: OpenTTD Developers

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1518
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Post by SirkoZ »

Simfield wrote:This little patch I once...
Nice one - I have sometimes missed this in the game.
Simfield
Engineer
Engineer
Posts: 17
Joined: 12 May 2005 15:23

Extra cheat - local authorities always allow

Post by Simfield »

Most of the time, I use OTTD as a 'virtual model train', so I just want to build extensive and complete networks and have trains running on them. I then often get frustrated by local authorities not allowing me to build an extra stop or demolish a piece of road. This tiny patch offers an extra cheat, that will always allow you these things, even if you have an appalling rating. The way your rating is calculated is NOT affected by the cheat.
Attachments
local_authorities_allow_always.patch
(3.4 KiB) Downloaded 268 times
User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1518
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Post by SirkoZ »

Wow - me too - but I just plant trees on empty squares in case of disgruntal authorities. :-)

There is also a Hostile/Permissive switch under difficulty settings...did you know that? Of course your patch is still quite useful because even in permissive you can have appaling rating... And those local "authorities" really don't know what's good for them. =)
Simfield
Engineer
Engineer
Posts: 17
Joined: 12 May 2005 15:23

Post by Simfield »

SirkoZ wrote:Wow - me too - but I just plant trees on empty squares in case of disgruntal authorities. :-) ...
Yeah, I know of these options and of the trees, and also about the benefits of urban buslines to improve ratings. But often I'm too impatient / lazy to make those lines or plant those trees ;-)
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Here's a fix for the strgen_vs80.vcproj file. This should fix the MSVC problem reported in the problems thread by Simfield. This change was made in the trunk at r6105 but the change somehow got missed when the MiniIN was synced at r6125.

Edit: DONE - committed at r6383
Attachments
Fix_Proj_MiniIN_r6375.patch
(345 Bytes) Downloaded 242 times
Last edited by mart3p on 04 Sep 2006 21:58, edited 1 time in total.
Image
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

1. Changes to depot finding code for YAPF (r6160) needs to check _patches.shared_depots and IsSisterCompany for subsidiaries.
2. Removed my temporary fix for depot finding problem as its not required now r6160 has been synced.

Edit: DONE - committed at r6384
Attachments
YAPF_Subs_Update_MiniIN_r6375.patch
(997 Bytes) Downloaded 221 times
Last edited by mart3p on 04 Sep 2006 21:59, edited 1 time in total.
Image
Simfield
Engineer
Engineer
Posts: 17
Joined: 12 May 2005 15:23

Post by Simfield »

mart3p wrote:Here's a fix for the strgen_vs80.vcproj file. This should fix the MSVC problem reported in the problems thread by Simfield. This change was made in the trunk at r6105 but the change somehow got missed when the MiniIN was synced at r6125.
Hi, thanks for taking the trouble, but for version 7.1 - using strgen.vcproj and langs.vcproj, rather than the _vs80-files - the problem continues. And I already checked if strgen.vcproj suffered the same "..\strings.c"-problem, but it doesn't :-(.
Simfield
Engineer
Engineer
Posts: 17
Joined: 12 May 2005 15:23

Railtypes in smallmap - release 6379

Post by Simfield »

Hi, updating to release 6379 introduced an unresolved conflict. Hereby the updated patch, resolving this conflict. Functionality of the patch remains the same.
Attachments
railtypes_in_smallmap.patch
(8.44 KiB) Downloaded 256 times
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

A couple of updates for the Drive-Through Road Stops patch:
1. The change made to the MiniIN at r5658 to prevent drive-through stops building a connecting road, also disabled the build sound effect and no longer closed the road stop selection window. :oops: This is now fixed properly. Also, uses enum value rather than magic number.
2. Tidied up changes made by my patch in RoadFindPathToDest in roadveh_cmd.c, following sync with r6233.

Edit: DONE - committed at r6399
Attachments
Drive_Thru_Updates_MiniIN_r6375.patch
(4.05 KiB) Downloaded 260 times
Last edited by mart3p on 05 Sep 2006 20:55, edited 1 time in total.
Image
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

Yeah, general apologies for any new errors introduced with the recent sync with trunk. I had 26 files with conflicts on this latest sync, after dealing with about 15 files on the previous one.

So much has changed in trunk in the last 300 revisions - Im frankly amazed I could get it to compile and load anything!

If you spot anything, please dont hesitate to post a patch - even 1 liners are appreciated. Thanks All :)
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
Frostregen
Transport Coordinator
Transport Coordinator
Posts: 340
Joined: 06 Feb 2006 23:58

Post by Frostregen »

Update for Copy&Paste Patch.

-small GUI update for increased usability
-internal Codechanges (Separated GUI Code from C&P Code)

Edit: DONE - committed at r6400
Attachments
copy_paste_rev6384_MiniIN_update.patch
(125.82 KiB) Downloaded 302 times
Last edited by Frostregen on 09 Sep 2006 19:23, edited 1 time in total.
User avatar
Maedhros
OpenTTD Developer
OpenTTD Developer
Posts: 603
Joined: 30 Mar 2006 18:24
Location: Durham, UK

Post by Maedhros »

This is an update for the diagonal level crossings patch. It cleans up the code (and the indentation), and adds fences along the "free" side of the crossing to indicate that roads can't join up with it. It also adds a patch option which increases the savegame revision again. No-one seems to have objected to the lack of one so far though, so I suppose this could be left out. :wink:

Edit: Applied in r6401.
Attachments
diagonal-crossings-miniin-r6392.diff
Patch against mini-in r6392.
(28.67 KiB) Downloaded 255 times
No-one's more important than the earthworm.
User avatar
Maedhros
OpenTTD Developer
OpenTTD Developer
Posts: 603
Joined: 30 Mar 2006 18:24
Location: Durham, UK

Post by Maedhros »

When you next sync with trunk, you'll need to apply this patch for diagonal crossings because of Darkvater's change in r6406, which changes TileOffsByDir to TileOffsByDiagDir.
Attachments
diagonal-crossings-miniin-r6408.diff
Patch against mini-in r6408.
(1.16 KiB) Downloaded 268 times
No-one's more important than the earthworm.
Asterix
Engineer
Engineer
Posts: 121
Joined: 04 Apr 2005 18:17
Location: Germany

Post by Asterix »

small patch for station-stats:
it shows how many vehicles visit a station per month, as well as average, minimum, maximum. (Small part of my original stats-patch)

Note that the number of scheduled vehicles for the station is not shown yet, even though the text already states it :wink:

Comments to the thread in the development-section please.
Thx in advance
Attachments
station_stats_4_MiniIN.diff
Station stats for vehicles MiniIN made for r6409
(18.26 KiB) Downloaded 285 times
Frostregen
Transport Coordinator
Transport Coordinator
Posts: 340
Joined: 06 Feb 2006 23:58

Post by Frostregen »

Update for Distant-join & Adjacent Stations Patch.

Changes:
-Only own & sister-Company stations are listed in GUI
-Usage change: removed ALT Key, because it won't work on some OSs.
-CTRL + build shows the GUI.
-Without CTRL it is normal behavior + popup if adjacent to 2 different stations.



Note:
Currently copy&paste won't work correctly for diagonal rail-road-crossings.
But since this is very rarely used, it is not this important for now. (It would break the current template files)
At least nobody noticed it so far =)
Attachments
adjacent_stations_rev6434_MiniIN_update.diff
(14.6 KiB) Downloaded 263 times
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

I am currently trying to bring the MiniIN back into sync with trunk, but it is proving complex. The window widget system has changed, so all patches that have their own guis need recoding. Its doable - its just taking some time.

Currently I have synced up to current trunk, and have resolved the conflicts. However, I am still working on the guis. ETA sometime this weekend - maybe.
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

richk67: good luck with the sync, it will be nice to have the latest trunk features in the MiniIN. :)

If it’s any help, I have updated the trunk versions of my patches. Have a look at these if you are having problems with gui changes related to my work.

As I’m sure you’re aware, peter1138 has added cargo subtypes/livery refits to the trunk. He has made many improvements, so in case of conflicts use his code not mine. ;)

I will keep a lookout for your updates and will post fixes if I find any problems.
Image
MeusH
Tycoon
Tycoon
Posts: 4349
Joined: 25 Oct 2004 15:39
Location: Mississauga

Post by MeusH »

Just for your information, tile measurement tool has been merged, so it's one patch less for you to care about :wink:
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

MeusH wrote:Just for your information, tile measurement tool has been merged, so it's one patch less for you to care about :wink:
Congrats. I saw the forum thread got closed. I wont merge up to your commit until I have completed the current sync.
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Following the latest MiniIN sync with the trunk, here is a patch that resolves a few remaining issues with the Cargo Subtypes patch due to removal of my version and the addition of peter1138's improved version.
1. Change to ensure that cloned vehicles are set to the correct cargo subtype (this has not yet been added to the trunk).
2. Revert of my change to save the cargo subtype. I had used a byte from the reserved bytes, peter1138's code has added a SLE_CONDVAR.
3. Removal of dead code from window.h

Edit: patch updated to r6947. No longer includes 1. as this was fixed during sync with trunk.

Edit: DONE at r6964, thanks glx
Attachments
Cargo_Subtype_Updates_MiniIN_r6947.patch
(1.19 KiB) Downloaded 206 times
Last edited by mart3p on 27 Oct 2006 15:47, edited 2 times in total.
Image
Post Reply

Return to “OpenTTD Suggestions”

Who is online

Users browsing this forum: No registered users and 0 guests