Tile measurement tool [v.8]
Moderator: OpenTTD Developers
- webfreakz.nl
- Director
- Posts: 627
- Joined: 11 Aug 2005 08:22
- Location: Localhost, 127.0.0.1, [The Netherlands: South Holland-> Westland]
- Contact:
Try this one. Guys told me on IRC that StringID wasn't defined (for some files strings.h was called before openttd.h, which was bad)
- Attachments
-
- measurement_6.patch
- (17.74 KiB) Downloaded 373 times
- webfreakz.nl
- Director
- Posts: 627
- Joined: 11 Aug 2005 08:22
- Location: Localhost, 127.0.0.1, [The Netherlands: South Holland-> Westland]
- Contact:
- webfreakz.nl
- Director
- Posts: 627
- Joined: 11 Aug 2005 08:22
- Location: Localhost, 127.0.0.1, [The Netherlands: South Holland-> Westland]
- Contact:
Darn. The patch doesn't work anymore after this revision-changeset: http://svn.openttd.org/cgi-bin/trac.cgi/changeset/5806
Here Tron deletes the function FindLandscapeHeight() which is used about 7 times in measurement_6.patch. Maybe you could update your patch? That would be great.
Here Tron deletes the function FindLandscapeHeight() which is used about 7 times in measurement_6.patch. Maybe you could update your patch? That would be great.
# Programming is like sex, one mistake and you have to support it for the rest of your life. (Michael Sinz)
I'm trying to finalize this patch.
Thanks to Tron, who helped me optimizing the code. Also he helped me realize I used FindLandscapeHeight bad way, or rather I didn't even had to use it.
There are two things, however, that aren't as good as I wanted:
2x1 autorail:
what's wrong:
Dragging in a "diagonal" direction shows length = 2 instead of 1
why it isn't that bad:
It is very rare (or it doesn't happen, ever) to measure length on such a small distance
Level land tool:
what's wrong:
I couldn't do what one user suggested; the measurement isn't reduced by 1 in width and height
why I couldn't do it:
The function I'm measuring in doesn't contain selection method data, but I'll work on it
Please voice your comments, also about the code style. Thank you in advance
Thanks to Tron, who helped me optimizing the code. Also he helped me realize I used FindLandscapeHeight bad way, or rather I didn't even had to use it.
There are two things, however, that aren't as good as I wanted:
2x1 autorail:
what's wrong:
Dragging in a "diagonal" direction shows length = 2 instead of 1
why it isn't that bad:
It is very rare (or it doesn't happen, ever) to measure length on such a small distance
Level land tool:
what's wrong:
I couldn't do what one user suggested; the measurement isn't reduced by 1 in width and height
why I couldn't do it:
The function I'm measuring in doesn't contain selection method data, but I'll work on it
Please voice your comments, also about the code style. Thank you in advance
- Attachments
-
- measurement_8.patch
- (15.23 KiB) Downloaded 405 times
- webfreakz.nl
- Director
- Posts: 627
- Joined: 11 Aug 2005 08:22
- Location: Localhost, 127.0.0.1, [The Netherlands: South Holland-> Westland]
- Contact:
FinallyMeusH wrote:r6758 is our happy revision.
Thanks to great help of Darkvater and other developers, and of course your tips and ideas, the patch is ready
My idea, and your programming (meush). Great!
# Programming is like sex, one mistake and you have to support it for the rest of your life. (Michael Sinz)
Who is online
Users browsing this forum: No registered users and 49 guests