YAPF - Testers needed!

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
gkirilov
Chief Executive
Chief Executive
Posts: 696
Joined: 03 May 2005 09:32
Location: Othala

Post by gkirilov »

I think KUDr will continue working on PBS. If I am wrong, please correct me.
OTTDCoop NewGRF Pack|Different sets of GRFs for TTDPatch (some of them work in OTTD) - 1|- 2|GRF sets for OTTD|OTTD nightly
Image
I hooked up my accelerator to my brake lights. I hit the gas, people behind me stop, and I'm gone.
Understeer is when you hit the wall with the front of the car. Oversteer is when you hit the wall with the rear of the car. Horsepower is how fast you hit the wall. Torque is how far you take the wall with you. Spoilers and bodykits are how much of the wall you take with you. Rollcages and windownets are how much of a mess you leave on the wall.
User avatar
Wolf01
Tycoon
Tycoon
Posts: 2016
Joined: 24 Apr 2004 10:43
Location: Venezia - Italia
Contact:

Post by Wolf01 »

i hope that

PBS is a great thing (also YAPF is a very great thing)
Frostregen
Transport Coordinator
Transport Coordinator
Posts: 340
Joined: 06 Feb 2006 23:58

Post by Frostregen »

Nobody reported compilation errors except Watcom and VC6 (that are no longer supported due to very bad C++ support).
Guess I have to switch to something else now.
Will be Eclipse + CDT + Cygwin now.
Working fine so far :)
Sacro
Tycoon
Tycoon
Posts: 1145
Joined: 18 Jun 2005 21:08
Location: Here
Contact:

Post by Sacro »

How do you get eclipse to work with the makefile? or dont you bother?
We Am De Best

Host of ThroughTheTube site
Frostregen
Transport Coordinator
Transport Coordinator
Posts: 340
Joined: 06 Feb 2006 23:58

Post by Frostregen »

What do you mean by "get eclipse to work with the makefile"?
I don't need to change anything in the makefile.
Just remove the default target "all" in eclipse, and it compiles fine.
(for a full rebuild you have to manually clean and build, but thats not a problem)
User avatar
White Rabbit
Tycoon
Tycoon
Posts: 1734
Joined: 22 Jun 2005 19:15

Post by White Rabbit »

I think something YAPF-related crashed Brianetta's nightly server (I don't have the crash report, I just timed out, because he was hosting). What happened was that two of my trains crashed, and moments afterwards, the server went down. Attached is the savegame in .tmp format.
Attachments
network_client.zip
(596.42 KiB) Downloaded 169 times
Image
KUDr
OpenTTD Developer
OpenTTD Developer
Posts: 219
Joined: 11 Jan 2006 21:36
Location: Czech Republic

Post by KUDr »

Thanks for that savegame. But unfortunatelly it works well for me (no asserts, crashes or any bad sign). The same as game provided by Brianetta yesterday.

But finally I was lucky and got savegame + exact case description how to reproduce it from Celestar. So it should be fixed at r5013 (also in today's nightly).

If the problem persists call your administrator. If you are your own admin then post new report (but please reproducible one) into flyspray or here.

Thanks, KUDr
User avatar
gkirilov
Chief Executive
Chief Executive
Posts: 696
Joined: 03 May 2005 09:32
Location: Othala

Post by gkirilov »

KUDr, can you write the options in the patches screen that should be on (or off) in order to use the YAPF.
OTTDCoop NewGRF Pack|Different sets of GRFs for TTDPatch (some of them work in OTTD) - 1|- 2|GRF sets for OTTD|OTTD nightly
Image
I hooked up my accelerator to my brake lights. I hit the gas, people behind me stop, and I'm gone.
Understeer is when you hit the wall with the front of the car. Oversteer is when you hit the wall with the rear of the car. Horsepower is how fast you hit the wall. Torque is how far you take the wall with you. Spoilers and bodykits are how much of the wall you take with you. Rollcages and windownets are how much of a mess you leave on the wall.
KUDr
OpenTTD Developer
OpenTTD Developer
Posts: 219
Joined: 11 Jan 2006 21:36
Location: Czech Republic

Post by KUDr »

gkirilov: I don't understand what exactly you mean.

There are only three on/off switches for YAPF for three transport types (ships, RVs and trains). The first one (ships) has default value off, the other two are on by default.
User avatar
Thief^
Route Supervisor
Route Supervisor
Posts: 468
Joined: 10 Oct 2004 00:11

Post by Thief^ »

I think gkirilov was asking whether NPF still needed to be on for YAPF, and what happens if NPF isn't on and YAPF is or NPF is and YAPF isn't.
Melt with the Shadows,
Embrace your destiny...
User avatar
Smoky555
Engineer
Engineer
Posts: 97
Joined: 06 Jan 2005 05:22
Location: Russia, Volgograd
Contact:

Post by Smoky555 »

SVN 5006, 5054, compiled in cygwin

When i enable YAPF for trains they didn't want to go to depot for servicing.

Attached save is for 5054.
Attachments
no_depot.zip
(88.57 KiB) Downloaded 211 times
KUDr
OpenTTD Developer
OpenTTD Developer
Posts: 219
Joined: 11 Jan 2006 21:36
Location: Czech Republic

Post by KUDr »

Fixed:

[08:52:00] <CIA-3> KUDr * r5057 /trunk/yapf/yapf_rail.cpp: -Fix: [YAPF] trains can't find depot for servicing (thanks Smoky555)
User avatar
gkirilov
Chief Executive
Chief Executive
Posts: 696
Joined: 03 May 2005 09:32
Location: Othala

Post by gkirilov »

Thief^ wrote:I think gkirilov was asking whether NPF still needed to be on for YAPF, and what happens if NPF isn't on and YAPF is or NPF is and YAPF isn't.
Yes, something like this.
In other words. What should be on/off in order to use YAPF, NPF, original PF.
OTTDCoop NewGRF Pack|Different sets of GRFs for TTDPatch (some of them work in OTTD) - 1|- 2|GRF sets for OTTD|OTTD nightly
Image
I hooked up my accelerator to my brake lights. I hit the gas, people behind me stop, and I'm gone.
Understeer is when you hit the wall with the front of the car. Oversteer is when you hit the wall with the rear of the car. Horsepower is how fast you hit the wall. Torque is how far you take the wall with you. Spoilers and bodykits are how much of the wall you take with you. Rollcages and windownets are how much of a mess you leave on the wall.
User avatar
Smoky555
Engineer
Engineer
Posts: 97
Joined: 06 Jan 2005 05:22
Location: Russia, Volgograd
Contact:

Post by Smoky555 »

KUDr wrote:Fixed:

[08:52:00] <CIA-3> KUDr * r5057 /trunk/yapf/yapf_rail.cpp: -Fix: [YAPF] trains can't find depot for servicing (thanks Smoky555)
thanks
KUDr
OpenTTD Developer
OpenTTD Developer
Posts: 219
Joined: 11 Jan 2006 21:36
Location: Czech Republic

Post by KUDr »

gkirilov: aha, sorry for misunderstanding

1) NPF overrides NTP
2) YAPF overrides both NTP and NPF so it doesn't matter if you have switched on the NPF or not
3) Forbid 90-deg works for NPF and YAPF (not for NTP). Again, it doesn't matter if you have NPF enabled or not.

I will need to make GUI texts more clear i guess
hertogjan
Director
Director
Posts: 560
Joined: 03 Jan 2006 20:45
Location: Netherlands

Post by hertogjan »

Is it true that YAPF tries to send my road vehicles to a competitor's depot (and vice versa)?
Answer: Yes, it even succeeds in getting my buses into someone else's depot.

This may be a bug caused by YAPF, since it doesn't happen when YAPF for road vehicles is disabled.
The problem may also be there for ships, although I haven't tested it (since the AI never builds ships). Someone may have to take a look at it, though.
KUDr
OpenTTD Developer
OpenTTD Developer
Posts: 219
Joined: 11 Jan 2006 21:36
Location: Czech Republic

Post by KUDr »

hertogjan:

5080-Fix: RVs can enter other player's depot or roadstop (introduced by YAPF related change of GetTileTrackStatus() - r4419)

did you mean that? It was my bug, sorry. But should be OK now.
hertogjan
Director
Director
Posts: 560
Joined: 03 Jan 2006 20:45
Location: Netherlands

Post by hertogjan »

Yes, that seems to be the right description of what I have seen.
User avatar
Smoky555
Engineer
Engineer
Posts: 97
Joined: 06 Jan 2005 05:22
Location: Russia, Volgograd
Contact:

Post by Smoky555 »

Hi :)

I found a ... bug or ....

Just simulate this situation: 3 stations (A, B and C), 1 depot and 3 trains.
Two of them has this orders: Go to station A -> Goto station B
One of them has this order: Goto station B -> Goto station A.
No one has in orders station C, but when i start the game with YAPF enabled, 1 train going to station A, second going to station B and the last train going to station C (!!!) - WHY ???.
When i disable YAPF, no one going to station C (it's normal).

OpenTTD rev 5113.

Situation is like on the picture.
Attachments
3train.JPG
3train.JPG (63.42 KiB) Viewed 4215 times
User avatar
XeryusTC
Tycoon
Tycoon
Posts: 15415
Joined: 02 May 2005 11:05
Skype: XeryusTC
Location: localhost

Post by XeryusTC »

That is probably because YAPF thinks that the ways to Station A/B are dead ends and the train can only pick Station C.
Don't panic - My YouTube channel - Follow me on twitter (@XeryusTC) - Play Tribes: Ascend - Tired of Dropbox? Try SpiderOak (use this link and we both get 1GB extra space)
Image
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
Image Image Image Image Image Image Image
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 0 guests