Code: Select all
<Bjarni> they are all orbiting the sun, which makes forum diffs very evil

Thanks for the invite matthijs, I'll try to hop on IRC when I get the chance.matthijs wrote:DevIant, can you explain why this fix works? Maybe we can help you finding a better solution for this problem. Also, stop by on IRC sometime

As for the problematic X, I think it's caused by the width of the sprite including it's shadow, but the shadow not being used in this case. I don't know enough about the GRFs yet to be sure. Reducing it's width by 1 is ugly, but I thought if it isn't used anywhere else, it shouldn't impact on anything.
Another part of the problem is there's no way to tell the difference between WWT_CLOSEBOX and WWT_TEXTBTN, so to the code a close box looks exactly like a button. The only way I can think of to tell the difference and allow DrawStringCentered() to make the alignment change is to look at which string is being passed. If it's a cross, shift it to the right one. Anything else, leave it as is.
I'm happy to code something along those lines if the devs prefer it that way?