Current project: Station reset and stats (greatly improved)

Got an idea for OpenTTD? Post it here!

Moderator: OpenTTD Developers

User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

Pipian: I can't quite follow you. That maybe related to the fact that I'm awake for 48 hours straight now, but I'd be great if you could rephrase and elaborate your suggestion a little further. I hope to resume coding on that patch tomorrow evening or on Tuesday, so whatever suggestions I get till then I'll try to implement.

Celestar
Pipian
Engineer
Engineer
Posts: 122
Joined: 10 Jul 2004 02:25
Contact:

Post by Pipian »

What I meant would be to sum all the cargo requests in the catchment area (1/8 passenger, 2/8 mail, 1/8 goods, etc) and show that, so you know how far away you are from accepting one of those three items.

Also, when not having the zero's it's harder to figure out what row a number is in, as there's no guiding line that can be used to align...
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

I'm not so sure I can integrate it into this patch but I'll have a look. Maybe I'll combine this patch and the modified catchment stuff into one patch eventually.

Celestar
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

Greatly improved functionality, now you can list the vehicles that are scheduled to the station. But there is still quite some stuff to do, especially the right string (can you spot it?) and the station index 0 problem.

Celestar
Attachments
morestats.jpg
morestats.jpg (252.1 KiB) Viewed 1057 times
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

Here we go (and you need the transfer patch as well)

New version is further down, this one had two bugs that have been fixed.

Celestar
Attachments
transfer-905.patch
-p1 needed
(13.39 KiB) Downloaded 163 times
Last edited by Celestar on 13 Jul 2004 21:00, edited 2 times in total.
User avatar
lucaspiller
Tycoon
Tycoon
Posts: 1228
Joined: 18 Apr 2004 20:27

Post by lucaspiller »

Urrr, what does the transfer patch do? Also it still they still don't work with TourtoiseSVN. :x
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

Whats the error message you're getting?

The transfer patch adds a "transfer" option to the orders. so that carriers unload cargo at stations even if they're accepted (so that the cargo stays at stations). Needed for feeder systems to airports for example.

Celestar
User avatar
lucaspiller
Tycoon
Tycoon
Posts: 1228
Joined: 18 Apr 2004 20:27

Post by lucaspiller »

The error message is the same as before:

Code: Select all

The line "Index:" was not found!
What did you use to make the patch?
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

I used "diff -urbN"

Here's another version that fixes two Segmentation Fault bugs I haven't noticed before.

Celestar
Attachments
station_stats-2-911.patch
(35.42 KiB) Downloaded 130 times
User avatar
mdhowe
Route Supervisor
Route Supervisor
Posts: 446
Joined: 09 Jul 2004 07:12
Location: Hobart, Australia

Post by mdhowe »

I found a bug in the station stats patch, the dialogue that lists trains that go to the station lists 2 trains that don't go there. It happens at several other stations to, I think ti might have something to do with the depots around that I force trains into (I read that it forces a different path or something)
Attachments
stats anomaly.sav
(143.9 KiB) Downloaded 142 times
stats anomaly.png
stats anomaly.png (96.87 KiB) Viewed 999 times
"Set fashion, not follow. Spit vitriol, not swallow" - Marilyn Manson
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

Thanks, I'll have a look into that.

Celestar
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

Your savegame segfaults on me :( I'm still trying to find the problem. Are you using the latest version of the station stats? (The one in the "my collected patches" thread)

Celestar
User avatar
mdhowe
Route Supervisor
Route Supervisor
Posts: 446
Joined: 09 Jul 2004 07:12
Location: Hobart, Australia

Post by mdhowe »

Are you using the latest version of the station stats? (The one in the "my collected patches" thread)
No, I wasn't actually but I'll try that now and see if theres any change.

A quick question, can I apply the new patch straight over the old one or do I need to remove the old one first?
"Set fashion, not follow. Spit vitriol, not swallow" - Marilyn Manson
User avatar
mdhowe
Route Supervisor
Route Supervisor
Posts: 446
Joined: 09 Jul 2004 07:12
Location: Hobart, Australia

Post by mdhowe »

A quick question, can I apply the new patch straight over the old one or do I need to remove the old one first?
Don't worry about that, stupid question.


I've applied your collected patches against svn 913 and the game loads and the bug is still there. I cant use a newer svn because my savegame won't load either (segfault), I wrote a post about that, here: http://www.tt-forums.net/viewtopic.php?t=8876

I've saved the same game with the newer patches applied and attached it if this would make any difference.
Attachments
stats anomaly.sav
(144.06 KiB) Downloaded 129 times
"Set fashion, not follow. Spit vitriol, not swallow" - Marilyn Manson
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

I have found the bug that causes wrong trains (or other vehicles) to be displayed and dealt with it.

Thanks for the feedback

Celestar
goalie
Route Supervisor
Route Supervisor
Posts: 406
Joined: 28 Aug 2003 14:54
Location: Düsseldorf
Contact:

Post by goalie »

could someone send me an exe with these patch per pn because i can not compile
please
Post Reply

Return to “OpenTTD Suggestions”

Who is online

Users browsing this forum: No registered users and 19 guests