JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Ricard
Engineer
Engineer
Posts: 1
Joined: 29 Jan 2025 11:28

Re: JGR's Patch Pack

Post by Ricard »

Many thanks for the good job you are doing.

Lately I'm having one problem. I'm not sure which version started happening but now I'm using 72.1

Some trains get stuck in stations for a while when reach 100% loading or 0% unloading. They stay stuck while other trains arrive, load or download and go on. After a variable time any stuck train come to live again and continue with their work. I've made some tests but I could not discover why one train gets stuck and when they go back to work.

I attach a couple of examples when you download the game, the focus is on one station with some stuck trains.
Attachments
Alba, bad100.sav
(866.43 KiB) Downloaded 19 times
Alba, bad.sav
(861.52 KiB) Downloaded 17 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2674
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Ricard wrote: 16 Jun 2026 09:00 Many thanks for the good job you are doing.

Lately I'm having one problem. I'm not sure which version started happening but now I'm using 72.1

Some trains get stuck in stations for a while when reach 100% loading or 0% unloading. They stay stuck while other trains arrive, load or download and go on. After a variable time any stuck train come to live again and continue with their work. I've made some tests but I could not discover why one train gets stuck and when they go back to work.

I attach a couple of examples when you download the game, the focus is on one station with some stuck trains.
It does not make sense to use timetable auto-separation for this group. I suggest you turn it off.
Your trains are waiting because they are running early. However the lateness state should probably just be ignored because the timetable is not in a started/valid state anyway.
Ex TTDPatch Coder
Patch Pack, Github
Ricard
Engineer
Engineer
Posts: 1
Joined: 29 Jan 2025 11:28

Re: JGR's Patch Pack

Post by Ricard »

My fault. I never use auto separation in non passenger trains. Now I have realised that there is a configuration option to put auto separation by default in all trains.

Thanks for your help
Last edited by Ricard on 17 Jun 2026 07:16, edited 1 time in total.
User avatar
gravelpit
Transport Coordinator
Transport Coordinator
Posts: 281
Joined: 26 Feb 2015 14:49
Location: Poland

Re: JGR's Patch Pack

Post by gravelpit »

Ricard wrote: 16 Jun 2026 09:00 Many thanks for the good job you are doing.

Lately I'm having one problem. I'm not sure which version started happening but now I'm using 72.1

Some trains get stuck in stations for a while when reach 100% loading or 0% unloading. They stay stuck while other trains arrive, load or download and go on. After a variable time any stuck train come to live again and continue with their work. I've made some tests but I could not discover why one train gets stuck and when they go back to work.

I attach a couple of examples when you download the game, the focus is on one station with some stuck trains.
Automatic separation should be turned off
As much realism as possible
Auge
Chief Executive
Chief Executive
Posts: 717
Joined: 23 Oct 2006 02:07
Location: Berlin

Re: JGR's Patch Pack

Post by Auge »

Hello
JGR wrote: 16 Jun 2026 17:43 It does not make sense to use timetable auto-separation for this group. I suggest you turn it off.
Ricard wrote: 17 Jun 2026 07:15 Now I have realised that there is a configuration option to put auto separation by default in all trains.
gravelpit wrote: 17 Jun 2026 16:58 Automatic separation should be turned off
Automatic separation turned on or off, both approaches have their drawbacks. Is it turned off, freight line vehicles which typically should start when fully loaded will do this but for passenger lines where one wants to have automatic separation one has to remember to manually turn it on. If turned on, one has to remember to turn it off again for freight line timetables. In my experience, I tend to forget this quite often (in my case to disable it for freight line timetables), and I reckon I’m by no means the only one.

Ideally the setting would have an option to set it on for passenger vehicles and to disable it for all other vehicles. But I haven’t the faintest idea whether something like that is even feasible.

Tschö, Auge
xarick
Transport Coordinator
Transport Coordinator
Posts: 361
Joined: 26 Feb 2015 00:52

Re: JGR's Patch Pack

Post by xarick »

I have received a bug report regarding AIList instances during save and load. See viewtopic.php?p=1279485#p1279485

I found out the reason the script crashes on load is due to a problem with saving in JGRPP.

https://github.com/JGRennison/OpenTTD-p ... #L454-L455
Between these two lines, adding the following fixes the save issue.

Code: Select all

SlWriteByte(SQSL_INSTANCE);
Formerly known as Samu
User avatar
JGR
Tycoon
Tycoon
Posts: 2674
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

xarick wrote: 30 Jun 2026 14:42 I have received a bug report regarding AIList instances during save and load. See viewtopic.php?p=1279485#p1279485

I found out the reason the script crashes on load is due to a problem with saving in JGRPP.

https://github.com/JGRennison/OpenTTD-p ... #L454-L455
Between these two lines, adding the following fixes the save issue.

Code: Select all

SlWriteByte(SQSL_INSTANCE);
Thanks, this will be fixed in the next release.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
gravelpit
Transport Coordinator
Transport Coordinator
Posts: 281
Joined: 26 Feb 2015 14:49
Location: Poland

Re: JGR's Patch Pack

Post by gravelpit »

I have an ongoing observation: could it be possible to count a vehicle's delivery cycles in a given year? Instead of checking how much it earned, we would instead check the cycles traveled from station to station. This way, we could easily compare which transport option would be best for a given route?
As much realism as possible
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 0 guests